Github messages for voidlinux
 help / color / mirror / Atom feed
From: classabbyamp <classabbyamp@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] hexchat: don't remove pkgconfig/headers
Date: Thu, 02 May 2024 04:50:13 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50151@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 474 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages hexchat
https://github.com/void-linux/void-packages/pull/50151

hexchat: don't remove pkgconfig/headers
they're not unnecessary, they're needed for compiling C plugins

#### Testing the changes
- I tested the changes in this PR: **YES**

@0x5c


A patch file from https://github.com/void-linux/void-packages/pull/50151.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-hexchat-50151.patch --]
[-- Type: text/x-diff, Size: 1256 bytes --]

From 127f77d85d55769329a15217c704f78678fefe01 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Wed, 1 May 2024 22:49:18 -0400
Subject: [PATCH] hexchat: don't remove pkgconfig/headers

---
 srcpkgs/hexchat/template | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/hexchat/template b/srcpkgs/hexchat/template
index d20bef5fccf20c..11b9253c4156e2 100644
--- a/srcpkgs/hexchat/template
+++ b/srcpkgs/hexchat/template
@@ -1,7 +1,7 @@
 # Template file for 'hexchat'
 pkgname=hexchat
 version=2.16.2
-revision=2
+revision=3
 build_style=meson
 configure_args="-Ddbus=enabled -Dtls=enabled
  -Dwith-perl=/usr/bin/perl -Dwith-python=python3
@@ -31,12 +31,6 @@ if [ "$CROSS_BUILD" ]; then
 	 shared-mime-info"
 fi
 
-post_install() {
-	# Remove useless files.
-	rm -rf "${DESTDIR}/usr/include"
-	rm -rf "${DESTDIR}/usr/lib/pkgconfig"
-}
-
 hexchat-perl_package() {
 	lib32disabled=yes
 	short_desc+=" - perl plugin"
@@ -64,3 +58,12 @@ hexchat-lua_package() {
 		vmove usr/lib/hexchat/plugins/lua.so
 	}
 }
+
+hexchat-devel_package() {
+	depends="${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/include
+		vmove usr/lib/pkgconfig
+	}
+}

             reply	other threads:[~2024-05-02  2:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-02  2:50 classabbyamp [this message]
2024-05-02  2:54 ` [PR PATCH] [Updated] " classabbyamp
2024-05-02  3:04 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50151@inbox.vuxu.org \
    --to=classabbyamp@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).