From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] bash: define SSH_SOURCE_BASHRC
Date: Sat, 11 May 2024 22:54:52 +0200 [thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50280@inbox.vuxu.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]
There is a new pull request by tornaria against master on the void-packages repository
https://github.com/tornaria/void-packages bash
https://github.com/void-linux/void-packages/pull/50280
bash: define SSH_SOURCE_BASHRC
This makes bash agree with its documentation at
https://www.gnu.org/software/bash/manual/html_node/Bash-Startup-Files.html
Bash attempts to determine when it is being run with its standard
input connected to a network connection, as when executed by the
historical remote shell daemon, usually rshd, or the secure shell
daemon sshd. If Bash determines it is being run non-interactively in
this fashion, it reads and executes commands from ~/.bashrc, if that
file exists and is readable. [...]
Notes:
- Disabled by upstream in 2.05a (2001), manual never changed
- This is enabled in Debian, Fedora, Gentoo, ...
To avoid this feature, add
```
[[ $- != *i* ]] && return
```
to the top of ~/.bashrc to skip running it in non-interactive mode.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/50280.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bash-50280.patch --]
[-- Type: text/x-diff, Size: 2168 bytes --]
From 2480028d65ac1e14e753664150c647bf9b3b7325 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Sat, 11 May 2024 17:22:47 -0300
Subject: [PATCH] bash: define SSH_SOURCE_BASHRC
This makes bash agree with its documentation at
https://www.gnu.org/software/bash/manual/html_node/Bash-Startup-Files.html
Bash attempts to determine when it is being run with its standard
input connected to a network connection, as when executed by the
historical remote shell daemon, usually rshd, or the secure shell
daemon sshd. If Bash determines it is being run non-interactively in
this fashion, it reads and executes commands from ~/.bashrc, if that
file exists and is readable. [...]
Notes:
- Disabled by upstream in 2.05a (2001), manual never changed
- This is enabled in Debian, Fedora, Gentoo, ...
---
srcpkgs/bash/template | 4 ++--
srcpkgs/bash/update | 5 -----
2 files changed, 2 insertions(+), 7 deletions(-)
delete mode 100644 srcpkgs/bash/update
diff --git a/srcpkgs/bash/template b/srcpkgs/bash/template
index a977c3a7d5c0af..03a5652b21e9e5 100644
--- a/srcpkgs/bash/template
+++ b/srcpkgs/bash/template
@@ -1,7 +1,7 @@
# Template file for 'bash'
pkgname=bash
version=5.2.21
-revision=1
+revision=2
build_style=gnu-configure
configure_args="--without-bash-malloc --with-curses --without-installed-readline"
make_build_args="TERMCAP_LIB=${XBPS_CROSS_BASE}/usr/lib/libncursesw.a"
@@ -24,7 +24,7 @@ alternatives="
sh:sh:/usr/bin/bash
sh:sh.1:/usr/share/man/man1/bash.1"
-CFLAGS="-DNON_INTERACTIVE_LOGIN_SHELLS -DSYS_BASHRC='\"/etc/bash/bashrc\"'"
+CFLAGS="-DSSH_SOURCE_BASHRC -DNON_INTERACTIVE_LOGIN_SHELLS -DSYS_BASHRC='\"/etc/bash/bashrc\"'"
post_install() {
rm -r ${DESTDIR}/usr/share/doc
diff --git a/srcpkgs/bash/update b/srcpkgs/bash/update
deleted file mode 100644
index 89e82249c5e3c2..00000000000000
--- a/srcpkgs/bash/update
+++ /dev/null
@@ -1,5 +0,0 @@
-site="http://git.savannah.gnu.org/cgit/bash.git/log/"
-pattern="Bash-\K\d(\.\d)+( patch \d+|-testing)?"
-version="$_bash_distver"
-[ ! -z "$_bash_patchlevel" ] && version+=" patch $_bash_patchlevel"
-ignore="*testing"
next reply other threads:[~2024-05-11 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 20:54 tornaria [this message]
2024-05-11 23:06 ` tornaria
2024-05-13 21:57 ` tornaria
2024-05-19 0:03 ` ahesford
2024-05-19 16:58 ` tornaria
2024-06-13 23:28 ` [PR PATCH] [Closed]: " abenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50280@inbox.vuxu.org \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).