Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] greybird-themes: update to 3.23.3, remove gtk-engine-murrine dep, adopt.
@ 2024-05-12  1:36 Calandracas606
  2024-06-05  2:48 ` [PR PATCH] [Closed]: " abenson
  0 siblings, 1 reply; 2+ messages in thread
From: Calandracas606 @ 2024-05-12  1:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1715 bytes --]

There is a new pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages greybird-deps
https://github.com/void-linux/void-packages/pull/50285

greybird-themes: update to 3.23.3, remove gtk-engine-murrine dep, adopt.
removes dependancy on gtk-engine-murrine. I don't see why a bunch of themes need this dependency. It is only needed for gtk2 support, so if users really need gtk2 support, they could just install that it manually. I don't think it makes sense to pull in gtk2 when installing a theme package.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686l
  - aarch64 (cross)
  - aarch64-musl (cross)
  - armv7l (cross)
  - armv7l-musl (cross)
  - armv6l (cross)
  - armv6l-musl (cross)



A patch file from https://github.com/void-linux/void-packages/pull/50285.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-greybird-deps-50285.patch --]
[-- Type: text/x-diff, Size: 1632 bytes --]

From 1195ee8cb8820520437e0f0b4ea76ea1bd60ac42 Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Sat, 11 May 2024 21:25:20 -0400
Subject: [PATCH] greybird-themes: update to 3.23.3, remove gtk-engine-murrine
 dep, adopt.

removes dependancy on gtk-engine-murrine. I don't see why a bunch of
themes need this dependancy. It is only needed for gtk2 support, so
if users really need gtk2 support, they could just install that it
manually. I don't think it makes sense to pull in gtk2 when
installing a theme package.
---
 srcpkgs/greybird-themes/template | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/greybird-themes/template b/srcpkgs/greybird-themes/template
index 7f5dfe93644b1f..b0115d2c402684 100644
--- a/srcpkgs/greybird-themes/template
+++ b/srcpkgs/greybird-themes/template
@@ -1,13 +1,12 @@
 # Template file for 'greybird-themes'
 pkgname=greybird-themes
-version=3.23.1
+version=3.23.3
 revision=1
 build_style=meson
-hostmakedepends="sassc ninja glib-devel gdk-pixbuf-devel librsvg-devel"
-depends="gtk-engine-murrine"
+hostmakedepends="sassc glib-devel gdk-pixbuf-devel librsvg-devel"
 short_desc="Elegant grey GTK+2/3 theme"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Daniel Martinez <danielmartinez@cock.li>"
 license="GPL-2.0-or-later, CC-BY-SA-3.0"
 homepage="https://github.com/shimmerproject/Greybird"
 distfiles="https://github.com/shimmerproject/Greybird/archive/v${version}.tar.gz"
-checksum=d7e6b94f956874b819e2e17c2368ffd6babf02e5df7f08f508cee4380c3e4e8a
+checksum=2c97d3a7281c80f5752294f196bff22a814aef8da7ca3b7545f50bbb9ed16d64

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Closed]: greybird-themes: update to 3.23.3, remove gtk-engine-murrine dep, adopt.
  2024-05-12  1:36 [PR PATCH] greybird-themes: update to 3.23.3, remove gtk-engine-murrine dep, adopt Calandracas606
@ 2024-06-05  2:48 ` abenson
  0 siblings, 0 replies; 2+ messages in thread
From: abenson @ 2024-06-05  2:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]

There's a closed pull request on the void-packages repository

greybird-themes: update to 3.23.3, remove gtk-engine-murrine dep, adopt.
https://github.com/void-linux/void-packages/pull/50285

Description:
removes dependancy on gtk-engine-murrine. I don't see why a bunch of themes need this dependency. It is only needed for gtk2 support, so if users really need gtk2 support, they could just install that it manually. I don't think it makes sense to pull in gtk2 when installing a theme package.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686
  - aarch64 (cross)
  - aarch64-musl (cross)
  - armv7l (cross)
  - armv7l-musl (cross)
  - armv6l (cross)
  - armv6l-musl (cross)



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-05  2:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-12  1:36 [PR PATCH] greybird-themes: update to 3.23.3, remove gtk-engine-murrine dep, adopt Calandracas606
2024-06-05  2:48 ` [PR PATCH] [Closed]: " abenson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).