[PR PATCH] snapcast: update to 0.28.0

[PR PATCH] snapcast: update to 0.28.0

[amak79]

[-- Attachment #1: Type: text/plain, Size: 2502 bytes --]

There is a new pull request by amak79 against master on the void-packages repository

https://github.com/amak79/void-packages snapcast
https://github.com/void-linux/void-packages/pull/50290

snapcast: update to 0.28.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

This release no longer bundles the pre-built [Snapweb](https://github.com/badaix/snapweb). When accessing the Snapweb page, you are now greeted with the following notice.
```
This is a placeholder for Snapweb, a web based control client and player for Snapcast.
To install Snapweb, please follow these steps:

    1. Download Snapweb on the Snapweb release page. You can either download
        * snapweb.zip and extract it on your Snapcast server machine, e.g. into /usr/share/snapserver/snapweb or
        * snapweb_x.y.z-1_all.deb and install it with sudo apt install ./snapweb_x.y.z-1_all.deb to /usr/share/snapweb
    2. Configure the document root (doc_root, see below) in the snapserver configuration file snapserver.conf — usually located in /etc/snapserver.conf — to the location where snapweb is extracted or installed.
    3. Restart Snapserver to activate the changes: sudo service snapserver restart
```
What should we do with Snapweb?
1. Leave the `snapcast` package as is and let the user fetch and extract the pre-built Snapweb as per instructions.
2. Fetch and install the pre-built Snapweb from the `snapserver` subpackage.
3. Create a new `snapweb` package and build it from source. The user can then install it if needed.

A patch file from https://github.com/void-linux/void-packages/pull/50290.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snapcast-50290.patch --]
[-- Type: text/x-diff, Size: 1133 bytes --]

From a4c41e23f9b10e2f8fc865b32de351555643a3c5 Mon Sep 17 00:00:00 2001
From: amak <amak.git@outlook.com>
Date: Sun, 12 May 2024 14:20:52 +1000
Subject: [PATCH] snapcast: update to 0.28.0

---
 srcpkgs/snapcast/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/snapcast/template b/srcpkgs/snapcast/template
index bd0c2e1056b128..cc20931d4d779a 100644
--- a/srcpkgs/snapcast/template
+++ b/srcpkgs/snapcast/template
@@ -1,6 +1,6 @@
 # Template file for 'snapcast'
 pkgname=snapcast
-version=0.27.0
+version=0.28.0
 revision=3
 build_style=cmake
 configure_args="-DCMAKE_INSTALL_SYSCONFDIR=/etc -DBUILD_WITH_TREMOR=OFF
@@ -16,7 +16,7 @@ license="GPL-3.0-or-later"
 homepage="https://github.com/badaix/snapcast"
 changelog="https://raw.githubusercontent.com/badaix/snapcast/master/changelog.md"
 distfiles="https://github.com/badaix/snapcast/archive/v${version}.tar.gz"
-checksum=c662c6eafbaa42a4797a4ed6ba4a7602332abf99f6ba6ea88ff8ae59978a86ba
+checksum=7911037dd4b06fe98166db1d49a7cd83ccf131210d5aaad47507bfa0cfc31407
 
 build_options="avahi pulseaudio"
 build_options_default="avahi pulseaudio"

Re: [PR PATCH] [Updated] snapcast: update to 0.28.0

[amak79]

[-- Attachment #1: Type: text/plain, Size: 2507 bytes --]

There is an updated pull request by amak79 against master on the void-packages repository

https://github.com/amak79/void-packages snapcast
https://github.com/void-linux/void-packages/pull/50290

snapcast: update to 0.28.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

This release no longer bundles the pre-built [Snapweb](https://github.com/badaix/snapweb). When accessing the Snapweb page, you are now greeted with the following notice.
```
This is a placeholder for Snapweb, a web based control client and player for Snapcast.
To install Snapweb, please follow these steps:

    1. Download Snapweb on the Snapweb release page. You can either download
        * snapweb.zip and extract it on your Snapcast server machine, e.g. into /usr/share/snapserver/snapweb or
        * snapweb_x.y.z-1_all.deb and install it with sudo apt install ./snapweb_x.y.z-1_all.deb to /usr/share/snapweb
    2. Configure the document root (doc_root, see below) in the snapserver configuration file snapserver.conf — usually located in /etc/snapserver.conf — to the location where snapweb is extracted or installed.
    3. Restart Snapserver to activate the changes: sudo service snapserver restart
```
What should we do with Snapweb?
1. Leave the `snapcast` package as is and let the user fetch and extract the pre-built Snapweb as per instructions.
2. Fetch and install the pre-built Snapweb from the `snapserver` subpackage.
3. Create a new `snapweb` package and build it from source. The user can then install it if needed.

A patch file from https://github.com/void-linux/void-packages/pull/50290.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snapcast-50290.patch --]
[-- Type: text/x-diff, Size: 1192 bytes --]

From 34720160689d884715ce92ab5677f80afd9a1430 Mon Sep 17 00:00:00 2001
From: amak <amak.git@outlook.com>
Date: Sun, 12 May 2024 14:20:52 +1000
Subject: [PATCH] snapcast: update to 0.28.0

---
 srcpkgs/snapcast/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/snapcast/template b/srcpkgs/snapcast/template
index bd0c2e1056b128..2fa65d26d9d7fb 100644
--- a/srcpkgs/snapcast/template
+++ b/srcpkgs/snapcast/template
@@ -1,7 +1,7 @@
 # Template file for 'snapcast'
 pkgname=snapcast
-version=0.27.0
-revision=3
+version=0.28.0
+revision=1
 build_style=cmake
 configure_args="-DCMAKE_INSTALL_SYSCONFDIR=/etc -DBUILD_WITH_TREMOR=OFF
  -DBUILD_WITH_AVAHI=$(vopt_if avahi ON OFF)
@@ -16,7 +16,7 @@ license="GPL-3.0-or-later"
 homepage="https://github.com/badaix/snapcast"
 changelog="https://raw.githubusercontent.com/badaix/snapcast/master/changelog.md"
 distfiles="https://github.com/badaix/snapcast/archive/v${version}.tar.gz"
-checksum=c662c6eafbaa42a4797a4ed6ba4a7602332abf99f6ba6ea88ff8ae59978a86ba
+checksum=7911037dd4b06fe98166db1d49a7cd83ccf131210d5aaad47507bfa0cfc31407
 
 build_options="avahi pulseaudio"
 build_options_default="avahi pulseaudio"

Re: snapcast: update to 0.28.0

[the-maldridge]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

New comment by the-maldridge on void-packages repository

https://github.com/void-linux/void-packages/pull/50290#issuecomment-2106122898

Comment:
This feels similar conceptually to grafana's assets package, where we use the pre-built one due to the complexity of getting large javascript projects to build reliably.  I would advise you to create a new package that just pulls in their pre-built package and puts it in the right place.

Re: snapcast: update to 0.28.0

[amak79]

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/50290#issuecomment-2106135895

Comment:
If we go the separate package route, there will be a file conflict as both packages install `index.html` in `/usr/share/snapserver/snapweb`. Perhaps it's better to go with option 2?

Re: [PR PATCH] [Updated] snapcast: update to 0.28.0

[amak79]

[-- Attachment #1: Type: text/plain, Size: 2507 bytes --]

There is an updated pull request by amak79 against master on the void-packages repository

https://github.com/amak79/void-packages snapcast
https://github.com/void-linux/void-packages/pull/50290

snapcast: update to 0.28.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

This release no longer bundles the pre-built [Snapweb](https://github.com/badaix/snapweb). When accessing the Snapweb page, you are now greeted with the following notice.
```
This is a placeholder for Snapweb, a web based control client and player for Snapcast.
To install Snapweb, please follow these steps:

    1. Download Snapweb on the Snapweb release page. You can either download
        * snapweb.zip and extract it on your Snapcast server machine, e.g. into /usr/share/snapserver/snapweb or
        * snapweb_x.y.z-1_all.deb and install it with sudo apt install ./snapweb_x.y.z-1_all.deb to /usr/share/snapweb
    2. Configure the document root (doc_root, see below) in the snapserver configuration file snapserver.conf — usually located in /etc/snapserver.conf — to the location where snapweb is extracted or installed.
    3. Restart Snapserver to activate the changes: sudo service snapserver restart
```
What should we do with Snapweb?
1. Leave the `snapcast` package as is and let the user fetch and extract the pre-built Snapweb as per instructions.
2. Fetch and install the pre-built Snapweb from the `snapserver` subpackage.
3. Create a new `snapweb` package and build it from source. The user can then install it if needed.

A patch file from https://github.com/void-linux/void-packages/pull/50290.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-snapcast-50290.patch --]
[-- Type: text/x-diff, Size: 1762 bytes --]

From 2a2a28d09b142d1edcac38b0a387d6bd44eb4398 Mon Sep 17 00:00:00 2001
From: amak <amak.git@outlook.com>
Date: Sun, 12 May 2024 14:20:52 +1000
Subject: [PATCH] snapcast: update to 0.28.0

---
 srcpkgs/snapcast/template | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/snapcast/template b/srcpkgs/snapcast/template
index bd0c2e1056b128..f6d680b96a731e 100644
--- a/srcpkgs/snapcast/template
+++ b/srcpkgs/snapcast/template
@@ -1,7 +1,8 @@
 # Template file for 'snapcast'
 pkgname=snapcast
-version=0.27.0
-revision=3
+version=0.28.0
+revision=1
+_snapweb_version=0.7.0
 build_style=cmake
 configure_args="-DCMAKE_INSTALL_SYSCONFDIR=/etc -DBUILD_WITH_TREMOR=OFF
  -DBUILD_WITH_AVAHI=$(vopt_if avahi ON OFF)
@@ -15,12 +16,19 @@ maintainer="amak <amak.git@outlook.com>"
 license="GPL-3.0-or-later"
 homepage="https://github.com/badaix/snapcast"
 changelog="https://raw.githubusercontent.com/badaix/snapcast/master/changelog.md"
-distfiles="https://github.com/badaix/snapcast/archive/v${version}.tar.gz"
-checksum=c662c6eafbaa42a4797a4ed6ba4a7602332abf99f6ba6ea88ff8ae59978a86ba
+distfiles="https://github.com/badaix/snapcast/archive/v${version}.tar.gz
+ https://github.com/badaix/snapweb/releases/download/v${_snapweb_version}/snapweb.zip>snapweb-${_snapweb_version}.zip"
+checksum="7911037dd4b06fe98166db1d49a7cd83ccf131210d5aaad47507bfa0cfc31407
+ 2acfc3538e4f4daefb0a2eac9126925f5a455dfd68b14ba5500fac5f1f82cb8f"
+skip_extraction="snapweb-${_snapweb_version}.zip"
 
 build_options="avahi pulseaudio"
 build_options_default="avahi pulseaudio"
 
+post_extract() {
+	vsrcextract -C server/etc/snapweb --strip-components=0 snapweb-${_snapweb_version}.zip
+}
+
 post_install() {
 	vdoc README.md
 	vdoc doc/player_setup.md

Re: snapcast: update to 0.28.0

[amak79]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/50290#issuecomment-2121763233

Comment:
I've implemented option 2 because of the file conflict.

Re: snapcast: update to 0.28.0

[amak79]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by amak79 on void-packages repository

https://github.com/void-linux/void-packages/pull/50290#issuecomment-2121763233

Comment:
I've implemented option 2 because of the file conflict. The resulting package is now equivalent to Snapcast <=0.27.0 where pre-built Snapweb is bundled.

Re: [PR PATCH] [Closed]: snapcast: update to 0.28.0

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 2352 bytes --]

There's a closed pull request on the void-packages repository

snapcast: update to 0.28.0
https://github.com/void-linux/void-packages/pull/50290

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

This release no longer bundles the pre-built [Snapweb](https://github.com/badaix/snapweb). When accessing the Snapweb page, you are now greeted with the following notice.
```
This is a placeholder for Snapweb, a web based control client and player for Snapcast.
To install Snapweb, please follow these steps:

    1. Download Snapweb on the Snapweb release page. You can either download
        * snapweb.zip and extract it on your Snapcast server machine, e.g. into /usr/share/snapserver/snapweb or
        * snapweb_x.y.z-1_all.deb and install it with sudo apt install ./snapweb_x.y.z-1_all.deb to /usr/share/snapweb
    2. Configure the document root (doc_root, see below) in the snapserver configuration file snapserver.conf — usually located in /etc/snapserver.conf — to the location where snapweb is extracted or installed.
    3. Restart Snapserver to activate the changes: sudo service snapserver restart
```
What should we do with Snapweb?
1. Leave the `snapcast` package as is and let the user fetch and extract the pre-built Snapweb as per instructions.
2. Fetch and install the pre-built Snapweb from the `snapserver` subpackage.
3. Create a new `snapweb` package and build it from source. The user can then install it if needed.