[PR PATCH] nicotine+: update to 3.3.4, co-adopt.

[PR PATCH] nicotine+: update to 3.3.4, co-adopt.

[Zyrtula]

[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]

There is a new pull request by Zyrtula against master on the void-packages repository

https://github.com/Zyrtula/void-packages nicotine
https://github.com/void-linux/void-packages/pull/50423

nicotine+: update to 3.3.4, co-adopt.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, **x86_64**
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl


A patch file from https://github.com/void-linux/void-packages/pull/50423.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nicotine-50423.patch --]
[-- Type: text/x-diff, Size: 1376 bytes --]

From 0d28ece8661652512c0dcd9c75dbb8a7ca0e6e3a Mon Sep 17 00:00:00 2001
From: Zyrtula <fk_development@protonmail.com>
Date: Sun, 19 May 2024 00:53:38 +0200
Subject: [PATCH] nicotine+: update to 3.3.4, co-adopt.

---
 srcpkgs/nicotine+/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/nicotine+/template b/srcpkgs/nicotine+/template
index 133d36a154f8c6..c385eeb2874ef7 100644
--- a/srcpkgs/nicotine+/template
+++ b/srcpkgs/nicotine+/template
@@ -1,15 +1,15 @@
 # Template file for 'nicotine+'
 pkgname=nicotine+
-version=3.2.9
-revision=2
+version=3.3.4
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools gettext"
 depends="gspell gtk+3 python3-gobject"
 checkdepends="$depends python3-pytest python3-pytest-xvfb"
 short_desc="Graphical client for the Soulseek peer-to-peer network"
-maintainer="doggone <doggone@airmail.cc>"
+maintainer="doggone <doggone@airmail.cc>, Fabian Kaiser <fk_development@protonmail.com"
 license="GPL-3.0-or-later"
 homepage="https://nicotine-plus.org"
 changelog="https://raw.githubusercontent.com/nicotine-plus/nicotine-plus/master/NEWS.md"
 distfiles="https://github.com/Nicotine-Plus/nicotine-plus/archive/${version}.tar.gz"
-checksum=aeaf45742a915345d1635f36ca334c3f332788c7a27262408be9998985f99e41
+checksum=0286df979e124ef90b335dbd4d992938c76e9ff1c9b654e02feb638a336af358

Re: [PR REVIEW] nicotine+: update to 3.3.4, co-adopt.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50423#discussion_r1605910224

Comment:
we'd prefer packages be adopted by established contributors. I encourage you to keep track of this package and continue making contributions, but please don't change the maintainer at this time.

Additionally, you do not need to be the maintainer of a package to update it, and "co-maintainership" is not typically done on void

https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#adopting-a-template

Re: [PR PATCH] [Updated] nicotine+: update to 3.3.4, co-adopt.

[Zyrtula]

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

There is an updated pull request by Zyrtula against master on the void-packages repository

https://github.com/Zyrtula/void-packages nicotine
https://github.com/void-linux/void-packages/pull/50423

nicotine+: update to 3.3.4, co-adopt.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, **x86_64**
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl


A patch file from https://github.com/void-linux/void-packages/pull/50423.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nicotine-50423.patch --]
[-- Type: text/x-diff, Size: 1118 bytes --]

From 36dca8c8b1bfa5b253f85804e83acf86a0474d31 Mon Sep 17 00:00:00 2001
From: Zyrtula <fk_development@protonmail.com>
Date: Sun, 19 May 2024 00:53:38 +0200
Subject: [PATCH] nicotine+: update to 3.3.4.

---
 srcpkgs/nicotine+/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/nicotine+/template b/srcpkgs/nicotine+/template
index 133d36a154f8c6..ad881cf24b0fc5 100644
--- a/srcpkgs/nicotine+/template
+++ b/srcpkgs/nicotine+/template
@@ -1,7 +1,7 @@
 # Template file for 'nicotine+'
 pkgname=nicotine+
-version=3.2.9
-revision=2
+version=3.3.4
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools gettext"
 depends="gspell gtk+3 python3-gobject"
@@ -12,4 +12,4 @@ license="GPL-3.0-or-later"
 homepage="https://nicotine-plus.org"
 changelog="https://raw.githubusercontent.com/nicotine-plus/nicotine-plus/master/NEWS.md"
 distfiles="https://github.com/Nicotine-Plus/nicotine-plus/archive/${version}.tar.gz"
-checksum=aeaf45742a915345d1635f36ca334c3f332788c7a27262408be9998985f99e41
+checksum=0286df979e124ef90b335dbd4d992938c76e9ff1c9b654e02feb638a336af358

Re: [PR PATCH] [Updated] nicotine+: update to 3.3.4

[Zyrtula]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

There is an updated pull request by Zyrtula against master on the void-packages repository

https://github.com/Zyrtula/void-packages nicotine
https://github.com/void-linux/void-packages/pull/50423

nicotine+: update to 3.3.4
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, **x86_64**
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl


A patch file from https://github.com/void-linux/void-packages/pull/50423.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nicotine-50423.patch --]
[-- Type: text/x-diff, Size: 1326 bytes --]

From bdbc3781c7467818e412c821304f976602ba6136 Mon Sep 17 00:00:00 2001
From: Zyrtula <fk_development@protonmail.com>
Date: Sun, 19 May 2024 00:53:38 +0200
Subject: [PATCH] nicotine+: update to 3.3.4.

---
 srcpkgs/nicotine+/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/nicotine+/template b/srcpkgs/nicotine+/template
index 133d36a154f8c6..7aac2286f89580 100644
--- a/srcpkgs/nicotine+/template
+++ b/srcpkgs/nicotine+/template
@@ -1,10 +1,10 @@
 # Template file for 'nicotine+'
 pkgname=nicotine+
-version=3.2.9
-revision=2
+version=3.3.4
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools gettext"
-depends="gspell gtk+3 python3-gobject"
+depends="gtk4 python3-gobject"
 checkdepends="$depends python3-pytest python3-pytest-xvfb"
 short_desc="Graphical client for the Soulseek peer-to-peer network"
 maintainer="doggone <doggone@airmail.cc>"
@@ -12,4 +12,4 @@ license="GPL-3.0-or-later"
 homepage="https://nicotine-plus.org"
 changelog="https://raw.githubusercontent.com/nicotine-plus/nicotine-plus/master/NEWS.md"
 distfiles="https://github.com/Nicotine-Plus/nicotine-plus/archive/${version}.tar.gz"
-checksum=aeaf45742a915345d1635f36ca334c3f332788c7a27262408be9998985f99e41
+checksum=0286df979e124ef90b335dbd4d992938c76e9ff1c9b654e02feb638a336af358

Re: nicotine+: update to 3.3.4

[Zyrtula]

[-- Attachment #1: Type: text/plain, Size: 171 bytes --]

New comment by Zyrtula on void-packages repository

https://github.com/void-linux/void-packages/pull/50423#issuecomment-2119350495

Comment:
fix: checks run without fails

Re: [PR PATCH] [Merged]: nicotine+: update to 3.3.4

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]

There's a merged pull request on the void-packages repository

nicotine+: update to 3.3.4
https://github.com/void-linux/void-packages/pull/50423

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, **x86_64**
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl