* Re: lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
@ 2024-05-23 15:52 ` classabbyamp
2024-05-23 20:29 ` slimjimsoftware
` (13 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: classabbyamp @ 2024-05-23 15:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 336 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/50486#issuecomment-2127484996
Comment:
why is this needed? (how is it currently "cluttered"?)
if you're going to do this, you need to make the main package depend on everything you split out to not break other people's setups
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
2024-05-23 15:52 ` classabbyamp
@ 2024-05-23 20:29 ` slimjimsoftware
2024-05-23 20:49 ` [PR REVIEW] " classabbyamp
` (12 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: slimjimsoftware @ 2024-05-23 20:29 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
New comment by slimjimsoftware on void-packages repository
https://github.com/void-linux/void-packages/pull/50486#issuecomment-2127966349
Comment:
@classabbyamp desktop menus (for some desktops) get cluttered with LSP icons, there are numerous reports of this and it appears to be something to do with GNOME not following XDG standards? Anyway a quick google shows up this:
https://www.linuxquestions.org/questions/linux-general-1/my-multimedia-menu-is-full-of-some-audio-related-stuff-any-idea-where-these-came-from-4175721036/
https://www.reddit.com/r/linux4noobs/comments/g40e3a/unwanted_lsp_plugins_showing_up/
I can confirm this happens on plasma 6 too.
Apple Silicon mac support requires just the lv2 set of lsp-plugins to enable audio so rather than install the entire set, we can split into subpackages and also avoid the icon clutter
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR REVIEW] lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
2024-05-23 15:52 ` classabbyamp
2024-05-23 20:29 ` slimjimsoftware
@ 2024-05-23 20:49 ` classabbyamp
2024-05-24 16:08 ` dkwo
` (11 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: classabbyamp @ 2024-05-23 20:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 193 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/50486#discussion_r1612279937
Comment:
standard package naming would be `-libs`
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR REVIEW] lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
` (2 preceding siblings ...)
2024-05-23 20:49 ` [PR REVIEW] " classabbyamp
@ 2024-05-24 16:08 ` dkwo
2024-05-24 16:22 ` [PR PATCH] [Updated] " dkwo
` (10 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: dkwo @ 2024-05-24 16:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 150 bytes --]
New review comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/50486#discussion_r1613714467
Comment:
Done.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Updated] lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
` (3 preceding siblings ...)
2024-05-24 16:08 ` dkwo
@ 2024-05-24 16:22 ` dkwo
2024-05-24 16:22 ` dkwo
` (9 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: dkwo @ 2024-05-24 16:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages lsp
https://github.com/void-linux/void-packages/pull/50486
lsp-plugins: split subpkgs
Tested by me and @slimjimsoftware
This helps unclutter things. @leahneukirchen can you take a look?
A patch file from https://github.com/void-linux/void-packages/pull/50486.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lsp-50486.patch --]
[-- Type: text/x-diff, Size: 4732 bytes --]
From 7d89e0ded877d116675b458912490224a6e4bd1f Mon Sep 17 00:00:00 2001
From: dkwo <npiazza@disroot.org>
Date: Tue, 21 May 2024 12:30:32 -0400
Subject: [PATCH 1/2] lsp-plugins: split subpkgs
---
srcpkgs/lsp-plugins-clap | 1 +
srcpkgs/lsp-plugins-ladspa | 1 +
srcpkgs/lsp-plugins-lib | 1 +
srcpkgs/lsp-plugins-lv2 | 1 +
srcpkgs/lsp-plugins-vst2 | 1 +
srcpkgs/lsp-plugins-xdg | 1 +
srcpkgs/lsp-plugins/template | 51 +++++++++++++++++++++++++++++++++++-
7 files changed, 56 insertions(+), 1 deletion(-)
create mode 120000 srcpkgs/lsp-plugins-clap
create mode 120000 srcpkgs/lsp-plugins-ladspa
create mode 120000 srcpkgs/lsp-plugins-lib
create mode 120000 srcpkgs/lsp-plugins-lv2
create mode 120000 srcpkgs/lsp-plugins-vst2
create mode 120000 srcpkgs/lsp-plugins-xdg
diff --git a/srcpkgs/lsp-plugins-clap b/srcpkgs/lsp-plugins-clap
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-clap
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-ladspa b/srcpkgs/lsp-plugins-ladspa
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-ladspa
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-lib b/srcpkgs/lsp-plugins-lib
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-lib
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-lv2 b/srcpkgs/lsp-plugins-lv2
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-lv2
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-vst2 b/srcpkgs/lsp-plugins-vst2
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-vst2
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-xdg b/srcpkgs/lsp-plugins-xdg
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-xdg
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins/template b/srcpkgs/lsp-plugins/template
index 9473573ff185d1..f32c2c133dad07 100644
--- a/srcpkgs/lsp-plugins/template
+++ b/srcpkgs/lsp-plugins/template
@@ -1,7 +1,7 @@
# Template file for 'lsp-plugins'
pkgname=lsp-plugins
version=1.2.14
-revision=1
+revision=2
build_style=gnu-makefile
make_use_env=yes
make_build_args="VERBOSE=0"
@@ -21,6 +21,55 @@ do_configure() {
make LD="$CXX" PREFIX=/usr config
}
+lsp-plugins-lib_package() {
+ short_desc+=" - main libraries"
+ pkg_install() {
+ vmove usr/lib/liblsp-r3d-glx-lib*
+ }
+}
+
+lsp-plugins-xdg_package() {
+ short_desc+=" - XDG integration"
+ pkg_install() {
+ vmove usr/share/applications
+ vmove usr/share/desktop-directories
+ vmove usr/share/icons
+ vmove etc/xdg/menus/applications-merged
+ }
+}
+
+lsp-plugins-clap_package() {
+ short_desc+=" - clap integrations"
+ depends="${sourcepkg}-lib>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/clap
+ }
+}
+
+lsp-plugins-ladspa_package() {
+ short_desc+=" - ladspa integration"
+ depends="${sourcepkg}-lib>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/ladspa
+ }
+}
+
+lsp-plugins-lv2_package() {
+ short_desc+=" - lv2 plugins"
+ depends="lv2>=0.6.0 ${sourcepkg}-lib>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/lv2
+ }
+}
+
+lsp-plugins-vst2_package() {
+ short_desc+=" - vst2 plugins"
+ depends="${sourcepkg}-lib>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/vst
+ }
+}
+
lsp-plugins-doc_package() {
short_desc+=" - documentation"
pkg_install() {
From a291b226d577053d54859195a4680f846dea26ba Mon Sep 17 00:00:00 2001
From: dkwo <npiazza@disroot.org>
Date: Fri, 24 May 2024 12:19:37 -0400
Subject: [PATCH 2/2] lsp-plugins: fix
---
srcpkgs/{lsp-plugins-lib => lsp-plugins-libs} | 0
srcpkgs/lsp-plugins/template | 4 ++--
2 files changed, 2 insertions(+), 2 deletions(-)
rename srcpkgs/{lsp-plugins-lib => lsp-plugins-libs} (100%)
diff --git a/srcpkgs/lsp-plugins-lib b/srcpkgs/lsp-plugins-libs
similarity index 100%
rename from srcpkgs/lsp-plugins-lib
rename to srcpkgs/lsp-plugins-libs
diff --git a/srcpkgs/lsp-plugins/template b/srcpkgs/lsp-plugins/template
index f32c2c133dad07..d6483e7328e870 100644
--- a/srcpkgs/lsp-plugins/template
+++ b/srcpkgs/lsp-plugins/template
@@ -21,10 +21,10 @@ do_configure() {
make LD="$CXX" PREFIX=/usr config
}
-lsp-plugins-lib_package() {
+lsp-plugins-libs_package() {
short_desc+=" - main libraries"
pkg_install() {
- vmove usr/lib/liblsp-r3d-glx-lib*
+ vmove usr/lib/liblsp-r3d-glx-lib*.so
}
}
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
` (4 preceding siblings ...)
2024-05-24 16:22 ` [PR PATCH] [Updated] " dkwo
@ 2024-05-24 16:22 ` dkwo
2024-05-24 16:25 ` [PR PATCH] [Updated] " dkwo
` (8 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: dkwo @ 2024-05-24 16:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 594 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/50486#issuecomment-2129937156
Comment:
Typically, one only needs one plugin, not necessarily all of them, as well as icons etc. You can compare the clutter via `xls`.
If the main package depends on all the splitted ones, then what's the point? I propose an install message, similar to Alpine's one.
> The plugins were split up into multiple subpackages [...] Be sure to install ones you were using.
Would this work?
I'm trying to get the devel part correct. Does it look right now?
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Updated] lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
` (5 preceding siblings ...)
2024-05-24 16:22 ` dkwo
@ 2024-05-24 16:25 ` dkwo
2024-05-26 4:34 ` classabbyamp
` (7 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: dkwo @ 2024-05-24 16:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages lsp
https://github.com/void-linux/void-packages/pull/50486
lsp-plugins: split subpkgs
Tested by me and @slimjimsoftware
This helps unclutter things. @leahneukirchen can you take a look?
A patch file from https://github.com/void-linux/void-packages/pull/50486.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lsp-50486.patch --]
[-- Type: text/x-diff, Size: 5823 bytes --]
From 7d89e0ded877d116675b458912490224a6e4bd1f Mon Sep 17 00:00:00 2001
From: dkwo <npiazza@disroot.org>
Date: Tue, 21 May 2024 12:30:32 -0400
Subject: [PATCH 1/2] lsp-plugins: split subpkgs
---
srcpkgs/lsp-plugins-clap | 1 +
srcpkgs/lsp-plugins-ladspa | 1 +
srcpkgs/lsp-plugins-lib | 1 +
srcpkgs/lsp-plugins-lv2 | 1 +
srcpkgs/lsp-plugins-vst2 | 1 +
srcpkgs/lsp-plugins-xdg | 1 +
srcpkgs/lsp-plugins/template | 51 +++++++++++++++++++++++++++++++++++-
7 files changed, 56 insertions(+), 1 deletion(-)
create mode 120000 srcpkgs/lsp-plugins-clap
create mode 120000 srcpkgs/lsp-plugins-ladspa
create mode 120000 srcpkgs/lsp-plugins-lib
create mode 120000 srcpkgs/lsp-plugins-lv2
create mode 120000 srcpkgs/lsp-plugins-vst2
create mode 120000 srcpkgs/lsp-plugins-xdg
diff --git a/srcpkgs/lsp-plugins-clap b/srcpkgs/lsp-plugins-clap
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-clap
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-ladspa b/srcpkgs/lsp-plugins-ladspa
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-ladspa
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-lib b/srcpkgs/lsp-plugins-lib
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-lib
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-lv2 b/srcpkgs/lsp-plugins-lv2
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-lv2
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-vst2 b/srcpkgs/lsp-plugins-vst2
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-vst2
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-xdg b/srcpkgs/lsp-plugins-xdg
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-xdg
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins/template b/srcpkgs/lsp-plugins/template
index 9473573ff185d1..f32c2c133dad07 100644
--- a/srcpkgs/lsp-plugins/template
+++ b/srcpkgs/lsp-plugins/template
@@ -1,7 +1,7 @@
# Template file for 'lsp-plugins'
pkgname=lsp-plugins
version=1.2.14
-revision=1
+revision=2
build_style=gnu-makefile
make_use_env=yes
make_build_args="VERBOSE=0"
@@ -21,6 +21,55 @@ do_configure() {
make LD="$CXX" PREFIX=/usr config
}
+lsp-plugins-lib_package() {
+ short_desc+=" - main libraries"
+ pkg_install() {
+ vmove usr/lib/liblsp-r3d-glx-lib*
+ }
+}
+
+lsp-plugins-xdg_package() {
+ short_desc+=" - XDG integration"
+ pkg_install() {
+ vmove usr/share/applications
+ vmove usr/share/desktop-directories
+ vmove usr/share/icons
+ vmove etc/xdg/menus/applications-merged
+ }
+}
+
+lsp-plugins-clap_package() {
+ short_desc+=" - clap integrations"
+ depends="${sourcepkg}-lib>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/clap
+ }
+}
+
+lsp-plugins-ladspa_package() {
+ short_desc+=" - ladspa integration"
+ depends="${sourcepkg}-lib>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/ladspa
+ }
+}
+
+lsp-plugins-lv2_package() {
+ short_desc+=" - lv2 plugins"
+ depends="lv2>=0.6.0 ${sourcepkg}-lib>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/lv2
+ }
+}
+
+lsp-plugins-vst2_package() {
+ short_desc+=" - vst2 plugins"
+ depends="${sourcepkg}-lib>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/vst
+ }
+}
+
lsp-plugins-doc_package() {
short_desc+=" - documentation"
pkg_install() {
From c585e64c7a341052dcf4218f1b750c71eaff56d8 Mon Sep 17 00:00:00 2001
From: dkwo <npiazza@disroot.org>
Date: Fri, 24 May 2024 12:19:37 -0400
Subject: [PATCH 2/2] lsp-plugins: fix
---
srcpkgs/{lsp-plugins-lib => lsp-plugins-libs} | 0
srcpkgs/lsp-plugins/template | 12 ++++++------
2 files changed, 6 insertions(+), 6 deletions(-)
rename srcpkgs/{lsp-plugins-lib => lsp-plugins-libs} (100%)
diff --git a/srcpkgs/lsp-plugins-lib b/srcpkgs/lsp-plugins-libs
similarity index 100%
rename from srcpkgs/lsp-plugins-lib
rename to srcpkgs/lsp-plugins-libs
diff --git a/srcpkgs/lsp-plugins/template b/srcpkgs/lsp-plugins/template
index f32c2c133dad07..77929268d1ae42 100644
--- a/srcpkgs/lsp-plugins/template
+++ b/srcpkgs/lsp-plugins/template
@@ -21,10 +21,10 @@ do_configure() {
make LD="$CXX" PREFIX=/usr config
}
-lsp-plugins-lib_package() {
+lsp-plugins-libs_package() {
short_desc+=" - main libraries"
pkg_install() {
- vmove usr/lib/liblsp-r3d-glx-lib*
+ vmove usr/lib/liblsp-r3d-glx-lib*.so
}
}
@@ -40,7 +40,7 @@ lsp-plugins-xdg_package() {
lsp-plugins-clap_package() {
short_desc+=" - clap integrations"
- depends="${sourcepkg}-lib>=${version}_${revision}"
+ depends="${sourcepkg}-libs>=${version}_${revision}"
pkg_install() {
vmove usr/lib/clap
}
@@ -48,7 +48,7 @@ lsp-plugins-clap_package() {
lsp-plugins-ladspa_package() {
short_desc+=" - ladspa integration"
- depends="${sourcepkg}-lib>=${version}_${revision}"
+ depends="${sourcepkg}-libs>=${version}_${revision}"
pkg_install() {
vmove usr/lib/ladspa
}
@@ -56,7 +56,7 @@ lsp-plugins-ladspa_package() {
lsp-plugins-lv2_package() {
short_desc+=" - lv2 plugins"
- depends="lv2>=0.6.0 ${sourcepkg}-lib>=${version}_${revision}"
+ depends="lv2>=0.6.0 ${sourcepkg}-libs>=${version}_${revision}"
pkg_install() {
vmove usr/lib/lv2
}
@@ -64,7 +64,7 @@ lsp-plugins-lv2_package() {
lsp-plugins-vst2_package() {
short_desc+=" - vst2 plugins"
- depends="${sourcepkg}-lib>=${version}_${revision}"
+ depends="${sourcepkg}-libs>=${version}_${revision}"
pkg_install() {
vmove usr/lib/vst
}
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
` (6 preceding siblings ...)
2024-05-24 16:25 ` [PR PATCH] [Updated] " dkwo
@ 2024-05-26 4:34 ` classabbyamp
2024-05-26 5:52 ` classabbyamp
` (6 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: classabbyamp @ 2024-05-26 4:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 257 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/50486#issuecomment-2132062031
Comment:
> If the main package depends on all the splitted ones, then what's the point?
to not break people's setups
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
` (7 preceding siblings ...)
2024-05-26 4:34 ` classabbyamp
@ 2024-05-26 5:52 ` classabbyamp
2024-05-26 16:46 ` [PR PATCH] [Updated] " dkwo
` (5 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: classabbyamp @ 2024-05-26 5:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 364 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/50486#issuecomment-2132062031
Comment:
> If the main package depends on all the splitted ones, then what's the point?
to not break people's setups. we can't know which plugins people were actually using, so `lsp-plugins` should be treated like a metapkg
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Updated] lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
` (8 preceding siblings ...)
2024-05-26 5:52 ` classabbyamp
@ 2024-05-26 16:46 ` dkwo
2024-05-27 14:35 ` dkwo
` (4 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: dkwo @ 2024-05-26 16:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages lsp
https://github.com/void-linux/void-packages/pull/50486
lsp-plugins: split subpkgs
Tested by me and @slimjimsoftware
This helps unclutter things. @leahneukirchen can you take a look?
A patch file from https://github.com/void-linux/void-packages/pull/50486.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lsp-50486.patch --]
[-- Type: text/x-diff, Size: 7270 bytes --]
From b3d635cd8c1d5600611d2ee6831602b3e8b1b6ad Mon Sep 17 00:00:00 2001
From: dkwo <npiazza@disroot.org>
Date: Tue, 21 May 2024 12:30:32 -0400
Subject: [PATCH 1/3] lsp-plugins: split subpkgs
---
srcpkgs/lsp-plugins-clap | 1 +
srcpkgs/lsp-plugins-ladspa | 1 +
srcpkgs/lsp-plugins-lib | 1 +
srcpkgs/lsp-plugins-lv2 | 1 +
srcpkgs/lsp-plugins-vst2 | 1 +
srcpkgs/lsp-plugins-xdg | 1 +
srcpkgs/lsp-plugins/template | 51 +++++++++++++++++++++++++++++++++++-
7 files changed, 56 insertions(+), 1 deletion(-)
create mode 120000 srcpkgs/lsp-plugins-clap
create mode 120000 srcpkgs/lsp-plugins-ladspa
create mode 120000 srcpkgs/lsp-plugins-lib
create mode 120000 srcpkgs/lsp-plugins-lv2
create mode 120000 srcpkgs/lsp-plugins-vst2
create mode 120000 srcpkgs/lsp-plugins-xdg
diff --git a/srcpkgs/lsp-plugins-clap b/srcpkgs/lsp-plugins-clap
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-clap
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-ladspa b/srcpkgs/lsp-plugins-ladspa
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-ladspa
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-lib b/srcpkgs/lsp-plugins-lib
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-lib
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-lv2 b/srcpkgs/lsp-plugins-lv2
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-lv2
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-vst2 b/srcpkgs/lsp-plugins-vst2
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-vst2
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-xdg b/srcpkgs/lsp-plugins-xdg
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-xdg
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins/template b/srcpkgs/lsp-plugins/template
index 9473573ff185d1..f32c2c133dad07 100644
--- a/srcpkgs/lsp-plugins/template
+++ b/srcpkgs/lsp-plugins/template
@@ -1,7 +1,7 @@
# Template file for 'lsp-plugins'
pkgname=lsp-plugins
version=1.2.14
-revision=1
+revision=2
build_style=gnu-makefile
make_use_env=yes
make_build_args="VERBOSE=0"
@@ -21,6 +21,55 @@ do_configure() {
make LD="$CXX" PREFIX=/usr config
}
+lsp-plugins-lib_package() {
+ short_desc+=" - main libraries"
+ pkg_install() {
+ vmove usr/lib/liblsp-r3d-glx-lib*
+ }
+}
+
+lsp-plugins-xdg_package() {
+ short_desc+=" - XDG integration"
+ pkg_install() {
+ vmove usr/share/applications
+ vmove usr/share/desktop-directories
+ vmove usr/share/icons
+ vmove etc/xdg/menus/applications-merged
+ }
+}
+
+lsp-plugins-clap_package() {
+ short_desc+=" - clap integrations"
+ depends="${sourcepkg}-lib>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/clap
+ }
+}
+
+lsp-plugins-ladspa_package() {
+ short_desc+=" - ladspa integration"
+ depends="${sourcepkg}-lib>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/ladspa
+ }
+}
+
+lsp-plugins-lv2_package() {
+ short_desc+=" - lv2 plugins"
+ depends="lv2>=0.6.0 ${sourcepkg}-lib>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/lv2
+ }
+}
+
+lsp-plugins-vst2_package() {
+ short_desc+=" - vst2 plugins"
+ depends="${sourcepkg}-lib>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/vst
+ }
+}
+
lsp-plugins-doc_package() {
short_desc+=" - documentation"
pkg_install() {
From 239e3bc1ce490294f2d28c1d97ea0edc94adb2af Mon Sep 17 00:00:00 2001
From: dkwo <npiazza@disroot.org>
Date: Fri, 24 May 2024 12:19:37 -0400
Subject: [PATCH 2/3] lsp-plugins: fix
---
srcpkgs/{lsp-plugins-lib => lsp-plugins-libs} | 0
srcpkgs/lsp-plugins/template | 12 ++++++------
2 files changed, 6 insertions(+), 6 deletions(-)
rename srcpkgs/{lsp-plugins-lib => lsp-plugins-libs} (100%)
diff --git a/srcpkgs/lsp-plugins-lib b/srcpkgs/lsp-plugins-libs
similarity index 100%
rename from srcpkgs/lsp-plugins-lib
rename to srcpkgs/lsp-plugins-libs
diff --git a/srcpkgs/lsp-plugins/template b/srcpkgs/lsp-plugins/template
index f32c2c133dad07..77929268d1ae42 100644
--- a/srcpkgs/lsp-plugins/template
+++ b/srcpkgs/lsp-plugins/template
@@ -21,10 +21,10 @@ do_configure() {
make LD="$CXX" PREFIX=/usr config
}
-lsp-plugins-lib_package() {
+lsp-plugins-libs_package() {
short_desc+=" - main libraries"
pkg_install() {
- vmove usr/lib/liblsp-r3d-glx-lib*
+ vmove usr/lib/liblsp-r3d-glx-lib*.so
}
}
@@ -40,7 +40,7 @@ lsp-plugins-xdg_package() {
lsp-plugins-clap_package() {
short_desc+=" - clap integrations"
- depends="${sourcepkg}-lib>=${version}_${revision}"
+ depends="${sourcepkg}-libs>=${version}_${revision}"
pkg_install() {
vmove usr/lib/clap
}
@@ -48,7 +48,7 @@ lsp-plugins-clap_package() {
lsp-plugins-ladspa_package() {
short_desc+=" - ladspa integration"
- depends="${sourcepkg}-lib>=${version}_${revision}"
+ depends="${sourcepkg}-libs>=${version}_${revision}"
pkg_install() {
vmove usr/lib/ladspa
}
@@ -56,7 +56,7 @@ lsp-plugins-ladspa_package() {
lsp-plugins-lv2_package() {
short_desc+=" - lv2 plugins"
- depends="lv2>=0.6.0 ${sourcepkg}-lib>=${version}_${revision}"
+ depends="lv2>=0.6.0 ${sourcepkg}-libs>=${version}_${revision}"
pkg_install() {
vmove usr/lib/lv2
}
@@ -64,7 +64,7 @@ lsp-plugins-lv2_package() {
lsp-plugins-vst2_package() {
short_desc+=" - vst2 plugins"
- depends="${sourcepkg}-lib>=${version}_${revision}"
+ depends="${sourcepkg}-libs>=${version}_${revision}"
pkg_install() {
vmove usr/lib/vst
}
From ae7ab395e24a35ee9dad2cffea5de6aa4b826f06 Mon Sep 17 00:00:00 2001
From: dkwo <npiazza@disroot.org>
Date: Sun, 26 May 2024 12:42:08 -0400
Subject: [PATCH 3/3] lsp-plugins: make it effectively a metapkg
---
srcpkgs/lsp-plugins/template | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/lsp-plugins/template b/srcpkgs/lsp-plugins/template
index 77929268d1ae42..40dce0617d9dfb 100644
--- a/srcpkgs/lsp-plugins/template
+++ b/srcpkgs/lsp-plugins/template
@@ -8,6 +8,8 @@ make_build_args="VERBOSE=0"
hostmakedepends="pkg-config php lv2"
makedepends="lv2 libglvnd-devel jack-devel libsndfile-devel
libXrandr-devel cairo-devel freetype-devel"
+depends="lsp-plugins-libs lsp-plugins-xdg
+ lsp-plugins-clap lsp-plugins-ladspa lsp-plugins-lv2 lsp-plugins-vst2"
short_desc="Collection of open-source audio plugins for studios"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
@@ -25,6 +27,7 @@ lsp-plugins-libs_package() {
short_desc+=" - main libraries"
pkg_install() {
vmove usr/lib/liblsp-r3d-glx-lib*.so
+ vmove usr/lib/lsp-plugins/liblsp-plugins-jack*.so
}
}
@@ -82,10 +85,6 @@ lsp-plugins-devel_package() {
short_desc+=" - development files"
pkg_install() {
vmove usr/lib/pkgconfig
- for f in $DESTDIR/usr/lib/*; do
- if echo ${f##*/} | grep -Eq '^[^.]*\.(a|so)$'; then
- vmove ${f#$DESTDIR/}
- fi
- done
+ vmove usr/lib/liblsp-r3d-glx-lib*.a
}
}
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
` (9 preceding siblings ...)
2024-05-26 16:46 ` [PR PATCH] [Updated] " dkwo
@ 2024-05-27 14:35 ` dkwo
2024-05-27 14:44 ` classabbyamp
` (3 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: dkwo @ 2024-05-27 14:35 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 206 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/50486#issuecomment-2133611942
Comment:
Let me know if this is now acceptable, then I'll squash my commits.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
` (10 preceding siblings ...)
2024-05-27 14:35 ` dkwo
@ 2024-05-27 14:44 ` classabbyamp
2024-05-27 22:56 ` [PR PATCH] [Updated] " dkwo
` (2 subsequent siblings)
14 siblings, 0 replies; 16+ messages in thread
From: classabbyamp @ 2024-05-27 14:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/50486#issuecomment-2133626720
Comment:
squash it
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Updated] lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
` (11 preceding siblings ...)
2024-05-27 14:44 ` classabbyamp
@ 2024-05-27 22:56 ` dkwo
2024-05-27 22:57 ` dkwo
2024-05-31 6:28 ` [PR PATCH] [Merged]: " classabbyamp
14 siblings, 0 replies; 16+ messages in thread
From: dkwo @ 2024-05-27 22:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages lsp
https://github.com/void-linux/void-packages/pull/50486
lsp-plugins: split subpkgs
Tested by me and @slimjimsoftware
This helps unclutter things. @leahneukirchen can you take a look?
A patch file from https://github.com/void-linux/void-packages/pull/50486.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lsp-50486.patch --]
[-- Type: text/x-diff, Size: 4500 bytes --]
From 632f6b3fb4e12b2fed2d9803ae24cc1b587c5783 Mon Sep 17 00:00:00 2001
From: dkwo <npiazza@disroot.org>
Date: Tue, 21 May 2024 12:30:32 -0400
Subject: [PATCH] lsp-plugins: split subpkgs, make it a metapkg
---
srcpkgs/lsp-plugins-clap | 1 +
srcpkgs/lsp-plugins-ladspa | 1 +
srcpkgs/lsp-plugins-libs | 1 +
srcpkgs/lsp-plugins-lv2 | 1 +
srcpkgs/lsp-plugins-vst2 | 1 +
srcpkgs/lsp-plugins-xdg | 1 +
srcpkgs/lsp-plugins/template | 60 ++++++++++++++++++++++++++++++++----
7 files changed, 60 insertions(+), 6 deletions(-)
create mode 120000 srcpkgs/lsp-plugins-clap
create mode 120000 srcpkgs/lsp-plugins-ladspa
create mode 120000 srcpkgs/lsp-plugins-libs
create mode 120000 srcpkgs/lsp-plugins-lv2
create mode 120000 srcpkgs/lsp-plugins-vst2
create mode 120000 srcpkgs/lsp-plugins-xdg
diff --git a/srcpkgs/lsp-plugins-clap b/srcpkgs/lsp-plugins-clap
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-clap
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-ladspa b/srcpkgs/lsp-plugins-ladspa
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-ladspa
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-libs b/srcpkgs/lsp-plugins-libs
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-libs
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-lv2 b/srcpkgs/lsp-plugins-lv2
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-lv2
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-vst2 b/srcpkgs/lsp-plugins-vst2
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-vst2
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins-xdg b/srcpkgs/lsp-plugins-xdg
new file mode 120000
index 00000000000000..f59057b0c7f794
--- /dev/null
+++ b/srcpkgs/lsp-plugins-xdg
@@ -0,0 +1 @@
+lsp-plugins
\ No newline at end of file
diff --git a/srcpkgs/lsp-plugins/template b/srcpkgs/lsp-plugins/template
index 9473573ff185d1..40dce0617d9dfb 100644
--- a/srcpkgs/lsp-plugins/template
+++ b/srcpkgs/lsp-plugins/template
@@ -1,13 +1,15 @@
# Template file for 'lsp-plugins'
pkgname=lsp-plugins
version=1.2.14
-revision=1
+revision=2
build_style=gnu-makefile
make_use_env=yes
make_build_args="VERBOSE=0"
hostmakedepends="pkg-config php lv2"
makedepends="lv2 libglvnd-devel jack-devel libsndfile-devel
libXrandr-devel cairo-devel freetype-devel"
+depends="lsp-plugins-libs lsp-plugins-xdg
+ lsp-plugins-clap lsp-plugins-ladspa lsp-plugins-lv2 lsp-plugins-vst2"
short_desc="Collection of open-source audio plugins for studios"
maintainer="Orphaned <orphan@voidlinux.org>"
license="GPL-3.0-or-later"
@@ -21,6 +23,56 @@ do_configure() {
make LD="$CXX" PREFIX=/usr config
}
+lsp-plugins-libs_package() {
+ short_desc+=" - main libraries"
+ pkg_install() {
+ vmove usr/lib/liblsp-r3d-glx-lib*.so
+ vmove usr/lib/lsp-plugins/liblsp-plugins-jack*.so
+ }
+}
+
+lsp-plugins-xdg_package() {
+ short_desc+=" - XDG integration"
+ pkg_install() {
+ vmove usr/share/applications
+ vmove usr/share/desktop-directories
+ vmove usr/share/icons
+ vmove etc/xdg/menus/applications-merged
+ }
+}
+
+lsp-plugins-clap_package() {
+ short_desc+=" - clap integrations"
+ depends="${sourcepkg}-libs>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/clap
+ }
+}
+
+lsp-plugins-ladspa_package() {
+ short_desc+=" - ladspa integration"
+ depends="${sourcepkg}-libs>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/ladspa
+ }
+}
+
+lsp-plugins-lv2_package() {
+ short_desc+=" - lv2 plugins"
+ depends="lv2>=0.6.0 ${sourcepkg}-libs>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/lv2
+ }
+}
+
+lsp-plugins-vst2_package() {
+ short_desc+=" - vst2 plugins"
+ depends="${sourcepkg}-libs>=${version}_${revision}"
+ pkg_install() {
+ vmove usr/lib/vst
+ }
+}
+
lsp-plugins-doc_package() {
short_desc+=" - documentation"
pkg_install() {
@@ -33,10 +85,6 @@ lsp-plugins-devel_package() {
short_desc+=" - development files"
pkg_install() {
vmove usr/lib/pkgconfig
- for f in $DESTDIR/usr/lib/*; do
- if echo ${f##*/} | grep -Eq '^[^.]*\.(a|so)$'; then
- vmove ${f#$DESTDIR/}
- fi
- done
+ vmove usr/lib/liblsp-r3d-glx-lib*.a
}
}
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
` (12 preceding siblings ...)
2024-05-27 22:56 ` [PR PATCH] [Updated] " dkwo
@ 2024-05-27 22:57 ` dkwo
2024-05-31 6:28 ` [PR PATCH] [Merged]: " classabbyamp
14 siblings, 0 replies; 16+ messages in thread
From: dkwo @ 2024-05-27 22:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 145 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/50486#issuecomment-2134121984
Comment:
Done.
^ permalink raw reply [flat|nested] 16+ messages in thread* Re: [PR PATCH] [Merged]: lsp-plugins: split subpkgs
2024-05-23 14:01 [PR PATCH] lsp-plugins: split subpkgs dkwo
` (13 preceding siblings ...)
2024-05-27 22:57 ` dkwo
@ 2024-05-31 6:28 ` classabbyamp
14 siblings, 0 replies; 16+ messages in thread
From: classabbyamp @ 2024-05-31 6:28 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
There's a merged pull request on the void-packages repository
lsp-plugins: split subpkgs
https://github.com/void-linux/void-packages/pull/50486
Description:
Tested by me and @slimjimsoftware
This helps unclutter things. @leahneukirchen can you take a look?
^ permalink raw reply [flat|nested] 16+ messages in thread