Github messages for voidlinux
 help / color / mirror / Atom feed
From: Zapeth <Zapeth@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] unrar: strip out native compilation flag
Date: Tue, 28 May 2024 16:11:34 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50557@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

There is a new pull request by Zapeth against master on the void-packages repository

https://github.com/Zapeth/void-packages unrar-patch
https://github.com/void-linux/void-packages/pull/50557

unrar: strip out native compilation flag
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

This should get rid of the native compilation flag in the makefile script.

Not sure if it was included upstream by mistake, but it should be looked out for when new versions are released (ie revert this change if the flag gets removed again).

A patch file from https://github.com/void-linux/void-packages/pull/50557.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-unrar-patch-50557.patch --]
[-- Type: text/x-diff, Size: 1285 bytes --]

From 9307170d3a5387e1be4a9721ee0c79149597f21b Mon Sep 17 00:00:00 2001
From: Zapeth <Zapeth@users.noreply.github.com>
Date: Tue, 28 May 2024 16:02:55 +0200
Subject: [PATCH] unrar: strip out native compilation flag

---
 srcpkgs/unrar/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/unrar/template b/srcpkgs/unrar/template
index 105c51b84bf33b..46f7375ca85090 100644
--- a/srcpkgs/unrar/template
+++ b/srcpkgs/unrar/template
@@ -1,7 +1,7 @@
 # Template file for 'unrar'
 pkgname=unrar
 version=7.0.9
-revision=1
+revision=2
 archs="x86_64* i686*"
 short_desc="Unarchiver for .rar files (non-free version)"
 maintainer="skmpz <dem.procopiou@gmail.com>"
@@ -12,13 +12,12 @@ checksum=505c13f9e4c54c01546f2e29b2fcc2d7fabc856a060b81e5cdfe6012a9198326
 repository=nonfree
 
 do_build() {
-	vsed -e 's/^\(CXXFLAGS\)=\(.*\)/\1+=\2/' \
+	vsed -e 's/^\(CXXFLAGS\)=-march=native \(.*\)/\1+=\2/' \
 		 -e 's/^\(LDFLAGS\)=\(.*\)/\1+=-lpthread \2/' \
 		 -i makefile
 	make CXX="$CXX" LD="$LD" STRIP=: -f makefile
-	# early install of unrar because makefile deletes unrar on lib creation
+	# early install of unrar because need to clean for lib creation
 	vbin unrar
-	# recompile for lib
 	make clean
 	make CXX="$CXX" LD="$LD" STRIP=: -f makefile lib
 }

             reply	other threads:[~2024-05-28 14:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 14:11 Zapeth [this message]
2024-06-09 15:58 ` [PR REVIEW] " vincele
2024-06-09 15:58 ` vincele
2024-06-09 15:58 ` vincele
2024-06-09 16:50 ` Zapeth
2024-06-09 16:52 ` Zapeth
2024-06-09 17:37 ` vincele
2024-06-09 17:40 ` vincele
2024-06-15 21:56 ` [PR PATCH] [Closed]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50557@inbox.vuxu.org \
    --to=zapeth@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).