Github messages for voidlinux
 help / color / mirror / Atom feed
From: deimonn <deimonn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] vscode: remove deprecated --unity-launch flag from desktop file
Date: Mon, 10 Jun 2024 18:06:19 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50762@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

There is a new pull request by deimonn against master on the void-packages repository

https://github.com/deimonn/void-packages vscode
https://github.com/void-linux/void-packages/pull/50762

vscode: remove deprecated --unity-launch flag from desktop file
VSCode has [deprecated the --unity-launch flag](https://github.com/microsoft/vscode/issues/202545) and its presence was breaking the "Open with Code" context menu option.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

Closes #50682

A patch file from https://github.com/void-linux/void-packages/pull/50762.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-vscode-50762.patch --]
[-- Type: text/x-diff, Size: 1272 bytes --]

From 948492fcc2fc5ed8ea1728b8b56ee541c7a2c088 Mon Sep 17 00:00:00 2001
From: deimonn <deimonn@outlook.com>
Date: Mon, 10 Jun 2024 11:53:26 -0300
Subject: [PATCH] vscode: remove deprecated --unity-launch flag from desktop
 file

---
 srcpkgs/vscode/patches/fix_dir.patch | 2 +-
 srcpkgs/vscode/template              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/vscode/patches/fix_dir.patch b/srcpkgs/vscode/patches/fix_dir.patch
index dbe615623d3c31..ca35ae86c677a4 100644
--- a/srcpkgs/vscode/patches/fix_dir.patch
+++ b/srcpkgs/vscode/patches/fix_dir.patch
@@ -33,7 +33,7 @@ index 4c939a2fab8..1f94f5fccfb 100755
  Comment=Code Editing. Redefined.
  GenericName=Text Editor
 -Exec=@@EXEC@@ %F
-+Exec=/usr/lib/@@NAME@@/bin/@@NAME@@ --unity-launch %F
++Exec=/usr/lib/@@NAME@@/bin/@@NAME@@ %F
  Icon=@@ICON@@
  Type=Application
  StartupNotify=false
diff --git a/srcpkgs/vscode/template b/srcpkgs/vscode/template
index deb3846a0037d0..97bfe6419f69d7 100644
--- a/srcpkgs/vscode/template
+++ b/srcpkgs/vscode/template
@@ -1,7 +1,7 @@
 # Template file for 'vscode'
 pkgname=vscode
 version=1.90.0
-revision=1
+revision=2
 _electronver=24.3.0
 _npmver=8.6.0
 hostmakedepends="pkg-config python3 python3-setuptools nodejs yarn tar git ripgrep"

             reply	other threads:[~2024-06-10 16:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 16:06 deimonn [this message]
2024-06-10 16:21 ` classabbyamp
2024-06-10 16:35 ` deimonn
2024-06-11 17:02 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-50762@inbox.vuxu.org \
    --to=deimonn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).