[PR PATCH] New package: biboumi-9.0.

[PR PATCH] New package: biboumi-9.0.

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]

There is a new pull request by AnInternetTroll against master on the void-packages repository

https://github.com/AnInternetTroll/void-packages user/luca/biboumi
https://github.com/void-linux/void-packages/pull/50855

New package: biboumi-9.0.
#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the package requirements: YES

#### Local build testing

- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl (crossbuild)

Crossbuilt from x86_64-glibc to aarch64-musl and tested with
prosody-0.12.4 (packaged on #48919).

Resubmission after stalebot caught me slacking in #49051


A patch file from https://github.com/void-linux/void-packages/pull/50855.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-user/luca/biboumi-50855.patch --]
[-- Type: text/x-diff, Size: 3218 bytes --]

From d77b038e203cac9b144bb389db6de50f54961f57 Mon Sep 17 00:00:00 2001
From: Luca Matei Pintilie <luca@lucamatei.com>
Date: Wed, 28 Feb 2024 19:17:42 +0100
Subject: [PATCH] New package: biboumi-9.0.

---
 srcpkgs/biboumi/files/biboumi/run        |  3 +++
 srcpkgs/biboumi/patches/remove-git.patch | 33 ++++++++++++++++++++++++
 srcpkgs/biboumi/template                 | 24 +++++++++++++++++
 3 files changed, 60 insertions(+)
 create mode 100644 srcpkgs/biboumi/files/biboumi/run
 create mode 100644 srcpkgs/biboumi/patches/remove-git.patch
 create mode 100644 srcpkgs/biboumi/template

diff --git a/srcpkgs/biboumi/files/biboumi/run b/srcpkgs/biboumi/files/biboumi/run
new file mode 100644
index 00000000000000..bcb8768436d329
--- /dev/null
+++ b/srcpkgs/biboumi/files/biboumi/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec chpst -u _biboumi:_biboumi biboumi /etc/biboumi/biboumi.cfg
diff --git a/srcpkgs/biboumi/patches/remove-git.patch b/srcpkgs/biboumi/patches/remove-git.patch
new file mode 100644
index 00000000000000..9d6290cf3f8b32
--- /dev/null
+++ b/srcpkgs/biboumi/patches/remove-git.patch
@@ -0,0 +1,33 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 687d68b..47bb1a0 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -287,27 +287,6 @@ foreach(file ${source_all})
+   set_property(SOURCE ${file} APPEND PROPERTY COMPILE_DEFINITIONS __FILENAME__="${shorter_file}")
+ endforeach()
+ 
+-#
+-## Add a rule to download the catch unit test framework
+-#
+-include(ExternalProject)
+-ExternalProject_Add(catch
+-  GIT_REPOSITORY "https://lab.louiz.org/louiz/Catch.git"
+-  PREFIX "external"
+-  UPDATE_COMMAND ""
+-  CONFIGURE_COMMAND ""
+-  BUILD_COMMAND ""
+-  INSTALL_COMMAND ""
+-  )
+-set_target_properties(catch PROPERTIES EXCLUDE_FROM_ALL TRUE)
+-ExternalProject_Get_Property(catch SOURCE_DIR)
+-if(NOT EXISTS ${CMAKE_SOURCE_DIR}/tests/catch.hpp)
+-  target_include_directories(test_suite
+-    PUBLIC "${SOURCE_DIR}/single_include/"
+-    )
+-  add_dependencies(test_suite catch)
+-endif()
+-
+ #
+ ## Add some custom rules to launch the tests
+ #
+
diff --git a/srcpkgs/biboumi/template b/srcpkgs/biboumi/template
new file mode 100644
index 00000000000000..e32e12eff411cd
--- /dev/null
+++ b/srcpkgs/biboumi/template
@@ -0,0 +1,24 @@
+# Template file for 'biboumi'
+pkgname=biboumi
+version=9.0
+revision=1
+build_style=cmake
+configure_args="-DWITHOUT_SYSTEMD=1 -Wno-dev"
+conf_files="/etc/biboumi/biboumi.cfg"
+make_dirs="/var/lib/biboumi/ 0755 _biboumi _biboumi"
+hostmakedepends="python3-Sphinx python3-sphinx_rtd_theme pkg-config"
+makedepends="expat-devel libticonv-devel sqlite-devel libpqxx-devel libidn-devel udns-devel botan-devel postgresql-libs-devel"
+short_desc="XMPP gateway that connects to IRC servers"
+maintainer="Luca Matei Pintilie <luca@lucamatei.com>"
+license="Zlib"
+homepage="https://biboumi.louiz.org/"
+changelog="https://codeberg.org/poezio/biboumi/src/branch/master/CHANGELOG.rst"
+distfiles="https://codeberg.org/poezio/biboumi/archive/${version}.tar.gz"
+checksum="618776cf3dccb59c84322a921681f4b1f8b144b523fd5e118d2b47fb0f3eb43f"
+
+system_accounts="_biboumi"
+
+post_install() {
+	cp conf/biboumi.cfg "${DESTDIR}/etc/biboumi/biboumi.cfg"
+	vsv biboumi
+}

Re: [PR REVIEW] New package: biboumi-9.0.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 169 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50855#discussion_r1641974348

Comment:
wrap at ~80chars

Re: [PR REVIEW] New package: biboumi-9.0.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50855#discussion_r1641974811

Comment:
should probably have `_biboumi_homedir="/var/lib/biboumi"` which might remove the need for `make_dirs`

Re: [PR REVIEW] New package: biboumi-9.0.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50855#discussion_r1641974896

Comment:
vinstall

Re: [PR REVIEW] New package: biboumi-9.0.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50855#discussion_r1641975018

Comment:
```suggestion
short_desc="XMPP to IRC gateway"
```
best to use upstream description

Re: [PR PATCH] [Updated] New package: biboumi-9.0.

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

There is an updated pull request by AnInternetTroll against master on the void-packages repository

https://github.com/AnInternetTroll/void-packages user/luca/biboumi
https://github.com/void-linux/void-packages/pull/50855

New package: biboumi-9.0.
#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the package requirements: YES

#### Local build testing

- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl (crossbuild)

Crossbuilt from x86_64-glibc to aarch64-musl and tested with
prosody-0.12.4 (packaged on #48919).

Resubmission after stalebot caught me slacking in #49051


A patch file from https://github.com/void-linux/void-packages/pull/50855.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-user/luca/biboumi-50855.patch --]
[-- Type: text/x-diff, Size: 3223 bytes --]

From c65c4d5e8061f25613d58543fa02bc3151500574 Mon Sep 17 00:00:00 2001
From: Luca Matei Pintilie <luca@lucamatei.com>
Date: Wed, 28 Feb 2024 19:17:42 +0100
Subject: [PATCH] New package: biboumi-9.0.

---
 srcpkgs/biboumi/files/biboumi/run        |  3 +++
 srcpkgs/biboumi/patches/remove-git.patch | 33 ++++++++++++++++++++++++
 srcpkgs/biboumi/template                 | 26 +++++++++++++++++++
 3 files changed, 62 insertions(+)
 create mode 100644 srcpkgs/biboumi/files/biboumi/run
 create mode 100644 srcpkgs/biboumi/patches/remove-git.patch
 create mode 100644 srcpkgs/biboumi/template

diff --git a/srcpkgs/biboumi/files/biboumi/run b/srcpkgs/biboumi/files/biboumi/run
new file mode 100644
index 00000000000000..bcb8768436d329
--- /dev/null
+++ b/srcpkgs/biboumi/files/biboumi/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec chpst -u _biboumi:_biboumi biboumi /etc/biboumi/biboumi.cfg
diff --git a/srcpkgs/biboumi/patches/remove-git.patch b/srcpkgs/biboumi/patches/remove-git.patch
new file mode 100644
index 00000000000000..9d6290cf3f8b32
--- /dev/null
+++ b/srcpkgs/biboumi/patches/remove-git.patch
@@ -0,0 +1,33 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 687d68b..47bb1a0 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -287,27 +287,6 @@ foreach(file ${source_all})
+   set_property(SOURCE ${file} APPEND PROPERTY COMPILE_DEFINITIONS __FILENAME__="${shorter_file}")
+ endforeach()
+ 
+-#
+-## Add a rule to download the catch unit test framework
+-#
+-include(ExternalProject)
+-ExternalProject_Add(catch
+-  GIT_REPOSITORY "https://lab.louiz.org/louiz/Catch.git"
+-  PREFIX "external"
+-  UPDATE_COMMAND ""
+-  CONFIGURE_COMMAND ""
+-  BUILD_COMMAND ""
+-  INSTALL_COMMAND ""
+-  )
+-set_target_properties(catch PROPERTIES EXCLUDE_FROM_ALL TRUE)
+-ExternalProject_Get_Property(catch SOURCE_DIR)
+-if(NOT EXISTS ${CMAKE_SOURCE_DIR}/tests/catch.hpp)
+-  target_include_directories(test_suite
+-    PUBLIC "${SOURCE_DIR}/single_include/"
+-    )
+-  add_dependencies(test_suite catch)
+-endif()
+-
+ #
+ ## Add some custom rules to launch the tests
+ #
+
diff --git a/srcpkgs/biboumi/template b/srcpkgs/biboumi/template
new file mode 100644
index 00000000000000..7a4ee80c3f578e
--- /dev/null
+++ b/srcpkgs/biboumi/template
@@ -0,0 +1,26 @@
+# Template file for 'biboumi'
+pkgname=biboumi
+version=9.0
+revision=1
+build_style=cmake
+configure_args="-DWITHOUT_SYSTEMD=1 -Wno-dev"
+conf_files="/etc/biboumi/biboumi.cfg"
+make_dirs="/var/lib/biboumi/ 0755 _biboumi _biboumi"
+hostmakedepends="python3-Sphinx python3-sphinx_rtd_theme pkg-config"
+makedepends="expat-devel libticonv-devel sqlite-devel libpqxx-devel
+ libidn-devel udns-devel botan-devel postgresql-libs-devel"
+short_desc="XMPP to IRC gateway"
+maintainer="Luca Matei Pintilie <luca@lucamatei.com>"
+license="Zlib"
+homepage="https://biboumi.louiz.org/"
+changelog="https://codeberg.org/poezio/biboumi/raw/branch/master/CHANGELOG.rst"
+distfiles="https://codeberg.org/poezio/biboumi/archive/${version}.tar.gz"
+checksum="618776cf3dccb59c84322a921681f4b1f8b144b523fd5e118d2b47fb0f3eb43f"
+
+system_accounts="_biboumi"
+_biboumi_homedir="/var/lib/biboumi"
+
+post_install() {
+	vinstall conf/biboumi.cfg 644 /etc/biboumi
+	vsv biboumi
+}

Re: [PR REVIEW] New package: biboumi-9.0.

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 231 bytes --]

New review comment by AnInternetTroll on void-packages repository

https://github.com/void-linux/void-packages/pull/50855#discussion_r1643152163

Comment:
Doesn't seem like _homedir creates the folder, so I kept the make_dirs line

Re: [PR PATCH] [Merged]: New package: biboumi-9.0.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 669 bytes --]

There's a merged pull request on the void-packages repository

New package: biboumi-9.0.
https://github.com/void-linux/void-packages/pull/50855

Description:
#### Testing the changes
- I tested the changes in this PR: YES

#### New package
- This new package conforms to the package requirements: YES

#### Local build testing

- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl (crossbuild)

Crossbuilt from x86_64-glibc to aarch64-musl and tested with
prosody-0.12.4 (packaged on #48919).

Resubmission after stalebot caught me slacking in #49051

[PR PATCH] New package: biboumi-9.0.

[AnInternetTroll]

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]

There is a new pull request by AnInternetTroll against master on the void-packages repository

https://github.com/AnInternetTroll/void-packages user/luca/biboumi
https://github.com/void-linux/void-packages/pull/49051

New package: biboumi-9.0.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86\_64-glibc)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl (crossbuild)

Crossbuilt from x86\_64-glibc to aarch64-musl and tested with
prosody-0.12.4 (packaged on #48919).


A patch file from https://github.com/void-linux/void-packages/pull/49051.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-user/luca/biboumi-49051.patch --]
[-- Type: text/x-diff, Size: 3218 bytes --]

From 1ea9ca63be9b8787d8b0246877c4092182c68803 Mon Sep 17 00:00:00 2001
From: Luca Matei Pintilie <luca@lucamatei.com>
Date: Wed, 28 Feb 2024 19:17:42 +0100
Subject: [PATCH] New package: biboumi-9.0.

---
 srcpkgs/biboumi/files/biboumi/run        |  3 +++
 srcpkgs/biboumi/patches/remove-git.patch | 33 ++++++++++++++++++++++++
 srcpkgs/biboumi/template                 | 24 +++++++++++++++++
 3 files changed, 60 insertions(+)
 create mode 100644 srcpkgs/biboumi/files/biboumi/run
 create mode 100644 srcpkgs/biboumi/patches/remove-git.patch
 create mode 100644 srcpkgs/biboumi/template

diff --git a/srcpkgs/biboumi/files/biboumi/run b/srcpkgs/biboumi/files/biboumi/run
new file mode 100644
index 00000000000000..bcb8768436d329
--- /dev/null
+++ b/srcpkgs/biboumi/files/biboumi/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec chpst -u _biboumi:_biboumi biboumi /etc/biboumi/biboumi.cfg
diff --git a/srcpkgs/biboumi/patches/remove-git.patch b/srcpkgs/biboumi/patches/remove-git.patch
new file mode 100644
index 00000000000000..9d6290cf3f8b32
--- /dev/null
+++ b/srcpkgs/biboumi/patches/remove-git.patch
@@ -0,0 +1,33 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 687d68b..47bb1a0 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -287,27 +287,6 @@ foreach(file ${source_all})
+   set_property(SOURCE ${file} APPEND PROPERTY COMPILE_DEFINITIONS __FILENAME__="${shorter_file}")
+ endforeach()
+ 
+-#
+-## Add a rule to download the catch unit test framework
+-#
+-include(ExternalProject)
+-ExternalProject_Add(catch
+-  GIT_REPOSITORY "https://lab.louiz.org/louiz/Catch.git"
+-  PREFIX "external"
+-  UPDATE_COMMAND ""
+-  CONFIGURE_COMMAND ""
+-  BUILD_COMMAND ""
+-  INSTALL_COMMAND ""
+-  )
+-set_target_properties(catch PROPERTIES EXCLUDE_FROM_ALL TRUE)
+-ExternalProject_Get_Property(catch SOURCE_DIR)
+-if(NOT EXISTS ${CMAKE_SOURCE_DIR}/tests/catch.hpp)
+-  target_include_directories(test_suite
+-    PUBLIC "${SOURCE_DIR}/single_include/"
+-    )
+-  add_dependencies(test_suite catch)
+-endif()
+-
+ #
+ ## Add some custom rules to launch the tests
+ #
+
diff --git a/srcpkgs/biboumi/template b/srcpkgs/biboumi/template
new file mode 100644
index 00000000000000..e32e12eff411cd
--- /dev/null
+++ b/srcpkgs/biboumi/template
@@ -0,0 +1,24 @@
+# Template file for 'biboumi'
+pkgname=biboumi
+version=9.0
+revision=1
+build_style=cmake
+configure_args="-DWITHOUT_SYSTEMD=1 -Wno-dev"
+conf_files="/etc/biboumi/biboumi.cfg"
+make_dirs="/var/lib/biboumi/ 0755 _biboumi _biboumi"
+hostmakedepends="python3-Sphinx python3-sphinx_rtd_theme pkg-config"
+makedepends="expat-devel libticonv-devel sqlite-devel libpqxx-devel libidn-devel udns-devel botan-devel postgresql-libs-devel"
+short_desc="XMPP gateway that connects to IRC servers"
+maintainer="Luca Matei Pintilie <luca@lucamatei.com>"
+license="Zlib"
+homepage="https://biboumi.louiz.org/"
+changelog="https://codeberg.org/poezio/biboumi/src/branch/master/CHANGELOG.rst"
+distfiles="https://codeberg.org/poezio/biboumi/archive/${version}.tar.gz"
+checksum="618776cf3dccb59c84322a921681f4b1f8b144b523fd5e118d2b47fb0f3eb43f"
+
+system_accounts="_biboumi"
+
+post_install() {
+	cp conf/biboumi.cfg "${DESTDIR}/etc/biboumi/biboumi.cfg"
+	vsv biboumi
+}