[PR PATCH] ClusterSSH: update to 4.16

[PR PATCH] ClusterSSH: update to 4.16

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 585 bytes --]

There is a new pull request by clyhtsuriva against master on the void-packages repository

https://github.com/clyhtsuriva/void-packages ClusterSSH-update
https://github.com/void-linux/void-packages/pull/50916

ClusterSSH: update to 4.16
#### Testing the changes
- I tested the changes in this PR: **yes**

#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I crossbuilded this PR locally for these architectures:
  - armv7l
  - armv6l-musl
  - aarch64-musl

A patch file from https://github.com/void-linux/void-packages/pull/50916.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ClusterSSH-update-50916.patch --]
[-- Type: text/x-diff, Size: 1164 bytes --]

From dee7510ca10e8cf27a6da8ce2d1141d3896c100f Mon Sep 17 00:00:00 2001
From: clyhtsuriva <aimeric@adjutor.xyz>
Date: Fri, 21 Jun 2024 23:09:25 +0200
Subject: [PATCH] ClusterSSH: update to 4.16

---
 srcpkgs/ClusterSSH/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ClusterSSH/template b/srcpkgs/ClusterSSH/template
index 7e3b2c42b43453..7cb23aeaea58e8 100644
--- a/srcpkgs/ClusterSSH/template
+++ b/srcpkgs/ClusterSSH/template
@@ -1,7 +1,7 @@
 # Template file for 'ClusterSSH'
 pkgname=ClusterSSH
-version=4.14
-revision=3
+version=4.16
+revision=1
 build_style=perl-ModuleBuild
 hostmakedepends="xterm openssh
  perl-CPAN-Changes perl-Module-Build perl-Try-Tiny perl-Tk
@@ -16,7 +16,7 @@ license="Artistic-1.0-Perl, GPL-1.0-or-later"
 homepage="https://github.com/duncs/clusterssh"
 changelog="https://raw.githubusercontent.com/duncs/clusterssh/master/Changes"
 distfiles="https://github.com/duncs/clusterssh/archive/v${version}.tar.gz"
-checksum=179ac8a7c27ec9674d2aa3f65ebb097b4945646c71f83f52fe2b8b24c21cd629
+checksum=1540f42bd521066ab0a41504258ac1aa4c501c6f713057f8906bb896f3335b9f
 
 pre_check() {
 	touch README

Re: ClusterSSH: update to 4.16

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

New comment by clyhtsuriva on void-packages repository

https://github.com/void-linux/void-packages/pull/50916#issuecomment-2183473775

Comment:
> Test Summary Report
> -------------------
> t/05getopts.t   (Wstat: 0 Tests: 175 Failed: 0)
>   TODO passed:   160-163, 168-171
> t/15config.t    (Wstat: 512 (exited 2) Tests: 155 Failed: 2)
>   Failed tests:  147, 151
>   Non-zero exit status: 2
> Files=14, Tests=1957,  2 wallclock secs ( 0.13 usr  0.02 sys +  1.55 cusr  0.33 csys =  2.03 CPU)
> Result: FAIL
> Failed 1/14 test programs. 2/1957 subtests failed.
> => ERROR: ClusterSSH-4.16_1: do_check: '${make_check_pre} ./Build test' exited with 255
> => ERROR:   in do_check() at common/build-style/perl-ModuleBuild.sh:44
> 
> Error: Process completed with exit code 1.

Weird, I had no issues natively on my x86_64, glibc system...

Re: ClusterSSH: update to 4.16

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50916#issuecomment-2183600917

Comment:
one of them assumes not being root:
```
#          got: ''
#     expected: 'Unable to write default $HOME/.clusterssh/config: Is a directory
```

Re: [PR PATCH] [Updated] ClusterSSH: update to 4.16

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

There is an updated pull request by clyhtsuriva against master on the void-packages repository

https://github.com/clyhtsuriva/void-packages ClusterSSH-update
https://github.com/void-linux/void-packages/pull/50916

ClusterSSH: update to 4.16
#### Testing the changes
- I tested the changes in this PR: **yes**

#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I crossbuilded this PR locally for these architectures:
  - armv7l
  - armv6l-musl
  - aarch64-musl

A patch file from https://github.com/void-linux/void-packages/pull/50916.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ClusterSSH-update-50916.patch --]
[-- Type: text/x-diff, Size: 2450 bytes --]

From f89e8a07ea6bbda6faa1346b0090f7b074bbdc33 Mon Sep 17 00:00:00 2001
From: clyhtsuriva <aimeric@adjutor.xyz>
Date: Sat, 22 Jun 2024 23:26:08 +0200
Subject: [PATCH] ClusterSSH: update to 4.16

---
 srcpkgs/ClusterSSH/patches/15config.diff | 28 ++++++++++++++++++++++++
 srcpkgs/ClusterSSH/template              |  6 ++---
 2 files changed, 31 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/ClusterSSH/patches/15config.diff

diff --git a/srcpkgs/ClusterSSH/patches/15config.diff b/srcpkgs/ClusterSSH/patches/15config.diff
new file mode 100644
index 00000000000000..c61a02318c5212
--- /dev/null
+++ b/srcpkgs/ClusterSSH/patches/15config.diff
@@ -0,0 +1,28 @@
+--- a/t/15config.t
++++ b/t/15config.t
+@@ -535,25 +535,6 @@
+     chmod( 0755, $ENV{HOME} . '/.csshrc.DISABLED', $ENV{HOME} );
+ }
+
+-note('check failure to write default config is caught');
+-$ENV{HOME} = tempdir( CLEANUP => 1 );
+-mkdir( $ENV{HOME} . '/.clusterssh' );
+-mkdir( $ENV{HOME} . '/.clusterssh/config' );
+-$config = App::ClusterSSH::Config->new();
+-trap {
+-    $config->load_configs();
+-};
+-is( $trap->leaveby, 'return', 'returned ok' );
+-isa_ok( $config, "App::ClusterSSH::Config" );
+-isa_ok( $config, "App::ClusterSSH::Config" );
+-is( $trap->stdout, q{}, 'Expecting no STDOUT' );
+-is( $trap->stderr,
+-    q{Unable to write default $HOME/.clusterssh/config: Is a directory}
+-        . $/
+-        . $/,
+-    'Expecting no STDERR'
+-);
+-
+ note('Checking dump');
+ $config = App::ClusterSSH::Config->new(
+     send_menu_xml_file => $ENV{HOME} . '/.clusterssh/send_menu', );
diff --git a/srcpkgs/ClusterSSH/template b/srcpkgs/ClusterSSH/template
index 7e3b2c42b43453..7cb23aeaea58e8 100644
--- a/srcpkgs/ClusterSSH/template
+++ b/srcpkgs/ClusterSSH/template
@@ -1,7 +1,7 @@
 # Template file for 'ClusterSSH'
 pkgname=ClusterSSH
-version=4.14
-revision=3
+version=4.16
+revision=1
 build_style=perl-ModuleBuild
 hostmakedepends="xterm openssh
  perl-CPAN-Changes perl-Module-Build perl-Try-Tiny perl-Tk
@@ -16,7 +16,7 @@ license="Artistic-1.0-Perl, GPL-1.0-or-later"
 homepage="https://github.com/duncs/clusterssh"
 changelog="https://raw.githubusercontent.com/duncs/clusterssh/master/Changes"
 distfiles="https://github.com/duncs/clusterssh/archive/v${version}.tar.gz"
-checksum=179ac8a7c27ec9674d2aa3f65ebb097b4945646c71f83f52fe2b8b24c21cd629
+checksum=1540f42bd521066ab0a41504258ac1aa4c501c6f713057f8906bb896f3335b9f
 
 pre_check() {
 	touch README

Re: ClusterSSH: update to 4.16

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 330 bytes --]

New comment by clyhtsuriva on void-packages repository

https://github.com/void-linux/void-packages/pull/50916#issuecomment-2184194735

Comment:
In lack of a better solution, I made a patch to remove the 2 checks failing in the within the CI.
Is it ok to proceed this way for now, and do I need to set the revision number to 2 ?

Re: [PR REVIEW] ClusterSSH: update to 4.16

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 247 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50916#discussion_r1649796817

Comment:
can you add a comment at the top saying this test fails in ci because it doesn't expect root? 

Re: ClusterSSH: update to 4.16

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

New comment by clyhtsuriva on void-packages repository

https://github.com/void-linux/void-packages/pull/50916#issuecomment-2184194735

Comment:
In lack of a better solution, I made a patch to remove the 2 checks failing within the CI.
Is it ok to proceed this way for now, and do I need to set the revision number to 2 ?

Re: ClusterSSH: update to 4.16

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/50916#issuecomment-2184194985

Comment:
don't change revision, it's all the same change

Re: [PR REVIEW] ClusterSSH: update to 4.16

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New review comment by clyhtsuriva on void-packages repository

https://github.com/void-linux/void-packages/pull/50916#discussion_r1649796888

Comment:
Alright

Re: [PR PATCH] [Updated] ClusterSSH: update to 4.16

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

There is an updated pull request by clyhtsuriva against master on the void-packages repository

https://github.com/clyhtsuriva/void-packages ClusterSSH-update
https://github.com/void-linux/void-packages/pull/50916

ClusterSSH: update to 4.16
#### Testing the changes
- I tested the changes in this PR: **yes**

#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I crossbuilded this PR locally for these architectures:
  - armv7l
  - armv6l-musl
  - aarch64-musl

A patch file from https://github.com/void-linux/void-packages/pull/50916.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ClusterSSH-update-50916.patch --]
[-- Type: text/x-diff, Size: 2527 bytes --]

From c84e3a11bfd886f7ba0af3b948aef3728c740c99 Mon Sep 17 00:00:00 2001
From: clyhtsuriva <aimeric@adjutor.xyz>
Date: Sat, 22 Jun 2024 23:36:15 +0200
Subject: [PATCH] ClusterSSH: update to 4.16

---
 srcpkgs/ClusterSSH/patches/15config.diff | 30 ++++++++++++++++++++++++
 srcpkgs/ClusterSSH/template              |  6 ++---
 2 files changed, 33 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/ClusterSSH/patches/15config.diff

diff --git a/srcpkgs/ClusterSSH/patches/15config.diff b/srcpkgs/ClusterSSH/patches/15config.diff
new file mode 100644
index 00000000000000..95aa12681ace32
--- /dev/null
+++ b/srcpkgs/ClusterSSH/patches/15config.diff
@@ -0,0 +1,30 @@
+This test fails because it doesn't account for running as root in the CI.
+
+--- a/t/15config.t
++++ b/t/15config.t
+@@ -535,25 +535,6 @@
+     chmod( 0755, $ENV{HOME} . '/.csshrc.DISABLED', $ENV{HOME} );
+ }
+
+-note('check failure to write default config is caught');
+-$ENV{HOME} = tempdir( CLEANUP => 1 );
+-mkdir( $ENV{HOME} . '/.clusterssh' );
+-mkdir( $ENV{HOME} . '/.clusterssh/config' );
+-$config = App::ClusterSSH::Config->new();
+-trap {
+-    $config->load_configs();
+-};
+-is( $trap->leaveby, 'return', 'returned ok' );
+-isa_ok( $config, "App::ClusterSSH::Config" );
+-isa_ok( $config, "App::ClusterSSH::Config" );
+-is( $trap->stdout, q{}, 'Expecting no STDOUT' );
+-is( $trap->stderr,
+-    q{Unable to write default $HOME/.clusterssh/config: Is a directory}
+-        . $/
+-        . $/,
+-    'Expecting no STDERR'
+-);
+-
+ note('Checking dump');
+ $config = App::ClusterSSH::Config->new(
+     send_menu_xml_file => $ENV{HOME} . '/.clusterssh/send_menu', );
diff --git a/srcpkgs/ClusterSSH/template b/srcpkgs/ClusterSSH/template
index 7e3b2c42b43453..7cb23aeaea58e8 100644
--- a/srcpkgs/ClusterSSH/template
+++ b/srcpkgs/ClusterSSH/template
@@ -1,7 +1,7 @@
 # Template file for 'ClusterSSH'
 pkgname=ClusterSSH
-version=4.14
-revision=3
+version=4.16
+revision=1
 build_style=perl-ModuleBuild
 hostmakedepends="xterm openssh
  perl-CPAN-Changes perl-Module-Build perl-Try-Tiny perl-Tk
@@ -16,7 +16,7 @@ license="Artistic-1.0-Perl, GPL-1.0-or-later"
 homepage="https://github.com/duncs/clusterssh"
 changelog="https://raw.githubusercontent.com/duncs/clusterssh/master/Changes"
 distfiles="https://github.com/duncs/clusterssh/archive/v${version}.tar.gz"
-checksum=179ac8a7c27ec9674d2aa3f65ebb097b4945646c71f83f52fe2b8b24c21cd629
+checksum=1540f42bd521066ab0a41504258ac1aa4c501c6f713057f8906bb896f3335b9f
 
 pre_check() {
 	touch README

Re: [PR REVIEW] ClusterSSH: update to 4.16

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New review comment by clyhtsuriva on void-packages repository

https://github.com/void-linux/void-packages/pull/50916#discussion_r1649797971

Comment:
Pushed

Re: ClusterSSH: update to 4.16

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

New comment by clyhtsuriva on void-packages repository

https://github.com/void-linux/void-packages/pull/50916#issuecomment-2184201280

Comment:
Note for the future, the actual upstream master branch contains this note for the check :

`-note('check failure to write default config is caught when loading config');`

as opposed to the current one (version 4.16) :

`-note('check failure to write default config is caught');`

Thus, patch will need to be corrected on the next version update.

Re: ClusterSSH: update to 4.16

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

New comment by clyhtsuriva on void-packages repository

https://github.com/void-linux/void-packages/pull/50916#issuecomment-2184201280

Comment:
Note for the future, the actual upstream master branch contains this note for the check :

`-note('check failure to write default config is caught when loading config');`

as opposed to the current one (version 4.16) :

`-note('check failure to write default config is caught');`

Thus, the patch will need to be corrected on the next version update.

Re: [PR PATCH] [Merged]: ClusterSSH: update to 4.16

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

There's a merged pull request on the void-packages repository

ClusterSSH: update to 4.16
https://github.com/void-linux/void-packages/pull/50916

Description:
#### Testing the changes
- I tested the changes in this PR: **yes**

#### Local build testing
- I built this PR locally for my native architecture, x86_64
- I crossbuilded this PR locally for these architectures:
  - armv7l
  - armv6l-musl
  - aarch64-musl