* [PR PATCH] tootle: remove package
@ 2024-06-24 21:58 oreo639
2024-06-25 0:13 ` [PR PATCH] [Merged]: " sgn
0 siblings, 1 reply; 2+ messages in thread
From: oreo639 @ 2024-06-24 21:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1373 bytes --]
There is a new pull request by oreo639 against master on the void-packages repository
https://github.com/oreo639/void-packages tootle
https://github.com/void-linux/void-packages/pull/50977
tootle: remove package
Unmaintained, uses soup2.
Upstream repo was archived and no continuations exist. Has plenty of alternatives avaliable in the repos.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/50977.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-tootle-50977.patch --]
[-- Type: text/x-diff, Size: 8516 bytes --]
From e366392f130276ebd881607e7e83549137b011d2 Mon Sep 17 00:00:00 2001
From: oreo639 <oreo6391@gmail.com>
Date: Mon, 24 Jun 2024 14:54:03 -0700
Subject: [PATCH] tootle: remove package
Unmaintained, uses soup2.
Upstream repo was archived and no continuations exist.
Has plenty of alternatives avaliable in the repos.
---
srcpkgs/removed-packages/template | 1 +
srcpkgs/tootle/patches/vala-0.54.patch | 66 -----------------------
srcpkgs/tootle/patches/vala-0.56.patch | 23 ---------
srcpkgs/tootle/patches/vala-0.56b.patch | 69 -------------------------
srcpkgs/tootle/template | 13 -----
5 files changed, 1 insertion(+), 171 deletions(-)
delete mode 100644 srcpkgs/tootle/patches/vala-0.54.patch
delete mode 100644 srcpkgs/tootle/patches/vala-0.56.patch
delete mode 100644 srcpkgs/tootle/patches/vala-0.56b.patch
delete mode 100644 srcpkgs/tootle/template
diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 6873066ece9ae4..67f0f4e72370f8 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -721,6 +721,7 @@ replaces="
tomahawk-devel<=0.8.4_25
tomahawk-qt5<=0.8.4_25
tomahawk-qt5-devel<=0.8.4_25
+ tootle<=1.0_1
transcode<=1.1.7_4
traverso<=0.49.6_2
ttyload-git<=20141117_4
diff --git a/srcpkgs/tootle/patches/vala-0.54.patch b/srcpkgs/tootle/patches/vala-0.54.patch
deleted file mode 100644
index 08ee23dd8fc8ec..00000000000000
--- a/srcpkgs/tootle/patches/vala-0.54.patch
+++ /dev/null
@@ -1,66 +0,0 @@
-From 0816105028c26965e37c9afc7c598854f3fecde1 Mon Sep 17 00:00:00 2001
-From: Clayton Craft <clayton@craftyguy.net>
-Date: Tue, 26 Oct 2021 15:03:25 -0700
-Subject: [PATCH] Adhere to GLib.Object naming conventions for properties
-
-Vala now validates property names against GLib.Object conventions, this
-fixes a compilation error as a result of this enforcement:
-
-../src/API/Status.vala:27.5-27.23: error: Name `_url' is not valid for a GLib.Object property
- public string? _url { get; set; }
- ^^^^^^^^^^^^^^^^^^^
-
-Relevant Vala change:
-https://gitlab.gnome.org/GNOME/vala/-/commit/38d61fbff037687ea4772e6df85c7e22a74b335e
-
-fixes #337
-
-Signed-off-by: Clayton Craft <clayton@craftyguy.net>
----
- src/API/Attachment.vala | 6 +++---
- src/API/Status.vala | 8 ++++----
- 2 files changed, 7 insertions(+), 7 deletions(-)
-
-diff --git a/src/API/Attachment.vala b/src/API/Attachment.vala
-index 88bc5bb..35c4018 100644
---- a/src/API/Attachment.vala
-+++ b/src/API/Attachment.vala
-@@ -4,10 +4,10 @@ public class Tootle.API.Attachment : Entity, Widgetizable {
- public string kind { get; set; default = "unknown"; }
- public string url { get; set; }
- public string? description { get; set; }
-- public string? _preview_url { get; set; }
-+ private string? t_preview_url { get; set; }
- public string? preview_url {
-- set { this._preview_url = value; }
-- get { return (this._preview_url == null || this._preview_url == "") ? url : _preview_url; }
-+ set { this.t_preview_url = value; }
-+ get { return (this.t_preview_url == null || this.t_preview_url == "") ? url : t_preview_url; }
- }
-
- public File? source_file { get; set; }
-diff --git a/src/API/Status.vala b/src/API/Status.vala
-index 4f92cdb..00e8a9f 100644
---- a/src/API/Status.vala
-+++ b/src/API/Status.vala
-@@ -28,16 +28,16 @@ public class Tootle.API.Status : Entity, Widgetizable {
- public ArrayList<API.Mention>? mentions { get; set; default = null; }
- public ArrayList<API.Attachment>? media_attachments { get; set; default = null; }
-
-- public string? _url { get; set; }
-+ private string? t_url { get; set; }
- public string url {
- owned get { return this.get_modified_url (); }
-- set { this._url = value; }
-+ set { this.t_url = value; }
- }
- string get_modified_url () {
-- if (this._url == null) {
-+ if (this.t_url == null) {
- return this.uri.replace ("/activity", "");
- }
-- return this._url;
-+ return this.t_url;
- }
-
- public Status formal {
diff --git a/srcpkgs/tootle/patches/vala-0.56.patch b/srcpkgs/tootle/patches/vala-0.56.patch
deleted file mode 100644
index 38adf0ff0930ed..00000000000000
--- a/srcpkgs/tootle/patches/vala-0.56.patch
+++ /dev/null
@@ -1,23 +0,0 @@
-From 11d94c05d4c4a2350801294f155230e899048ab5 Mon Sep 17 00:00:00 2001
-From: Bobby Rong <rjl931189261@126.com>
-Date: Sat, 19 Mar 2022 16:59:31 +0800
-Subject: [PATCH] Application: make app_entries private
-
-Fixes compilation with latest valac.
----
- src/Application.vala | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/src/Application.vala b/src/Application.vala
-index 57d0fd7..b48cb53 100644
---- a/src/Application.vala
-+++ b/src/Application.vala
-@@ -43,7 +43,7 @@ namespace Tootle {
- { null }
- };
-
-- public const GLib.ActionEntry[] app_entries = {
-+ private const GLib.ActionEntry[] app_entries = {
- { "about", about_activated },
- { "compose", compose_activated },
- { "back", back_activated },
diff --git a/srcpkgs/tootle/patches/vala-0.56b.patch b/srcpkgs/tootle/patches/vala-0.56b.patch
deleted file mode 100644
index 2432c03c28a969..00000000000000
--- a/srcpkgs/tootle/patches/vala-0.56b.patch
+++ /dev/null
@@ -1,69 +0,0 @@
-diff --git a/src/API/NotificationType.vala b/src/API/NotificationType.vala
-index c3f4420..15ba2ae 100644
---- a/src/API/NotificationType.vala
-+++ b/src/API/NotificationType.vala
-@@ -5,7 +5,8 @@ public enum Tootle.API.NotificationType {
- FAVOURITE,
- FOLLOW,
- FOLLOW_REQUEST, // Internal
-- WATCHLIST; // Internal
-+ WATCHLIST, // Internal
-+ NONE; // Internal
-
- public string to_string () {
- switch (this) {
-diff --git a/src/Widgets/Notification.vala b/src/Widgets/Notification.vala
-index 3e2fe54..41ed71f 100644
---- a/src/Widgets/Notification.vala
-+++ b/src/Widgets/Notification.vala
-@@ -16,7 +16,7 @@ public class Tootle.Widgets.Notification : Widgets.Status {
- }
-
- protected override void on_kind_changed () {
-- if (kind == null)
-+ if (kind == API.NotificationType.NONE)
- return;
-
- header_icon.visible = header_label.visible = true;
-diff --git a/src/Widgets/Status.vala b/src/Widgets/Status.vala
-index ef51340..ce1c951 100644
---- a/src/Widgets/Status.vala
-+++ b/src/Widgets/Status.vala
-@@ -5,7 +5,7 @@ using Gdk;
- public class Tootle.Widgets.Status : ListBoxRow {
-
- public API.Status status { get; construct set; }
-- public API.NotificationType? kind { get; construct set; }
-+ public API.NotificationType kind { get; construct set; }
-
- public enum ThreadRole {
- NONE,
-@@ -113,7 +113,7 @@ public class Tootle.Widgets.Status : ListBoxRow {
- notify["kind"].connect (on_kind_changed);
- open.connect (on_open);
-
-- if (kind == null) {
-+ if (kind == API.NotificationType.NONE) {
- if (status.reblog != null)
- kind = API.NotificationType.REBLOG_REMOTE_USER;
- }
-@@ -164,7 +164,7 @@ public class Tootle.Widgets.Status : ListBoxRow {
- menu_button.clicked.connect (open_menu);
- }
-
-- public Status (owned API.Status status, API.NotificationType? kind = null) {
-+ public Status (owned API.Status status, API.NotificationType kind = API.NotificationType.NONE) {
- Object (
- status: status,
- kind: kind
-@@ -180,8 +180,8 @@ public class Tootle.Widgets.Status : ListBoxRow {
- }
-
- protected virtual void on_kind_changed () {
-- header_icon.visible = header_label.visible = (kind != null);
-- if (kind == null)
-+ header_icon.visible = header_label.visible = (kind != API.NotificationType.NONE);
-+ if (kind == API.NotificationType.NONE)
- return;
-
- header_icon.icon_name = kind.get_icon ();
diff --git a/srcpkgs/tootle/template b/srcpkgs/tootle/template
deleted file mode 100644
index dbb3f904fd7773..00000000000000
--- a/srcpkgs/tootle/template
+++ /dev/null
@@ -1,13 +0,0 @@
-# Template file for 'tootle'
-pkgname=tootle
-version=1.0
-revision=1
-build_style=meson
-hostmakedepends="vala pkg-config gettext glib-devel"
-makedepends="vala libhandy1-devel libsoup-devel libgee08-devel json-glib-devel"
-short_desc="Native GTK Mastodon client"
-maintainer="Orphaned <orphan@voidlinux.org>"
-license="GPL-3.0-or-later"
-homepage="https://github.com/bleakgrey/tootle/"
-distfiles="https://github.com/bleakgrey/tootle/archive/$version.tar.gz"
-checksum=e0a0a062b1b72010242f7bb4db97cd71190f23067188b5c07372264d768a0496
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PR PATCH] [Merged]: tootle: remove package
2024-06-24 21:58 [PR PATCH] tootle: remove package oreo639
@ 2024-06-25 0:13 ` sgn
0 siblings, 0 replies; 2+ messages in thread
From: sgn @ 2024-06-25 0:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]
There's a merged pull request on the void-packages repository
tootle: remove package
https://github.com/void-linux/void-packages/pull/50977
Description:
Unmaintained, uses soup2.
Upstream repo was archived and no continuations exist. Has plenty of alternatives avaliable in the repos.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **briefly**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-25 0:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-24 21:58 [PR PATCH] tootle: remove package oreo639
2024-06-25 0:13 ` [PR PATCH] [Merged]: " sgn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).