[ISSUE] kodi build errors

[ISSUE] kodi build errors

[ACR-Jeff]

[-- Attachment #1: Type: text/plain, Size: 3559 bytes --]

New issue by ACR-Jeff on void-packages repository

https://github.com/void-linux/void-packages/issues/51033

Description:
### Is this a new report?

Yes

### System Info

Void 6.6.35_1 x86_64 AuthenticAMD uptodate hold rmFFFFFFFFF

### Package(s) Affected

kodi-19.4_9

### Does a report exist for this bug with the project's home (upstream) and/or another distro?

_No response_

### Expected behaviour

Expecting src-pkgs to install

### Actual behaviour

`../xbmc/windowing/X11/GLContext.h:30:11: error: 'uint64_t' does not name a type
   30 |   virtual uint64_t GetVblankTiming(uint64_t &msc, uint64_t &interval) { return 0; };
      |           ^~~~~~~~
../xbmc/windowing/X11/GLContext.h:14:1: note: 'uint64_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
   13 | #include <X11/Xlib.h>
  +++ |+#include <cstdint>
   14 | 
[152/1719] Building CXX object build/windowing/X11/CMakeFiles/windowing_X11.dir/X11DPMSSupport.cpp.o
[153/1719] Building CXX object build/windowing/X11/CMakeFiles/windowing_X11.dir/WinSystemX11.cpp.o
In file included from ../xbmc/input/InputManager.h:19,
                 from ../xbmc/windowing/X11/WinSystemX11.cpp:18:
../xbmc/utils/Observer.h:47:23: warning: 'virtual Observable& Observable::operator=(const Observable&)' was hidden [-Woverloaded-virtual=]
   47 |   virtual Observable &operator=(const Observable &observable);
      |                       ^~~~~~~~
../xbmc/input/InputManager.h:69:24: note:   by 'const CInputManager& CInputManager::operator=(const CInputManager&)'
   69 |   CInputManager const& operator=(CInputManager const&) = delete;
      |                        ^~~~~~~~
../xbmc/utils/Observer.h:47:23: warning: 'virtual Observable& Observable::operator=(const Observable&)' was hidden [-Woverloaded-virtual=]
   47 |   virtual Observable &operator=(const Observable &observable);
      |                       ^~~~~~~~
In file included from ../xbmc/windowing/X11/WinSystemX11.cpp:20:
../xbmc/settings/DisplaySettings.h:147:21: note:   by 'CDisplaySettings& CDisplaySettings::operator=(const CDisplaySettings&)'
  147 |   CDisplaySettings& operator=(CDisplaySettings const&) = delete;
      |                     ^~~~~~~~
[154/1719] Building CXX object build/windowing/X11/CMakeFiles/windowing_X11.dir/WinEventsX11.cpp.o
In file included from ../xbmc/input/InputManager.h:19,
                 from ../xbmc/windowing/X11/WinEventsX11.cpp:17:
../xbmc/utils/Observer.h:47:23: warning: 'virtual Observable& Observable::operator=(const Observable&)' was hidden [-Woverloaded-virtual=]
   47 |   virtual Observable &operator=(const Observable &observable);
      |                       ^~~~~~~~
../xbmc/input/InputManager.h:69:24: note:   by 'const CInputManager& CInputManager::operator=(const CInputManager&)'
   69 |   CInputManager const& operator=(CInputManager const&) = delete;
      |                        ^~~~~~~~
[155/1719] Building CXX object build/windowing/X11/CMakeFiles/windowing_X11.dir/GLContextEGL.cpp.o
[156/1719] Building CXX object build/windowing/X11/CMakeFiles/windowing_X11.dir/VideoSyncGLX.cpp.o
[157/1719] Building CXX object build/windowing/X11/CMakeFiles/windowing_X11.dir/XRandR.cpp.o
ninja: build stopped: subcommand failed.
=> ERROR: kodi-19.4_9: do_build: '${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}' exited with 1
=> ERROR:   in do_build() at common/build-style/cmake.sh:95`

### Steps to reproduce

cd /path/to/void-packages
./xbps-src pkg kodi
while building errors are presented

Re: kodi build errors

[meator]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/issues/51033#issuecomment-2198203714

Comment:
This issue is indirectly resolved by #50183  (see https://github.com/void-linux/void-packages/pull/50183/files#diff-e773acf9a4e8390c3709adf717c186f6856c69ed5c2a6b5850260212d0ba7b98)

Re: kodi build errors

[ACR-Jeff]

[-- Attachment #1: Type: text/plain, Size: 1022 bytes --]

New comment by ACR-Jeff on void-packages repository

https://github.com/void-linux/void-packages/issues/51033#issuecomment-2198757321

Comment:
> This issue is indirectly resolved by #50183 (see https://github.com/void-linux/void-packages/pull/50183/files#diff-e773acf9a4e8390c3709adf717c186f6856c69ed5c2a6b5850260212d0ba7b98)

Thank you, 
I read the Handling-Patches Man page https://github.com/void-linux/void-packages/blob/master/Manual.md#handling-patches
Read through https://github.com/void-linux/void-packages/pull/50183
Followed through with adding the patch you've posted above in reference 
https://github.com/void-linux/void-packages/pull/50183/files#diff-e773acf9a4e8390c3709adf717c186f6856c69ed5c2a6b5850260212d0ba7b98
But the same issue occurred, 
1. I proceeded to removing any previous build attempts from /hostdir/sources to be sure not to contaminate any further builds
2. ./xbps-src pkg kodi
3. Same issue occurred
Am I doing something incorrect or missing something to apply the patch, Etc?

Re: kodi build errors

[ACR-Jeff]

[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]

New comment by ACR-Jeff on void-packages repository

https://github.com/void-linux/void-packages/issues/51033#issuecomment-2198757321

Comment:
> This issue is indirectly resolved by #50183 (see https://github.com/void-linux/void-packages/pull/50183/files#diff-e773acf9a4e8390c3709adf717c186f6856c69ed5c2a6b5850260212d0ba7b98)

Thank you, 
I read the Handling-Patches Man page https://github.com/void-linux/void-packages/blob/master/Manual.md#handling-patches
Read through https://github.com/void-linux/void-packages/pull/50183
Followed through with adding the patch you've posted above in reference 
https://github.com/void-linux/void-packages/pull/50183/files#diff-e773acf9a4e8390c3709adf717c186f6856c69ed5c2a6b5850260212d0ba7b98
But the same issue occurred, 
1. I proceeded to removing any previous build attempts from /hostdir/sources to be sure not to contaminate any further builds
2. cd to/path/void-packages
3. ./xbps-src pkg kodi
4. Same issue occurred
Am I doing something incorrect or missing something to apply the patch, Etc?

Re: kodi build errors

[meator]

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

New comment by meator on void-packages repository

https://github.com/void-linux/void-packages/issues/51033#issuecomment-2198771094

Comment:
Try following https://xbps-src-tutorials.github.io/pr-testing-tutorial.html with pull request #50183

The primary focus of this pull request is spdlog and fmtlib, the Kodi fix there is ancillary.

Alternatively, you could copy the patch manually as you were (I assume) trying to do previously. You can copy [the raw patch](https://raw.githubusercontent.com/Calandracas606/void-packages/fmt-and-spdlog-update/srcpkgs/kodi/patches/cstdint.patch) to `srcpkgs/kodi/patches/cstdint.patch` in your void-packages clone. You can then proceed with building Kodi.