[PR PATCH] android-file-transfer-linux: update to 4.3, split cli and libs

[PR PATCH] android-file-transfer-linux: update to 4.3, split cli and libs

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

There is a new pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages aft
https://github.com/void-linux/void-packages/pull/51840

android-file-transfer-linux: update to 4.3, split cli and libs
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-glibc)

cc @Vaelatern 

This is so that we don't have to bring in gui stuff to use cli tools.

A patch file from https://github.com/void-linux/void-packages/pull/51840.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aft-51840.patch --]
[-- Type: text/x-diff, Size: 2509 bytes --]

From 4cdd3e5d86e9c8b9568dd22928ad8d965e9d5bc5 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Wed, 14 Aug 2024 08:26:41 +0200
Subject: [PATCH] android-file-transfer-linux: update to 4.3, split cli, libs

---
 srcpkgs/android-file-transfer-linux-cli      |  1 +
 srcpkgs/android-file-transfer-linux-libs     |  1 +
 srcpkgs/android-file-transfer-linux/template | 22 ++++++++++++++++----
 3 files changed, 20 insertions(+), 4 deletions(-)
 create mode 120000 srcpkgs/android-file-transfer-linux-cli
 create mode 120000 srcpkgs/android-file-transfer-linux-libs

diff --git a/srcpkgs/android-file-transfer-linux-cli b/srcpkgs/android-file-transfer-linux-cli
new file mode 120000
index 00000000000000..88c5f3204d111f
--- /dev/null
+++ b/srcpkgs/android-file-transfer-linux-cli
@@ -0,0 +1 @@
+android-file-transfer-linux
\ No newline at end of file
diff --git a/srcpkgs/android-file-transfer-linux-libs b/srcpkgs/android-file-transfer-linux-libs
new file mode 120000
index 00000000000000..88c5f3204d111f
--- /dev/null
+++ b/srcpkgs/android-file-transfer-linux-libs
@@ -0,0 +1 @@
+android-file-transfer-linux
\ No newline at end of file
diff --git a/srcpkgs/android-file-transfer-linux/template b/srcpkgs/android-file-transfer-linux/template
index d223ff0ee2aab8..8459f4e36c7289 100644
--- a/srcpkgs/android-file-transfer-linux/template
+++ b/srcpkgs/android-file-transfer-linux/template
@@ -1,16 +1,30 @@
 # Template file for 'android-file-transfer-linux'
 pkgname=android-file-transfer-linux
-version=4.2
-revision=4
+version=4.3
+revision=1
 build_style=cmake
 configure_args="-DBUILD_SHARED_LIB=1"
 hostmakedepends="qt5-qmake qt5-host-tools ninja pkg-config"
 makedepends="file-devel fuse-devel qt5-devel readline-devel
  qt5-tools-devel"
-depends="qt5-svg"
+depends="qt5-svg $pkgname-cli $pkgname-libs"
 short_desc="Android File Transfer for Linux"
 maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://github.com/whoozle/android-file-transfer-linux"
 distfiles="https://github.com/whoozle/android-file-transfer-linux/archive/v${version}.tar.gz"
-checksum=cc607d68e8a18273c9b56975a70a0e68fbdf9d5b903b2727a345a605ff48a19f
+checksum=8ff658630fc820a7ca0b70025aa47d235b7fb64f5cb6a72ca76a7acbf3435128
+
+android-file-transfer-linux-libs_package() {
+	short_desc+=" - library"
+	pkg_install() {
+		vmove usr/lib/*
+	}
+}
+
+android-file-transfer-linux-cli_package() {
+	short_desc+=" - cli tools"
+	pkg_install() {
+		vmove usr/bin/aft-mtp-*
+	}
+}

Re: [PR REVIEW] android-file-transfer-linux: update to 4.3, split cli and libs

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New review comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/51840#discussion_r1716792538

Comment:
slight preference for not doing $pkgname replacement here

Re: android-file-transfer-linux: update to 4.3, split cli and libs

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by Vaelatern on void-packages repository

https://github.com/void-linux/void-packages/pull/51840#issuecomment-2288542362

Comment:
I'm OK with this with the 1 change

Re: [PR PATCH] [Updated] android-file-transfer-linux: update to 4.3, split cli and libs

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages aft
https://github.com/void-linux/void-packages/pull/51840

android-file-transfer-linux: update to 4.3, split cli and libs
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-glibc)

cc @Vaelatern 

This is so that we don't have to bring in gui stuff to use cli tools.

A patch file from https://github.com/void-linux/void-packages/pull/51840.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-aft-51840.patch --]
[-- Type: text/x-diff, Size: 2547 bytes --]

From 338b07e84262435a89a9f2fce868634fda03c19b Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Wed, 14 Aug 2024 08:26:41 +0200
Subject: [PATCH] android-file-transfer-linux: update to 4.3, split cli, libs

---
 srcpkgs/android-file-transfer-linux-cli      |  1 +
 srcpkgs/android-file-transfer-linux-libs     |  1 +
 srcpkgs/android-file-transfer-linux/template | 22 ++++++++++++++++----
 3 files changed, 20 insertions(+), 4 deletions(-)
 create mode 120000 srcpkgs/android-file-transfer-linux-cli
 create mode 120000 srcpkgs/android-file-transfer-linux-libs

diff --git a/srcpkgs/android-file-transfer-linux-cli b/srcpkgs/android-file-transfer-linux-cli
new file mode 120000
index 00000000000000..88c5f3204d111f
--- /dev/null
+++ b/srcpkgs/android-file-transfer-linux-cli
@@ -0,0 +1 @@
+android-file-transfer-linux
\ No newline at end of file
diff --git a/srcpkgs/android-file-transfer-linux-libs b/srcpkgs/android-file-transfer-linux-libs
new file mode 120000
index 00000000000000..88c5f3204d111f
--- /dev/null
+++ b/srcpkgs/android-file-transfer-linux-libs
@@ -0,0 +1 @@
+android-file-transfer-linux
\ No newline at end of file
diff --git a/srcpkgs/android-file-transfer-linux/template b/srcpkgs/android-file-transfer-linux/template
index d223ff0ee2aab8..15258975994010 100644
--- a/srcpkgs/android-file-transfer-linux/template
+++ b/srcpkgs/android-file-transfer-linux/template
@@ -1,16 +1,30 @@
 # Template file for 'android-file-transfer-linux'
 pkgname=android-file-transfer-linux
-version=4.2
-revision=4
+version=4.3
+revision=1
 build_style=cmake
 configure_args="-DBUILD_SHARED_LIB=1"
 hostmakedepends="qt5-qmake qt5-host-tools ninja pkg-config"
 makedepends="file-devel fuse-devel qt5-devel readline-devel
  qt5-tools-devel"
-depends="qt5-svg"
+depends="qt5-svg android-file-transfer-linux-cli android-file-transfer-linux-libs"
 short_desc="Android File Transfer for Linux"
 maintainer="Toyam Cox <Vaelatern@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://github.com/whoozle/android-file-transfer-linux"
 distfiles="https://github.com/whoozle/android-file-transfer-linux/archive/v${version}.tar.gz"
-checksum=cc607d68e8a18273c9b56975a70a0e68fbdf9d5b903b2727a345a605ff48a19f
+checksum=8ff658630fc820a7ca0b70025aa47d235b7fb64f5cb6a72ca76a7acbf3435128
+
+android-file-transfer-linux-libs_package() {
+	short_desc+=" - library"
+	pkg_install() {
+		vmove usr/lib/*
+	}
+}
+
+android-file-transfer-linux-cli_package() {
+	short_desc+=" - cli tools"
+	pkg_install() {
+		vmove usr/bin/aft-mtp-*
+	}
+}

Re: [PR REVIEW] android-file-transfer-linux: update to 4.3, split cli and libs

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New review comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/51840#discussion_r1716854735

Comment:
Done, thanks.

Re: [PR PATCH] [Merged]: android-file-transfer-linux: update to 4.3, split cli and libs

[Vaelatern]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

There's a merged pull request on the void-packages repository

android-file-transfer-linux: update to 4.3, split cli and libs
https://github.com/void-linux/void-packages/pull/51840

Description:
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-glibc)

cc @Vaelatern 

This is so that we don't have to bring in gui stuff to use cli tools.