Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] common/build-style/go.sh: support $make_check_pre
@ 2024-09-17  7:15 icp1994
  2024-09-17 14:50 ` dkwo
  2024-09-17 15:15 ` [PR PATCH] [Merged]: " classabbyamp
  0 siblings, 2 replies; 3+ messages in thread
From: icp1994 @ 2024-09-17  7:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 496 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages go-test
https://github.com/void-linux/void-packages/pull/52247

common/build-style/go.sh: support $make_check_pre
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

A patch file from https://github.com/void-linux/void-packages/pull/52247.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-go-test-52247.patch --]
[-- Type: text/x-diff, Size: 830 bytes --]

From fa6ba2546e1e3fcba9f6949fefb0826f67063773 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Tue, 17 Sep 2024 12:42:28 +0530
Subject: [PATCH] common/build-style/go.sh: support $make_check_pre

---
 common/build-style/go.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/build-style/go.sh b/common/build-style/go.sh
index d6c65396e9d16f..2a6305d959b8b6 100644
--- a/common/build-style/go.sh
+++ b/common/build-style/go.sh
@@ -63,7 +63,7 @@ do_build() {
 do_check() {
 	: ${make_check_target:=./...}
 
-	go test -p "$XBPS_MAKEJOBS" -v -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${make_check_args} ${make_check_target}
+	${make_check_pre} go test -p "$XBPS_MAKEJOBS" -v -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${make_check_args} ${make_check_target}
 }
 
 do_install() {

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: common/build-style/go.sh: support $make_check_pre
  2024-09-17  7:15 [PR PATCH] common/build-style/go.sh: support $make_check_pre icp1994
@ 2024-09-17 14:50 ` dkwo
  2024-09-17 15:15 ` [PR PATCH] [Merged]: " classabbyamp
  1 sibling, 0 replies; 3+ messages in thread
From: dkwo @ 2024-09-17 14:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 264 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/52247#issuecomment-2356106445

Comment:
Interesting. I thought this was already implemented when @classabbyamp implemented the check stage for go, see e.g. `gopass`.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: common/build-style/go.sh: support $make_check_pre
  2024-09-17  7:15 [PR PATCH] common/build-style/go.sh: support $make_check_pre icp1994
  2024-09-17 14:50 ` dkwo
@ 2024-09-17 15:15 ` classabbyamp
  1 sibling, 0 replies; 3+ messages in thread
From: classabbyamp @ 2024-09-17 15:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

There's a merged pull request on the void-packages repository

common/build-style/go.sh: support $make_check_pre
https://github.com/void-linux/void-packages/pull/52247

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-17 15:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-17  7:15 [PR PATCH] common/build-style/go.sh: support $make_check_pre icp1994
2024-09-17 14:50 ` dkwo
2024-09-17 15:15 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).