[PR PATCH] obs: change CMAKE_INSTALL_DATAROOTDIR to relative path

[PR PATCH] obs: change CMAKE_INSTALL_DATAROOTDIR to relative path

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1384 bytes --]

There is a new pull request by Johnnynator against master on the void-packages repository

https://github.com/Johnnynator/void-packages obs
https://github.com/void-linux/void-packages/pull/52313

obs: change CMAKE_INSTALL_DATAROOTDIR to relative path
The absolute path results in obs trying to load plugin data from
/usr/usr/share which can't work for obvious reasons

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/52313.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-obs-52313.patch --]
[-- Type: text/x-diff, Size: 1061 bytes --]

From 8fffbbd85034fb6245f02ecd2d13b404af6657ef Mon Sep 17 00:00:00 2001
From: John <me@johnnynator.dev>
Date: Sun, 22 Sep 2024 22:58:20 +0200
Subject: [PATCH] obs: change CMAKE_INSTALL_DATAROOTDIR to relative path

The absolute path results in obs trying to load plugin data from
/usr/usr/share which can't work for obvious reasons
---
 srcpkgs/obs/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/obs/template b/srcpkgs/obs/template
index 4cb26fc8d8653b..c0a57717744bcb 100644
--- a/srcpkgs/obs/template
+++ b/srcpkgs/obs/template
@@ -1,11 +1,11 @@
 # Template file for 'obs'
 pkgname=obs
 version=30.2.3
-revision=1
+revision=2
 archs="i686* x86_64* ppc64le* aarch64* riscv64*"
 build_style=cmake
 configure_args="-DOBS_VERSION_OVERRIDE=${version} -DENABLE_JACK=ON
- -DCMAKE_INSTALL_DATAROOTDIR=/usr/share
+ -DCMAKE_INSTALL_DATAROOTDIR=share
  -DENABLE_VST=OFF -DENABLE_AJA=OFF -DCALM_DEPRECATION=ON
  -DENABLE_SCRIPTING_LUA=$(vopt_if luajit 'ON' 'OFF')
  -DENABLE_NATIVE_NVENC=OFF -DENABLE_QSV11=$(vopt_if 'ON' 'OFF')"

Re: obs: change CMAKE_INSTALL_DATAROOTDIR to relative path

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by Johnnynator on void-packages repository

https://github.com/void-linux/void-packages/pull/52313#issuecomment-2366963001

Comment:
@sgn Was there a reason that this was set to `/usr/share`?

Re: obs: change CMAKE_INSTALL_DATAROOTDIR to relative path

[lemmi]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New comment by lemmi on void-packages repository

https://github.com/void-linux/void-packages/pull/52313#issuecomment-2366973972

Comment:
Just tried it and with that fade transitions work again.

Re: obs: change CMAKE_INSTALL_DATAROOTDIR to relative path

[zlice]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

New comment by zlice on void-packages repository

https://github.com/void-linux/void-packages/pull/52313#issuecomment-2368806386

Comment:
looks like the issue was removed - https://github.com/void-linux/void-packages/issues/51629. but i had a patch that fixes the issue of double loading plugins and nuking working and found plugins with bad directory recursion and trying the same plugins multiple times.

Re: obs: change CMAKE_INSTALL_DATAROOTDIR to relative path

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/52313#issuecomment-2370399262

Comment:
it's available in https://inbox.vuxu.org/voidlinux-github/gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-51629@inbox.vuxu.org/

Re: obs: change CMAKE_INSTALL_DATAROOTDIR to relative path

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/52313#issuecomment-2370399262

Comment:
it's available at https://inbox.vuxu.org/voidlinux-github/gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-51629@inbox.vuxu.org/

Re: obs: change CMAKE_INSTALL_DATAROOTDIR to relative path

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/52313#issuecomment-2370399262

Comment:
it's available at https://inbox.vuxu.org/voidlinux-github/gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-51629@inbox.vuxu.org/t/#u

Re: obs: change CMAKE_INSTALL_DATAROOTDIR to relative path

[sgn]

[-- Attachment #1: Type: text/plain, Size: 358 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/52313#issuecomment-2370435006

Comment:
> @sgn Was there a reason that this was set to `/usr/share`?

Yes, there was a reason! I will try to build `obs` without that and see what is the reason, I think somethings has `${XBPS_CROSS_BASE}/usr/share` inside it.

Re: obs: change CMAKE_INSTALL_DATAROOTDIR to relative path

[zlice]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

New comment by zlice on void-packages repository

https://github.com/void-linux/void-packages/pull/52313#issuecomment-2371641721

Comment:
thx abby. here it is extracted so it's easy to grab. if the PR changes back paths it prolly fixes the bad obs logic for pretty much everyone. if not then it seems like a good idea to use something like this. didn't sound like it will be accepted upstream

[obs-path-patch.txt](https://github.com/user-attachments/files/17116967/obs-path-patch.txt)

Re: obs: change CMAKE_INSTALL_DATAROOTDIR to relative path

[zlice]

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

New comment by zlice on void-packages repository

https://github.com/void-linux/void-packages/pull/52313#issuecomment-2371641721

Comment:
thx abby. here it is extracted so it's easy to grab. if the PR changes back paths it prolly 'fixes' ('hides' a better word?) the bad obs logic for pretty much everyone. if not then it seems like a good idea to use something like this. didn't sound like it will be accepted upstream

[obs-path-patch.txt](https://github.com/user-attachments/files/17116967/obs-path-patch.txt)

Re: [PR PATCH] [Merged]: obs: change CMAKE_INSTALL_DATAROOTDIR to relative path

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

There's a merged pull request on the void-packages repository

obs: change CMAKE_INSTALL_DATAROOTDIR to relative path
https://github.com/void-linux/void-packages/pull/52313

Description:
The absolute path results in obs trying to load plugin data from
/usr/usr/share which can't work for obvious reasons

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->