Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] sonic-visualiser: update to 5.0
@ 2024-09-29 12:46 newbluemoon
  2024-10-03 21:14 ` [PR PATCH] [Updated] " newbluemoon
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: newbluemoon @ 2024-09-29 12:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 2250 bytes --]

There is a new pull request by newbluemoon against master on the void-packages repository

https://github.com/newbluemoon/void-packages sonic-visualiser
https://github.com/void-linux/void-packages/pull/52406

sonic-visualiser: update to 5.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64 (cross)
  - armv7l (cross) --> fails, see below
  - x86_64-musl
  - i686

There is a problem with 32-bit cross builds on a 64-bit host.
Meson detects Qt6 using pkg-config. However, the corresponding .pc files have
```
prefix=/usr
exec_prefix=${prefix}
bindir=${prefix}/lib32/qt6/bin
libexecdir=${prefix}/lib32/qt6/libexec
libdir=${prefix}/lib
includedir=${prefix}/include/qt6
```
i.e. they have `.../lib32/...` hard coded and so detection of the host tools fails when they are under `.../lib64/...`.

There are not much options to tweak this; using qmake instead of pkg-config yields the same error.

I think a clean solution would be adjusting Qt6’s .pc files to contain `.../lib/...` solely. There shouldn’t be a problem, because `lib32` and `lib64` are symlinks to `lib`, anyway. Everything else I can think of would be quite hacky. I don’t know if this is the only package having this problem; I searched for other templates, but didn’t find anything alike.

Any ideas/suggestions are very welcome :)

A patch file from https://github.com/void-linux/void-packages/pull/52406.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sonic-visualiser-52406.patch --]
[-- Type: text/x-diff, Size: 1748 bytes --]

From 35b21ba6a94138d6fbd794a30c0825bb50520ca0 Mon Sep 17 00:00:00 2001
From: newbluemoon <blaumolch@mailbox.org>
Date: Sun, 29 Sep 2024 14:19:46 +0200
Subject: [PATCH] sonic-visualiser: update to 5.0

---
 srcpkgs/sonic-visualiser/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/sonic-visualiser/template b/srcpkgs/sonic-visualiser/template
index 193b4b18bcae16..8cdaab236fad80 100644
--- a/srcpkgs/sonic-visualiser/template
+++ b/srcpkgs/sonic-visualiser/template
@@ -1,12 +1,12 @@
 # Template file for 'sonic-visualiser'
 pkgname=sonic-visualiser
-version=4.5.2
-revision=2
+version=5.0
+revision=1
 build_style=meson
-hostmakedepends="pkg-config capnproto-devel qt5-host-tools"
+hostmakedepends="pkg-config capnproto-devel qt6-base qt6-tools"
 makedepends="capnproto-devel jack-devel libfishsound-devel libid3tag-devel
  liblo-devel liblrdf-devel libmad-devel liboggz-devel libsamplerate-devel
- opusfile-devel portaudio-devel pulseaudio-devel qt5-svg-devel rubberband-devel
+ opusfile-devel portaudio-devel pulseaudio-devel qt6-svg-devel rubberband-devel
  speex-devel sord-devel vamp-plugin-sdk-devel"
 short_desc="Viewing and analysing the contents of music audio files"
 maintainer="newbluemoon <blaumolch@mailbox.org>"
@@ -14,4 +14,4 @@ license="GPL-2.0-or-later"
 homepage="https://www.sonicvisualiser.org/"
 changelog="https://raw.githubusercontent.com/sonic-visualiser/sonic-visualiser/default/CHANGELOG"
 distfiles="https://github.com/sonic-visualiser/sonic-visualiser/releases/download/sv_v${version}/sonic-visualiser-${version}.tar.gz"
-checksum=0816e1ba9e3f97af495ece2554186bccad1cf47090ff8a13f1d08322212db487
+checksum=88f479704e0faeff44fa49ef6ecf6abd9a45945f175d6ee99a00fac43f5857bb

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2025-02-09  8:10 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-29 12:46 [PR PATCH] sonic-visualiser: update to 5.0 newbluemoon
2024-10-03 21:14 ` [PR PATCH] [Updated] " newbluemoon
2024-10-23 19:15 ` [PR PATCH] [Updated] sonic-visualiser: update to 5.0.1 newbluemoon
2024-11-21  8:45 ` newbluemoon
2024-12-19  5:03 ` newbluemoon
2024-12-25  9:28 ` newbluemoon
2024-12-25  9:35 ` newbluemoon
2025-01-11 17:02 ` [PR PATCH] [Updated] " newbluemoon
2025-01-28 17:41 ` newbluemoon
2025-02-09  8:10 ` newbluemoon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).