Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI
@ 2024-10-05  8:17 Lacedaemon
  2024-10-05 18:53 ` [PR PATCH] [Updated] " Lacedaemon
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Lacedaemon @ 2024-10-05  8:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]

There is a new pull request by Lacedaemon against master on the void-packages repository

https://github.com/Lacedaemon/void-packages bugfix/nvidia-cdi-hook
https://github.com/void-linux/void-packages/pull/52507

nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI
Fixes the following error when trying to start a Podman container with an NVIDIA GPU attached:

```
Error: unable to start container: runc: runc create failed: unable to start container process: error during container init: error running hook #0: fork/exec /usr/bin/nvidia-cdi-hook: no such file or directory: OCI runtime attempted to invoke a command that was not found
```

And this warning when running `nvidia-ctk cdi generate --output=/etc/cdi/nvidia.yaml`:

```
WARN[0000] Failed to locate nvidia-cdi-hook: pattern nvidia-cdi-hook not found
```

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/52507.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bugfix/nvidia-cdi-hook-52507.patch --]
[-- Type: text/x-diff, Size: 1755 bytes --]

From 355a134201686b058a038dac0f525464407d076a Mon Sep 17 00:00:00 2001
From: "Nathan A." <5259183+Lacedaemon@users.noreply.github.com>
Date: Sat, 5 Oct 2024 01:12:07 -0700
Subject: [PATCH] Add nvidia-cdi-hook to nvidia-container-toolkit template

Fixes the following error when trying to start a Podman container with an NVIDIA GPU attached:

```
Error: unable to start container: runc: runc create failed: unable to start container process: error during container init: error running hook #0: fork/exec /usr/bin/nvidia-cdi-hook: no such file or directory: OCI runtime attempted to invoke a command that was not found
```

And this warning when running `nvidia-ctk cdi generate --output=/etc/cdi/nvidia.yaml`:

```
WARN[0000] Failed to locate nvidia-cdi-hook: pattern nvidia-cdi-hook not found
```
---
 srcpkgs/nvidia-container-toolkit/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/nvidia-container-toolkit/template b/srcpkgs/nvidia-container-toolkit/template
index a5d724c1f3db3b..6748d41699b64c 100644
--- a/srcpkgs/nvidia-container-toolkit/template
+++ b/srcpkgs/nvidia-container-toolkit/template
@@ -1,13 +1,14 @@
 # Template file for 'nvidia-container-toolkit'
 pkgname=nvidia-container-toolkit
 version=1.16.1
-revision=2
+revision=3
 archs="x86_64"
 build_style=go
 go_import_path=github.com/NVIDIA/nvidia-container-toolkit
 go_package="${go_import_path}/cmd/nvidia-container-runtime-hook
  ${go_import_path}/cmd/nvidia-container-runtime
- ${go_import_path}/cmd/nvidia-ctk"
+ ${go_import_path}/cmd/nvidia-ctk
+ ${go_import_path}/cmd/nvidia-cdi-hook"
 depends="libnvidia-container"
 short_desc="Build and run containers leveraging NVIDIA GPUs"
 maintainer="Quentin Freimanis <quentinfreimanis@gmail.com>"

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI
  2024-10-05  8:17 [PR PATCH] nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI Lacedaemon
@ 2024-10-05 18:53 ` Lacedaemon
  2024-10-05 20:40 ` Lacedaemon
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Lacedaemon @ 2024-10-05 18:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1904 bytes --]

There is an updated pull request by Lacedaemon against master on the void-packages repository

https://github.com/Lacedaemon/void-packages bugfix/nvidia-cdi-hook
https://github.com/void-linux/void-packages/pull/52507

nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI
Fixes the following error when trying to start a Podman container with an NVIDIA GPU attached:

```
Error: unable to start container: runc: runc create failed: unable to start container process: error during container init: error running hook #0: fork/exec /usr/bin/nvidia-cdi-hook: no such file or directory: OCI runtime attempted to invoke a command that was not found
```

And this warning when running `nvidia-ctk cdi generate --output=/etc/cdi/nvidia.yaml`:

```
WARN[0000] Failed to locate nvidia-cdi-hook: pattern nvidia-cdi-hook not found
```

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/52507.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bugfix/nvidia-cdi-hook-52507.patch --]
[-- Type: text/x-diff, Size: 1756 bytes --]

From 7f54499049ab59fc18d603c9e5154096ac0a6f47 Mon Sep 17 00:00:00 2001
From: "Nathan A." <5259183+Lacedaemon@users.noreply.github.com>
Date: Sat, 5 Oct 2024 01:12:07 -0700
Subject: [PATCH] nvidia-container-toolkit: Add nvidia-cdi-hook to template

Fixes the following error when trying to start a Podman container with an NVIDIA GPU attached:

```
Error: unable to start container: runc: runc create failed: unable to start container process: error during container init: error running hook #0: fork/exec /usr/bin/nvidia-cdi-hook: no such file or directory: OCI runtime attempted to invoke a command that was not found
```

And this warning when running `nvidia-ctk cdi generate --output=/etc/cdi/nvidia.yaml`:

```
WARN[0000] Failed to locate nvidia-cdi-hook: pattern nvidia-cdi-hook not found
```
---
 srcpkgs/nvidia-container-toolkit/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/nvidia-container-toolkit/template b/srcpkgs/nvidia-container-toolkit/template
index a5d724c1f3db3b..6748d41699b64c 100644
--- a/srcpkgs/nvidia-container-toolkit/template
+++ b/srcpkgs/nvidia-container-toolkit/template
@@ -1,13 +1,14 @@
 # Template file for 'nvidia-container-toolkit'
 pkgname=nvidia-container-toolkit
 version=1.16.1
-revision=2
+revision=3
 archs="x86_64"
 build_style=go
 go_import_path=github.com/NVIDIA/nvidia-container-toolkit
 go_package="${go_import_path}/cmd/nvidia-container-runtime-hook
  ${go_import_path}/cmd/nvidia-container-runtime
- ${go_import_path}/cmd/nvidia-ctk"
+ ${go_import_path}/cmd/nvidia-ctk
+ ${go_import_path}/cmd/nvidia-cdi-hook"
 depends="libnvidia-container"
 short_desc="Build and run containers leveraging NVIDIA GPUs"
 maintainer="Quentin Freimanis <quentinfreimanis@gmail.com>"

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI
  2024-10-05  8:17 [PR PATCH] nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI Lacedaemon
  2024-10-05 18:53 ` [PR PATCH] [Updated] " Lacedaemon
@ 2024-10-05 20:40 ` Lacedaemon
  2024-10-06 20:13 ` [PR PATCH] [Updated] " Lacedaemon
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Lacedaemon @ 2024-10-05 20:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

New comment by Lacedaemon on void-packages repository

https://github.com/void-linux/void-packages/pull/52507#issuecomment-2395191851

Comment:
Changed commit message to be compliant with CONTRIBUTING.md

It's not immediately obvious why `do_check()` is returning:

```
=> ERROR: nvidia-container-toolkit-1.16.1_3: do_check: '${make_check_pre} go test -p "$XBPS_MAKEJOBS" -v -tags "${go_build_tags}" -ldflags "${go_ldflags}" ${make_check_args} ${make_check_target}' exited with 1
=> ERROR:   in do_check() at common/build-style/go.sh:66
```

The application otherwise builds and runs just fine...

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI
  2024-10-05  8:17 [PR PATCH] nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI Lacedaemon
  2024-10-05 18:53 ` [PR PATCH] [Updated] " Lacedaemon
  2024-10-05 20:40 ` Lacedaemon
@ 2024-10-06 20:13 ` Lacedaemon
  2024-10-06 20:15 ` Lacedaemon
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Lacedaemon @ 2024-10-06 20:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1904 bytes --]

There is an updated pull request by Lacedaemon against master on the void-packages repository

https://github.com/Lacedaemon/void-packages bugfix/nvidia-cdi-hook
https://github.com/void-linux/void-packages/pull/52507

nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI
Fixes the following error when trying to start a Podman container with an NVIDIA GPU attached:

```
Error: unable to start container: runc: runc create failed: unable to start container process: error during container init: error running hook #0: fork/exec /usr/bin/nvidia-cdi-hook: no such file or directory: OCI runtime attempted to invoke a command that was not found
```

And this warning when running `nvidia-ctk cdi generate --output=/etc/cdi/nvidia.yaml`:

```
WARN[0000] Failed to locate nvidia-cdi-hook: pattern nvidia-cdi-hook not found
```

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/52507.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-bugfix/nvidia-cdi-hook-52507.patch --]
[-- Type: text/x-diff, Size: 1187 bytes --]

From 022714f48d5a95beaf2cf4dc0296f08541f5f473 Mon Sep 17 00:00:00 2001
From: Lacedaemon <likes.copilot0q@icloud.com>
Date: Sat, 5 Oct 2024 01:12:07 -0700
Subject: [PATCH] nvidia-container-toolkit: Add nvidia-cdi-hook to template

---
 srcpkgs/nvidia-container-toolkit/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/nvidia-container-toolkit/template b/srcpkgs/nvidia-container-toolkit/template
index a5d724c1f3db3b..6748d41699b64c 100644
--- a/srcpkgs/nvidia-container-toolkit/template
+++ b/srcpkgs/nvidia-container-toolkit/template
@@ -1,13 +1,14 @@
 # Template file for 'nvidia-container-toolkit'
 pkgname=nvidia-container-toolkit
 version=1.16.1
-revision=2
+revision=3
 archs="x86_64"
 build_style=go
 go_import_path=github.com/NVIDIA/nvidia-container-toolkit
 go_package="${go_import_path}/cmd/nvidia-container-runtime-hook
  ${go_import_path}/cmd/nvidia-container-runtime
- ${go_import_path}/cmd/nvidia-ctk"
+ ${go_import_path}/cmd/nvidia-ctk
+ ${go_import_path}/cmd/nvidia-cdi-hook"
 depends="libnvidia-container"
 short_desc="Build and run containers leveraging NVIDIA GPUs"
 maintainer="Quentin Freimanis <quentinfreimanis@gmail.com>"

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI
  2024-10-05  8:17 [PR PATCH] nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI Lacedaemon
                   ` (2 preceding siblings ...)
  2024-10-06 20:13 ` [PR PATCH] [Updated] " Lacedaemon
@ 2024-10-06 20:15 ` Lacedaemon
  2025-01-05  2:03 ` github-actions
  2025-01-20  1:58 ` [PR PATCH] [Closed]: " github-actions
  5 siblings, 0 replies; 7+ messages in thread
From: Lacedaemon @ 2024-10-06 20:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by Lacedaemon on void-packages repository

https://github.com/void-linux/void-packages/pull/52507#issuecomment-2395571079

Comment:
* Trimmed long commit message
* Changed email from noreply

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI
  2024-10-05  8:17 [PR PATCH] nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI Lacedaemon
                   ` (3 preceding siblings ...)
  2024-10-06 20:15 ` Lacedaemon
@ 2025-01-05  2:03 ` github-actions
  2025-01-20  1:58 ` [PR PATCH] [Closed]: " github-actions
  5 siblings, 0 replies; 7+ messages in thread
From: github-actions @ 2025-01-05  2:03 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/52507#issuecomment-2571469643

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Closed]: nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI
  2024-10-05  8:17 [PR PATCH] nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI Lacedaemon
                   ` (4 preceding siblings ...)
  2025-01-05  2:03 ` github-actions
@ 2025-01-20  1:58 ` github-actions
  5 siblings, 0 replies; 7+ messages in thread
From: github-actions @ 2025-01-20  1:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]

There's a closed pull request on the void-packages repository

nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI
https://github.com/void-linux/void-packages/pull/52507

Description:
Fixes the following error when trying to start a Podman container with an NVIDIA GPU attached:

```
Error: unable to start container: runc: runc create failed: unable to start container process: error during container init: error running hook #0: fork/exec /usr/bin/nvidia-cdi-hook: no such file or directory: OCI runtime attempted to invoke a command that was not found
```

And this warning when running `nvidia-ctk cdi generate --output=/etc/cdi/nvidia.yaml`:

```
WARN[0000] Failed to locate nvidia-cdi-hook: pattern nvidia-cdi-hook not found
```

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-01-20  1:58 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-05  8:17 [PR PATCH] nvidia-container-toolkit: Add nvidia-cdi-hook as part of build to fix NVIDIA container support via CDI Lacedaemon
2024-10-05 18:53 ` [PR PATCH] [Updated] " Lacedaemon
2024-10-05 20:40 ` Lacedaemon
2024-10-06 20:13 ` [PR PATCH] [Updated] " Lacedaemon
2024-10-06 20:15 ` Lacedaemon
2025-01-05  2:03 ` github-actions
2025-01-20  1:58 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).