[PR PATCH] New package: firewalld-2.2.1

[PR PATCH] New package: firewalld-2.2.1

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1531 bytes --]

There is a new pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages firewalld
https://github.com/void-linux/void-packages/pull/52519

New package: firewalld-2.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686
  - aarch64 (cross)
  - aarch64-musl (cross)
  - armv7l (cross)
  - armv7l-musl (cross)
  - armv6l (cross)
  - armv6l-musl (cross)


based on https://github.com/void-linux/void-packages/pull/34378, but splitting the configuration gui and applet into subpackages, and gave them the proper dependencies 



A patch file from https://github.com/void-linux/void-packages/pull/52519.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-52519.patch --]
[-- Type: text/x-diff, Size: 3959 bytes --]

From a5f1be7248b820389eb6850cb5e51a2d0265177f Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Sat, 5 Oct 2024 18:46:33 -0400
Subject: [PATCH] New package: firewalld-2.2.1

---
 srcpkgs/firewalld-applet                  |  1 +
 srcpkgs/firewalld-config                  |  1 +
 srcpkgs/firewalld/files/firewalld/log/run |  3 ++
 srcpkgs/firewalld/files/firewalld/run     |  4 ++
 srcpkgs/firewalld/template                | 54 +++++++++++++++++++++++
 5 files changed, 63 insertions(+)
 create mode 120000 srcpkgs/firewalld-applet
 create mode 120000 srcpkgs/firewalld-config
 create mode 100755 srcpkgs/firewalld/files/firewalld/log/run
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld-applet b/srcpkgs/firewalld-applet
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-applet
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld-config b/srcpkgs/firewalld-config
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-config
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld/files/firewalld/log/run b/srcpkgs/firewalld/files/firewalld/log/run
new file mode 100755
index 00000000000000..7b49eedfdf09cc
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/log/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+exec vlogger -t firewalld
diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 00000000000000..e63ef1f97b5d7a
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+exec 2>&1
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 00000000000000..a0d600c1f31da0
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,54 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=2.2.1
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt
+ python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables ipset polkit"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Daniel Martinez <danielmartinez@cock.li>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/firewalld/firewalld/releases/download/v${version}/firewalld-${version}.tar.bz2"
+checksum=5215ba30236ee1e3df2c2292465a9ff605b9c445dcab2e37da4961cb27c7f36e
+python_version=3.12
+conf_files="/etc/firewalld/*"
+# firewalld does not believe it is root in the chroot and fails
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	vsv ${pkgname}
+}
+
+firewalld-applet_package() {
+	short_desc+=" - desktop applet"
+	depends="firewalld>=${version}_${revision} python3-pyqt6-gui
+	 python3-pyqt6-dbus python3-pyqt6-widgets libnotify"
+	pkg_install() {
+		vmove etc/xdg/autostart/firewall-applet.desktop
+		vmove usr/bin/firewall-applet
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-applet*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-applet*"
+		vmove usr/share/man/man1/firewall-applet.1
+	}
+}
+
+firewalld-config_package() {
+	short_desc+=" - configuration gui"
+	depends="firewalld>=${version}_${revision} gtk+3"
+	pkg_install() {
+		vmove usr/bin/firewall-config
+		vmove usr/share/applications/firewall-config.desktop
+		vmove usr/share/firewalld/firewall-config.glade
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-config*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-config*"
+		vmove usr/share/man/man1/firewall-config.1
+		vmove usr/share/metainfo/firewall-config.appdata.xml
+	}
+}

Re: [PR REVIEW] New package: firewalld-2.2.1

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New review comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/52519#discussion_r1788768190

Comment:
the binary is `/usr/bin/firewall-applet`, maybe the subpackage should be named `firewall-applet` ?

Re: [PR REVIEW] New package: firewalld-2.2.1

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

New review comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/52519#discussion_r1788768256

Comment:
the binary is `/usr/bin/firewall-config`, maybe the subpackage should be named `firewall-config` ?

Re: New package: firewalld-2.2.1

[manfred3000]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

New comment by manfred3000 on void-packages repository

https://github.com/void-linux/void-packages/pull/52519#issuecomment-2395408119

Comment:
`ipset` and `polkit` are optional dependencies that "[may enhance firewalld's functionality, but they are not required](https://github.com/firewalld/firewalld)".
Personally, I avoid software that tries to pull in `polkit` (I used to use `firewalld` while on Arch Linux, and was quite happy with it).

Just my 2 cents - thanks for templating :)

Re: New package: firewalld-2.2.1

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

New comment by Calandracas606 on void-packages repository

https://github.com/void-linux/void-packages/pull/52519#issuecomment-2395411191

Comment:
> `ipset` and `polkit` are optional dependencies that "[may enhance firewalld's functionality, but they are not required](https://github.com/firewalld/firewalld)". 

interesting... the service refused to start in my test vm until polkit was installed. I'll test again later today.

polkit is defineately required for the applet and config utilities, which have be turned into services to avoid pulling in qt6 and gtk+3

Re: New package: firewalld-2.2.1

[manfred3000]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

New comment by manfred3000 on void-packages repository

https://github.com/void-linux/void-packages/pull/52519#issuecomment-2395418769

Comment:
Nothing is preventing the user from installing `polkit` manually...
Suggestion: add a comment inside the service file or inform the user during the installation process (I'm not sure how cases like this are usually handled on Void - but "not having to work out-of-the-box" doesn't seem to go against Void's philosophy, imho).

Re: New package: firewalld-2.2.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/52519#issuecomment-2395464801

Comment:
if it doesn't work without polkit it should depend on polkit

Re: [PR PATCH] [Updated] New package: firewalld-2.2.1

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]

There is an updated pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages firewalld
https://github.com/void-linux/void-packages/pull/52519

New package: firewalld-2.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686
  - aarch64 (cross)
  - aarch64-musl (cross)
  - armv7l (cross)
  - armv7l-musl (cross)
  - armv6l (cross)
  - armv6l-musl (cross)


based on https://github.com/void-linux/void-packages/pull/34378, but splitting the configuration gui and applet into subpackages, and gave them the proper dependencies 



A patch file from https://github.com/void-linux/void-packages/pull/52519.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-52519.patch --]
[-- Type: text/x-diff, Size: 3959 bytes --]

From 71e67350178525e8a916536a8345b0c53c836b14 Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Sat, 5 Oct 2024 18:46:33 -0400
Subject: [PATCH] New package: firewalld-2.2.1

---
 srcpkgs/firewalld-applet                  |  1 +
 srcpkgs/firewalld-config                  |  1 +
 srcpkgs/firewalld/files/firewalld/log/run |  3 ++
 srcpkgs/firewalld/files/firewalld/run     |  4 ++
 srcpkgs/firewalld/template                | 54 +++++++++++++++++++++++
 5 files changed, 63 insertions(+)
 create mode 120000 srcpkgs/firewalld-applet
 create mode 120000 srcpkgs/firewalld-config
 create mode 100755 srcpkgs/firewalld/files/firewalld/log/run
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld-applet b/srcpkgs/firewalld-applet
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-applet
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld-config b/srcpkgs/firewalld-config
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-config
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld/files/firewalld/log/run b/srcpkgs/firewalld/files/firewalld/log/run
new file mode 100755
index 00000000000000..7b49eedfdf09cc
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/log/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+exec vlogger -t firewalld
diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 00000000000000..e63ef1f97b5d7a
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+exec 2>&1
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 00000000000000..a0d600c1f31da0
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,54 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=2.2.1
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt
+ python3 docbook-xsl glib-devel"
+depends="python3-gobject python3-dbus nftables ipset polkit"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Daniel Martinez <danielmartinez@cock.li>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/firewalld/firewalld/releases/download/v${version}/firewalld-${version}.tar.bz2"
+checksum=5215ba30236ee1e3df2c2292465a9ff605b9c445dcab2e37da4961cb27c7f36e
+python_version=3.12
+conf_files="/etc/firewalld/*"
+# firewalld does not believe it is root in the chroot and fails
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	vsv ${pkgname}
+}
+
+firewalld-applet_package() {
+	short_desc+=" - desktop applet"
+	depends="firewalld>=${version}_${revision} python3-pyqt6-gui
+	 python3-pyqt6-dbus python3-pyqt6-widgets libnotify"
+	pkg_install() {
+		vmove etc/xdg/autostart/firewall-applet.desktop
+		vmove usr/bin/firewall-applet
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-applet*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-applet*"
+		vmove usr/share/man/man1/firewall-applet.1
+	}
+}
+
+firewalld-config_package() {
+	short_desc+=" - configuration gui"
+	depends="firewalld>=${version}_${revision} gtk+3"
+	pkg_install() {
+		vmove usr/bin/firewall-config
+		vmove usr/share/applications/firewall-config.desktop
+		vmove usr/share/firewalld/firewall-config.glade
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-config*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-config*"
+		vmove usr/share/man/man1/firewall-config.1
+		vmove usr/share/metainfo/firewall-config.appdata.xml
+	}
+}

Re: [PR REVIEW] New package: firewalld-2.2.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/52519#discussion_r1894632572

Comment:
docbook-xsl is here twice

Re: [PR REVIEW] New package: firewalld-2.2.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/52519#discussion_r1894632772

Comment:
no, i think it's good to have the pkgnames related by firewalld. it's an applet for firewalld not any firewall

Re: [PR REVIEW] New package: firewalld-2.2.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 202 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/52519#discussion_r1894632912

Comment:
same thing, config for firewalld not any firewall

Re: [PR PATCH] [Updated] New package: firewalld-2.2.1

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]

There is an updated pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages firewalld
https://github.com/void-linux/void-packages/pull/52519

New package: firewalld-2.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686
  - aarch64 (cross)
  - aarch64-musl (cross)
  - armv7l (cross)
  - armv7l-musl (cross)
  - armv6l (cross)
  - armv6l-musl (cross)


based on https://github.com/void-linux/void-packages/pull/34378, but splitting the configuration gui and applet into subpackages, and gave them the proper dependencies 



A patch file from https://github.com/void-linux/void-packages/pull/52519.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-52519.patch --]
[-- Type: text/x-diff, Size: 3947 bytes --]

From aaac9d29dd3ca3b18ecfcceabf53bf844f507923 Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Sat, 5 Oct 2024 18:46:33 -0400
Subject: [PATCH] New package: firewalld-2.3.0

---
 srcpkgs/firewalld-applet                  |  1 +
 srcpkgs/firewalld-config                  |  1 +
 srcpkgs/firewalld/files/firewalld/log/run |  3 ++
 srcpkgs/firewalld/files/firewalld/run     |  4 ++
 srcpkgs/firewalld/template                | 54 +++++++++++++++++++++++
 5 files changed, 63 insertions(+)
 create mode 120000 srcpkgs/firewalld-applet
 create mode 120000 srcpkgs/firewalld-config
 create mode 100755 srcpkgs/firewalld/files/firewalld/log/run
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld-applet b/srcpkgs/firewalld-applet
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-applet
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld-config b/srcpkgs/firewalld-config
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-config
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld/files/firewalld/log/run b/srcpkgs/firewalld/files/firewalld/log/run
new file mode 100755
index 00000000000000..7b49eedfdf09cc
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/log/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+exec vlogger -t firewalld
diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 00000000000000..e63ef1f97b5d7a
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+exec 2>&1
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 00000000000000..a8aeced38aed67
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,54 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=2.3.0
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt
+ python3 glib-devel"
+depends="python3-gobject python3-dbus nftables ipset polkit"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Daniel Martinez <danielmartinez@cock.li>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/firewalld/firewalld/releases/download/v${version}/firewalld-${version}.tar.bz2"
+checksum=f6ba846c92fc08aebda8dfd2856e6c6224d170a5288a2ae1c181d6a43036c009
+python_version=3.12
+conf_files="/etc/firewalld/*"
+# firewalld does not believe it is root in the chroot and fails
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	vsv ${pkgname}
+}
+
+firewalld-applet_package() {
+	short_desc+=" - desktop applet"
+	depends="firewalld>=${version}_${revision} python3-pyqt6-gui
+	 python3-pyqt6-dbus python3-pyqt6-widgets libnotify"
+	pkg_install() {
+		vmove etc/xdg/autostart/firewall-applet.desktop
+		vmove usr/bin/firewall-applet
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-applet*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-applet*"
+		vmove usr/share/man/man1/firewall-applet.1
+	}
+}
+
+firewalld-config_package() {
+	short_desc+=" - configuration gui"
+	depends="firewalld>=${version}_${revision} gtk+3"
+	pkg_install() {
+		vmove usr/bin/firewall-config
+		vmove usr/share/applications/firewall-config.desktop
+		vmove usr/share/firewalld/firewall-config.glade
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-config*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-config*"
+		vmove usr/share/man/man1/firewall-config.1
+		vmove usr/share/metainfo/firewall-config.appdata.xml
+	}
+}

Re: New package: firewalld-2.2.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/52519#issuecomment-2561997328

Comment:
should `/etc/firewall/applet.conf` go in the applet pkg? 

Re: [PR PATCH] [Updated] New package: firewalld-2.2.1

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]

There is an updated pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages firewalld
https://github.com/void-linux/void-packages/pull/52519

New package: firewalld-2.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686
  - aarch64 (cross)
  - aarch64-musl (cross)
  - armv7l (cross)
  - armv7l-musl (cross)
  - armv6l (cross)
  - armv6l-musl (cross)


based on https://github.com/void-linux/void-packages/pull/34378, but splitting the configuration gui and applet into subpackages, and gave them the proper dependencies 



A patch file from https://github.com/void-linux/void-packages/pull/52519.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-52519.patch --]
[-- Type: text/x-diff, Size: 3997 bytes --]

From c1e6d4f371ff3994507425f55fef5c7adde3a3c7 Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Sat, 5 Oct 2024 18:46:33 -0400
Subject: [PATCH] New package: firewalld-2.3.0

---
 srcpkgs/firewalld-applet                  |  1 +
 srcpkgs/firewalld-config                  |  1 +
 srcpkgs/firewalld/files/firewalld/log/run |  3 ++
 srcpkgs/firewalld/files/firewalld/run     |  4 ++
 srcpkgs/firewalld/template                | 54 +++++++++++++++++++++++
 5 files changed, 63 insertions(+)
 create mode 120000 srcpkgs/firewalld-applet
 create mode 120000 srcpkgs/firewalld-config
 create mode 100755 srcpkgs/firewalld/files/firewalld/log/run
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld-applet b/srcpkgs/firewalld-applet
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-applet
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld-config b/srcpkgs/firewalld-config
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-config
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld/files/firewalld/log/run b/srcpkgs/firewalld/files/firewalld/log/run
new file mode 100755
index 00000000000000..7b49eedfdf09cc
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/log/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+
+exec vlogger -t firewalld
diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 00000000000000..e63ef1f97b5d7a
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+exec 2>&1
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 00000000000000..8734d9fe3268a3
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,54 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=2.3.0
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt
+ python3 glib-devel iptables-nft ipset"
+depends="python3-gobject python3-dbus libcap-ng-python3 nftables iptables-nft ipset polkit"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Daniel Martinez <danielmartinez@cock.li>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/firewalld/firewalld/releases/download/v${version}/firewalld-${version}.tar.bz2"
+checksum=f6ba846c92fc08aebda8dfd2856e6c6224d170a5288a2ae1c181d6a43036c009
+python_version=3.12
+conf_files="/etc/firewalld/*"
+# firewalld does not believe it is root in the chroot and fails
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	vsv ${pkgname}
+}
+
+firewalld-applet_package() {
+	short_desc+=" - desktop applet"
+	depends="firewalld>=${version}_${revision} python3-pyqt6-gui
+	 python3-pyqt6-dbus python3-pyqt6-widgets libnotify"
+	pkg_install() {
+		vmove etc/xdg/autostart/firewall-applet.desktop
+		vmove usr/bin/firewall-applet
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-applet*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-applet*"
+		vmove usr/share/man/man1/firewall-applet.1
+	}
+}
+
+firewalld-config_package() {
+	short_desc+=" - configuration gui"
+	depends="firewalld>=${version}_${revision} gtk+3"
+	pkg_install() {
+		vmove usr/bin/firewall-config
+		vmove usr/share/applications/firewall-config.desktop
+		vmove usr/share/firewalld/firewall-config.glade
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-config*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-config*"
+		vmove usr/share/man/man1/firewall-config.1
+		vmove usr/share/metainfo/firewall-config.appdata.xml
+	}
+}

Re: [PR PATCH] [Updated] New package: firewalld-2.2.1

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]

There is an updated pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages firewalld
https://github.com/void-linux/void-packages/pull/52519

New package: firewalld-2.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686
  - aarch64 (cross)
  - aarch64-musl (cross)
  - armv7l (cross)
  - armv7l-musl (cross)
  - armv6l (cross)
  - armv6l-musl (cross)


based on https://github.com/void-linux/void-packages/pull/34378, but splitting the configuration gui and applet into subpackages, and gave them the proper dependencies 



A patch file from https://github.com/void-linux/void-packages/pull/52519.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-52519.patch --]
[-- Type: text/x-diff, Size: 4107 bytes --]

From 9abf5c5492be695a37a61b97696cab0d4795cd04 Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Sat, 5 Oct 2024 18:46:33 -0400
Subject: [PATCH] New package: firewalld-2.3.0

---
 srcpkgs/firewalld-applet                |  1 +
 srcpkgs/firewalld-config                |  1 +
 srcpkgs/firewalld/files/firewalld/check |  2 +
 srcpkgs/firewalld/files/firewalld/run   |  4 ++
 srcpkgs/firewalld/template              | 56 +++++++++++++++++++++++++
 5 files changed, 64 insertions(+)
 create mode 120000 srcpkgs/firewalld-applet
 create mode 120000 srcpkgs/firewalld-config
 create mode 100755 srcpkgs/firewalld/files/firewalld/check
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld-applet b/srcpkgs/firewalld-applet
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-applet
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld-config b/srcpkgs/firewalld-config
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-config
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld/files/firewalld/check b/srcpkgs/firewalld/files/firewalld/check
new file mode 100755
index 00000000000000..7438c9f48220e7
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/check
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec firewall-cmd --state >/dev/null 2>&1
diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 00000000000000..e63ef1f97b5d7a
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,4 @@
+#!/bin/sh
+exec 2>&1
+sv check dbus >/dev/null || exit 1
+exec firewalld --nofork
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 00000000000000..2b05fd09b7553a
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,56 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=2.3.0
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt
+ python3 glib-devel iptables-nft ipset"
+depends="python3-gobject python3-dbus libcap-ng-python3 nftables iptables-nft ipset polkit"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Daniel Martinez <danielmartinez@cock.li>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/firewalld/firewalld/releases/download/v${version}/firewalld-${version}.tar.bz2"
+checksum=f6ba846c92fc08aebda8dfd2856e6c6224d170a5288a2ae1c181d6a43036c009
+python_version=3.12
+conf_files="/etc/firewalld/firewalld.conf /etc/sysconfig/firewalld"
+# firewalld does not believe it is root in the chroot and fails
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	vsv ${pkgname}
+}
+
+firewalld-applet_package() {
+	short_desc+=" - desktop applet"
+	depends="firewalld>=${version}_${revision} python3-pyqt6-gui
+	 python3-pyqt6-dbus python3-pyqt6-widgets libnotify"
+	conf_files="/etc/firewall/applet.conf"
+	pkg_install() {
+		vmove etc/xdg/autostart/firewall-applet.desktop
+		vmove usr/bin/firewall-applet
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-applet*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-applet*"
+		vmove usr/share/man/man1/firewall-applet.1
+		vmove etc/firewall/applet.conf
+	}
+}
+
+firewalld-config_package() {
+	short_desc+=" - configuration gui"
+	depends="firewalld>=${version}_${revision} gtk+3"
+	pkg_install() {
+		vmove usr/bin/firewall-config
+		vmove usr/share/applications/firewall-config.desktop
+		vmove usr/share/firewalld/firewall-config.glade
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-config*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-config*"
+		vmove usr/share/man/man1/firewall-config.1
+		vmove usr/share/metainfo/firewall-config.appdata.xml
+	}
+}

Re: [PR PATCH] [Updated] New package: firewalld-2.2.1

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]

There is an updated pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages firewalld
https://github.com/void-linux/void-packages/pull/52519

New package: firewalld-2.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686
  - aarch64 (cross)
  - aarch64-musl (cross)
  - armv7l (cross)
  - armv7l-musl (cross)
  - armv6l (cross)
  - armv6l-musl (cross)


based on https://github.com/void-linux/void-packages/pull/34378, but splitting the configuration gui and applet into subpackages, and gave them the proper dependencies 



A patch file from https://github.com/void-linux/void-packages/pull/52519.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-52519.patch --]
[-- Type: text/x-diff, Size: 4195 bytes --]

From 8be0f1cb8816b6d08eeaec2e2a4cd50391bfe2df Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Sat, 5 Oct 2024 18:46:33 -0400
Subject: [PATCH] New package: firewalld-2.3.0

---
 srcpkgs/firewalld-applet                |  1 +
 srcpkgs/firewalld-config                |  1 +
 srcpkgs/firewalld/files/firewalld/check |  2 +
 srcpkgs/firewalld/files/firewalld/run   |  5 +++
 srcpkgs/firewalld/template              | 56 +++++++++++++++++++++++++
 5 files changed, 65 insertions(+)
 create mode 120000 srcpkgs/firewalld-applet
 create mode 120000 srcpkgs/firewalld-config
 create mode 100755 srcpkgs/firewalld/files/firewalld/check
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld-applet b/srcpkgs/firewalld-applet
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-applet
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld-config b/srcpkgs/firewalld-config
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-config
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld/files/firewalld/check b/srcpkgs/firewalld/files/firewalld/check
new file mode 100755
index 00000000000000..7438c9f48220e7
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/check
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec firewall-cmd --state >/dev/null 2>&1
diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 00000000000000..284ce89168495f
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+exec 2>&1
+sv check dbus >/dev/null || exit 1
+[ -r /etc/sysconfig/firewalld ] && . /etc/sysconfig/firewalld
+exec firewalld --nofork --nopid $FIREWALLD_ARGS
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 00000000000000..2b05fd09b7553a
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,56 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=2.3.0
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt
+ python3 glib-devel iptables-nft ipset"
+depends="python3-gobject python3-dbus libcap-ng-python3 nftables iptables-nft ipset polkit"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Daniel Martinez <danielmartinez@cock.li>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/firewalld/firewalld/releases/download/v${version}/firewalld-${version}.tar.bz2"
+checksum=f6ba846c92fc08aebda8dfd2856e6c6224d170a5288a2ae1c181d6a43036c009
+python_version=3.12
+conf_files="/etc/firewalld/firewalld.conf /etc/sysconfig/firewalld"
+# firewalld does not believe it is root in the chroot and fails
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	vsv ${pkgname}
+}
+
+firewalld-applet_package() {
+	short_desc+=" - desktop applet"
+	depends="firewalld>=${version}_${revision} python3-pyqt6-gui
+	 python3-pyqt6-dbus python3-pyqt6-widgets libnotify"
+	conf_files="/etc/firewall/applet.conf"
+	pkg_install() {
+		vmove etc/xdg/autostart/firewall-applet.desktop
+		vmove usr/bin/firewall-applet
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-applet*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-applet*"
+		vmove usr/share/man/man1/firewall-applet.1
+		vmove etc/firewall/applet.conf
+	}
+}
+
+firewalld-config_package() {
+	short_desc+=" - configuration gui"
+	depends="firewalld>=${version}_${revision} gtk+3"
+	pkg_install() {
+		vmove usr/bin/firewall-config
+		vmove usr/share/applications/firewall-config.desktop
+		vmove usr/share/firewalld/firewall-config.glade
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-config*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-config*"
+		vmove usr/share/man/man1/firewall-config.1
+		vmove usr/share/metainfo/firewall-config.appdata.xml
+	}
+}

Re: [PR REVIEW] New package: firewalld-2.2.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/52519#discussion_r1899693558

Comment:
should only be `2`, `3`, or `ignore`

Re: [PR PATCH] [Updated] New package: firewalld-2.2.1

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]

There is an updated pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages firewalld
https://github.com/void-linux/void-packages/pull/52519

New package: firewalld-2.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686
  - aarch64 (cross)
  - aarch64-musl (cross)
  - armv7l (cross)
  - armv7l-musl (cross)
  - armv6l (cross)
  - armv6l-musl (cross)


based on https://github.com/void-linux/void-packages/pull/34378, but splitting the configuration gui and applet into subpackages, and gave them the proper dependencies 



A patch file from https://github.com/void-linux/void-packages/pull/52519.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-52519.patch --]
[-- Type: text/x-diff, Size: 4543 bytes --]

From 272570efc46d203a1a65531570d66b2e292d13e7 Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Sat, 5 Oct 2024 18:46:33 -0400
Subject: [PATCH] New package: firewalld-2.3.0

---
 srcpkgs/firewalld-applet                |  1 +
 srcpkgs/firewalld-config                |  1 +
 srcpkgs/firewalld/files/firewalld/check |  2 +
 srcpkgs/firewalld/files/firewalld/conf  |  3 ++
 srcpkgs/firewalld/files/firewalld/run   |  5 +++
 srcpkgs/firewalld/template              | 56 +++++++++++++++++++++++++
 6 files changed, 68 insertions(+)
 create mode 120000 srcpkgs/firewalld-applet
 create mode 120000 srcpkgs/firewalld-config
 create mode 100755 srcpkgs/firewalld/files/firewalld/check
 create mode 100644 srcpkgs/firewalld/files/firewalld/conf
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld-applet b/srcpkgs/firewalld-applet
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-applet
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld-config b/srcpkgs/firewalld-config
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-config
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld/files/firewalld/check b/srcpkgs/firewalld/files/firewalld/check
new file mode 100755
index 00000000000000..7438c9f48220e7
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/check
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec firewall-cmd --state >/dev/null 2>&1
diff --git a/srcpkgs/firewalld/files/firewalld/conf b/srcpkgs/firewalld/files/firewalld/conf
new file mode 100644
index 00000000000000..17a9f0f33b3924
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/conf
@@ -0,0 +1,3 @@
+
+# firewalld command line args
+FIREWALLD_ARGS=
diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 00000000000000..6d6b570fc87868
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+exec 2>&1
+sv check dbus >/dev/null || exit 1
+[ -r conf ] && . ./conf
+exec firewalld --nofork --nopid ${FIREWALLD_ARGS}
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 00000000000000..2b05fd09b7553a
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,56 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=2.3.0
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt
+ python3 glib-devel iptables-nft ipset"
+depends="python3-gobject python3-dbus libcap-ng-python3 nftables iptables-nft ipset polkit"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Daniel Martinez <danielmartinez@cock.li>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/firewalld/firewalld/releases/download/v${version}/firewalld-${version}.tar.bz2"
+checksum=f6ba846c92fc08aebda8dfd2856e6c6224d170a5288a2ae1c181d6a43036c009
+python_version=3.12
+conf_files="/etc/firewalld/firewalld.conf /etc/sysconfig/firewalld"
+# firewalld does not believe it is root in the chroot and fails
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	vsv ${pkgname}
+}
+
+firewalld-applet_package() {
+	short_desc+=" - desktop applet"
+	depends="firewalld>=${version}_${revision} python3-pyqt6-gui
+	 python3-pyqt6-dbus python3-pyqt6-widgets libnotify"
+	conf_files="/etc/firewall/applet.conf"
+	pkg_install() {
+		vmove etc/xdg/autostart/firewall-applet.desktop
+		vmove usr/bin/firewall-applet
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-applet*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-applet*"
+		vmove usr/share/man/man1/firewall-applet.1
+		vmove etc/firewall/applet.conf
+	}
+}
+
+firewalld-config_package() {
+	short_desc+=" - configuration gui"
+	depends="firewalld>=${version}_${revision} gtk+3"
+	pkg_install() {
+		vmove usr/bin/firewall-config
+		vmove usr/share/applications/firewall-config.desktop
+		vmove usr/share/firewalld/firewall-config.glade
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-config*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-config*"
+		vmove usr/share/man/man1/firewall-config.1
+		vmove usr/share/metainfo/firewall-config.appdata.xml
+	}
+}

Re: [PR PATCH] [Updated] New package: firewalld-2.2.1

[Calandracas606]

[-- Attachment #1: Type: text/plain, Size: 1536 bytes --]

There is an updated pull request by Calandracas606 against master on the void-packages repository

https://github.com/Calandracas606/void-packages firewalld
https://github.com/void-linux/void-packages/pull/52519

New package: firewalld-2.2.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686
  - aarch64 (cross)
  - aarch64-musl (cross)
  - armv7l (cross)
  - armv7l-musl (cross)
  - armv6l (cross)
  - armv6l-musl (cross)


based on https://github.com/void-linux/void-packages/pull/34378, but splitting the configuration gui and applet into subpackages, and gave them the proper dependencies 



A patch file from https://github.com/void-linux/void-packages/pull/52519.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-firewalld-52519.patch --]
[-- Type: text/x-diff, Size: 4540 bytes --]

From cc09b3b9d819a119e8fbf9daf257c73708990b52 Mon Sep 17 00:00:00 2001
From: Daniel Martinez <danielmartinez@cock.li>
Date: Sat, 5 Oct 2024 18:46:33 -0400
Subject: [PATCH] New package: firewalld-2.3.0

---
 srcpkgs/firewalld-applet                |  1 +
 srcpkgs/firewalld-config                |  1 +
 srcpkgs/firewalld/files/firewalld/check |  2 +
 srcpkgs/firewalld/files/firewalld/conf  |  3 ++
 srcpkgs/firewalld/files/firewalld/run   |  5 +++
 srcpkgs/firewalld/template              | 56 +++++++++++++++++++++++++
 6 files changed, 68 insertions(+)
 create mode 120000 srcpkgs/firewalld-applet
 create mode 120000 srcpkgs/firewalld-config
 create mode 100755 srcpkgs/firewalld/files/firewalld/check
 create mode 100644 srcpkgs/firewalld/files/firewalld/conf
 create mode 100755 srcpkgs/firewalld/files/firewalld/run
 create mode 100644 srcpkgs/firewalld/template

diff --git a/srcpkgs/firewalld-applet b/srcpkgs/firewalld-applet
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-applet
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld-config b/srcpkgs/firewalld-config
new file mode 120000
index 00000000000000..0c412c1f20de0c
--- /dev/null
+++ b/srcpkgs/firewalld-config
@@ -0,0 +1 @@
+firewalld
\ No newline at end of file
diff --git a/srcpkgs/firewalld/files/firewalld/check b/srcpkgs/firewalld/files/firewalld/check
new file mode 100755
index 00000000000000..7438c9f48220e7
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/check
@@ -0,0 +1,2 @@
+#!/bin/sh
+exec firewall-cmd --state >/dev/null 2>&1
diff --git a/srcpkgs/firewalld/files/firewalld/conf b/srcpkgs/firewalld/files/firewalld/conf
new file mode 100644
index 00000000000000..17a9f0f33b3924
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/conf
@@ -0,0 +1,3 @@
+
+# firewalld command line args
+FIREWALLD_ARGS=
diff --git a/srcpkgs/firewalld/files/firewalld/run b/srcpkgs/firewalld/files/firewalld/run
new file mode 100755
index 00000000000000..6d6b570fc87868
--- /dev/null
+++ b/srcpkgs/firewalld/files/firewalld/run
@@ -0,0 +1,5 @@
+#!/bin/sh
+exec 2>&1
+sv check dbus >/dev/null || exit 1
+[ -r conf ] && . ./conf
+exec firewalld --nofork --nopid ${FIREWALLD_ARGS}
diff --git a/srcpkgs/firewalld/template b/srcpkgs/firewalld/template
new file mode 100644
index 00000000000000..f374247574a40e
--- /dev/null
+++ b/srcpkgs/firewalld/template
@@ -0,0 +1,56 @@
+# Template file for 'firewalld'
+pkgname=firewalld
+version=2.3.0
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config docbook-xsl xmlcatmgr intltool libxslt
+ python3 glib-devel iptables-nft ipset"
+depends="python3-gobject python3-dbus libcap-ng-python3 nftables iptables-nft ipset polkit"
+short_desc="Dynamically managed firewall with support for network zones"
+maintainer="Daniel Martinez <danielmartinez@cock.li>"
+license="GPL-2.0-or-later"
+homepage="https://firewalld.org/"
+distfiles="https://github.com/firewalld/firewalld/releases/download/v${version}/firewalld-${version}.tar.bz2"
+checksum=f6ba846c92fc08aebda8dfd2856e6c6224d170a5288a2ae1c181d6a43036c009
+python_version=3
+conf_files="/etc/firewalld/firewalld.conf /etc/sysconfig/firewalld"
+# firewalld does not believe it is root in the chroot and fails
+make_check=no
+
+post_install() {
+	mv ${DESTDIR}/etc/modprobe.d ${DESTDIR}/usr/lib
+	vsv ${pkgname}
+}
+
+firewalld-applet_package() {
+	short_desc+=" - desktop applet"
+	depends="firewalld>=${version}_${revision} python3-pyqt6-gui
+	 python3-pyqt6-dbus python3-pyqt6-widgets libnotify"
+	conf_files="/etc/firewall/applet.conf"
+	pkg_install() {
+		vmove etc/xdg/autostart/firewall-applet.desktop
+		vmove usr/bin/firewall-applet
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-applet*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-applet*"
+		vmove usr/share/man/man1/firewall-applet.1
+		vmove etc/firewall/applet.conf
+	}
+}
+
+firewalld-config_package() {
+	short_desc+=" - configuration gui"
+	depends="firewalld>=${version}_${revision} gtk+3"
+	pkg_install() {
+		vmove usr/bin/firewall-config
+		vmove usr/share/applications/firewall-config.desktop
+		vmove usr/share/firewalld/firewall-config.glade
+		for size in 16 22 24 32 48; do
+	 		vmove "usr/share/icons/hicolor/${size}x${size}/apps/firewall-config*"
+		done
+		vmove "usr/share/icons/hicolor/scalable/apps/firewall-config*"
+		vmove usr/share/man/man1/firewall-config.1
+		vmove usr/share/metainfo/firewall-config.appdata.xml
+	}
+}

Re: [PR PATCH] [Merged]: New package: firewalld-2.2.1

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

There's a merged pull request on the void-packages repository

New package: firewalld-2.2.1
https://github.com/void-linux/void-packages/pull/52519

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl
  - i686
  - aarch64 (cross)
  - aarch64-musl (cross)
  - armv7l (cross)
  - armv7l-musl (cross)
  - armv6l (cross)
  - armv6l-musl (cross)


based on https://github.com/void-linux/void-packages/pull/34378, but splitting the configuration gui and applet into subpackages, and gave them the proper dependencies