[PR PATCH] incus: add control/t file for graceful shutdown

[PR PATCH] incus: add control/t file for graceful shutdown

[duskmoss]

[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]

There is a new pull request by duskmoss against master on the void-packages repository

https://github.com/duskmoss/void-packages incus-service
https://github.com/void-linux/void-packages/pull/52554

incus: add control/t file for graceful shutdown
Incus interprets `SIGTERM` as a temporary shutdown of the incus daemon and leaves the instances running. `incus admin shutdown` starts a clean shutdown of all instances before exiting the incus daemon. This is important for system shutdown on an incus host.

**Note** I could add a time out to the incus shutdown command if that's desired.

#### Testing the changes
- I tested the changes in this PR: **YES** I've been running with this control file in my customized incus service since September 9th.


#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
   x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl 
  - (cross) aarch64-musl
  - (cross) armv7l
  - (cross) armv6l-musl


A patch file from https://github.com/void-linux/void-packages/pull/52554.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-incus-service-52554.patch --]
[-- Type: text/x-diff, Size: 996 bytes --]

From 5a0dab6006a776b2eb9b6121bb0ea6a2e8e96d3b Mon Sep 17 00:00:00 2001
From: Moss Hope <duskmoss@proton.me>
Date: Mon, 7 Oct 2024 14:56:27 -0700
Subject: [PATCH] incus: add control/t file for graceful shutdown

---
 srcpkgs/incus/files/incus/control/t | 2 ++
 srcpkgs/incus/template              | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/incus/files/incus/control/t

diff --git a/srcpkgs/incus/files/incus/control/t b/srcpkgs/incus/files/incus/control/t
new file mode 100644
index 00000000000000..3d45529d0db197
--- /dev/null
+++ b/srcpkgs/incus/files/incus/control/t
@@ -0,0 +1,2 @@
+#!/bin/sh
+incus admin shutdown
diff --git a/srcpkgs/incus/template b/srcpkgs/incus/template
index af37776caf8343..a7c8e9bfda226a 100644
--- a/srcpkgs/incus/template
+++ b/srcpkgs/incus/template
@@ -1,7 +1,7 @@
 # Template file for 'incus'
 pkgname=incus
 version=6.6.0
-revision=1
+revision=2
 build_style=go
 build_helper=qemu
 go_import_path=github.com/lxc/incus/v6

Re: incus: add control/t file for graceful shutdown

[duskmoss]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New comment by duskmoss on void-packages repository

https://github.com/void-linux/void-packages/pull/52554#issuecomment-2398110137

Comment:
@dkwo for your consideration!

Re: incus: add control/t file for graceful shutdown

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 170 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/52554#issuecomment-2400413406

Comment:
This looks good to me, thanks.

Re: [PR PATCH] [Closed]: incus: add control/t file for graceful shutdown

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

There's a closed pull request on the void-packages repository

incus: add control/t file for graceful shutdown
https://github.com/void-linux/void-packages/pull/52554

Description:
Incus interprets `SIGTERM` as a temporary shutdown of the incus daemon and leaves the instances running. `incus admin shutdown` starts a clean shutdown of all instances before exiting the incus daemon. This is important for system shutdown on an incus host.

**Note** I could add a time out to the incus shutdown command if that's desired.

#### Testing the changes
- I tested the changes in this PR: **YES** I've been running with this control file in my customized incus service since September 9th.


#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
   x86_64
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - x86_64-musl 
  - (cross) aarch64-musl
  - (cross) armv7l
  - (cross) armv6l-musl