Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] PrismLauncher: remove SOURCE_DATE_EPOCH special handling
@ 2024-10-28 20:05 sertonix
  2024-11-01  3:18 ` [PR PATCH] [Merged]: " classabbyamp
  0 siblings, 1 reply; 2+ messages in thread
From: sertonix @ 2024-10-28 20:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

There is a new pull request by sertonix against master on the void-packages repository

https://github.com/sertonix/void-packages patch-1
https://github.com/void-linux/void-packages/pull/52819

PrismLauncher: remove SOURCE_DATE_EPOCH special handling
Since cmake version 3.8 it will automatically use SOURCE_DATE_EPOCH for the build timestamp.

https://cmake.org/cmake/help/latest/command/string.html#timestamp

#### Testing the changes
- I tested the changes in this PR: **NO**


A patch file from https://github.com/void-linux/void-packages/pull/52819.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-1-52819.patch --]
[-- Type: text/x-diff, Size: 942 bytes --]

From 7cbc4726b0aed79a8ab065053f9a518f08919942 Mon Sep 17 00:00:00 2001
From: Sertonix <sertonix@posteo.net>
Date: Mon, 28 Oct 2024 20:02:20 +0000
Subject: [PATCH] PrismLauncher: remove SOURCE_DATE_EPOCH special handling

Since cmake version 3.8 it will automatically use SOURCE_DATE_EPOCH for the build timestamp.

https://cmake.org/cmake/help/latest/command/string.html#timestamp
---
 srcpkgs/PrismLauncher/template | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/srcpkgs/PrismLauncher/template b/srcpkgs/PrismLauncher/template
index bc56c595667853..8d1f0b2094dcf7 100644
--- a/srcpkgs/PrismLauncher/template
+++ b/srcpkgs/PrismLauncher/template
@@ -26,11 +26,6 @@ case "$XBPS_TARGET_MACHINE" in
 esac
 
 pre_configure() {
-	local _date
-	if [ "$SOURCE_DATE_EPOCH" ]; then
-		_date="$(date --utc --date "@$SOURCE_DATE_EPOCH" "+%Y-%m-%d")"
-		configure_args+=" -DLauncher_BUILD_TIMESTAMP=${_date}"
-	fi
 	. /etc/profile.d/jdk.sh
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PR PATCH] [Merged]: PrismLauncher: remove SOURCE_DATE_EPOCH special handling
  2024-10-28 20:05 [PR PATCH] PrismLauncher: remove SOURCE_DATE_EPOCH special handling sertonix
@ 2024-11-01  3:18 ` classabbyamp
  0 siblings, 0 replies; 2+ messages in thread
From: classabbyamp @ 2024-11-01  3:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 424 bytes --]

There's a merged pull request on the void-packages repository

PrismLauncher: remove SOURCE_DATE_EPOCH special handling
https://github.com/void-linux/void-packages/pull/52819

Description:
Since cmake version 3.8 it will automatically use SOURCE_DATE_EPOCH for the build timestamp.

https://cmake.org/cmake/help/latest/command/string.html#timestamp

#### Testing the changes
- I tested the changes in this PR: **NO**


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-01  3:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-28 20:05 [PR PATCH] PrismLauncher: remove SOURCE_DATE_EPOCH special handling sertonix
2024-11-01  3:18 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).