* [PR PATCH] gajim-omemo: remove package
@ 2024-10-30 8:37 Emru1
2024-10-30 9:00 ` [PR PATCH] [Closed]: " tranzystorekk
2024-10-30 9:00 ` tranzystorekk
0 siblings, 2 replies; 3+ messages in thread
From: Emru1 @ 2024-10-30 8:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
There is a new pull request by Emru1 against master on the void-packages repository
https://github.com/Emru1/void-packages gajim-omemo
https://github.com/void-linux/void-packages/pull/52845
gajim-omemo: remove package
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
gajim-omemo is no longer needed as it was built in into gajim some time ago.
Should I also push changes to `removed-packages`?
Manual says I should, but `git log` is inconclusive for me.
A patch file from https://github.com/void-linux/void-packages/pull/52845.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gajim-omemo-52845.patch --]
[-- Type: text/x-diff, Size: 905 bytes --]
From f0e201934f92ca6c72ef4a1208316e4237ee1d48 Mon Sep 17 00:00:00 2001
From: Emil Tomczyk <emru@emru.xyz>
Date: Wed, 30 Oct 2024 09:35:03 +0100
Subject: [PATCH] gajim-omemo: remove package
---
srcpkgs/gajim-omemo | 1 -
srcpkgs/gajim/template | 6 ------
2 files changed, 7 deletions(-)
delete mode 120000 srcpkgs/gajim-omemo
diff --git a/srcpkgs/gajim-omemo b/srcpkgs/gajim-omemo
deleted file mode 120000
index 61722e706beb58..00000000000000
--- a/srcpkgs/gajim-omemo
+++ /dev/null
@@ -1 +0,0 @@
-gajim
\ No newline at end of file
diff --git a/srcpkgs/gajim/template b/srcpkgs/gajim/template
index 9c64fa60710c18..f2188709d34809 100644
--- a/srcpkgs/gajim/template
+++ b/srcpkgs/gajim/template
@@ -32,9 +32,3 @@ post_install() {
do_check() {
python -m unittest discover -s test
}
-
-gajim-omemo_package() {
- depends="gajim"
- short_desc+=" (transitional dummy package)"
- build_style=meta
-}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PR PATCH] [Closed]: gajim-omemo: remove package
2024-10-30 8:37 [PR PATCH] gajim-omemo: remove package Emru1
@ 2024-10-30 9:00 ` tranzystorekk
2024-10-30 9:00 ` tranzystorekk
1 sibling, 0 replies; 3+ messages in thread
From: tranzystorekk @ 2024-10-30 9:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
There's a closed pull request on the void-packages repository
gajim-omemo: remove package
https://github.com/void-linux/void-packages/pull/52845
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
gajim-omemo is no longer needed as it was built in into gajim some time ago.
Should I also push changes to `removed-packages`?
Manual says I should, but `git log` is inconclusive for me.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gajim-omemo: remove package
2024-10-30 8:37 [PR PATCH] gajim-omemo: remove package Emru1
2024-10-30 9:00 ` [PR PATCH] [Closed]: " tranzystorekk
@ 2024-10-30 9:00 ` tranzystorekk
1 sibling, 0 replies; 3+ messages in thread
From: tranzystorekk @ 2024-10-30 9:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
New comment by tranzystorekk on void-packages repository
https://github.com/void-linux/void-packages/pull/52845#issuecomment-2446243693
Comment:
The `gajim-omemo` subpackage is a transitional dummy - a special package that installs `gajim` since it provides the functionality. It shouldn't be removed, we keep such packages indefinitely to reduce breaking or unexpected removals for users.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-30 9:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-30 8:37 [PR PATCH] gajim-omemo: remove package Emru1
2024-10-30 9:00 ` [PR PATCH] [Closed]: " tranzystorekk
2024-10-30 9:00 ` tranzystorekk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).