Github messages for voidlinux
 help / color / mirror / Atom feed
From: tranzystorekk <tranzystorekk@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] [RFC] libgit2-1.8: switch from libssh2 to openssh
Date: Wed, 11 Dec 2024 22:57:45 +0100	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-53477@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 698 bytes --]

There is a new pull request by tranzystorekk against master on the void-packages repository

https://github.com/tranzystorekk/void-packages libgit-openssh
https://github.com/void-linux/void-packages/pull/53477

[RFC] libgit2-1.8: switch from libssh2 to openssh
Switches newest libgit2 to invoke `openssh` from commandline for ssh git remotes etc.

Rationale:

- `git` also uses openssh under the hood
- parses ssh configuration files, making use of all openssh features

Note that since consistency is one of the goals here, I'd consider rebuilding any remaining non-rust packages to 1.8 a priority.

A patch file from https://github.com/void-linux/void-packages/pull/53477.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-libgit-openssh-53477.patch --]
[-- Type: text/x-diff, Size: 1187 bytes --]

From c787b50f4e0ca2b6e920acf333c04d1ce940ac26 Mon Sep 17 00:00:00 2001
From: tranzystorekk <tranzystorek.io@protonmail.com>
Date: Wed, 11 Dec 2024 22:48:07 +0100
Subject: [PATCH] libgit2-1.8: switch from libssh2 to openssh

---
 srcpkgs/libgit2-1.8/template | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/libgit2-1.8/template b/srcpkgs/libgit2-1.8/template
index 96f11929368d45..3d3df7854ab461 100644
--- a/srcpkgs/libgit2-1.8/template
+++ b/srcpkgs/libgit2-1.8/template
@@ -1,11 +1,12 @@
 # Template file for 'libgit2-1.8'
 pkgname=libgit2-1.8
 version=1.8.4
-revision=1
+revision=2
 build_style=cmake
-configure_args="-DENABLE_REPRODUCIBLE_BUILDS=ON -DBUILD_CLI=OFF -DUSE_SSH=ON -DUSE_HTTP_PARSER=llhttp"
+configure_args="-DENABLE_REPRODUCIBLE_BUILDS=ON -DBUILD_CLI=OFF -DUSE_SSH=exec -DUSE_HTTP_PARSER=llhttp"
 hostmakedepends="python3 pkg-config"
-makedepends="zlib-devel openssl-devel llhttp-devel libssh2-devel"
+makedepends="zlib-devel openssl-devel llhttp-devel"
+depends=openssh
 short_desc="Git linkable library ${pkgname#libgit2-}"
 maintainer="tranzystorekk <tranzystorek.io@protonmail.com>"
 license="GPL-2.0-only WITH GCC-exception-2.0"

             reply	other threads:[~2024-12-11 21:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11 21:57 tranzystorekk [this message]
2025-01-05 19:33 ` [PR PATCH] [Merged]: " tranzystorekk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-53477@inbox.vuxu.org \
    --to=tranzystorekk@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).