Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] ncspot: update to 1.2.1
@ 2024-12-13  1:12 terminaldweller
  2024-12-13 15:47 ` [PR PATCH] [Updated] " terminaldweller
                   ` (22 more replies)
  0 siblings, 23 replies; 24+ messages in thread
From: terminaldweller @ 2024-12-13  1:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

There is a new pull request by terminaldweller against master on the void-packages repository

https://github.com/terminaldweller/void-packages ncspot
https://github.com/void-linux/void-packages/pull/53502

ncspot: update to 1.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/53502.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-53502.patch --]
[-- Type: text/x-diff, Size: 1089 bytes --]

From 2d57a05a93365a2e743b364b8d481c7c89e5f797 Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Thu, 12 Dec 2024 20:11:52 -0500
Subject: [PATCH] ncspot: update to 1.2.1

---
 srcpkgs/ncspot/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 1bd8ede7ec6126..85a15376a8eaa1 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,6 +1,6 @@
 # Template file for 'ncspot'
 pkgname=ncspot
-version=1.1.0
+version=1.2.1
 revision=1
 build_style=cargo
 build_helper="qemu"
@@ -14,7 +14,7 @@ license="BSD-2-Clause"
 homepage="https://github.com/hrkfdn/ncspot"
 changelog="https://raw.githubusercontent.com/hrkfdn/ncspot/main/CHANGELOG.md"
 distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
-checksum=d3cd828cebb3e84470f03be16925db566d4dd8289cfd3e230e64278ec9d96338
+checksum=6bd08609a56aa5854a1964c9a872fe58b69a768d7d94c874d40d7a8848241213
 
 post_build() {
 	cargo auditable build --release --target ${RUST_TARGET} --package xtask

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
@ 2024-12-13 15:47 ` terminaldweller
  2024-12-13 17:21 ` terminaldweller
                   ` (21 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: terminaldweller @ 2024-12-13 15:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

There is an updated pull request by terminaldweller against master on the void-packages repository

https://github.com/terminaldweller/void-packages ncspot
https://github.com/void-linux/void-packages/pull/53502

ncspot: update to 1.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/53502.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-53502.patch --]
[-- Type: text/x-diff, Size: 1897 bytes --]

From 2d57a05a93365a2e743b364b8d481c7c89e5f797 Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Thu, 12 Dec 2024 20:11:52 -0500
Subject: [PATCH 1/2] ncspot: update to 1.2.1

---
 srcpkgs/ncspot/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 1bd8ede7ec6126..85a15376a8eaa1 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,6 +1,6 @@
 # Template file for 'ncspot'
 pkgname=ncspot
-version=1.1.0
+version=1.2.1
 revision=1
 build_style=cargo
 build_helper="qemu"
@@ -14,7 +14,7 @@ license="BSD-2-Clause"
 homepage="https://github.com/hrkfdn/ncspot"
 changelog="https://raw.githubusercontent.com/hrkfdn/ncspot/main/CHANGELOG.md"
 distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
-checksum=d3cd828cebb3e84470f03be16925db566d4dd8289cfd3e230e64278ec9d96338
+checksum=6bd08609a56aa5854a1964c9a872fe58b69a768d7d94c874d40d7a8848241213
 
 post_build() {
 	cargo auditable build --release --target ${RUST_TARGET} --package xtask

From eca928c3ebe6835fa8508bbbc402044f1a65c000 Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Fri, 13 Dec 2024 10:47:56 -0500
Subject: [PATCH 2/2] arm7i,x86_64,glibc needs cmake

---
 srcpkgs/ncspot/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 85a15376a8eaa1..25ffacda64250e 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -5,7 +5,7 @@ revision=1
 build_style=cargo
 build_helper="qemu"
 configure_args="--features alsa_backend,cover"
-hostmakedepends="pkg-config python3"
+hostmakedepends="pkg-config python3 cmake"
 makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
 depends="ueberzug"
 short_desc="Cross-platform ncurses Spotify client"

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
  2024-12-13 15:47 ` [PR PATCH] [Updated] " terminaldweller
@ 2024-12-13 17:21 ` terminaldweller
  2024-12-14 15:11 ` xavierfortier1
                   ` (20 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: terminaldweller @ 2024-12-13 17:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

There is an updated pull request by terminaldweller against master on the void-packages repository

https://github.com/terminaldweller/void-packages ncspot
https://github.com/void-linux/void-packages/pull/53502

ncspot: update to 1.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/53502.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-53502.patch --]
[-- Type: text/x-diff, Size: 2806 bytes --]

From 2d57a05a93365a2e743b364b8d481c7c89e5f797 Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Thu, 12 Dec 2024 20:11:52 -0500
Subject: [PATCH 1/3] ncspot: update to 1.2.1

---
 srcpkgs/ncspot/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 1bd8ede7ec6126..85a15376a8eaa1 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,6 +1,6 @@
 # Template file for 'ncspot'
 pkgname=ncspot
-version=1.1.0
+version=1.2.1
 revision=1
 build_style=cargo
 build_helper="qemu"
@@ -14,7 +14,7 @@ license="BSD-2-Clause"
 homepage="https://github.com/hrkfdn/ncspot"
 changelog="https://raw.githubusercontent.com/hrkfdn/ncspot/main/CHANGELOG.md"
 distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
-checksum=d3cd828cebb3e84470f03be16925db566d4dd8289cfd3e230e64278ec9d96338
+checksum=6bd08609a56aa5854a1964c9a872fe58b69a768d7d94c874d40d7a8848241213
 
 post_build() {
 	cargo auditable build --release --target ${RUST_TARGET} --package xtask

From eca928c3ebe6835fa8508bbbc402044f1a65c000 Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Fri, 13 Dec 2024 10:47:56 -0500
Subject: [PATCH 2/3] arm7i,x86_64,glibc needs cmake

---
 srcpkgs/ncspot/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 85a15376a8eaa1..25ffacda64250e 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -5,7 +5,7 @@ revision=1
 build_style=cargo
 build_helper="qemu"
 configure_args="--features alsa_backend,cover"
-hostmakedepends="pkg-config python3"
+hostmakedepends="pkg-config python3 cmake"
 makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
 depends="ueberzug"
 short_desc="Cross-platform ncurses Spotify client"

From f78baa7e2906c22d11c44fd2d9498b2b7e6aebec Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Fri, 13 Dec 2024 12:22:02 -0500
Subject: [PATCH 3/3] arm7l and arm6l need rust-bindgen apparently

---
 srcpkgs/ncspot/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 25ffacda64250e..b2f77c3d40460d 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -6,7 +6,7 @@ build_style=cargo
 build_helper="qemu"
 configure_args="--features alsa_backend,cover"
 hostmakedepends="pkg-config python3 cmake"
-makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
+makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel rust-bindgen"
 depends="ueberzug"
 short_desc="Cross-platform ncurses Spotify client"
 maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
  2024-12-13 15:47 ` [PR PATCH] [Updated] " terminaldweller
  2024-12-13 17:21 ` terminaldweller
@ 2024-12-14 15:11 ` xavierfortier1
  2024-12-15 18:56 ` xavierfortier1
                   ` (19 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: xavierfortier1 @ 2024-12-14 15:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

New comment by xavierfortier1 on void-packages repository

https://github.com/void-linux/void-packages/pull/53502#issuecomment-2543148030

Comment:
I came across this PR while I was looking in the repo and just so you know, I'm trying to update `spotify-player` in #53498 and there is a problem in the `aws-lc-rs` crate. You also have to update the `rust-binden` template to match the latest version, cause .

Also, lint checks doesn't pass, because you have to amend and force push the changes instead of creating a new commit (so, only a commit per update/package).

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (2 preceding siblings ...)
  2024-12-14 15:11 ` xavierfortier1
@ 2024-12-15 18:56 ` xavierfortier1
  2024-12-15 18:57 ` xavierfortier1
                   ` (18 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: xavierfortier1 @ 2024-12-15 18:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

New comment by xavierfortier1 on void-packages repository

https://github.com/void-linux/void-packages/pull/53502#issuecomment-2543148030

Comment:
I came across this PR while I was looking in the repo and just so you know, I'm trying to update `spotify-player` in #53498 and there is a problem in the `aws-lc-rs` crate. You also have to update the `rust-bindgen` template to match the latest version, cause .

Also, lint checks doesn't pass, because you have to amend and force push the changes instead of creating a new commit (so, only a commit per update/package).

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (3 preceding siblings ...)
  2024-12-15 18:56 ` xavierfortier1
@ 2024-12-15 18:57 ` xavierfortier1
  2024-12-19 17:25 ` xavierfortier1
                   ` (17 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: xavierfortier1 @ 2024-12-15 18:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

New comment by xavierfortier1 on void-packages repository

https://github.com/void-linux/void-packages/pull/53502#issuecomment-2543148030

Comment:
I came across this PR while I was looking in the repo and just so you know, I'm trying to update `spotify-player` in #53498 and there is a problem in the `aws-lc-rs` crate. You also have to update the `rust-bindgen` template to match the latest version.

Also, lint checks doesn't pass, because you have to amend and force push the changes instead of creating a new commit (so, only a commit per update/package).

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (4 preceding siblings ...)
  2024-12-15 18:57 ` xavierfortier1
@ 2024-12-19 17:25 ` xavierfortier1
  2024-12-19 17:27 ` xavierfortier1
                   ` (16 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: xavierfortier1 @ 2024-12-19 17:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

New comment by xavierfortier1 on void-packages repository

https://github.com/void-linux/void-packages/pull/53502#issuecomment-2555257399

Comment:
Hello! There has been updates in #53498. I've managed to build the package with a workaround for `armv7l` provided by `aws`. Take a look at the template, you can probably testusethe new dependencies and the workaround for `ncspot`!

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (5 preceding siblings ...)
  2024-12-19 17:25 ` xavierfortier1
@ 2024-12-19 17:27 ` xavierfortier1
  2024-12-19 17:30 ` [PR PATCH] [Updated] " terminaldweller
                   ` (15 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: xavierfortier1 @ 2024-12-19 17:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

New comment by xavierfortier1 on void-packages repository

https://github.com/void-linux/void-packages/pull/53502#issuecomment-2555257399

Comment:
Hello! There has been updates in #53498. I've managed to build the package with a workaround for `armv7l` provided by `aws`. Take a look at the template, you can probably testusethe new dependencies and the workaround for `ncspot`!

edit: If you plan to take a look at the PR, you should probably take the workaround from master instead of the PR.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (6 preceding siblings ...)
  2024-12-19 17:27 ` xavierfortier1
@ 2024-12-19 17:30 ` terminaldweller
  2024-12-19 17:33 ` xavierfortier1
                   ` (14 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: terminaldweller @ 2024-12-19 17:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

There is an updated pull request by terminaldweller against master on the void-packages repository

https://github.com/terminaldweller/void-packages ncspot
https://github.com/void-linux/void-packages/pull/53502

ncspot: update to 1.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/53502.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-53502.patch --]
[-- Type: text/x-diff, Size: 4086 bytes --]

From 2d57a05a93365a2e743b364b8d481c7c89e5f797 Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Thu, 12 Dec 2024 20:11:52 -0500
Subject: [PATCH 1/4] ncspot: update to 1.2.1

---
 srcpkgs/ncspot/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 1bd8ede7ec6126..85a15376a8eaa1 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,6 +1,6 @@
 # Template file for 'ncspot'
 pkgname=ncspot
-version=1.1.0
+version=1.2.1
 revision=1
 build_style=cargo
 build_helper="qemu"
@@ -14,7 +14,7 @@ license="BSD-2-Clause"
 homepage="https://github.com/hrkfdn/ncspot"
 changelog="https://raw.githubusercontent.com/hrkfdn/ncspot/main/CHANGELOG.md"
 distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
-checksum=d3cd828cebb3e84470f03be16925db566d4dd8289cfd3e230e64278ec9d96338
+checksum=6bd08609a56aa5854a1964c9a872fe58b69a768d7d94c874d40d7a8848241213
 
 post_build() {
 	cargo auditable build --release --target ${RUST_TARGET} --package xtask

From eca928c3ebe6835fa8508bbbc402044f1a65c000 Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Fri, 13 Dec 2024 10:47:56 -0500
Subject: [PATCH 2/4] arm7i,x86_64,glibc needs cmake

---
 srcpkgs/ncspot/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 85a15376a8eaa1..25ffacda64250e 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -5,7 +5,7 @@ revision=1
 build_style=cargo
 build_helper="qemu"
 configure_args="--features alsa_backend,cover"
-hostmakedepends="pkg-config python3"
+hostmakedepends="pkg-config python3 cmake"
 makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
 depends="ueberzug"
 short_desc="Cross-platform ncurses Spotify client"

From f78baa7e2906c22d11c44fd2d9498b2b7e6aebec Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Fri, 13 Dec 2024 12:22:02 -0500
Subject: [PATCH 3/4] arm7l and arm6l need rust-bindgen apparently

---
 srcpkgs/ncspot/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 25ffacda64250e..b2f77c3d40460d 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -6,7 +6,7 @@ build_style=cargo
 build_helper="qemu"
 configure_args="--features alsa_backend,cover"
 hostmakedepends="pkg-config python3 cmake"
-makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
+makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel rust-bindgen"
 depends="ueberzug"
 short_desc="Cross-platform ncurses Spotify client"
 maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"

From 46346c0398322b2d475ae15b59821be8ea18fe8a Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Thu, 19 Dec 2024 12:30:39 -0500
Subject: [PATCH 4/4] workaround for arm7l

---
 srcpkgs/ncspot/template | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index b2f77c3d40460d..4eebe9166fd2ce 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -5,8 +5,8 @@ revision=1
 build_style=cargo
 build_helper="qemu"
 configure_args="--features alsa_backend,cover"
-hostmakedepends="pkg-config python3 cmake"
-makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel rust-bindgen"
+hostmakedepends="pkg-config python3 cmake clang rust-bindgen"
+makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
 depends="ueberzug"
 short_desc="Cross-platform ncurses Spotify client"
 maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
@@ -32,3 +32,8 @@ post_install() {
 	vcompletion misc/_ncspot zsh
 	vcompletion misc/ncspot.fish fish
 }
+
+# FIXME: Workaround. Should be removed when https://github.com/aws/aws-lc-rs/issues/632 is resolved.
+if [ "$XBPS_TARGET_MACHINE" = armv7l ]; then
+	export AWS_LC_SYS_CFLAGS="-Wno-stringop-overflow"
+fi

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (7 preceding siblings ...)
  2024-12-19 17:30 ` [PR PATCH] [Updated] " terminaldweller
@ 2024-12-19 17:33 ` xavierfortier1
  2024-12-19 17:35 ` xavierfortier1
                   ` (13 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: xavierfortier1 @ 2024-12-19 17:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

New comment by xavierfortier1 on void-packages repository

https://github.com/void-linux/void-packages/pull/53502#issuecomment-2555257399

Comment:
Hello! There has been updates in #53498. I've managed to build the package with a workaround for `armv7l` provided by `aws`. Take a look at the template, you can probably testusethe new dependencies and the workaround for `ncspot`!

edit: If you plan to take a look at the PR, you must take the workaround from master instead of the PR.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (8 preceding siblings ...)
  2024-12-19 17:33 ` xavierfortier1
@ 2024-12-19 17:35 ` xavierfortier1
  2024-12-19 17:37 ` xavierfortier1
                   ` (12 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: xavierfortier1 @ 2024-12-19 17:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

New comment by xavierfortier1 on void-packages repository

https://github.com/void-linux/void-packages/pull/53502#issuecomment-2555257399

Comment:
Hello! There has been updates in #53498. I've managed to build the package with a workaround for `armv7l` provided by `aws`. Take a look at the template, you can probably testusethe new dependencies and the workaround for `ncspot`!

edit: If you plan to take a look at the PR, you must take the workaround from master instead of the PR. This one:
```sh
case "$XBPS_TARGET_MACHINE" in
	armv[67]l)
	export AWS_LC_SYS_CFLAGS="-Wno-stringop-overflow"
	;;
esac
```

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (9 preceding siblings ...)
  2024-12-19 17:35 ` xavierfortier1
@ 2024-12-19 17:37 ` xavierfortier1
  2024-12-19 17:54 ` [PR PATCH] [Updated] " terminaldweller
                   ` (11 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: xavierfortier1 @ 2024-12-19 17:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 643 bytes --]

New comment by xavierfortier1 on void-packages repository

https://github.com/void-linux/void-packages/pull/53502#issuecomment-2555257399

Comment:
Hello! There has been updates in #53498. I've managed to build the package with a workaround for `armv7l` provided by `aws`. Take a look at the template, you can probably testusethe new dependencies and the workaround for `ncspot`!

edit: If you plan to take a look at the PR, you must take the workaround from master instead of the PR and put it after checksum. This one:
```sh
case "$XBPS_TARGET_MACHINE" in
	armv[67]l)
	export AWS_LC_SYS_CFLAGS="-Wno-stringop-overflow"
	;;
esac
```

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (10 preceding siblings ...)
  2024-12-19 17:37 ` xavierfortier1
@ 2024-12-19 17:54 ` terminaldweller
  2024-12-24 18:44 ` [PR REVIEW] " classabbyamp
                   ` (10 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: terminaldweller @ 2024-12-19 17:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

There is an updated pull request by terminaldweller against master on the void-packages repository

https://github.com/terminaldweller/void-packages ncspot
https://github.com/void-linux/void-packages/pull/53502

ncspot: update to 1.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/53502.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-53502.patch --]
[-- Type: text/x-diff, Size: 1703 bytes --]

From 7928aed5a2ba67204e6ae8e472ff1be296e80196 Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Thu, 19 Dec 2024 12:54:19 -0500
Subject: [PATCH] ncspot: update to 1.2.1

---
 srcpkgs/ncspot/template | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 1bd8ede7ec6126..4eebe9166fd2ce 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,11 +1,11 @@
 # Template file for 'ncspot'
 pkgname=ncspot
-version=1.1.0
+version=1.2.1
 revision=1
 build_style=cargo
 build_helper="qemu"
 configure_args="--features alsa_backend,cover"
-hostmakedepends="pkg-config python3"
+hostmakedepends="pkg-config python3 cmake clang rust-bindgen"
 makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
 depends="ueberzug"
 short_desc="Cross-platform ncurses Spotify client"
@@ -14,7 +14,7 @@ license="BSD-2-Clause"
 homepage="https://github.com/hrkfdn/ncspot"
 changelog="https://raw.githubusercontent.com/hrkfdn/ncspot/main/CHANGELOG.md"
 distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
-checksum=d3cd828cebb3e84470f03be16925db566d4dd8289cfd3e230e64278ec9d96338
+checksum=6bd08609a56aa5854a1964c9a872fe58b69a768d7d94c874d40d7a8848241213
 
 post_build() {
 	cargo auditable build --release --target ${RUST_TARGET} --package xtask
@@ -32,3 +32,8 @@ post_install() {
 	vcompletion misc/_ncspot zsh
 	vcompletion misc/ncspot.fish fish
 }
+
+# FIXME: Workaround. Should be removed when https://github.com/aws/aws-lc-rs/issues/632 is resolved.
+if [ "$XBPS_TARGET_MACHINE" = armv7l ]; then
+	export AWS_LC_SYS_CFLAGS="-Wno-stringop-overflow"
+fi

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (11 preceding siblings ...)
  2024-12-19 17:54 ` [PR PATCH] [Updated] " terminaldweller
@ 2024-12-24 18:44 ` classabbyamp
  2024-12-24 19:08 ` [PR PATCH] [Updated] " terminaldweller
                   ` (9 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2024-12-24 18:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/53502#discussion_r1896917645

Comment:
this if block should go before functions

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (12 preceding siblings ...)
  2024-12-24 18:44 ` [PR REVIEW] " classabbyamp
@ 2024-12-24 19:08 ` terminaldweller
  2024-12-24 19:08 ` [PR REVIEW] " xavierfortier1
                   ` (8 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: terminaldweller @ 2024-12-24 19:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

There is an updated pull request by terminaldweller against master on the void-packages repository

https://github.com/terminaldweller/void-packages ncspot
https://github.com/void-linux/void-packages/pull/53502

ncspot: update to 1.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/53502.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-53502.patch --]
[-- Type: text/x-diff, Size: 1599 bytes --]

From f8bdbe0461ffc27824f0e754fe19a93c212231d2 Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Tue, 24 Dec 2024 14:08:26 -0500
Subject: [PATCH] ncspot: update to 1.2.1

---
 srcpkgs/ncspot/template | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 1bd8ede7ec6126..9bedfbd191a16d 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,11 +1,11 @@
 # Template file for 'ncspot'
 pkgname=ncspot
-version=1.1.0
+version=1.2.1
 revision=1
 build_style=cargo
 build_helper="qemu"
 configure_args="--features alsa_backend,cover"
-hostmakedepends="pkg-config python3"
+hostmakedepends="pkg-config python3 cmake clang rust-bindgen"
 makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
 depends="ueberzug"
 short_desc="Cross-platform ncurses Spotify client"
@@ -14,7 +14,12 @@ license="BSD-2-Clause"
 homepage="https://github.com/hrkfdn/ncspot"
 changelog="https://raw.githubusercontent.com/hrkfdn/ncspot/main/CHANGELOG.md"
 distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
-checksum=d3cd828cebb3e84470f03be16925db566d4dd8289cfd3e230e64278ec9d96338
+checksum=6bd08609a56aa5854a1964c9a872fe58b69a768d7d94c874d40d7a8848241213
+
+# FIXME: Workaround. Should be removed when https://github.com/aws/aws-lc-rs/issues/632 is resolved.
+if [ "$XBPS_TARGET_MACHINE" = armv7l ]; then
+	export AWS_LC_SYS_CFLAGS="-Wno-stringop-overflow"
+fi
 
 post_build() {
 	cargo auditable build --release --target ${RUST_TARGET} --package xtask

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (13 preceding siblings ...)
  2024-12-24 19:08 ` [PR PATCH] [Updated] " terminaldweller
@ 2024-12-24 19:08 ` xavierfortier1
  2024-12-24 19:10 ` classabbyamp
                   ` (7 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: xavierfortier1 @ 2024-12-24 19:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New review comment by xavierfortier1 on void-packages repository

https://github.com/void-linux/void-packages/pull/53502#discussion_r1896926776

Comment:
This if is not enough, because armv6l won't compile. This is why I proposed the case like the template of spotify-player

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (14 preceding siblings ...)
  2024-12-24 19:08 ` [PR REVIEW] " xavierfortier1
@ 2024-12-24 19:10 ` classabbyamp
  2024-12-24 19:17 ` [PR PATCH] [Updated] " terminaldweller
                   ` (6 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2024-12-24 19:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/53502#discussion_r1896927480

Comment:
that too

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (15 preceding siblings ...)
  2024-12-24 19:10 ` classabbyamp
@ 2024-12-24 19:17 ` terminaldweller
  2024-12-24 19:21 ` terminaldweller
                   ` (5 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: terminaldweller @ 2024-12-24 19:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

There is an updated pull request by terminaldweller against master on the void-packages repository

https://github.com/terminaldweller/void-packages ncspot
https://github.com/void-linux/void-packages/pull/53502

ncspot: update to 1.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/53502.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-53502.patch --]
[-- Type: text/x-diff, Size: 1625 bytes --]

From d7188b8d727f03c828d243b69cbd5042a8de275b Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Tue, 24 Dec 2024 14:17:46 -0500
Subject: [PATCH] ncspot: update to 1.2.1

---
 srcpkgs/ncspot/template | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 1bd8ede7ec6126..0b38148d19fd2e 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,11 +1,11 @@
 # Template file for 'ncspot'
 pkgname=ncspot
-version=1.1.0
+version=1.2.1
 revision=1
 build_style=cargo
 build_helper="qemu"
 configure_args="--features alsa_backend,cover"
-hostmakedepends="pkg-config python3"
+hostmakedepends="pkg-config python3 cmake clang rust-bindgen"
 makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
 depends="ueberzug"
 short_desc="Cross-platform ncurses Spotify client"
@@ -14,7 +14,14 @@ license="BSD-2-Clause"
 homepage="https://github.com/hrkfdn/ncspot"
 changelog="https://raw.githubusercontent.com/hrkfdn/ncspot/main/CHANGELOG.md"
 distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
-checksum=d3cd828cebb3e84470f03be16925db566d4dd8289cfd3e230e64278ec9d96338
+checksum=6bd08609a56aa5854a1964c9a872fe58b69a768d7d94c874d40d7a8848241213
+
+# FIXME: Workaround will be removed when https://github.com/aws/aws-lc-rs/issues/632 is resolved
+case "$XBPS_TARGET_MACHINE" in
+        armv[67]l)
+        export AWS_LC_SYS_CFLAGS="-Wno-stringop-overflow"
+        ;;
+esac
 
 post_build() {
 	cargo auditable build --release --target ${RUST_TARGET} --package xtask

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (16 preceding siblings ...)
  2024-12-24 19:17 ` [PR PATCH] [Updated] " terminaldweller
@ 2024-12-24 19:21 ` terminaldweller
  2024-12-24 19:34 ` [PR REVIEW] " classabbyamp
                   ` (4 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: terminaldweller @ 2024-12-24 19:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

There is an updated pull request by terminaldweller against master on the void-packages repository

https://github.com/terminaldweller/void-packages ncspot
https://github.com/void-linux/void-packages/pull/53502

ncspot: update to 1.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/53502.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-53502.patch --]
[-- Type: text/x-diff, Size: 1604 bytes --]

From 393576c3e6f467b0d60bf3e73edf569fa4944354 Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Tue, 24 Dec 2024 14:21:10 -0500
Subject: [PATCH] ncspot: update to 1.2.1

---
 srcpkgs/ncspot/template | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 1bd8ede7ec6126..6efbfd08aa8c58 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,11 +1,11 @@
 # Template file for 'ncspot'
 pkgname=ncspot
-version=1.1.0
+version=1.2.1
 revision=1
 build_style=cargo
 build_helper="qemu"
 configure_args="--features alsa_backend,cover"
-hostmakedepends="pkg-config python3"
+hostmakedepends="pkg-config python3 cmake clang rust-bindgen"
 makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
 depends="ueberzug"
 short_desc="Cross-platform ncurses Spotify client"
@@ -14,7 +14,14 @@ license="BSD-2-Clause"
 homepage="https://github.com/hrkfdn/ncspot"
 changelog="https://raw.githubusercontent.com/hrkfdn/ncspot/main/CHANGELOG.md"
 distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
-checksum=d3cd828cebb3e84470f03be16925db566d4dd8289cfd3e230e64278ec9d96338
+checksum=6bd08609a56aa5854a1964c9a872fe58b69a768d7d94c874d40d7a8848241213
+
+# FIXME: Workaround will be removed when https://github.com/aws/aws-lc-rs/issues/632 is resolved
+	case "$XBPS_TARGET_MACHINE" in
+	armv[67]l)
+	export AWS_LC_SYS_CFLAGS="-Wno-stringop-overflow"
+;;
+esac
 
 post_build() {
 	cargo auditable build --release --target ${RUST_TARGET} --package xtask

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (17 preceding siblings ...)
  2024-12-24 19:21 ` terminaldweller
@ 2024-12-24 19:34 ` classabbyamp
  2024-12-24 19:36 ` [PR PATCH] [Updated] " terminaldweller
                   ` (3 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2024-12-24 19:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/53502#discussion_r1896935186

Comment:
```suggestion
case "$XBPS_TARGET_MACHINE" in
	armv[67]l)
		export AWS_LC_SYS_CFLAGS="-Wno-stringop-overflow"
		;;
esac
```

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (18 preceding siblings ...)
  2024-12-24 19:34 ` [PR REVIEW] " classabbyamp
@ 2024-12-24 19:36 ` terminaldweller
  2024-12-24 19:37 ` [PR REVIEW] " classabbyamp
                   ` (2 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: terminaldweller @ 2024-12-24 19:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

There is an updated pull request by terminaldweller against master on the void-packages repository

https://github.com/terminaldweller/void-packages ncspot
https://github.com/void-linux/void-packages/pull/53502

ncspot: update to 1.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/53502.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-53502.patch --]
[-- Type: text/x-diff, Size: 1607 bytes --]

From 7403882e96ab9528a818b09ba39b1a8288d33750 Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Tue, 24 Dec 2024 14:36:15 -0500
Subject: [PATCH] ncspot: update to 1.2.1

---
 srcpkgs/ncspot/template | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 1bd8ede7ec6126..466ad664a3e70d 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,11 +1,11 @@
 # Template file for 'ncspot'
 pkgname=ncspot
-version=1.1.0
+version=1.2.1
 revision=1
 build_style=cargo
 build_helper="qemu"
 configure_args="--features alsa_backend,cover"
-hostmakedepends="pkg-config python3"
+hostmakedepends="pkg-config python3 cmake clang rust-bindgen"
 makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
 depends="ueberzug"
 short_desc="Cross-platform ncurses Spotify client"
@@ -14,7 +14,14 @@ license="BSD-2-Clause"
 homepage="https://github.com/hrkfdn/ncspot"
 changelog="https://raw.githubusercontent.com/hrkfdn/ncspot/main/CHANGELOG.md"
 distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
-checksum=d3cd828cebb3e84470f03be16925db566d4dd8289cfd3e230e64278ec9d96338
+checksum=6bd08609a56aa5854a1964c9a872fe58b69a768d7d94c874d40d7a8848241213
+
+# FIXME: Workaround will be removed when https://github.com/aws/aws-lc-rs/issues/632 is resolved
+	case "$XBPS_TARGET_MACHINE" in
+	armv[67]l)
+		export AWS_LC_SYS_CFLAGS="-Wno-stringop-overflow"
+		;;
+esac
 
 post_build() {
 	cargo auditable build --release --target ${RUST_TARGET} --package xtask

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR REVIEW] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (19 preceding siblings ...)
  2024-12-24 19:36 ` [PR PATCH] [Updated] " terminaldweller
@ 2024-12-24 19:37 ` classabbyamp
  2024-12-24 19:38 ` [PR PATCH] [Updated] " terminaldweller
  2024-12-24 20:07 ` [PR PATCH] [Merged]: " classabbyamp
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2024-12-24 19:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 214 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/53502#discussion_r1896936216

Comment:
still an extra indent on the first line of the case statement

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Updated] ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (20 preceding siblings ...)
  2024-12-24 19:37 ` [PR REVIEW] " classabbyamp
@ 2024-12-24 19:38 ` terminaldweller
  2024-12-24 20:07 ` [PR PATCH] [Merged]: " classabbyamp
  22 siblings, 0 replies; 24+ messages in thread
From: terminaldweller @ 2024-12-24 19:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

There is an updated pull request by terminaldweller against master on the void-packages repository

https://github.com/terminaldweller/void-packages ncspot
https://github.com/void-linux/void-packages/pull/53502

ncspot: update to 1.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/53502.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ncspot-53502.patch --]
[-- Type: text/x-diff, Size: 1606 bytes --]

From bf3f93872170499fbcb327e68400b2e7473141a6 Mon Sep 17 00:00:00 2001
From: terminaldweller <devi@terminaldweller.com>
Date: Tue, 24 Dec 2024 14:38:59 -0500
Subject: [PATCH] ncspot: update to 1.2.1

---
 srcpkgs/ncspot/template | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/ncspot/template b/srcpkgs/ncspot/template
index 1bd8ede7ec6126..431ae6c2bfc273 100644
--- a/srcpkgs/ncspot/template
+++ b/srcpkgs/ncspot/template
@@ -1,11 +1,11 @@
 # Template file for 'ncspot'
 pkgname=ncspot
-version=1.1.0
+version=1.2.1
 revision=1
 build_style=cargo
 build_helper="qemu"
 configure_args="--features alsa_backend,cover"
-hostmakedepends="pkg-config python3"
+hostmakedepends="pkg-config python3 cmake clang rust-bindgen"
 makedepends="openssl-devel dbus-devel pulseaudio-devel alsa-lib-devel"
 depends="ueberzug"
 short_desc="Cross-platform ncurses Spotify client"
@@ -14,7 +14,14 @@ license="BSD-2-Clause"
 homepage="https://github.com/hrkfdn/ncspot"
 changelog="https://raw.githubusercontent.com/hrkfdn/ncspot/main/CHANGELOG.md"
 distfiles="https://github.com/hrkfdn/ncspot/archive/refs/tags/v${version}.tar.gz"
-checksum=d3cd828cebb3e84470f03be16925db566d4dd8289cfd3e230e64278ec9d96338
+checksum=6bd08609a56aa5854a1964c9a872fe58b69a768d7d94c874d40d7a8848241213
+
+# FIXME: Workaround will be removed when https://github.com/aws/aws-lc-rs/issues/632 is resolved
+case "$XBPS_TARGET_MACHINE" in
+	armv[67]l)
+		export AWS_LC_SYS_CFLAGS="-Wno-stringop-overflow"
+		;;
+esac
 
 post_build() {
 	cargo auditable build --release --target ${RUST_TARGET} --package xtask

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PR PATCH] [Merged]: ncspot: update to 1.2.1
  2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
                   ` (21 preceding siblings ...)
  2024-12-24 19:38 ` [PR PATCH] [Updated] " terminaldweller
@ 2024-12-24 20:07 ` classabbyamp
  22 siblings, 0 replies; 24+ messages in thread
From: classabbyamp @ 2024-12-24 20:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

There's a merged pull request on the void-packages repository

ncspot: update to 1.2.1
https://github.com/void-linux/void-packages/pull/53502

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2024-12-24 20:07 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-13  1:12 [PR PATCH] ncspot: update to 1.2.1 terminaldweller
2024-12-13 15:47 ` [PR PATCH] [Updated] " terminaldweller
2024-12-13 17:21 ` terminaldweller
2024-12-14 15:11 ` xavierfortier1
2024-12-15 18:56 ` xavierfortier1
2024-12-15 18:57 ` xavierfortier1
2024-12-19 17:25 ` xavierfortier1
2024-12-19 17:27 ` xavierfortier1
2024-12-19 17:30 ` [PR PATCH] [Updated] " terminaldweller
2024-12-19 17:33 ` xavierfortier1
2024-12-19 17:35 ` xavierfortier1
2024-12-19 17:37 ` xavierfortier1
2024-12-19 17:54 ` [PR PATCH] [Updated] " terminaldweller
2024-12-24 18:44 ` [PR REVIEW] " classabbyamp
2024-12-24 19:08 ` [PR PATCH] [Updated] " terminaldweller
2024-12-24 19:08 ` [PR REVIEW] " xavierfortier1
2024-12-24 19:10 ` classabbyamp
2024-12-24 19:17 ` [PR PATCH] [Updated] " terminaldweller
2024-12-24 19:21 ` terminaldweller
2024-12-24 19:34 ` [PR REVIEW] " classabbyamp
2024-12-24 19:36 ` [PR PATCH] [Updated] " terminaldweller
2024-12-24 19:37 ` [PR REVIEW] " classabbyamp
2024-12-24 19:38 ` [PR PATCH] [Updated] " terminaldweller
2024-12-24 20:07 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).