[PR PATCH] freerdp3: update to 3.10.0

[PR PATCH] freerdp3: update to 3.10.0

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

There is a new pull request by chrysos349 against master on the void-packages repository

https://github.com/chrysos349/void-packages freerdp3
https://github.com/void-linux/void-packages/pull/53544

freerdp3: update to 3.10.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl

A patch file from https://github.com/void-linux/void-packages/pull/53544.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freerdp3-53544.patch --]
[-- Type: text/x-diff, Size: 4176 bytes --]

From 409115c5ef6e2ac4a36b4e5dd3eebe3def751568 Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Tue, 17 Dec 2024 02:45:25 +0300
Subject: [PATCH] freerdp3: update to 3.10.0

---
 srcpkgs/freerdp3/patches/fix-cross.patch | 27 ++++++++++++------------
 srcpkgs/freerdp3/template                | 10 ++++-----
 2 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/srcpkgs/freerdp3/patches/fix-cross.patch b/srcpkgs/freerdp3/patches/fix-cross.patch
index d7d5b8cfe5cfdc..0bff5ce8356755 100644
--- a/srcpkgs/freerdp3/patches/fix-cross.patch
+++ b/srcpkgs/freerdp3/patches/fix-cross.patch
@@ -1,27 +1,26 @@
 diff --git a/client/common/man/CMakeLists.txt b/client/common/man/CMakeLists.txt
-index 798957c78..c14d22319 100644
+index 40c7e3d8..68d18451 100644
 --- a/client/common/man/CMakeLists.txt
 +++ b/client/common/man/CMakeLists.txt
 @@ -1,6 +1,3 @@
 -if(CMAKE_CROSSCOMPILING)
--	find_package(GenerateArgumentManpage)
+-  find_package(GenerateArgumentManpage)
 -else()
-     include_directories(${CMAKE_BINARY_DIR}/include/)
+   include_directories(${CMAKE_BINARY_DIR}/include/)
  
-     add_executable(generate_argument_manpage
-@@ -9,14 +6,13 @@ else()
-     )
- 	export(TARGETS generate_argument_manpage FILE
- 		"${CMAKE_BINARY_DIR}/GenerateArgumentManpageConfig.cmake")
+   add_executable(generate_argument_manpage generate_argument_manpage.c ../cmdline.h)
+@@ -15,13 +12,12 @@ else()
+   endif()
+ 
+   export(TARGETS generate_argument_manpage FILE "${CMAKE_BINARY_DIR}/GenerateArgumentManpageConfig.cmake")
 -endif()
  
  set(MAN_OPTIONS_FILE "${CMAKE_CURRENT_BINARY_DIR}/freerdp-global-options.1")
  set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS ${MAN_OPTIONS_FILE})
  
  add_custom_command(
- 	OUTPUT ${MAN_OPTIONS_FILE}
--	COMMAND ${CMAKE_BINARY_DIR}/client/common/man/generate_argument_manpage "${MAN_OPTIONS_FILE}"
-+	COMMAND generate_argument_manpage "${MAN_OPTIONS_FILE}"
- 	WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
- 	DEPENDS
- 		generate_argument_manpage
+-  OUTPUT ${MAN_OPTIONS_FILE} COMMAND $<TARGET_FILE:generate_argument_manpage> "${MAN_OPTIONS_FILE}"
++  OUTPUT ${MAN_OPTIONS_FILE} COMMAND generate_argument_manpage "${MAN_OPTIONS_FILE}"
+   WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} DEPENDS generate_argument_manpage
+ )
+ add_custom_target(
diff --git a/srcpkgs/freerdp3/template b/srcpkgs/freerdp3/template
index 41fbe1551f463f..c39a9635dcdb89 100644
--- a/srcpkgs/freerdp3/template
+++ b/srcpkgs/freerdp3/template
@@ -1,10 +1,10 @@
 # Template file for 'freerdp3'
 pkgname=freerdp3
-version=3.9.0
+version=3.10.0
 revision=1
 build_style=cmake
 build_helper=qemu
-configure_args="-DCHANNEL_URBDRC_CLIENT=ON
+configure_args="-Wno-dev -DCMAKE_BUILD_TYPE=Release -DCHANNEL_URBDRC_CLIENT=ON
  -DPKG_CONFIG_RELOCATABLE=OFF -DPROXY_PLUGINDIR=/usr/lib/${pkgname}/server/proxy/plugins
  -DRDTK_FORCE_STATIC_BUILD=ON -DWAYLAND_SCANNER=/usr/bin/wayland-scanner
  -DWITH_BINARY_VERSIONING=ON
@@ -19,7 +19,8 @@ configure_args="-DCHANNEL_URBDRC_CLIENT=ON
  -DWITH_FFMPEG=$(vopt_if ffmpeg ON OFF) -DWITH_PCSC=$(vopt_if smartcard ON OFF)
  -DWITH_PKCS11=$(vopt_if smartcard ON OFF) -DWITH_SWSCALE=$(vopt_if ffmpeg ON OFF)
  -DWITH_WAYLAND=$(vopt_if wayland ON OFF) -DWITH_WEBVIEW=$(vopt_if webview ON OFF)
- -DWITH_CLIENT_SDL_VERSIONED=$(vopt_if sdl2 ON OFF)"
+ -DWITH_CLIENT_SDL_VERSIONED=$(vopt_if sdl2 ON OFF) -DWITH_VERBOSE_WINPR_ASSERT=OFF
+ -DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON"
 hostmakedepends="pkg-config $(vopt_if wayland wayland-devel)"
 makedepends="alsa-lib-devel cups-devel fuse3-devel icu-devel libXcursor-devel
  libXdamage-devel libXinerama-devel libXrandr-devel libXv-devel
@@ -35,8 +36,7 @@ license="Apache-2.0"
 homepage="https://www.freerdp.com/"
 changelog="https://raw.githubusercontent.com/FreeRDP/FreeRDP/master/ChangeLog"
 distfiles="https://github.com/FreeRDP/FreeRDP/archive/${version}.tar.gz"
-checksum=a1d2946c67037bf6bb8aa2f0441c7cacd5e92c835d776cecffb4fcdbaa45ec4f
-CFLAGS="-Wno-dev"
+checksum=fb776f1f7ef401f8ceb54eb9fce5457c1e2ac04230d62fbc31dc25d9bdca0b1a
 
 # wayland - deprecated, sdl2 - experimental
 build_options="aad ffmpeg sdl2 smartcard wayland webview"

Re: [PR PATCH] [Updated] freerdp3: update to 3.10.0

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

There is an updated pull request by chrysos349 against master on the void-packages repository

https://github.com/chrysos349/void-packages freerdp3
https://github.com/void-linux/void-packages/pull/53544

freerdp3: update to 3.10.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl

A patch file from https://github.com/void-linux/void-packages/pull/53544.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freerdp3-53544.patch --]
[-- Type: text/x-diff, Size: 4176 bytes --]

From e88b29661daac792e0f6d5faa91de496900ffa63 Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Tue, 17 Dec 2024 02:45:25 +0300
Subject: [PATCH] freerdp3: update to 3.10.0

---
 srcpkgs/freerdp3/patches/fix-cross.patch | 27 ++++++++++++------------
 srcpkgs/freerdp3/template                | 10 ++++-----
 2 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/srcpkgs/freerdp3/patches/fix-cross.patch b/srcpkgs/freerdp3/patches/fix-cross.patch
index d7d5b8cfe5cfdc..0bff5ce8356755 100644
--- a/srcpkgs/freerdp3/patches/fix-cross.patch
+++ b/srcpkgs/freerdp3/patches/fix-cross.patch
@@ -1,27 +1,26 @@
 diff --git a/client/common/man/CMakeLists.txt b/client/common/man/CMakeLists.txt
-index 798957c78..c14d22319 100644
+index 40c7e3d8..68d18451 100644
 --- a/client/common/man/CMakeLists.txt
 +++ b/client/common/man/CMakeLists.txt
 @@ -1,6 +1,3 @@
 -if(CMAKE_CROSSCOMPILING)
--	find_package(GenerateArgumentManpage)
+-  find_package(GenerateArgumentManpage)
 -else()
-     include_directories(${CMAKE_BINARY_DIR}/include/)
+   include_directories(${CMAKE_BINARY_DIR}/include/)
  
-     add_executable(generate_argument_manpage
-@@ -9,14 +6,13 @@ else()
-     )
- 	export(TARGETS generate_argument_manpage FILE
- 		"${CMAKE_BINARY_DIR}/GenerateArgumentManpageConfig.cmake")
+   add_executable(generate_argument_manpage generate_argument_manpage.c ../cmdline.h)
+@@ -15,13 +12,12 @@ else()
+   endif()
+ 
+   export(TARGETS generate_argument_manpage FILE "${CMAKE_BINARY_DIR}/GenerateArgumentManpageConfig.cmake")
 -endif()
  
  set(MAN_OPTIONS_FILE "${CMAKE_CURRENT_BINARY_DIR}/freerdp-global-options.1")
  set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS ${MAN_OPTIONS_FILE})
  
  add_custom_command(
- 	OUTPUT ${MAN_OPTIONS_FILE}
--	COMMAND ${CMAKE_BINARY_DIR}/client/common/man/generate_argument_manpage "${MAN_OPTIONS_FILE}"
-+	COMMAND generate_argument_manpage "${MAN_OPTIONS_FILE}"
- 	WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
- 	DEPENDS
- 		generate_argument_manpage
+-  OUTPUT ${MAN_OPTIONS_FILE} COMMAND $<TARGET_FILE:generate_argument_manpage> "${MAN_OPTIONS_FILE}"
++  OUTPUT ${MAN_OPTIONS_FILE} COMMAND generate_argument_manpage "${MAN_OPTIONS_FILE}"
+   WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} DEPENDS generate_argument_manpage
+ )
+ add_custom_target(
diff --git a/srcpkgs/freerdp3/template b/srcpkgs/freerdp3/template
index 41fbe1551f463f..c39a9635dcdb89 100644
--- a/srcpkgs/freerdp3/template
+++ b/srcpkgs/freerdp3/template
@@ -1,10 +1,10 @@
 # Template file for 'freerdp3'
 pkgname=freerdp3
-version=3.9.0
+version=3.10.0
 revision=1
 build_style=cmake
 build_helper=qemu
-configure_args="-DCHANNEL_URBDRC_CLIENT=ON
+configure_args="-Wno-dev -DCMAKE_BUILD_TYPE=Release -DCHANNEL_URBDRC_CLIENT=ON
  -DPKG_CONFIG_RELOCATABLE=OFF -DPROXY_PLUGINDIR=/usr/lib/${pkgname}/server/proxy/plugins
  -DRDTK_FORCE_STATIC_BUILD=ON -DWAYLAND_SCANNER=/usr/bin/wayland-scanner
  -DWITH_BINARY_VERSIONING=ON
@@ -19,7 +19,8 @@ configure_args="-DCHANNEL_URBDRC_CLIENT=ON
  -DWITH_FFMPEG=$(vopt_if ffmpeg ON OFF) -DWITH_PCSC=$(vopt_if smartcard ON OFF)
  -DWITH_PKCS11=$(vopt_if smartcard ON OFF) -DWITH_SWSCALE=$(vopt_if ffmpeg ON OFF)
  -DWITH_WAYLAND=$(vopt_if wayland ON OFF) -DWITH_WEBVIEW=$(vopt_if webview ON OFF)
- -DWITH_CLIENT_SDL_VERSIONED=$(vopt_if sdl2 ON OFF)"
+ -DWITH_CLIENT_SDL_VERSIONED=$(vopt_if sdl2 ON OFF) -DWITH_VERBOSE_WINPR_ASSERT=OFF
+ -DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON"
 hostmakedepends="pkg-config $(vopt_if wayland wayland-devel)"
 makedepends="alsa-lib-devel cups-devel fuse3-devel icu-devel libXcursor-devel
  libXdamage-devel libXinerama-devel libXrandr-devel libXv-devel
@@ -35,8 +36,7 @@ license="Apache-2.0"
 homepage="https://www.freerdp.com/"
 changelog="https://raw.githubusercontent.com/FreeRDP/FreeRDP/master/ChangeLog"
 distfiles="https://github.com/FreeRDP/FreeRDP/archive/${version}.tar.gz"
-checksum=a1d2946c67037bf6bb8aa2f0441c7cacd5e92c835d776cecffb4fcdbaa45ec4f
-CFLAGS="-Wno-dev"
+checksum=fb776f1f7ef401f8ceb54eb9fce5457c1e2ac04230d62fbc31dc25d9bdca0b1a
 
 # wayland - deprecated, sdl2 - experimental
 build_options="aad ffmpeg sdl2 smartcard wayland webview"

Re: [PR PATCH] [Updated] freerdp3: update to 3.10.0

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

There is an updated pull request by chrysos349 against master on the void-packages repository

https://github.com/chrysos349/void-packages freerdp3
https://github.com/void-linux/void-packages/pull/53544

freerdp3: update to 3.10.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl

A patch file from https://github.com/void-linux/void-packages/pull/53544.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freerdp3-53544.patch --]
[-- Type: text/x-diff, Size: 4176 bytes --]

From fd29c88850c0c545341662922d4453c2a51d9a92 Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Tue, 17 Dec 2024 02:45:25 +0300
Subject: [PATCH] freerdp3: update to 3.10.3

---
 srcpkgs/freerdp3/patches/fix-cross.patch | 27 ++++++++++++------------
 srcpkgs/freerdp3/template                | 10 ++++-----
 2 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/srcpkgs/freerdp3/patches/fix-cross.patch b/srcpkgs/freerdp3/patches/fix-cross.patch
index d7d5b8cfe5cfdc..0bff5ce8356755 100644
--- a/srcpkgs/freerdp3/patches/fix-cross.patch
+++ b/srcpkgs/freerdp3/patches/fix-cross.patch
@@ -1,27 +1,26 @@
 diff --git a/client/common/man/CMakeLists.txt b/client/common/man/CMakeLists.txt
-index 798957c78..c14d22319 100644
+index 40c7e3d8..68d18451 100644
 --- a/client/common/man/CMakeLists.txt
 +++ b/client/common/man/CMakeLists.txt
 @@ -1,6 +1,3 @@
 -if(CMAKE_CROSSCOMPILING)
--	find_package(GenerateArgumentManpage)
+-  find_package(GenerateArgumentManpage)
 -else()
-     include_directories(${CMAKE_BINARY_DIR}/include/)
+   include_directories(${CMAKE_BINARY_DIR}/include/)
  
-     add_executable(generate_argument_manpage
-@@ -9,14 +6,13 @@ else()
-     )
- 	export(TARGETS generate_argument_manpage FILE
- 		"${CMAKE_BINARY_DIR}/GenerateArgumentManpageConfig.cmake")
+   add_executable(generate_argument_manpage generate_argument_manpage.c ../cmdline.h)
+@@ -15,13 +12,12 @@ else()
+   endif()
+ 
+   export(TARGETS generate_argument_manpage FILE "${CMAKE_BINARY_DIR}/GenerateArgumentManpageConfig.cmake")
 -endif()
  
  set(MAN_OPTIONS_FILE "${CMAKE_CURRENT_BINARY_DIR}/freerdp-global-options.1")
  set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS ${MAN_OPTIONS_FILE})
  
  add_custom_command(
- 	OUTPUT ${MAN_OPTIONS_FILE}
--	COMMAND ${CMAKE_BINARY_DIR}/client/common/man/generate_argument_manpage "${MAN_OPTIONS_FILE}"
-+	COMMAND generate_argument_manpage "${MAN_OPTIONS_FILE}"
- 	WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
- 	DEPENDS
- 		generate_argument_manpage
+-  OUTPUT ${MAN_OPTIONS_FILE} COMMAND $<TARGET_FILE:generate_argument_manpage> "${MAN_OPTIONS_FILE}"
++  OUTPUT ${MAN_OPTIONS_FILE} COMMAND generate_argument_manpage "${MAN_OPTIONS_FILE}"
+   WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} DEPENDS generate_argument_manpage
+ )
+ add_custom_target(
diff --git a/srcpkgs/freerdp3/template b/srcpkgs/freerdp3/template
index 41fbe1551f463f..45dc167b334978 100644
--- a/srcpkgs/freerdp3/template
+++ b/srcpkgs/freerdp3/template
@@ -1,10 +1,10 @@
 # Template file for 'freerdp3'
 pkgname=freerdp3
-version=3.9.0
+version=3.10.3
 revision=1
 build_style=cmake
 build_helper=qemu
-configure_args="-DCHANNEL_URBDRC_CLIENT=ON
+configure_args="-Wno-dev -DCMAKE_BUILD_TYPE=Release -DCHANNEL_URBDRC_CLIENT=ON
  -DPKG_CONFIG_RELOCATABLE=OFF -DPROXY_PLUGINDIR=/usr/lib/${pkgname}/server/proxy/plugins
  -DRDTK_FORCE_STATIC_BUILD=ON -DWAYLAND_SCANNER=/usr/bin/wayland-scanner
  -DWITH_BINARY_VERSIONING=ON
@@ -19,7 +19,8 @@ configure_args="-DCHANNEL_URBDRC_CLIENT=ON
  -DWITH_FFMPEG=$(vopt_if ffmpeg ON OFF) -DWITH_PCSC=$(vopt_if smartcard ON OFF)
  -DWITH_PKCS11=$(vopt_if smartcard ON OFF) -DWITH_SWSCALE=$(vopt_if ffmpeg ON OFF)
  -DWITH_WAYLAND=$(vopt_if wayland ON OFF) -DWITH_WEBVIEW=$(vopt_if webview ON OFF)
- -DWITH_CLIENT_SDL_VERSIONED=$(vopt_if sdl2 ON OFF)"
+ -DWITH_CLIENT_SDL_VERSIONED=$(vopt_if sdl2 ON OFF) -DWITH_VERBOSE_WINPR_ASSERT=OFF
+ -DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON"
 hostmakedepends="pkg-config $(vopt_if wayland wayland-devel)"
 makedepends="alsa-lib-devel cups-devel fuse3-devel icu-devel libXcursor-devel
  libXdamage-devel libXinerama-devel libXrandr-devel libXv-devel
@@ -35,8 +36,7 @@ license="Apache-2.0"
 homepage="https://www.freerdp.com/"
 changelog="https://raw.githubusercontent.com/FreeRDP/FreeRDP/master/ChangeLog"
 distfiles="https://github.com/FreeRDP/FreeRDP/archive/${version}.tar.gz"
-checksum=a1d2946c67037bf6bb8aa2f0441c7cacd5e92c835d776cecffb4fcdbaa45ec4f
-CFLAGS="-Wno-dev"
+checksum=011b645e49401e59396ded91cccf9a0cdf68e6c43a3cb0bf6a9b6852c9c564a4
 
 # wayland - deprecated, sdl2 - experimental
 build_options="aad ffmpeg sdl2 smartcard wayland webview"

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here.

From my understanding MD4/MD5/RC4 are provided by OpenSSL and support for them can be configured by the user by enabling/disabling legacy crypto in the OpenSSL config. (Also, from my understanding those should only be needed for NTLM, whereas Kerberos supports newer crypto)

https://github.com/FreeRDP/FreeRDP/issues/10908#issuecomment-2517338121

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here?

From my understanding MD4/MD5/RC4 are provided by OpenSSL and support for them can be configured by the user by enabling/disabling legacy crypto in the OpenSSL config. (Also, from my understanding those should only be needed for NTLM, whereas Kerberos supports newer crypto)

https://github.com/FreeRDP/FreeRDP/issues/10908#issuecomment-2517338121

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 219 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here?

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here?

From my understanding MD4/MD5/RC4 are provided by OpenSSL (`openssl dgst -list`). (Also, from my understanding those should only be needed for NTLM, whereas Kerberos supports newer crypto)

https://github.com/FreeRDP/FreeRDP/issues/10908#issuecomment-2517338121

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here?

From my understanding MD4/MD5/RC4 are provided by OpenSSL (`openssl dgst -list`) as long as the legacy provider is enabled in the openssl config file. (Also, from my understanding those should only be needed for NTLM, whereas Kerberos supports newer crypto)

https://github.com/FreeRDP/FreeRDP/issues/10908#issuecomment-2517338121

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here?

From my understanding MD4/MD5/RC4 are provided by OpenSSL (`openssl dgst -list`) as long as the legacy provider is enabled in the OpenSSL config file (`/etc/ssl/openssl.cnf`). (Also, from my understanding those should only be needed for NTLM, whereas Kerberos supports newer crypto)

https://github.com/FreeRDP/FreeRDP/issues/10908#issuecomment-2517338121

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here?

From my understanding MD4/MD5/RC4 are provided by OpenSSL (`openssl dgst -list`) as long as the legacy provider is enabled in the OpenSSL config and the `CRYPTOGRAPHY_OPENSSL_NO_LEGACY` environment variable is not set. (Also, from my understanding those should only be needed for NTLM, whereas Kerberos supports newer crypto)

https://github.com/FreeRDP/FreeRDP/issues/10908#issuecomment-2517338121

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 550 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here?

From my understanding MD4/MD5/RC4 are provided by OpenSSL (`openssl dgst -list`) as long as the legacy provider is enabled in the OpenSSL config. (Also, from my understanding those should only be needed for NTLM, whereas Kerberos supports newer crypto)

https://github.com/FreeRDP/FreeRDP/issues/10908#issuecomment-2517338121

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here?

From my understanding MD4/MD5/RC4 are provided by OpenSSL (`openssl dgst -list` and `echo -n "aaa" | openssl md4 -provider legacy`) as long as the legacy provider is enabled in the OpenSSL config. (Also, from my understanding those should only be needed for NTLM, whereas Kerberos supports newer crypto)

https://github.com/FreeRDP/FreeRDP/issues/10908#issuecomment-2517338121

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here?

From my understanding MD4/MD5/RC4 are provided by OpenSSL (`openssl dgst -list` and `echo -n "aaa" | openssl md4 -provider legacy`) as long as the legacy provider is enabled in the OpenSSL config.

https://github.com/FreeRDP/FreeRDP/issues/10908#issuecomment-2517338121

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here?

From my understanding MD4/MD5/RC4 are provided by OpenSSL through the legacy provider (`echo -n "aaa" | openssl md4 -provider legacy`).

https://github.com/FreeRDP/FreeRDP/issues/10908#issuecomment-2517338121

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 458 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here?

From my understanding MD4/MD5/RC4 are provided by OpenSSL through the legacy provider (`openssl dgst -list` and `echo -n "aaa" | openssl md4 -provider legacy`).

https://github.com/FreeRDP/FreeRDP/issues/10908#issuecomment-2517338121

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here?

From my understanding MD4/MD5/RC4 are provided by OpenSSL through the legacy provider (`openssl dgst -list` and `echo -n "aaa" | openssl md4 -provider legacy`).

https://github.com/FreeRDP/FreeRDP/issues/10908#issuecomment-2517338121
https://github.com/FreeRDP/FreeRDP/blob/9fe96b430380921f9b0e2c150d9c852aa39987c6/winpr/libwinpr/utils/ssl.c#L327-L337

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 579 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1895218890

Comment:
Why did you add `-DWITH_INTERNAL_MD4=ON -DWITH_INTERNAL_RC4=ON` here?

From my understanding MD4/MD5/RC4 are provided by OpenSSL through the legacy provider (`openssl dgst -list` and `echo -n "aaa" | openssl md4 -provider legacy`).

https://github.com/FreeRDP/FreeRDP/issues/10908#issuecomment-2517338121

https://github.com/FreeRDP/FreeRDP/blob/9fe96b430380921f9b0e2c150d9c852aa39987c6/winpr/libwinpr/utils/ssl.c#L327-L337

Re: [PR REVIEW] freerdp3: update to 3.10.3

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1898161099

Comment:
these warnings (and an error) are produced IF `configure_args` above are not enabled:
```
[ERROR][com.winpr.crypto.hash] - [winpr_Digest_Init_Internal]: Failed to initialize digest md4
[WARN][com.freerdp.core.rdp] - [log_build_warn_hash][0x55f7c955a3c0]: *************************************************
[WARN][com.freerdp.core.rdp] - [log_build_warn_hash][0x55f7c955a3c0]: [SSL] {Digest} build or configuration missing:
[WARN][com.freerdp.core.rdp] - [log_build_warn_hash][0x55f7c955a3c0]:  * md4: NTLM support not available
[WARN][com.freerdp.core.rdp] - [log_build_warn_hash][0x55f7c955a3c0]: *************************************************
[WARN][com.freerdp.core.rdp] - [log_build_warn_cipher][0x55f7c955a3c0]: *************************************************
[WARN][com.freerdp.core.rdp] - [log_build_warn_cipher][0x55f7c955a3c0]: [SSL] {Cipher} build or configuration missing:
[WARN][com.freerdp.core.rdp] - [log_build_warn_cipher][0x55f7c955a3c0]: * rc4: assistance files with encrypted passwords, NTLM, RDP licensing and RDP security will not work
[WARN][com.freerdp.core.rdp] - [log_build_warn_cipher][0x55f7c955a3c0]: *************************************************
```

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1899032783

Comment:
What command are you running to produce those errors?

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1899032783

Comment:
What command are you running to produce those warnings?

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1899032783

Comment:
What command are you running to produce those warnings?

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1899036098

Comment:
Alright, those warnings are printed in `freerdp_context_new()`, whereas `winpr_InitializeSSL()` doesn't get called until `freerdp_connect()`.

https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/freerdp.c#L805
https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/connection.c#L321

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 601 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1899036098

Comment:
Alright, those warnings are printed in `freerdp_context_new()`, whereas `winpr_InitializeSSL()` doesn't get called until `freerdp_connect()`.

https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/freerdp.c#L805
https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/connection.c#L321

Which is probably why `winpr-hash3` still works without those configure args.

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 634 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1899036098

Comment:
Alright, those warnings are printed in `freerdp_context_new()`, whereas `winpr_InitializeSSL()` doesn't get called until `freerdp_connect()`. I also confirmed this using GDB.

https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/freerdp.c#L805
https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/connection.c#L321

Which is probably why `winpr-hash3` still works without those configure args.

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 767 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1899036098

Comment:
Alright, those warnings are printed in `freerdp_context_new()`, whereas `winpr_InitializeSSL()` doesn't get called until `freerdp_connect()`. I also confirmed this using GDB.

https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/freerdp.c#L805
https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/connection.c#L321

Seems like this warning was a recent addition: https://github.com/FreeRDP/FreeRDP/commit/d511316e860f682bfdf7525125a6cee3f3224096

Which is probably why `winpr-hash3` still works without those configure args.

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 769 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1899036098

Comment:
Alright, those warnings are printed in `freerdp_context_new()`, whereas `winpr_InitializeSSL()` doesn't get called until `freerdp_connect()`. I also confirmed this using GDB.

https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/freerdp.c#L805
https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/connection.c#L321

Seems like those warnings are a recent addition: https://github.com/FreeRDP/FreeRDP/commit/d511316e860f682bfdf7525125a6cee3f3224096

Which is probably why `winpr-hash3` still works without those configure args.

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 813 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1899036098

Comment:
Alright, those warnings are printed in `freerdp_context_new()`, whereas `winpr_InitializeSSL()` doesn't get called until `freerdp_connect()`. I also confirmed this using GDB.

https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/freerdp.c#L805
https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/connection.c#L321

Seems like those warnings are a recent addition: https://github.com/FreeRDP/FreeRDP/commit/d511316e860f682bfdf7525125a6cee3f3224096 (and probably false positives in this case)

Which is probably why `winpr-hash3` still works without those configure args.

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 769 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1899036098

Comment:
Alright, those warnings are printed in `freerdp_context_new()`, whereas `winpr_InitializeSSL()` doesn't get called until `freerdp_connect()`. I also confirmed this using GDB.

https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/freerdp.c#L805
https://github.com/FreeRDP/FreeRDP/blob/6e24bdd817f6aeae8d2a0e0d19606934e9588b2d/libfreerdp/core/connection.c#L321

Seems like those warnings are a recent addition: https://github.com/FreeRDP/FreeRDP/commit/d511316e860f682bfdf7525125a6cee3f3224096

Which is probably why `winpr-hash3` still works without those configure args.

Re: [PR REVIEW] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

New review comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1899095465

Comment:
I brought this up on the matrix and a patch has been submitted upstream by the maintainer to resolve this: https://github.com/FreeRDP/FreeRDP/pull/11023

Re: [PR PATCH] [Updated] freerdp3: update to 3.10.3

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

There is an updated pull request by chrysos349 against master on the void-packages repository

https://github.com/chrysos349/void-packages freerdp3
https://github.com/void-linux/void-packages/pull/53544

freerdp3: update to 3.10.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl

A patch file from https://github.com/void-linux/void-packages/pull/53544.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freerdp3-53544.patch --]
[-- Type: text/x-diff, Size: 5783 bytes --]

From 16947d47c988f1f539adc869f69e7ced0f4871ec Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Tue, 17 Dec 2024 02:45:25 +0300
Subject: [PATCH] freerdp3: update to 3.10.3

---
 srcpkgs/freerdp3/patches/fix-cross.patch      | 27 +++++++--------
 .../patches/warn-print-after-ssl-init.patch   | 34 +++++++++++++++++++
 srcpkgs/freerdp3/template                     |  9 +++--
 3 files changed, 51 insertions(+), 19 deletions(-)
 create mode 100644 srcpkgs/freerdp3/patches/warn-print-after-ssl-init.patch

diff --git a/srcpkgs/freerdp3/patches/fix-cross.patch b/srcpkgs/freerdp3/patches/fix-cross.patch
index d7d5b8cfe5cfdc..0bff5ce8356755 100644
--- a/srcpkgs/freerdp3/patches/fix-cross.patch
+++ b/srcpkgs/freerdp3/patches/fix-cross.patch
@@ -1,27 +1,26 @@
 diff --git a/client/common/man/CMakeLists.txt b/client/common/man/CMakeLists.txt
-index 798957c78..c14d22319 100644
+index 40c7e3d8..68d18451 100644
 --- a/client/common/man/CMakeLists.txt
 +++ b/client/common/man/CMakeLists.txt
 @@ -1,6 +1,3 @@
 -if(CMAKE_CROSSCOMPILING)
--	find_package(GenerateArgumentManpage)
+-  find_package(GenerateArgumentManpage)
 -else()
-     include_directories(${CMAKE_BINARY_DIR}/include/)
+   include_directories(${CMAKE_BINARY_DIR}/include/)
  
-     add_executable(generate_argument_manpage
-@@ -9,14 +6,13 @@ else()
-     )
- 	export(TARGETS generate_argument_manpage FILE
- 		"${CMAKE_BINARY_DIR}/GenerateArgumentManpageConfig.cmake")
+   add_executable(generate_argument_manpage generate_argument_manpage.c ../cmdline.h)
+@@ -15,13 +12,12 @@ else()
+   endif()
+ 
+   export(TARGETS generate_argument_manpage FILE "${CMAKE_BINARY_DIR}/GenerateArgumentManpageConfig.cmake")
 -endif()
  
  set(MAN_OPTIONS_FILE "${CMAKE_CURRENT_BINARY_DIR}/freerdp-global-options.1")
  set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS ${MAN_OPTIONS_FILE})
  
  add_custom_command(
- 	OUTPUT ${MAN_OPTIONS_FILE}
--	COMMAND ${CMAKE_BINARY_DIR}/client/common/man/generate_argument_manpage "${MAN_OPTIONS_FILE}"
-+	COMMAND generate_argument_manpage "${MAN_OPTIONS_FILE}"
- 	WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
- 	DEPENDS
- 		generate_argument_manpage
+-  OUTPUT ${MAN_OPTIONS_FILE} COMMAND $<TARGET_FILE:generate_argument_manpage> "${MAN_OPTIONS_FILE}"
++  OUTPUT ${MAN_OPTIONS_FILE} COMMAND generate_argument_manpage "${MAN_OPTIONS_FILE}"
+   WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} DEPENDS generate_argument_manpage
+ )
+ add_custom_target(
diff --git a/srcpkgs/freerdp3/patches/warn-print-after-ssl-init.patch b/srcpkgs/freerdp3/patches/warn-print-after-ssl-init.patch
new file mode 100644
index 00000000000000..9ae1dabc1505e9
--- /dev/null
+++ b/srcpkgs/freerdp3/patches/warn-print-after-ssl-init.patch
@@ -0,0 +1,34 @@
+From 60ed73552ffdb499dddf06c119be9437da7f9261 Mon Sep 17 00:00:00 2001
+From: akallabeth <akallabeth@posteo.net>
+Date: Sun, 29 Dec 2024 10:22:56 +0100
+Subject: [PATCH 1/2] [core,connection] print SSL warnings after init
+
+---
+ libfreerdp/core/connection.c | 1 +
+ libfreerdp/core/freerdp.c    | 1 -
+ 2 files changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/libfreerdp/core/connection.c b/libfreerdp/core/connection.c
+index 979ccdf60a57..001b56944b8c 100644
+--- a/libfreerdp/core/connection.c
++++ b/libfreerdp/core/connection.c
+@@ -319,6 +319,7 @@ BOOL rdp_client_connect(rdpRdp* rdp)
+ 		flags |= WINPR_SSL_INIT_ENABLE_FIPS;
+ 
+ 	winpr_InitializeSSL(flags);
++	rdp_log_build_warnings(rdp);
+ 
+ 	/* FIPS Mode forces the following and overrides the following(by happening later */
+ 	/* in the command line processing): */
+diff --git a/libfreerdp/core/freerdp.c b/libfreerdp/core/freerdp.c
+index 94dad20a0cd9..715da31d917b 100644
+--- a/libfreerdp/core/freerdp.c
++++ b/libfreerdp/core/freerdp.c
+@@ -802,7 +802,6 @@ BOOL freerdp_context_new_ex(freerdp* instance, rdpSettings* settings)
+ 	if (!rdp)
+ 		goto fail;
+ 
+-	rdp_log_build_warnings(rdp);
+ 	context->rdp = rdp;
+ 	context->pubSub = rdp->pubSub;
+ 
diff --git a/srcpkgs/freerdp3/template b/srcpkgs/freerdp3/template
index 41fbe1551f463f..7b3a788b367050 100644
--- a/srcpkgs/freerdp3/template
+++ b/srcpkgs/freerdp3/template
@@ -1,10 +1,10 @@
 # Template file for 'freerdp3'
 pkgname=freerdp3
-version=3.9.0
+version=3.10.3
 revision=1
 build_style=cmake
 build_helper=qemu
-configure_args="-DCHANNEL_URBDRC_CLIENT=ON
+configure_args="-Wno-dev -DCMAKE_BUILD_TYPE=Release -DCHANNEL_URBDRC_CLIENT=ON
  -DPKG_CONFIG_RELOCATABLE=OFF -DPROXY_PLUGINDIR=/usr/lib/${pkgname}/server/proxy/plugins
  -DRDTK_FORCE_STATIC_BUILD=ON -DWAYLAND_SCANNER=/usr/bin/wayland-scanner
  -DWITH_BINARY_VERSIONING=ON
@@ -19,7 +19,7 @@ configure_args="-DCHANNEL_URBDRC_CLIENT=ON
  -DWITH_FFMPEG=$(vopt_if ffmpeg ON OFF) -DWITH_PCSC=$(vopt_if smartcard ON OFF)
  -DWITH_PKCS11=$(vopt_if smartcard ON OFF) -DWITH_SWSCALE=$(vopt_if ffmpeg ON OFF)
  -DWITH_WAYLAND=$(vopt_if wayland ON OFF) -DWITH_WEBVIEW=$(vopt_if webview ON OFF)
- -DWITH_CLIENT_SDL_VERSIONED=$(vopt_if sdl2 ON OFF)"
+ -DWITH_CLIENT_SDL_VERSIONED=$(vopt_if sdl2 ON OFF) -DWITH_VERBOSE_WINPR_ASSERT=OFF"
 hostmakedepends="pkg-config $(vopt_if wayland wayland-devel)"
 makedepends="alsa-lib-devel cups-devel fuse3-devel icu-devel libXcursor-devel
  libXdamage-devel libXinerama-devel libXrandr-devel libXv-devel
@@ -35,8 +35,7 @@ license="Apache-2.0"
 homepage="https://www.freerdp.com/"
 changelog="https://raw.githubusercontent.com/FreeRDP/FreeRDP/master/ChangeLog"
 distfiles="https://github.com/FreeRDP/FreeRDP/archive/${version}.tar.gz"
-checksum=a1d2946c67037bf6bb8aa2f0441c7cacd5e92c835d776cecffb4fcdbaa45ec4f
-CFLAGS="-Wno-dev"
+checksum=011b645e49401e59396ded91cccf9a0cdf68e6c43a3cb0bf6a9b6852c9c564a4
 
 # wayland - deprecated, sdl2 - experimental
 build_options="aad ffmpeg sdl2 smartcard wayland webview"

Re: [PR REVIEW] freerdp3: update to 3.10.3

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#discussion_r1899136061

Comment:
added the patch.

Re: [PR PATCH] [Updated] freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

There is an updated pull request by oreo639 against master on the void-packages repository

https://github.com/chrysos349/void-packages freerdp3
https://github.com/void-linux/void-packages/pull/53544

freerdp3: update to 3.10.3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl

A patch file from https://github.com/void-linux/void-packages/pull/53544.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-freerdp3-53544.patch --]
[-- Type: text/x-diff, Size: 6291 bytes --]

From 21385dc11ac4402ac0f92ee1fb8607613d0cf2b2 Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Tue, 17 Dec 2024 02:45:25 +0300
Subject: [PATCH] freerdp3: update to 3.10.3

---
 srcpkgs/freerdp3/patches/fix-cross.patch      | 27 +++++++--------
 .../patches/warn-print-after-ssl-init.patch   | 34 +++++++++++++++++++
 srcpkgs/freerdp3/template                     | 17 ++++++----
 3 files changed, 58 insertions(+), 20 deletions(-)
 create mode 100644 srcpkgs/freerdp3/patches/warn-print-after-ssl-init.patch

diff --git a/srcpkgs/freerdp3/patches/fix-cross.patch b/srcpkgs/freerdp3/patches/fix-cross.patch
index d7d5b8cfe5cfdc..0bff5ce8356755 100644
--- a/srcpkgs/freerdp3/patches/fix-cross.patch
+++ b/srcpkgs/freerdp3/patches/fix-cross.patch
@@ -1,27 +1,26 @@
 diff --git a/client/common/man/CMakeLists.txt b/client/common/man/CMakeLists.txt
-index 798957c78..c14d22319 100644
+index 40c7e3d8..68d18451 100644
 --- a/client/common/man/CMakeLists.txt
 +++ b/client/common/man/CMakeLists.txt
 @@ -1,6 +1,3 @@
 -if(CMAKE_CROSSCOMPILING)
--	find_package(GenerateArgumentManpage)
+-  find_package(GenerateArgumentManpage)
 -else()
-     include_directories(${CMAKE_BINARY_DIR}/include/)
+   include_directories(${CMAKE_BINARY_DIR}/include/)
  
-     add_executable(generate_argument_manpage
-@@ -9,14 +6,13 @@ else()
-     )
- 	export(TARGETS generate_argument_manpage FILE
- 		"${CMAKE_BINARY_DIR}/GenerateArgumentManpageConfig.cmake")
+   add_executable(generate_argument_manpage generate_argument_manpage.c ../cmdline.h)
+@@ -15,13 +12,12 @@ else()
+   endif()
+ 
+   export(TARGETS generate_argument_manpage FILE "${CMAKE_BINARY_DIR}/GenerateArgumentManpageConfig.cmake")
 -endif()
  
  set(MAN_OPTIONS_FILE "${CMAKE_CURRENT_BINARY_DIR}/freerdp-global-options.1")
  set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS ${MAN_OPTIONS_FILE})
  
  add_custom_command(
- 	OUTPUT ${MAN_OPTIONS_FILE}
--	COMMAND ${CMAKE_BINARY_DIR}/client/common/man/generate_argument_manpage "${MAN_OPTIONS_FILE}"
-+	COMMAND generate_argument_manpage "${MAN_OPTIONS_FILE}"
- 	WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
- 	DEPENDS
- 		generate_argument_manpage
+-  OUTPUT ${MAN_OPTIONS_FILE} COMMAND $<TARGET_FILE:generate_argument_manpage> "${MAN_OPTIONS_FILE}"
++  OUTPUT ${MAN_OPTIONS_FILE} COMMAND generate_argument_manpage "${MAN_OPTIONS_FILE}"
+   WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} DEPENDS generate_argument_manpage
+ )
+ add_custom_target(
diff --git a/srcpkgs/freerdp3/patches/warn-print-after-ssl-init.patch b/srcpkgs/freerdp3/patches/warn-print-after-ssl-init.patch
new file mode 100644
index 00000000000000..9ae1dabc1505e9
--- /dev/null
+++ b/srcpkgs/freerdp3/patches/warn-print-after-ssl-init.patch
@@ -0,0 +1,34 @@
+From 60ed73552ffdb499dddf06c119be9437da7f9261 Mon Sep 17 00:00:00 2001
+From: akallabeth <akallabeth@posteo.net>
+Date: Sun, 29 Dec 2024 10:22:56 +0100
+Subject: [PATCH 1/2] [core,connection] print SSL warnings after init
+
+---
+ libfreerdp/core/connection.c | 1 +
+ libfreerdp/core/freerdp.c    | 1 -
+ 2 files changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/libfreerdp/core/connection.c b/libfreerdp/core/connection.c
+index 979ccdf60a57..001b56944b8c 100644
+--- a/libfreerdp/core/connection.c
++++ b/libfreerdp/core/connection.c
+@@ -319,6 +319,7 @@ BOOL rdp_client_connect(rdpRdp* rdp)
+ 		flags |= WINPR_SSL_INIT_ENABLE_FIPS;
+ 
+ 	winpr_InitializeSSL(flags);
++	rdp_log_build_warnings(rdp);
+ 
+ 	/* FIPS Mode forces the following and overrides the following(by happening later */
+ 	/* in the command line processing): */
+diff --git a/libfreerdp/core/freerdp.c b/libfreerdp/core/freerdp.c
+index 94dad20a0cd9..715da31d917b 100644
+--- a/libfreerdp/core/freerdp.c
++++ b/libfreerdp/core/freerdp.c
+@@ -802,7 +802,6 @@ BOOL freerdp_context_new_ex(freerdp* instance, rdpSettings* settings)
+ 	if (!rdp)
+ 		goto fail;
+ 
+-	rdp_log_build_warnings(rdp);
+ 	context->rdp = rdp;
+ 	context->pubSub = rdp->pubSub;
+ 
diff --git a/srcpkgs/freerdp3/template b/srcpkgs/freerdp3/template
index 41fbe1551f463f..f796bb464ee96a 100644
--- a/srcpkgs/freerdp3/template
+++ b/srcpkgs/freerdp3/template
@@ -1,13 +1,19 @@
 # Template file for 'freerdp3'
 pkgname=freerdp3
-version=3.9.0
+version=3.10.3
 revision=1
 build_style=cmake
 build_helper=qemu
-configure_args="-DCHANNEL_URBDRC_CLIENT=ON
+configure_args="-Wno-dev -DCMAKE_BUILD_TYPE=Release
+ -DCMAKE_CXX_FLAGS_RELEASE=-DNDEBUG
+ -DCMAKE_CXX_FLAGS_DEBUG=-DNDEBUG
+ -DCMAKE_CXX_FLAGS_RELWITHDEBINFO=-DNDEBUG
+ -DCMAKE_C_FLAGS_RELEASE=-DNDEBUG
+ -DCMAKE_C_FLAGS_DEBUG=-DNDEBUG
+ -DCMAKE_C_FLAGS_RELWITHDEBINFO=-DNDEBUG
  -DPKG_CONFIG_RELOCATABLE=OFF -DPROXY_PLUGINDIR=/usr/lib/${pkgname}/server/proxy/plugins
  -DRDTK_FORCE_STATIC_BUILD=ON -DWAYLAND_SCANNER=/usr/bin/wayland-scanner
- -DWITH_BINARY_VERSIONING=ON
+ -DCHANNEL_URBDRC_CLIENT=ON -DWITH_BINARY_VERSIONING=ON
  -DWITH_ALSA=ON -DWITH_CHANNELS=ON -DWITH_CLIENT_CHANNELS=ON -DWITH_CUPS=ON
  -DWITH_FREERDP_DEPRECATED_COMMANDLINE=ON -DWITH_FUSE=ON -DWITH_GSTREAMER_1_0=OFF
  -DWITH_ICU=ON -DWITH_JPEG=ON -DWITH_LIBSYSTEMD=OFF -DWITH_PULSE=ON -DWITH_SAMPLE=OFF
@@ -19,7 +25,7 @@ configure_args="-DCHANNEL_URBDRC_CLIENT=ON
  -DWITH_FFMPEG=$(vopt_if ffmpeg ON OFF) -DWITH_PCSC=$(vopt_if smartcard ON OFF)
  -DWITH_PKCS11=$(vopt_if smartcard ON OFF) -DWITH_SWSCALE=$(vopt_if ffmpeg ON OFF)
  -DWITH_WAYLAND=$(vopt_if wayland ON OFF) -DWITH_WEBVIEW=$(vopt_if webview ON OFF)
- -DWITH_CLIENT_SDL_VERSIONED=$(vopt_if sdl2 ON OFF)"
+ -DWITH_CLIENT_SDL_VERSIONED=$(vopt_if sdl2 ON OFF) -DWITH_VERBOSE_WINPR_ASSERT=OFF"
 hostmakedepends="pkg-config $(vopt_if wayland wayland-devel)"
 makedepends="alsa-lib-devel cups-devel fuse3-devel icu-devel libXcursor-devel
  libXdamage-devel libXinerama-devel libXrandr-devel libXv-devel
@@ -35,8 +41,7 @@ license="Apache-2.0"
 homepage="https://www.freerdp.com/"
 changelog="https://raw.githubusercontent.com/FreeRDP/FreeRDP/master/ChangeLog"
 distfiles="https://github.com/FreeRDP/FreeRDP/archive/${version}.tar.gz"
-checksum=a1d2946c67037bf6bb8aa2f0441c7cacd5e92c835d776cecffb4fcdbaa45ec4f
-CFLAGS="-Wno-dev"
+checksum=011b645e49401e59396ded91cccf9a0cdf68e6c43a3cb0bf6a9b6852c9c564a4
 
 # wayland - deprecated, sdl2 - experimental
 build_options="aad ffmpeg sdl2 smartcard wayland webview"

Re: freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 245 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#issuecomment-2565118365

Comment:
I pushed a fix for the cflags (since `-DCMAKE_BUILD_TYPE=Release` adds undesirable stuff to the cflags)

Re: freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53544#issuecomment-2565118365

Comment:
I pushed a fix for the cflags (since `-DCMAKE_BUILD_TYPE=Release` adds undesirable stuff to the cflags by default)

Re: [PR PATCH] [Merged]: freerdp3: update to 3.10.3

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

There's a merged pull request on the void-packages repository

freerdp3: update to 3.10.3
https://github.com/void-linux/void-packages/pull/53544

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl