[PR PATCH] vala, valadoc: update to 0.56.17

[PR PATCH] vala, valadoc: update to 0.56.17

[RangHo]

[-- Attachment #1: Type: text/plain, Size: 915 bytes --]

There is a new pull request by RangHo against master on the void-packages repository

https://github.com/RangHo/void-packages update-vala
https://github.com/void-linux/void-packages/pull/53689

vala, valadoc: update to 0.56.17
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, `x86_64-glibc`.



A patch file from https://github.com/void-linux/void-packages/pull/53689.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-vala-53689.patch --]
[-- Type: text/x-diff, Size: 2186 bytes --]

From 8301029c18b9e2f4bacb0724679f52f2ee82a285 Mon Sep 17 00:00:00 2001
From: RangHo Lee <hello@rangho.me>
Date: Thu, 26 Dec 2024 21:53:23 +0900
Subject: [PATCH] vala: update to 0.56.17

---
 srcpkgs/vala/template    | 6 +++---
 srcpkgs/valadoc/template | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/vala/template b/srcpkgs/vala/template
index 87599d409396e2..10f902a08be477 100644
--- a/srcpkgs/vala/template
+++ b/srcpkgs/vala/template
@@ -1,8 +1,8 @@
 # Template file for 'vala'
 pkgname=vala
 # Should be kept in sync with 'valadoc' (shared distfiles)
-version=0.56.16
-revision=2
+version=0.56.17
+revision=1
 build_style=gnu-configure
 configure_args="--disable-valadoc GI_GIRDIR=/usr/share/gir-1.0"
 hostmakedepends="flex libxslt pkg-config automake libtool"
@@ -14,7 +14,7 @@ license="LGPL-2.1-or-later"
 homepage="https://wiki.gnome.org/Projects/Vala"
 changelog="https://gitlab.gnome.org/GNOME/vala/raw/master/NEWS"
 distfiles="${GNOME_SITE}/vala/${version%.*}/vala-${version}.tar.xz"
-checksum=05487b5600f5d2f09e66a753cccd8f39c1bff9f148aea1b7774d505b9c8bca9b
+checksum=26100c4e4ef0049c619275f140d97cf565883d00c7543c82bcce5a426934ed6a
 shlib_provides="libvalaccodegen.so"
 make_check=extended # take a lot of time
 
diff --git a/srcpkgs/valadoc/template b/srcpkgs/valadoc/template
index fcad4327110ea8..1cbf8158b53914 100644
--- a/srcpkgs/valadoc/template
+++ b/srcpkgs/valadoc/template
@@ -1,8 +1,8 @@
 # Template file for 'valadoc'
 pkgname=valadoc
 # Should be kept in sync with 'vala' (shared distfiles)
-version=0.56.16
-revision=2
+version=0.56.17
+revision=1
 build_style=gnu-configure
 configure_args="--with-cgraph=yes GI_GIRDIR=/usr/share/gir-1.0"
 hostmakedepends="flex libxslt pkg-config automake libtool vala"
@@ -15,7 +15,7 @@ license="LGPL-2.1-or-later"
 homepage="https://wiki.gnome.org/Projects/Vala"
 changelog="https://gitlab.gnome.org/GNOME/vala/raw/master/NEWS"
 distfiles="${GNOME_SITE}/vala/${version%.*}/vala-${version}.tar.xz"
-checksum=05487b5600f5d2f09e66a753cccd8f39c1bff9f148aea1b7774d505b9c8bca9b
+checksum=26100c4e4ef0049c619275f140d97cf565883d00c7543c82bcce5a426934ed6a
 
 pre_configure() {
 	autoreconf -if

Re: vala, valadoc: update to 0.56.17

[RangHo]

[-- Attachment #1: Type: text/plain, Size: 400 bytes --]

New comment by RangHo on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2564335655

Comment:
Alright, the check for `valadoc` seems to fail for `x86_64-musl`.

I suspect this is an upstream issue: see [upstream issue 1573](https://gitlab.gnome.org/GNOME/vala/-/issues/1573) for more information.

I'll convert this into a draft until this is fixed.

Re: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2601294080

Comment:
vala and valadoc need to be separate commits in this pr.
Thanks for looking in to the issue.
Here is the revert patch I used for future reference (the vala tarball has the c files auto-generated and we build vala without as system vala install, hence why valadoc is built seperately): https://gist.github.com/oreo639/163a82e6a5348c5aac61e823f91418f7

Re: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2601294080

Comment:
vala and valadoc need to be separate commits in this pr.
Thanks for looking in to the issue.
Here is the revert patch I used for future reference (the vala tarball has the c files auto-generated and we build vala without as system vala install, hence why valadoc is built seperately): https://gist.github.com/oreo639/163a82e6a5348c5aac61e823f91418f7 (just to confirm that is the offending commit)

Re: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2601294080

Comment:
vala and valadoc need to be separate commits in this pr.
Thanks for looking in to the issue.
Here is the revert patch I used for future reference (the vala tarball has the c files auto-generated and we build vala without as system vala install, hence why valadoc is built seperately): https://gist.github.com/oreo639/163a82e6a5348c5aac61e823f91418f7 (just to confirm that is the offending commit)

It seems like Vala does have code to ensure the copied array is null terminated, but only if it is a reference type: https://gitlab.gnome.org/GNOME/vala/-/blob/main/codegen/valaccodearraymodule.vala#L586-591

Re: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2601294080

Comment:
vala and valadoc need to be separate commits in this pr.
Thanks for looking in to the issue.
Here is the revert patch I used for future reference (the vala tarball has the c files auto-generated and we build vala without as system vala install, hence why valadoc is built seperately): https://gist.github.com/oreo639/163a82e6a5348c5aac61e823f91418f7 (just to confirm that is the offending commit)

It seems like Vala does have code to ensure the copied array is null terminated, but only if it is a reference type: https://gitlab.gnome.org/GNOME/vala/-/blob/main/codegen/valaccodearraymodule.vala#L586-591

Changing the above so that length + 1 always occurs appears to resolve the issue, although I'm not sure if that would cause regressions elsewhere (all the tests passed): https://gist.github.com/oreo639/3450df16bda7edf1b415d022e0708469

Re: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2601294080

Comment:
vala and valadoc need to be separate commits in this pr.
Thanks for looking in to the issue.
Here is the revert patch I used for future reference (the vala tarball has the c files auto-generated and we build vala without as system vala install, hence why valadoc is built seperately): https://gist.github.com/oreo639/163a82e6a5348c5aac61e823f91418f7 (just to confirm that is the offending commit)

It seems like Vala does have code to ensure the copied array is null terminated, but only if it is a reference type: https://gitlab.gnome.org/GNOME/vala/-/blob/main/codegen/valaccodearraymodule.vala#L586-591

Changing the above so that length + 1 always occurs appears to resolve the issue, although I'm not sure if that would cause regressions elsewhere (all the tests passed) and there is a second code path for `!requires_copy()`: https://gist.github.com/oreo639/3450df16bda7edf1b415d022e0708469

Re: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2601294080

Comment:
vala and valadoc need to be separate commits in this pr.
Thanks for looking in to the issue.
Here is the revert patch I used for future reference (the vala tarball has the c files auto-generated and we build vala without as system vala install, hence why valadoc is built seperately): https://gist.github.com/oreo639/163a82e6a5348c5aac61e823f91418f7 (just to confirm that is the offending commit)

It seems like Vala does have code to ensure the copied array is null terminated, but only if it is a reference type: https://gitlab.gnome.org/GNOME/vala/-/blob/main/codegen/valaccodearraymodule.vala#L586-591

Changing the above so that length + 1 always occurs appears to resolve the issue, although I'm not sure if that would cause regressions elsewhere (all the tests passed) also there is a second code path for `!requires_copy()`: https://gist.github.com/oreo639/3450df16bda7edf1b415d022e0708469

Re: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2601294080

Comment:
vala and valadoc need to be separate commits in this pr.
Thanks for looking in to the issue.

Re: vala, valadoc: update to 0.56.17

[RangHo]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

New comment by RangHo on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2603212034

Comment:
@oreo639 Thanks for the workaround in the upstream issue. Before I close this issue, do you think we can keep [your patch](https://gist.github.com/oreo639/3450df16bda7edf1b415d022e0708469) as a "Void-specific patch" until upstream fixes it?

Re: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2603313225

Comment:
For now, sure.
Make sure to include a description of the patch and links to the issue and pr in the patch header.

Re: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 262 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2603313225

Comment:
For now, sure.
Make sure to include a brief description of the patch and links to the issue and pr in the patch header.

Re: vala, valadoc: update to 0.56.17

[RangHo]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

New comment by RangHo on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2603368931

Comment:
Sure! I'll close and replace this PR once I have a working version. (I'm on a vacation at the moment so it might take a while :wink:)

Re: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2603381055

Comment:
Don't close the pr, just `git rebase`/`git commit --amend`.

Re: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2603381055

Comment:
Don't close the pr, just `git rebase`/`git commit --amend`: https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md

Re: vala, valadoc: update to 0.56.17

[RangHo]

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by RangHo on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2603383957

Comment:
Ah, sorry. I misread the instruction as "make separate PRs". That makes my life a lot easier!

Re: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2603313225

Comment:
For now, sure.
Make sure to include a brief description of the patch and links to the issue and the vala pr in the patch header.

Re: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2603313225

Comment:
For now, sure.
Make sure to include a brief description of the patch and links to the issue and the vala MR in the patch header.

Re: [PR PATCH] [Updated] vala, valadoc: update to 0.56.17

[RangHo]

[-- Attachment #1: Type: text/plain, Size: 920 bytes --]

There is an updated pull request by RangHo against master on the void-packages repository

https://github.com/RangHo/void-packages update-vala
https://github.com/void-linux/void-packages/pull/53689

vala, valadoc: update to 0.56.17
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, `x86_64-glibc`.



A patch file from https://github.com/void-linux/void-packages/pull/53689.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-vala-53689.patch --]
[-- Type: text/x-diff, Size: 10250 bytes --]

From a1cddbe41e9357b8ee6efbd6ef6572571805f3c9 Mon Sep 17 00:00:00 2001
From: RangHo Lee <hello@rangho.me>
Date: Thu, 26 Dec 2024 21:53:23 +0900
Subject: [PATCH 1/2] vala: update to 0.56.17.

---
 .../vala/patches/array-len-dup-overflow.patch | 195 ++++++++++++++++++
 srcpkgs/vala/template                         |   6 +-
 2 files changed, 198 insertions(+), 3 deletions(-)
 create mode 100644 srcpkgs/vala/patches/array-len-dup-overflow.patch

diff --git a/srcpkgs/vala/patches/array-len-dup-overflow.patch b/srcpkgs/vala/patches/array-len-dup-overflow.patch
new file mode 100644
index 00000000000000..aed367f7441790
--- /dev/null
+++ b/srcpkgs/vala/patches/array-len-dup-overflow.patch
@@ -0,0 +1,195 @@
+This patch is a fix for the errornous array boundary check introduced in commit 7e17c3f.
+See: https://gitlab.gnome.org/GNOME/vala/-/issues/1573
+
+--- a/codegen/valaccodearraymodule.vala
++++ b/codegen.valaccodearraymodule.vala
+@@ -583,8 +583,8 @@ public class Vala.CCodeArrayModule : CCo
+ 			CCodeExpression length_expr = new CCodeIdentifier ("length");
+ 			CCodeBinaryOperator length_check_op;
+ 			// add extra item to have array NULL-terminated for all reference types
++			length_expr = new CCodeBinaryExpression (CCodeBinaryOperator.PLUS, length_expr, new CCodeConstant ("1"));
+ 			if (array_type.element_type.type_symbol != null && array_type.element_type.type_symbol.is_reference_type ()) {
+-				length_expr = new CCodeBinaryExpression (CCodeBinaryOperator.PLUS, length_expr, new CCodeConstant ("1"));
+ 				length_check_op = CCodeBinaryOperator.GREATER_THAN_OR_EQUAL;
+ 			} else {
+ 				length_check_op = CCodeBinaryOperator.GREATER_THAN;
+--- a/codegen/valaccodearraymodule.c
++++ b/codegen/valaccodearraymodule.c
+@@ -3032,11 +3032,15 @@ vala_ccode_array_module_generate_array_d
+ 		ValaCCodeExpression* length_expr = NULL;
+ 		ValaCCodeIdentifier* _tmp57_;
+ 		ValaCCodeBinaryOperator length_check_op = 0;
+-		gboolean _tmp58_ = FALSE;
+-		ValaDataType* _tmp59_;
+-		ValaDataType* _tmp60_;
+-		ValaTypeSymbol* _tmp61_;
+-		ValaTypeSymbol* _tmp62_;
++		ValaCCodeExpression* _tmp58_;
++		ValaCCodeConstant* _tmp59_;
++		ValaCCodeConstant* _tmp60_;
++		ValaCCodeBinaryExpression* _tmp61_;
++		gboolean _tmp62_ = FALSE;
++		ValaDataType* _tmp63_;
++		ValaDataType* _tmp64_;
++		ValaTypeSymbol* _tmp65_;
++		ValaTypeSymbol* _tmp66_;
+ 		ValaCCodeFunctionCall* _tmp71_;
+ 		ValaCCodeExpression* _tmp72_;
+ 		ValaCodeContext* _tmp73_;
+@@ -3170,35 +3174,31 @@ vala_ccode_array_module_generate_array_d
+ 		}
+ 		_tmp57_ = vala_ccode_identifier_new ("length");
+ 		length_expr = (ValaCCodeExpression*) _tmp57_;
+-		_tmp59_ = vala_array_type_get_element_type (array_type);
++		_tmp58_ = length_expr;
++		_tmp59_ = vala_ccode_constant_new ("1");
+ 		_tmp60_ = _tmp59_;
+-		_tmp61_ = vala_data_type_get_type_symbol (_tmp60_);
+-		_tmp62_ = _tmp61_;
+-		if (_tmp62_ != NULL) {
+-			ValaDataType* _tmp63_;
+-			ValaDataType* _tmp64_;
+-			ValaTypeSymbol* _tmp65_;
+-			ValaTypeSymbol* _tmp66_;
+-			_tmp63_ = vala_array_type_get_element_type (array_type);
+-			_tmp64_ = _tmp63_;
+-			_tmp65_ = vala_data_type_get_type_symbol (_tmp64_);
+-			_tmp66_ = _tmp65_;
+-			_tmp58_ = vala_typesymbol_is_reference_type (_tmp66_);
++		_tmp61_ = vala_ccode_binary_expression_new (VALA_CCODE_BINARY_OPERATOR_PLUS, _tmp58_, (ValaCCodeExpression*) _tmp60_);
++		_vala_ccode_node_unref0 (length_expr);
++		length_expr = (ValaCCodeExpression*) _tmp61_;
++		_vala_ccode_node_unref0 (_tmp60_);
++		_tmp63_ = vala_array_type_get_element_type (array_type);
++		_tmp64_ = _tmp63_;
++		_tmp65_ = vala_data_type_get_type_symbol (_tmp64_);
++		_tmp66_ = _tmp65_;
++		if (_tmp66_ != NULL) {
++			ValaDataType* _tmp67_;
++			ValaDataType* _tmp68_;
++			ValaTypeSymbol* _tmp69_;
++			ValaTypeSymbol* _tmp70_;
++			_tmp67_ = vala_array_type_get_element_type (array_type);
++			_tmp68_ = _tmp67_;
++			_tmp69_ = vala_data_type_get_type_symbol (_tmp68_);
++			_tmp70_ = _tmp69_;
++			_tmp62_ = vala_typesymbol_is_reference_type (_tmp70_);
+ 		} else {
+-			_tmp58_ = FALSE;
++			_tmp62_ = FALSE;
+ 		}
+-		if (_tmp58_) {
+-			ValaCCodeExpression* _tmp67_;
+-			ValaCCodeConstant* _tmp68_;
+-			ValaCCodeConstant* _tmp69_;
+-			ValaCCodeBinaryExpression* _tmp70_;
+-			_tmp67_ = length_expr;
+-			_tmp68_ = vala_ccode_constant_new ("1");
+-			_tmp69_ = _tmp68_;
+-			_tmp70_ = vala_ccode_binary_expression_new (VALA_CCODE_BINARY_OPERATOR_PLUS, _tmp67_, (ValaCCodeExpression*) _tmp69_);
+-			_vala_ccode_node_unref0 (length_expr);
+-			length_expr = (ValaCCodeExpression*) _tmp70_;
+-			_vala_ccode_node_unref0 (_tmp69_);
++		if (_tmp62_) {
+ 			length_check_op = VALA_CCODE_BINARY_OPERATOR_GREATER_THAN_OR_EQUAL;
+ 		} else {
+ 			length_check_op = VALA_CCODE_BINARY_OPERATOR_GREATER_THAN;
+
+--- a/tests/arrays/empty-length-0.c-expected
++++ b/tests/arrays/empty-length-0.c-expected
+@@ -215,7 +215,7 @@ _vala_array_dup3 (Manam* self,
+ 	if (length > 0) {
+ 		Manam* result;
+ 		gssize i;
+-		result = g_new0 (Manam, length);
++		result = g_new0 (Manam, length + 1);
+ 		for (i = 0; i < length; i++) {
+ 			Manam _tmp0_;
+ 			Manam _tmp1_ = {0};
+--- a/tests/generics/arrays.c-expected
++++ b/tests/generics/arrays.c-expected
+@@ -131,7 +131,7 @@ _vala_array_dup1 (gpointer* self,
+ 	if (length > 0) {
+ 		gpointer* result;
+ 		gssize i;
+-		result = g_new0 (gpointer, length);
++		result = g_new0 (gpointer, length + 1);
+ 		for (i = 0; i < length; i++) {
+ 			gpointer _tmp0_;
+ 			_tmp0_ = ((self[i] != NULL) && (g_dup_func != NULL)) ? g_dup_func ((gpointer) self[i]) : ((gpointer) self[i]);
+@@ -426,7 +426,7 @@ _vala_array_dup2 (gpointer* self,
+ 	if (length > 0) {
+ 		gpointer* result;
+ 		gssize i;
+-		result = g_new0 (gpointer, length);
++		result = g_new0 (gpointer, length + 1);
+ 		for (i = 0; i < length; i++) {
+ 			gpointer _tmp0_;
+ 			_tmp0_ = ((self[i] != NULL) && (g_dup_func != NULL)) ? g_dup_func ((gpointer) self[i]) : ((gpointer) self[i]);
+--- a/tests/posix/empty-length-0.c-expected
++++ b/tests/posix/empty-length-0.c-expected
+@@ -197,7 +197,7 @@ _vala_array_dup3 (Manam* self,
+ 	if (length > 0) {
+ 		Manam* result;
+ 		ssize_t i;
+-		result = calloc (length, sizeof (Manam));
++		result = calloc (length + 1, sizeof (Manam));
+ 		for (i = 0; i < length; i++) {
+ 			Manam _tmp0_;
+ 			Manam _tmp1_ = {0};
+--- a/tests/objects/property-array.c-expected
++++ b/tests/objects/property-array.c-expected
+@@ -316,7 +316,7 @@ _vala_array_dup1 (Manam** self,
+ 	if (length > 0) {
+ 		Manam** result;
+ 		gssize i;
+-		result = g_new0 (Manam*, length);
++		result = g_new0 (Manam*, length + 1);
+ 		for (i = 0; i < length; i++) {
+ 			Manam* _tmp0_;
+ 			_tmp0_ = _manam_dup0 (self[i]);
+@@ -398,7 +398,7 @@ _vala_array_dup2 (Manam** self,
+ 	if (length > 0) {
+ 		Manam** result;
+ 		gssize i;
+-		result = g_new0 (Manam*, length);
++		result = g_new0 (Manam*, length + 1);
+ 		for (i = 0; i < length; i++) {
+ 			Manam* _tmp0_;
+ 			_tmp0_ = _manam_dup0 (self[i]);
+@@ -446,7 +446,7 @@ _vala_array_dup3 (Manam** self,
+ 	if (length > 0) {
+ 		Manam** result;
+ 		gssize i;
+-		result = g_new0 (Manam*, length);
++		result = g_new0 (Manam*, length + 1);
+ 		for (i = 0; i < length; i++) {
+ 			Manam* _tmp0_;
+ 			_tmp0_ = _manam_dup0 (self[i]);
+@@ -515,7 +515,7 @@ _vala_array_dup4 (Manam** self,
+ 	if (length > 0) {
+ 		Manam** result;
+ 		gssize i;
+-		result = g_new0 (Manam*, length);
++		result = g_new0 (Manam*, length + 1);
+ 		for (i = 0; i < length; i++) {
+ 			Manam* _tmp0_;
+ 			_tmp0_ = _manam_dup0 (self[i]);
+@@ -908,7 +908,7 @@ _vala_array_dup7 (Manam** self,
+ 	if (length > 0) {
+ 		Manam** result;
+ 		gssize i;
+-		result = g_new0 (Manam*, length);
++		result = g_new0 (Manam*, length + 1);
+ 		for (i = 0; i < length; i++) {
+ 			Manam* _tmp0_;
+ 			_tmp0_ = _manam_dup0 (self[i]);
+@@ -982,7 +982,7 @@ _vala_array_dup8 (Manam** self,
+ 	if (length > 0) {
+ 		Manam** result;
+ 		gssize i;
+-		result = g_new0 (Manam*, length);
++		result = g_new0 (Manam*, length + 1);
+ 		for (i = 0; i < length; i++) {
+ 			Manam* _tmp0_;
+ 			_tmp0_ = _manam_dup0 (self[i]);
diff --git a/srcpkgs/vala/template b/srcpkgs/vala/template
index 87599d409396e2..10f902a08be477 100644
--- a/srcpkgs/vala/template
+++ b/srcpkgs/vala/template
@@ -1,8 +1,8 @@
 # Template file for 'vala'
 pkgname=vala
 # Should be kept in sync with 'valadoc' (shared distfiles)
-version=0.56.16
-revision=2
+version=0.56.17
+revision=1
 build_style=gnu-configure
 configure_args="--disable-valadoc GI_GIRDIR=/usr/share/gir-1.0"
 hostmakedepends="flex libxslt pkg-config automake libtool"
@@ -14,7 +14,7 @@ license="LGPL-2.1-or-later"
 homepage="https://wiki.gnome.org/Projects/Vala"
 changelog="https://gitlab.gnome.org/GNOME/vala/raw/master/NEWS"
 distfiles="${GNOME_SITE}/vala/${version%.*}/vala-${version}.tar.xz"
-checksum=05487b5600f5d2f09e66a753cccd8f39c1bff9f148aea1b7774d505b9c8bca9b
+checksum=26100c4e4ef0049c619275f140d97cf565883d00c7543c82bcce5a426934ed6a
 shlib_provides="libvalaccodegen.so"
 make_check=extended # take a lot of time
 

From 198f376e0b2c7993083a0853aa2da78ed9fc3cbb Mon Sep 17 00:00:00 2001
From: RangHo Lee <hello@rangho.me>
Date: Wed, 22 Jan 2025 03:19:24 +0900
Subject: [PATCH 2/2] valadoc: update to 0.56.17.

---
 srcpkgs/valadoc/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/valadoc/template b/srcpkgs/valadoc/template
index fcad4327110ea8..1cbf8158b53914 100644
--- a/srcpkgs/valadoc/template
+++ b/srcpkgs/valadoc/template
@@ -1,8 +1,8 @@
 # Template file for 'valadoc'
 pkgname=valadoc
 # Should be kept in sync with 'vala' (shared distfiles)
-version=0.56.16
-revision=2
+version=0.56.17
+revision=1
 build_style=gnu-configure
 configure_args="--with-cgraph=yes GI_GIRDIR=/usr/share/gir-1.0"
 hostmakedepends="flex libxslt pkg-config automake libtool vala"
@@ -15,7 +15,7 @@ license="LGPL-2.1-or-later"
 homepage="https://wiki.gnome.org/Projects/Vala"
 changelog="https://gitlab.gnome.org/GNOME/vala/raw/master/NEWS"
 distfiles="${GNOME_SITE}/vala/${version%.*}/vala-${version}.tar.xz"
-checksum=05487b5600f5d2f09e66a753cccd8f39c1bff9f148aea1b7774d505b9c8bca9b
+checksum=26100c4e4ef0049c619275f140d97cf565883d00c7543c82bcce5a426934ed6a
 
 pre_configure() {
 	autoreconf -if

Re: vala, valadoc: update to 0.56.17

[RangHo]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New comment by RangHo on void-packages repository

https://github.com/void-linux/void-packages/pull/53689#issuecomment-2605447879

Comment:
I just confirmed that all tests pass without problem with the patch above, and separated the commits into two.

Now ready for final check in the CI!

Re: [PR PATCH] [Merged]: vala, valadoc: update to 0.56.17

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

There's a merged pull request on the void-packages repository

vala, valadoc: update to 0.56.17
https://github.com/void-linux/void-packages/pull/53689

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, `x86_64-glibc`.