[PR PATCH] fplll: update to 5.5.0, python3-fpylll: update to 0.6.2.

[PR PATCH] fplll: update to 5.5.0, python3-fpylll: update to 0.6.2.

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages fplll
https://github.com/void-linux/void-packages/pull/53702

fplll: update to 5.5.0, python3-fpylll: update to 0.6.2.
- **fplll: update to 5.5.0.**
- **python3-fpylll: update to 0.6.2.**

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly** (tested with sagemath 10.5 from #51902)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/53702.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fplll-53702.patch --]
[-- Type: text/x-diff, Size: 3021 bytes --]

From 075af82c07047a09d79c99d90258e8a8cf17515f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 23 Dec 2024 16:32:21 -0300
Subject: [PATCH 1/2] fplll: update to 5.5.0.

---
 common/shlibs          | 2 +-
 srcpkgs/fplll/template | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index 4c9648fb36190b..879241cfb98c25 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -87,7 +87,7 @@ libt3widget.so.2 libt3widget-1.2.2_1
 libtranscript.so.1 libtranscript-0.3.3_1
 libnetcdf.so.19 netcdf-4.9.2_1
 libformw.so.6 ncurses-libs-5.8_1 ignore
-libfplll.so.8 fplll-5.4.4_1
+libfplll.so.9 fplll-5.5.0_1
 libpanelw.so.6 ncurses-libs-5.8_1 ignore
 libmenuw.so.6 ncurses-libs-5.8_1 ignore
 libobjc.so.4 libobjc-4.7.3_12
diff --git a/srcpkgs/fplll/template b/srcpkgs/fplll/template
index 74fb8744ef51ad..2f8c13ce29c1e8 100644
--- a/srcpkgs/fplll/template
+++ b/srcpkgs/fplll/template
@@ -1,6 +1,6 @@
 # Template file for 'fplll'
 pkgname=fplll
-version=5.4.5
+version=5.5.0
 revision=1
 build_style=gnu-configure
 makedepends="gmp-devel mpfr-devel"
@@ -10,7 +10,7 @@ license="LGPL-2.1-or-later"
 homepage="https://github.com/fplll/fplll"
 changelog="https://github.com/fplll/fplll/releases"
 distfiles="https://github.com/fplll/fplll/releases/download/${version}/fplll-${version}.tar.gz"
-checksum=76d3778f0326597ed7505bab19493a9bf6b73a5c5ca614e8fb82f42105c57d00
+checksum=f0af6bdd0ebd5871e87ff3ef7737cb5360b1e38181a4e5a8c1236f3476fec3b2
 
 fplll-devel_package() {
 	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"

From dc685003459c3df256568b3abd73be3939147be5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 23 Dec 2024 15:59:35 -0300
Subject: [PATCH 2/2] python3-fpylll: update to 0.6.2.

---
 srcpkgs/python3-fpylll/template | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/python3-fpylll/template b/srcpkgs/python3-fpylll/template
index 10cf315f00d771..54612c9a90f663 100644
--- a/srcpkgs/python3-fpylll/template
+++ b/srcpkgs/python3-fpylll/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-fpylll'
 pkgname=python3-fpylll
-version=0.6.1
-revision=2
+version=0.6.2
+revision=1
 build_style=python3-pep517
 hostmakedepends="python3-setuptools python3-wheel python3-Cython
  python3-cysignals"
@@ -14,9 +14,13 @@ license="GPL-2.0-or-later"
 homepage="https://github.com/fplll/fpylll"
 changelog="https://github.com/fplll/fpylll/releases"
 distfiles="${PYPI_SITE}/f/fpylll/fpylll-${version}.tar.gz"
-checksum=dfd9529a26c50993a2a716177debd7994312219070574cad31b35b4f0c040a19
+checksum=d5b2f250afb6fb2f9c70e03ffe1169ff6f2e167e348da1328cc20b693b915fbe
 make_check_pre="env PY_IGNORE_IMPORTMISMATCH=1"
 
+post_patch() {
+	vsed -i -e s/"cysignals<1.12.0"/"cysignals"/ pyproject.toml
+}
+
 case $XBPS_TARGET_MACHINE in
 	# skip a test with numerical noise on 32 bit
 	i686*) make_check_args="-k not(averaged_simulate_prob)" ;;

Re: [PR REVIEW] fplll: update to 5.5.0, python3-fpylll: update to 0.6.2.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 522 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/53702#discussion_r1901018350

Comment:
We generally prefer that `vsed` be reserved for patches that depend on runtime conditions like per-architecture flags. I suggest making this change as a proper patch. Alternatively, just pass `--skip-dependency-check` in `make_build_args`. I've given up the fight in `python3-scipy` and a few other packages that abuse these version restrictions. It's not worth the hassle.

Re: [PR REVIEW] fplll: update to 5.5.0, python3-fpylll: update to 0.6.2.

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]

New review comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/53702#discussion_r1901113238

Comment:
I don't mind this here at all, but let me mention one reason to do it this way: this is a very semantic change (replace a dependency on "cysignals<1.12.0" by a dependency on "cysignals") and easy to create. While a patch is very fragile due to the 3-line context, meaning if other dependencies change, or the order, etc, the patch needs to be edited, etc.

I know about `--skip-dependency-check`, which would work here but it seems too big a hammer. Maybe I still want to be warned about other dependencies that upstream adds in the future.

Moreover, policy now is that CI fails when we build a python package with missing dependencies. E.g. I had to disable `debugpy` dependency for ipykernel: https://github.com/void-linux/void-packages/blob/master/srcpkgs/python3-ipython_ipykernel/patches/disable-debugpy.patch this would be simpler as a `vsed`, in the sense that this patch will probably have to be adjusted every time. And I don't think `--skip-dependency-check` would work for that.

Anyway, for the current package, it's not a big deal since it updates slowly. And I didn't update cysignals in the end since 1.12 breaks other stuff (i.e. sagemath).

Re: [PR PATCH] [Updated] fplll: update to 5.5.0, python3-fpylll: update to 0.6.2.

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages fplll
https://github.com/void-linux/void-packages/pull/53702

fplll: update to 5.5.0, python3-fpylll: update to 0.6.2.
- **fplll: update to 5.5.0.**
- **python3-fpylll: update to 0.6.2.**

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly** (tested with sagemath 10.5 from #51902)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/53702.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fplll-53702.patch --]
[-- Type: text/x-diff, Size: 2946 bytes --]

From 979e071cf9f659480e5206ac43a755f7e305a6a2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 23 Dec 2024 16:32:21 -0300
Subject: [PATCH 1/2] fplll: update to 5.5.0.

---
 common/shlibs          | 2 +-
 srcpkgs/fplll/template | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/shlibs b/common/shlibs
index befb37d1b1e5ad..e265df273d86f4 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -87,7 +87,7 @@ libt3widget.so.2 libt3widget-1.2.2_1
 libtranscript.so.1 libtranscript-0.3.3_1
 libnetcdf.so.19 netcdf-4.9.2_1
 libformw.so.6 ncurses-libs-5.8_1 ignore
-libfplll.so.8 fplll-5.4.4_1
+libfplll.so.9 fplll-5.5.0_1
 libpanelw.so.6 ncurses-libs-5.8_1 ignore
 libmenuw.so.6 ncurses-libs-5.8_1 ignore
 libobjc.so.4 libobjc-4.7.3_12
diff --git a/srcpkgs/fplll/template b/srcpkgs/fplll/template
index 74fb8744ef51ad..2f8c13ce29c1e8 100644
--- a/srcpkgs/fplll/template
+++ b/srcpkgs/fplll/template
@@ -1,6 +1,6 @@
 # Template file for 'fplll'
 pkgname=fplll
-version=5.4.5
+version=5.5.0
 revision=1
 build_style=gnu-configure
 makedepends="gmp-devel mpfr-devel"
@@ -10,7 +10,7 @@ license="LGPL-2.1-or-later"
 homepage="https://github.com/fplll/fplll"
 changelog="https://github.com/fplll/fplll/releases"
 distfiles="https://github.com/fplll/fplll/releases/download/${version}/fplll-${version}.tar.gz"
-checksum=76d3778f0326597ed7505bab19493a9bf6b73a5c5ca614e8fb82f42105c57d00
+checksum=f0af6bdd0ebd5871e87ff3ef7737cb5360b1e38181a4e5a8c1236f3476fec3b2
 
 fplll-devel_package() {
 	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"

From d0ba30e7d34364a77c749878744780a73979a53e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 23 Dec 2024 15:59:35 -0300
Subject: [PATCH 2/2] python3-fpylll: update to 0.6.2.

---
 srcpkgs/python3-fpylll/template | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/srcpkgs/python3-fpylll/template b/srcpkgs/python3-fpylll/template
index 10cf315f00d771..56cd75d5603b4c 100644
--- a/srcpkgs/python3-fpylll/template
+++ b/srcpkgs/python3-fpylll/template
@@ -1,7 +1,7 @@
 # Template file for 'python3-fpylll'
 pkgname=python3-fpylll
-version=0.6.1
-revision=2
+version=0.6.2
+revision=1
 build_style=python3-pep517
 hostmakedepends="python3-setuptools python3-wheel python3-Cython
  python3-cysignals"
@@ -14,10 +14,4 @@ license="GPL-2.0-or-later"
 homepage="https://github.com/fplll/fpylll"
 changelog="https://github.com/fplll/fpylll/releases"
 distfiles="${PYPI_SITE}/f/fpylll/fpylll-${version}.tar.gz"
-checksum=dfd9529a26c50993a2a716177debd7994312219070574cad31b35b4f0c040a19
-make_check_pre="env PY_IGNORE_IMPORTMISMATCH=1"
-
-case $XBPS_TARGET_MACHINE in
-	# skip a test with numerical noise on 32 bit
-	i686*) make_check_args="-k not(averaged_simulate_prob)" ;;
-esac
+checksum=d5b2f250afb6fb2f9c70e03ffe1169ff6f2e167e348da1328cc20b693b915fbe

Re: [PR REVIEW] fplll: update to 5.5.0, python3-fpylll: update to 0.6.2.

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

New review comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/53702#discussion_r1901124194

Comment:
... and I pushed a new version without the vsed

Re: [PR REVIEW] fplll: update to 5.5.0, python3-fpylll: update to 0.6.2.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/53702#discussion_r1901416909

Comment:
Yes, disabling checks is a big hammer, but I've received such pushback from upstreams when I complain about how they abuse these version restrictions that I've decided to swing it.

Fragility of the patch is a feature. Changes will be immediately obvious and spur contributors to consider whether ignoring upper bounds is appropriate when the dependency list changes. Patching with `vsed` can subtly fail when changes to the dependency result in a failure to match. In CI, this is a hard error, but local testers might overlook the default behavior of simply warning when `vsed` makes no changes.

Re: [PR PATCH] [Merged]: fplll: update to 5.5.0, python3-fpylll: update to 0.6.2.

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]

There's a merged pull request on the void-packages repository

fplll: update to 5.5.0, python3-fpylll: update to 0.6.2.
https://github.com/void-linux/void-packages/pull/53702

Description:
- **fplll: update to 5.5.0.**
- **python3-fpylll: update to 0.6.2.**

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly** (tested with sagemath 10.5 from #51902)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->