Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] SDL: update to 1.2.68
@ 2024-12-30 11:00 ii8
  2024-12-30 21:50 ` classabbyamp
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: ii8 @ 2024-12-30 11:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 853 bytes --]

There is a new pull request by ii8 against master on the void-packages repository

https://github.com/ii8/void-packages sdl12-compat
https://github.com/void-linux/void-packages/pull/53761

SDL: update to 1.2.68
This upgrade switches the legacy SDL to sdl12-compat as recommended by the SDL developers.
Pros are: It's maintained and gets fixes, sdl 1.2 applications work on wayland with this, it's simpler and requires less disk space. As far as I can tell there are no downsides.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64 musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l
  - armv6l-musl

A patch file from https://github.com/void-linux/void-packages/pull/53761.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sdl12-compat-53761.patch --]
[-- Type: text/x-diff, Size: 15690 bytes --]

From ecdd79e200b45bc5b3304fec72c2ac733974c1f5 Mon Sep 17 00:00:00 2001
From: ii8 <murray.calavera@protonmail.com>
Date: Mon, 30 Dec 2024 10:35:15 +0000
Subject: [PATCH] SDL: update to 1.2.68

---
 .../patches/SDL-1.2.10-GrabNotViewable.patch  |  22 -
 srcpkgs/SDL/patches/SDL-1.2.12-multilib.patch |  24 --
 srcpkgs/SDL/patches/SDL-1.2.15-sndio.patch    | 375 ------------------
 srcpkgs/SDL/template                          |  43 +-
 4 files changed, 15 insertions(+), 449 deletions(-)
 delete mode 100644 srcpkgs/SDL/patches/SDL-1.2.10-GrabNotViewable.patch
 delete mode 100644 srcpkgs/SDL/patches/SDL-1.2.12-multilib.patch
 delete mode 100644 srcpkgs/SDL/patches/SDL-1.2.15-sndio.patch

diff --git a/srcpkgs/SDL/patches/SDL-1.2.10-GrabNotViewable.patch b/srcpkgs/SDL/patches/SDL-1.2.10-GrabNotViewable.patch
deleted file mode 100644
index a05c37044c68ca..00000000000000
--- a/srcpkgs/SDL/patches/SDL-1.2.10-GrabNotViewable.patch
+++ /dev/null
@@ -1,22 +0,0 @@
-Makes SDL-1.2 SDL_WM_GrabInput() non-blocking in case of SDL window is not
-viewable. Patch provided by <pbonzini@redhat.com>.
-See <http://bugzilla.libsdl.org/show_bug.cgi?id=1155>.
-
---- a/src/video/x11/SDL_x11wm.c	2007-12-31 04:48:13.000000000 +0000
-+++ b/src/video/x11/SDL_x11wm.c	2009-01-15 10:27:14.000000000 +0000
-@@ -351,13 +351,14 @@ SDL_GrabMode X11_GrabInputNoLock(_THIS, 
- 			result = XGrabPointer(SDL_Display, SDL_Window, True, 0,
- 						GrabModeAsync, GrabModeAsync,
- 						SDL_Window, None, CurrentTime);
--			if ( result == GrabSuccess ) {
-+			if ( result == GrabSuccess || result == GrabNotViewable ) {
- 				break;
- 			}
- 			SDL_Delay(100);
- 		}
- 		if ( result != GrabSuccess ) {
- 			/* Uh, oh, what do we do here? */ ;
-+			return(SDL_GRAB_OFF);
- 		}
- 		/* Now grab the keyboard */
- 		XGrabKeyboard(SDL_Display, WMwindow, True,
diff --git a/srcpkgs/SDL/patches/SDL-1.2.12-multilib.patch b/srcpkgs/SDL/patches/SDL-1.2.12-multilib.patch
deleted file mode 100644
index 5afa0a4059f91e..00000000000000
--- a/srcpkgs/SDL/patches/SDL-1.2.12-multilib.patch
+++ /dev/null
@@ -1,24 +0,0 @@
---- a/sdl-config.in.multilib	2007-07-20 07:52:45.000000000 +0200
-+++ b/sdl-config.in	2007-11-06 17:07:25.000000000 +0100
-@@ -3,7 +3,6 @@
- prefix=@prefix@
- exec_prefix=@exec_prefix@
- exec_prefix_set=no
--libdir=@libdir@
- 
- @ENABLE_STATIC_FALSE@usage="\
- @ENABLE_STATIC_FALSE@Usage: sdl-config [--prefix[=DIR]] [--exec-prefix[=DIR]] [--version] [--cflags] [--libs]"
-@@ -45,11 +44,11 @@ while test $# -gt 0; do
-       echo -I@includedir@/SDL @SDL_CFLAGS@
-       ;;
- @ENABLE_SHARED_TRUE@    --libs)
--@ENABLE_SHARED_TRUE@      echo -L@libdir@ @SDL_RLD_FLAGS@ @SDL_LIBS@
-+@ENABLE_SHARED_TRUE@      echo @SDL_RLD_FLAGS@ @SDL_LIBS@
- @ENABLE_SHARED_TRUE@      ;;
- @ENABLE_STATIC_TRUE@@ENABLE_SHARED_TRUE@    --static-libs)
- @ENABLE_STATIC_TRUE@@ENABLE_SHARED_FALSE@    --libs|--static-libs)
--@ENABLE_STATIC_TRUE@      echo -L@libdir@ @SDL_RLD_FLAGS@ @SDL_STATIC_LIBS@
-+@ENABLE_STATIC_TRUE@      echo @SDL_RLD_FLAGS@ @SDL_STATIC_LIBS@
- @ENABLE_STATIC_TRUE@      ;;
-     *)
-       echo "${usage}" 1>&2
diff --git a/srcpkgs/SDL/patches/SDL-1.2.15-sndio.patch b/srcpkgs/SDL/patches/SDL-1.2.15-sndio.patch
deleted file mode 100644
index 94d13f9223001e..00000000000000
--- a/srcpkgs/SDL/patches/SDL-1.2.15-sndio.patch
+++ /dev/null
@@ -1,375 +0,0 @@
---- a/configure        2012-01-19 07:30:12.000000000 +0100
-+++ b/configure  2018-11-27 22:58:07.344753821 +0100
-@@ -1514,6 +1514,7 @@
-   --disable-esdtest       Do not try to compile and run a test ESD program
-   --enable-esd-shared     dynamically load ESD audio support [default=yes]
-   --enable-pulseaudio     use PulseAudio [default=yes]
-+  --enable-sndio          use SNDIO [default=yes]
-   --enable-pulseaudio-shared
-                           dynamically load PulseAudio support [default=yes]
-   --enable-arts           support the Analog Real Time Synthesizer
-@@ -21000,6 +21001,23 @@
-     fi
- }
-
-+CheckSndio()
-+{
-+# Check whether --enable-sndio was given.
-+if test "${enable_sndio+set}" = set; then
-+  enableval=$enable_sndio;
-+else
-+  enable_sndio=yes
-+fi
-+
-+if test "x${enable_sndio}" = "xyes"; then :
-+  SOURCES="$SOURCES $srcdir/src/audio/sndio/SDL_sndioaudio.c"
-+  EXTRA_CFLAGS="$EXTRA_CFLAGS -DSDL_AUDIO_DRIVER_SNDIO=1"
-+  EXTRA_LDFLAGS="$EXTRA_LDFLAGS -lsndio"
-+  have_audio=yes
-+fi
-+}
-+
- CheckPulseAudio()
- {
-     # Check whether --enable-pulseaudio was given.
-@@ -29550,6 +29568,7 @@
-         CheckMME
-         CheckALSA
-         CheckARTSC
-+        CheckSndio
-         CheckESD
-         CheckPulseAudio
-         CheckNAS
---- a/include/SDL_config.h.in	2018-11-27 21:52:07.645177938 +0100
-+++ b/include/SDL_config.h.in	2018-11-27 22:03:06.217107399 +0100
-@@ -184,6 +184,7 @@
- #undef SDL_AUDIO_DRIVER_QNXNTO
- #undef SDL_AUDIO_DRIVER_SNDMGR
- #undef SDL_AUDIO_DRIVER_SUNAUDIO
-+#undef SDL_AUDIO_DRIVER_SNDIO
- #undef SDL_AUDIO_DRIVER_WAVEOUT
- 
- /* Enable various cdrom drivers */
---- a/src/audio/SDL_audio.c	2018-11-27 21:52:07.646177937 +0100
-+++ b/src/audio/SDL_audio.c	2018-11-27 22:04:37.977097571 +0100
-@@ -42,6 +42,9 @@
- #if SDL_AUDIO_DRIVER_ALSA
- 	&ALSA_bootstrap,
- #endif
-+#if SDL_AUDIO_DRIVER_SNDIO
-+	&SNDIO_bootstrap,
-+#endif
- #if SDL_AUDIO_DRIVER_BSD
- 	&BSD_AUDIO_bootstrap,
- #endif
---- a/src/audio/SDL_sysaudio.h	2018-11-27 21:52:07.647177937 +0100
-+++ b/src/audio/SDL_sysaudio.h	2018-11-27 22:05:13.697093745 +0100
-@@ -105,6 +105,9 @@
- #if SDL_AUDIO_DRIVER_BSD
- extern AudioBootStrap BSD_AUDIO_bootstrap;
- #endif
-+#if SDL_AUDIO_DRIVER_SNDIO
-+extern AudioBootStrap SNDIO_bootstrap;
-+#endif
- #if SDL_AUDIO_DRIVER_PULSE
- extern AudioBootStrap PULSE_bootstrap;
- #endif
---- a/src/audio/sndio/SDL_sndioaudio.c	1970-01-01 01:00:00.000000000 +0100
-+++ b/src/audio/sndio/SDL_sndioaudio.c	2013-12-19 10:24:18.000000000 +0100
-@@ -0,0 +1,243 @@
-+/*
-+ * Copyright (c) 2008 Jacob Meuser <jakemsr@sdf.lonestar.org>
-+ *
-+ * Permission to use, copy, modify, and distribute this software for any
-+ * purpose with or without fee is hereby granted, provided that the above
-+ * copyright notice and this permission notice appear in all copies.
-+ *
-+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
-+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
-+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
-+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
-+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
-+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
-+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
-+ */
-+
-+#include "SDL_config.h"
-+
-+/* Allow access to a raw mixing buffer */
-+
-+#ifdef HAVE_SIGNAL_H
-+#include <signal.h>
-+#endif
-+#include <unistd.h>
-+
-+#include "SDL_timer.h"
-+#include "SDL_audio.h"
-+#include "../SDL_audiomem.h"
-+#include "../SDL_audio_c.h"
-+#include "../SDL_audiodev_c.h"
-+#include "SDL_sndioaudio.h"
-+
-+/* The tag name used by sndio audio */
-+#define SNDIO_DRIVER_NAME         "sndio"
-+
-+/* Audio driver functions */
-+static int SNDIO_OpenAudio(_THIS, SDL_AudioSpec *spec);
-+static void SNDIO_WaitAudio(_THIS);
-+static void SNDIO_PlayAudio(_THIS);
-+static Uint8 *SNDIO_GetAudioBuf(_THIS);
-+static void SNDIO_CloseAudio(_THIS);
-+
-+/* Audio driver bootstrap functions */
-+
-+static int Audio_Available(void)
-+{
-+	struct sio_hdl *this_hdl;
-+	int available = 0;
-+
-+	if ( (this_hdl = sio_open(SIO_DEVANY, SIO_PLAY, 0)) != NULL ) {
-+		sio_close(this_hdl);
-+		available = 1;
-+	}
-+
-+	return available;
-+}
-+
-+static void Audio_DeleteDevice(SDL_AudioDevice *device)
-+{
-+	SDL_free(device->hidden);
-+	SDL_free(device);
-+}
-+
-+static SDL_AudioDevice *Audio_CreateDevice(int devindex)
-+{
-+	SDL_AudioDevice *this;
-+
-+	/* Initialize all variables that we clean on shutdown */
-+	this = (SDL_AudioDevice *)SDL_malloc(sizeof(SDL_AudioDevice));
-+	if ( this ) {
-+		SDL_memset(this, 0, (sizeof *this));
-+		this->hidden = (struct SDL_PrivateAudioData *)
-+				SDL_malloc((sizeof *this->hidden));
-+	}
-+	if ( (this == NULL) || (this->hidden == NULL) ) {
-+		SDL_OutOfMemory();
-+		if ( this ) {
-+			SDL_free(this);
-+		}
-+		return(0);
-+	}
-+	SDL_memset(this->hidden, 0, (sizeof *this->hidden));
-+
-+	/* Set the function pointers */
-+	this->OpenAudio = SNDIO_OpenAudio;
-+	this->WaitAudio = SNDIO_WaitAudio;
-+	this->PlayAudio = SNDIO_PlayAudio;
-+	this->GetAudioBuf = SNDIO_GetAudioBuf;
-+	this->CloseAudio = SNDIO_CloseAudio;
-+
-+	this->free = Audio_DeleteDevice;
-+
-+	hdl = NULL;
-+
-+	return this;
-+}
-+
-+AudioBootStrap SNDIO_bootstrap = {
-+	SNDIO_DRIVER_NAME, "sndio",
-+	Audio_Available, Audio_CreateDevice
-+};
-+
-+
-+
-+/* This function waits until it is possible to write a full sound buffer */
-+static void SNDIO_WaitAudio(_THIS)
-+{
-+	/* nothing, we're using the blocking api */
-+}
-+
-+static void SNDIO_PlayAudio(_THIS)
-+{
-+	int written;
-+
-+	/* Write the audio data */
-+	written = sio_write(hdl, mixbuf, mixlen);
-+	
-+	/* If we couldn't write, assume fatal error for now */
-+	if ( written == 0 ) {
-+		this->enabled = 0;
-+	}
-+#ifdef DEBUG_AUDIO
-+	fprintf(stderr, "Wrote %d bytes of audio data\n", written);
-+#endif
-+}
-+
-+static Uint8 *SNDIO_GetAudioBuf(_THIS)
-+{
-+	return(mixbuf);
-+}
-+
-+static void SNDIO_CloseAudio(_THIS)
-+{
-+	if ( mixbuf != NULL ) {
-+		SDL_FreeAudioMem(mixbuf);
-+		mixbuf = NULL;
-+	}
-+	if ( hdl != NULL ) {
-+		sio_close(hdl);
-+		hdl = NULL;
-+	}
-+}
-+
-+static int SNDIO_OpenAudio(_THIS, SDL_AudioSpec *spec)
-+{
-+	struct sio_par par;
-+
-+	mixbuf = NULL;
-+
-+	if ((hdl = sio_open(NULL, SIO_PLAY, 0)) == NULL) {
-+		SDL_SetError("sio_open() failed");
-+		return(-1);
-+	}
-+
-+	sio_initpar(&par);
-+
-+	switch (spec->format) {
-+	case AUDIO_S16LSB:
-+		par.bits = 16;
-+		par.sig = 1;
-+		par.le = 1;
-+		break;
-+	case AUDIO_S16MSB:
-+		par.bits = 16;
-+		par.sig = 1;
-+		par.le = 0;
-+		break;
-+	case AUDIO_S8:
-+		par.bits = 8;
-+		par.sig = 1;
-+		break;
-+	case AUDIO_U16LSB:
-+		par.bits = 16;
-+		par.sig = 0;
-+		par.le = 1;
-+		break;
-+	case AUDIO_U16MSB:
-+		par.bits = 16;
-+		par.sig = 0;
-+		par.le = 0;
-+		break;
-+	case AUDIO_U8:
-+		par.bits = 8;
-+		par.sig = 0;
-+		break;
-+	default:
-+		SDL_SetError("SNDIO unknown format");
-+		return(-1);
-+	}
-+
-+	par.rate = spec->freq;
-+	par.pchan = spec->channels;
-+	par.round = spec->samples;
-+	par.appbufsz = par.round * 2;
-+
-+	if (sio_setpar(hdl, &par) == 0) {
-+		SDL_SetError("sio_setpar() failed");
-+		return(-1);
-+	}
-+
-+	if (sio_getpar(hdl, &par) == 0) {
-+		SDL_SetError("sio_getpar() failed");
-+		return(-1);
-+	}
-+
-+	if (par.bits == 16) {
-+		if (par.sig && par.le) {
-+			spec->format = AUDIO_S16LSB;
-+		} else if (par.sig && !par.le) {
-+			spec->format = AUDIO_S16MSB;
-+		} else if (!par.sig && par.le) {
-+			spec->format = AUDIO_U16LSB;
-+		} else 
-+			spec->format = AUDIO_U16MSB;
-+	} else if (par.bits == 8) {
-+		spec->format = par.sig ? AUDIO_S8 : AUDIO_U8;
-+	} else {
-+		SDL_SetError("SNDIO couldn't configure a suitable format");
-+		return(-1);
-+	}
-+
-+	spec->freq = par.rate;
-+	spec->channels = par.pchan;
-+	spec->samples = par.round;
-+
-+	SDL_CalculateAudioSpec(spec);
-+
-+	/* Allocate mixing buffer */
-+	mixlen = spec->size;
-+	mixbuf = (Uint8 *)SDL_AllocAudioMem(mixlen);
-+	if ( mixbuf == NULL ) {
-+		return(-1);
-+	}
-+	SDL_memset(mixbuf, spec->silence, spec->size);
-+
-+	if ( sio_start(hdl) == 0 ) {
-+		SDL_SetError("sio_start() failed");
-+		return(-1);
-+	}
-+
-+	/* We're ready to rock and roll. :-) */
-+	return(0);
-+}
---- a/src/audio/sndio/SDL_sndioaudio.h	1970-01-01 01:00:00.000000000 +0100
-+++ b/src/audio/sndio/SDL_sndioaudio.h	2013-12-15 02:57:55.000000000 +0100
-@@ -0,0 +1,50 @@
-+/*
-+ * Copyright (c) 2008 Jacob Meuser <jakemsr@sdf.lonestar.org>
-+ *
-+ * Permission to use, copy, modify, and distribute this software for any
-+ * purpose with or without fee is hereby granted, provided that the above
-+ * copyright notice and this permission notice appear in all copies.
-+ *
-+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
-+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
-+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
-+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
-+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
-+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
-+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
-+ */
-+
-+#include "SDL_config.h"
-+
-+#ifndef _SDL_sndioaudio_h
-+#define _SDL_sndioaudio_h
-+
-+#include <sndio.h>
-+
-+#include "../SDL_sysaudio.h"
-+
-+/* Hidden "this" pointer for the video functions */
-+#define _THIS	SDL_AudioDevice *this
-+
-+struct SDL_PrivateAudioData {
-+	/* The stream descriptor for the audio device */
-+	struct sio_hdl *hdl;
-+
-+	/* The parent process id, to detect when application quits */
-+	pid_t parent;
-+
-+	/* Raw mixing buffer */
-+	Uint8 *mixbuf;
-+	int    mixlen;
-+
-+};
-+
-+/* Old variable names */
-+#define stream			(this->hidden->stream)
-+#define parent			(this->hidden->parent)
-+#define mixbuf			(this->hidden->mixbuf)
-+#define mixlen			(this->hidden->mixlen)
-+#define hdl			(this->hidden->hdl)
-+
-+#endif /* _SDL_sndioaudio_h */
-+
diff --git a/srcpkgs/SDL/template b/srcpkgs/SDL/template
index ee8447047b42c8..59ea6452d71038 100644
--- a/srcpkgs/SDL/template
+++ b/srcpkgs/SDL/template
@@ -1,38 +1,25 @@
 # Template file for 'SDL'
 pkgname=SDL
-version=1.2.15
-revision=14
-build_style=gnu-configure
-configure_args="--enable-alsa --enable-sndio --disable-esd --disable-rpath
- --enable-clock_gettime --disable-nas --disable-arts --disable-x11-shared
- --disable-alsa-shared --disable-pulseaudio-shared --disable-video-dga
- --disable-osmesa-shared $(vopt_enable aalib video-aalib)
- $(vopt_enable pulseaudio) $(vopt_enable opengl video-opengl)
- $(vopt_if x11 '-enable-video-x11-xrandr --enable-video-x11-vm --enable-video-x11-xv')"
-hostmakedepends="pkg-config nasm"
-makedepends="alsa-lib-devel sndio-devel $(vopt_if x11 libXrandr-devel)
- $(vopt_if aalib aalib-devel) $(vopt_if opengl glu-devel)
- $(vopt_if pulseaudio pulseaudio-devel)"
-short_desc="Simple Directmedia Layer"
+version=1.2.68
+revision=1
+build_style=cmake
+configure_args="-DSTATICDEVEL=ON"
+hostmakedepends="pkg-config"
+makedepends="SDL2-devel"
+short_desc="SDL-1.2 compatibility layer that uses SDL 2.0 behind the scenes"
 maintainer="Orphaned <orphan@voidlinux.org>"
-license="LGPL-2.1-only"
-homepage="https://www.libsdl.org/"
-distfiles="https://www.libsdl.org/release/SDL-${version}.tar.gz"
-checksum=d6d316a793e5e348155f0dd93b979798933fb98aa1edebcc108829d6474aad00
+license="Zlib AND (Public Domain OR MIT-0)"
+homepage="https://github.com/libsdl-org/sdl12-compat"
+distfiles="https://github.com/libsdl-org/sdl12-compat/archive/refs/tags/release-${version}.tar.gz"
+checksum=63c6e4dcc1154299e6f363c872900be7f3dcb3e42b9f8f57e05442ec3d89d02d
 
-# Package build options
-build_options="x11 opengl aalib pulseaudio"
-build_options_default="x11 opengl pulseaudio"
-
-if [ "$build_option_opengl" ]; then
-	# libGL.so.1 is dynamically loaded with dlopen.
-	shlib_requires="libGL.so.1"
-	depends="virtual?libGL"
-fi
+post_install() {
+	vlicense LICENSE.txt
+}
 
 SDL-devel_package() {
 	short_desc+=" - development files"
-	depends="${makedepends} SDL>=${version}_${revision}"
+	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"
 	pkg_install() {
 		vmove usr/bin
 		vmove usr/include

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: SDL: update to 1.2.68
  2024-12-30 11:00 [PR PATCH] SDL: update to 1.2.68 ii8
@ 2024-12-30 21:50 ` classabbyamp
  2024-12-30 23:19 ` ii8
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: classabbyamp @ 2024-12-30 21:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/53761#issuecomment-2565949081

Comment:
What do other distros do with SDL1 vs SDL12-compat? maybe it would be better to create sdl12-compat as a separate package and transition all sdl1 packages to it?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: SDL: update to 1.2.68
  2024-12-30 11:00 [PR PATCH] SDL: update to 1.2.68 ii8
  2024-12-30 21:50 ` classabbyamp
@ 2024-12-30 23:19 ` ii8
  2024-12-30 23:56 ` ii8
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: ii8 @ 2024-12-30 23:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

New comment by ii8 on void-packages repository

https://github.com/void-linux/void-packages/pull/53761#issuecomment-2566001127

Comment:
Alpine and Arch have only sdl12-compat, no SDL package.

It might cause people problems if packages were gradually transitioned because it's tricky to have both SDL1 and sdl12-compat installed at the same time, they have the same files in the same places.

Could maybe add sdl12-compat as a separate package that has a `replaces="SDL>=0"` in it, but I don't know how that works exactly with transitioning packages that depend on sdl.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: SDL: update to 1.2.68
  2024-12-30 11:00 [PR PATCH] SDL: update to 1.2.68 ii8
  2024-12-30 21:50 ` classabbyamp
  2024-12-30 23:19 ` ii8
@ 2024-12-30 23:56 ` ii8
  2025-02-03 14:09 ` [PR PATCH] [Closed]: " ahesford
  2025-02-03 14:09 ` ahesford
  4 siblings, 0 replies; 6+ messages in thread
From: ii8 @ 2024-12-30 23:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

New comment by ii8 on void-packages repository

https://github.com/void-linux/void-packages/pull/53761#issuecomment-2566001127

Comment:
Alpine and Arch have only sdl12-compat, no SDL package.

It might cause people problems if packages were gradually transitioned because it's tricky to have both SDL1 and sdl12-compat installed at the same time, they have the same files in the same places.

Could maybe add sdl12-compat as a separate package that has a `replaces="SDL>=0"` in it, but I don't know how that works exactly with transitioning packages that depend on sdl.

In the end the only difference is the name.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: SDL: update to 1.2.68
  2024-12-30 11:00 [PR PATCH] SDL: update to 1.2.68 ii8
                   ` (2 preceding siblings ...)
  2024-12-30 23:56 ` ii8
@ 2025-02-03 14:09 ` ahesford
  2025-02-03 14:09 ` ahesford
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2025-02-03 14:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

There's a closed pull request on the void-packages repository

SDL: update to 1.2.68
https://github.com/void-linux/void-packages/pull/53761

Description:
This upgrade switches the legacy SDL to sdl12-compat as recommended by the SDL developers.
Pros are: It's maintained and gets fixes, sdl 1.2 applications work on wayland with this, it's simpler and requires less disk space. As far as I can tell there are no downsides.

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64 musl
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - armv6l
  - armv6l-musl

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: SDL: update to 1.2.68
  2024-12-30 11:00 [PR PATCH] SDL: update to 1.2.68 ii8
                   ` (3 preceding siblings ...)
  2025-02-03 14:09 ` [PR PATCH] [Closed]: " ahesford
@ 2025-02-03 14:09 ` ahesford
  4 siblings, 0 replies; 6+ messages in thread
From: ahesford @ 2025-02-03 14:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/53761#issuecomment-2631109317

Comment:
#54199 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-02-03 14:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-30 11:00 [PR PATCH] SDL: update to 1.2.68 ii8
2024-12-30 21:50 ` classabbyamp
2024-12-30 23:19 ` ii8
2024-12-30 23:56 ` ii8
2025-02-03 14:09 ` [PR PATCH] [Closed]: " ahesford
2025-02-03 14:09 ` ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).