[PR PATCH] jadx: install desktop entry

[PR PATCH] jadx: install desktop entry

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

There is a new pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages jadx
https://github.com/void-linux/void-packages/pull/53772

jadx: install desktop entry
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

cc @abenson 

A patch file from https://github.com/void-linux/void-packages/pull/53772.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jadx-53772.patch --]
[-- Type: text/x-diff, Size: 1540 bytes --]

From baf7625f23cf5553504a1a28e9257d0a5dfaf29e Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Tue, 31 Dec 2024 13:47:37 +0100
Subject: [PATCH] jadx: install desktop entry

---
 srcpkgs/jadx/files/jadx-gui.desktop | 9 +++++++++
 srcpkgs/jadx/template               | 5 ++++-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/jadx/files/jadx-gui.desktop

diff --git a/srcpkgs/jadx/files/jadx-gui.desktop b/srcpkgs/jadx/files/jadx-gui.desktop
new file mode 100644
index 00000000000000..f879b24e3a8e23
--- /dev/null
+++ b/srcpkgs/jadx/files/jadx-gui.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=Jadx GUI
+Comment=Dalvik bytecode decompiler
+Icon=jadx
+Exec=/usr/bin/jadx-gui
+StartupNotify=true
+Terminal=false
+Type=Application
+Categories=Development;
diff --git a/srcpkgs/jadx/template b/srcpkgs/jadx/template
index 874f6507008af7..4bb86b094364d6 100644
--- a/srcpkgs/jadx/template
+++ b/srcpkgs/jadx/template
@@ -1,7 +1,7 @@
 # Template file for 'jadx'
 pkgname=jadx
 version=1.5.1
-revision=1
+revision=2
 hostmakedepends="openjdk11 gradle"
 short_desc="Decompiler for Dalvik bytecode"
 maintainer="Andrew Benson <abenson+void@gmail.com>"
@@ -20,4 +20,7 @@ do_install() {
 	vmkdir usr/bin
 	ln -s /usr/share/jadx/bin/jadx ${DESTDIR}/usr/bin/jadx
 	ln -s /usr/share/jadx/bin/jadx-gui ${DESTDIR}/usr/bin/jadx-gui
+
+	vinstall ${FILESDIR}/jadx-gui.desktop 644 usr/share/applications
+	vinstall jadx-gui/src/main/resources/logos/jadx-logo.svg 644 usr/share/icons/hicolor/symbolic/apps jadx.svg
 }

Re: [PR PATCH] [Updated] jadx: install desktop entry

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 574 bytes --]

There is an updated pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages jadx
https://github.com/void-linux/void-packages/pull/53772

jadx: install desktop entry
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

cc @abenson 

A patch file from https://github.com/void-linux/void-packages/pull/53772.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jadx-53772.patch --]
[-- Type: text/x-diff, Size: 1549 bytes --]

From 43e07a89b6668e8b96c3b9ad4d81f7f54aebb677 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Tue, 31 Dec 2024 13:47:37 +0100
Subject: [PATCH] jadx: add desktop entry for jadx-gui

---
 srcpkgs/jadx/files/jadx-gui.desktop | 9 +++++++++
 srcpkgs/jadx/template               | 5 ++++-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/jadx/files/jadx-gui.desktop

diff --git a/srcpkgs/jadx/files/jadx-gui.desktop b/srcpkgs/jadx/files/jadx-gui.desktop
new file mode 100644
index 00000000000000..f879b24e3a8e23
--- /dev/null
+++ b/srcpkgs/jadx/files/jadx-gui.desktop
@@ -0,0 +1,9 @@
+[Desktop Entry]
+Name=Jadx GUI
+Comment=Dalvik bytecode decompiler
+Icon=jadx
+Exec=/usr/bin/jadx-gui
+StartupNotify=true
+Terminal=false
+Type=Application
+Categories=Development;
diff --git a/srcpkgs/jadx/template b/srcpkgs/jadx/template
index 874f6507008af7..4bb86b094364d6 100644
--- a/srcpkgs/jadx/template
+++ b/srcpkgs/jadx/template
@@ -1,7 +1,7 @@
 # Template file for 'jadx'
 pkgname=jadx
 version=1.5.1
-revision=1
+revision=2
 hostmakedepends="openjdk11 gradle"
 short_desc="Decompiler for Dalvik bytecode"
 maintainer="Andrew Benson <abenson+void@gmail.com>"
@@ -20,4 +20,7 @@ do_install() {
 	vmkdir usr/bin
 	ln -s /usr/share/jadx/bin/jadx ${DESTDIR}/usr/bin/jadx
 	ln -s /usr/share/jadx/bin/jadx-gui ${DESTDIR}/usr/bin/jadx-gui
+
+	vinstall ${FILESDIR}/jadx-gui.desktop 644 usr/share/applications
+	vinstall jadx-gui/src/main/resources/logos/jadx-logo.svg 644 usr/share/icons/hicolor/symbolic/apps jadx.svg
 }

Re: [PR REVIEW] jadx: add desktop entry for jadx-gui

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 221 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/53772#discussion_r1900208774

Comment:
we should not be vendoring or inventing our own desktop files #49164

Re: [PR REVIEW] jadx: add desktop entry for jadx-gui

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/53772#discussion_r1900369722

Comment:
I'll see if I can upstream it then

Re: [PR REVIEW] jadx: add desktop entry for jadx-gui

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 258 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/53772#discussion_r1900441071

Comment:
The desktop file is upstreamed. Should we wait for the next release or add the desktop file addition as a patch?

Re: [PR REVIEW] jadx: add desktop entry for jadx-gui

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 296 bytes --]

New review comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/53772#discussion_r1900441071

Comment:
The desktop file is upstreamed. Should we wait for the next release or add the desktop file addition as a patch (or does somebody have a better idea)?

Re: [PR REVIEW] jadx: add desktop entry for jadx-gui

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/53772#discussion_r1900441232

Comment:
we could add it as a patch, I guess

Re: [PR PATCH] [Updated] jadx: add desktop entry for jadx-gui

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

There is an updated pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages jadx
https://github.com/void-linux/void-packages/pull/53772

jadx: add desktop entry for jadx-gui
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc

cc @abenson 

A patch file from https://github.com/void-linux/void-packages/pull/53772.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jadx-53772.patch --]
[-- Type: text/x-diff, Size: 2310 bytes --]

From a1af4f6e3278982227102405522e4be8b38fc0df Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Tue, 31 Dec 2024 13:47:37 +0100
Subject: [PATCH] jadx: add desktop entry for jadx-gui

---
 srcpkgs/jadx/patches/add-desktop-file.patch | 25 +++++++++++++++++++++
 srcpkgs/jadx/template                       |  9 +++++++-
 2 files changed, 33 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/jadx/patches/add-desktop-file.patch

diff --git a/srcpkgs/jadx/patches/add-desktop-file.patch b/srcpkgs/jadx/patches/add-desktop-file.patch
new file mode 100644
index 00000000000000..3c11fb735ce549
--- /dev/null
+++ b/srcpkgs/jadx/patches/add-desktop-file.patch
@@ -0,0 +1,25 @@
+From 6889670b1130f9ac278e7de2e503de39ae86c4e6 Mon Sep 17 00:00:00 2001
+From: Bnyro <bnyro@tutanota.com>
+Date: Wed, 1 Jan 2025 18:47:29 +0100
+Subject: [PATCH] chore: add .desktop file for jadx-gui (PR #2388)
+
+---
+ contrib/jadx-gui.desktop | 9 +++++++++
+ 1 file changed, 9 insertions(+)
+ create mode 100644 contrib/jadx-gui.desktop
+
+diff --git a/contrib/jadx-gui.desktop b/contrib/jadx-gui.desktop
+new file mode 100644
+index 00000000000..950cc0da9b4
+--- /dev/null
++++ b/contrib/jadx-gui.desktop
+@@ -0,0 +1,9 @@
++[Desktop Entry]
++Name=JADX GUI
++Comment=Dex to Java compiler
++Icon=jadx
++Exec=jadx-gui %f
++Terminal=false
++Type=Application
++Categories=Development;Java;
++Keywords=Java;Decompiler;
diff --git a/srcpkgs/jadx/template b/srcpkgs/jadx/template
index 874f6507008af7..fe627c28e6bc39 100644
--- a/srcpkgs/jadx/template
+++ b/srcpkgs/jadx/template
@@ -1,7 +1,7 @@
 # Template file for 'jadx'
 pkgname=jadx
 version=1.5.1
-revision=1
+revision=2
 hostmakedepends="openjdk11 gradle"
 short_desc="Decompiler for Dalvik bytecode"
 maintainer="Andrew Benson <abenson+void@gmail.com>"
@@ -20,4 +20,11 @@ do_install() {
 	vmkdir usr/bin
 	ln -s /usr/share/jadx/bin/jadx ${DESTDIR}/usr/bin/jadx
 	ln -s /usr/share/jadx/bin/jadx-gui ${DESTDIR}/usr/bin/jadx-gui
+
+	vinstall contrib/jadx-gui.desktop 644 usr/share/applications
+	vinstall jadx-gui/src/main/resources/logos/jadx-logo.svg 644 usr/share/icons/hicolor/scalable/apps jadx.svg
+
+	for size in 16 32 48; do
+		vinstall jadx-gui/src/main/resources/logos/jadx-logo-${size}px.png 644 usr/share/icons/hicolor/${size}x${size}/apps jadx.png
+	done
 }

Re: jadx: add desktop entry for jadx-gui

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/53772#issuecomment-2771100414

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: jadx: add desktop entry for jadx-gui

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 144 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/53772#issuecomment-2771750274

Comment:
bump