Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] spotify: update to 1.2.52
@ 2025-01-11  6:18 leeminusminus
  2025-01-11 18:29 ` abenson
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: leeminusminus @ 2025-01-11  6:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

There is a new pull request by leeminusminus against master on the void-packages repository

https://github.com/leeminusminus/void-packages master
https://github.com/void-linux/void-packages/pull/53927

spotify: update to 1.2.52
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

The .deb file for 1.2.50 doesn't seem to exist anymore, and the old script doesn't work.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/53927.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-53927.patch --]
[-- Type: text/x-diff, Size: 4961 bytes --]

From 9906f694c433e7a371783e6b8e3d32822efc0020 Mon Sep 17 00:00:00 2001
From: leeminusminus <superslothsworld2@gmail.com>
Date: Sat, 11 Jan 2025 01:01:36 -0500
Subject: [PATCH 1/3] Updated template to match new update

---
 template | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 template

diff --git a/template b/template
new file mode 100644
index 00000000000000..53108f5e5c46c3
--- /dev/null
+++ b/template
@@ -0,0 +1,45 @@
+# Template file for 'spotify'
+pkgname=spotify
+version=1.2.52
+revision=1
+_subver=442.g01893f92
+archs="x86_64"
+create_wrksrc=yes
+hostmakedepends="libcurl"
+depends="libcurl libayatana-appindicator libatomic"
+short_desc="Proprietary music streaming client"
+maintainer="Stefan Mühlinghaus <jazzman@alphabreed.com>"
+license="custom:Proprietary"
+homepage="https://www.spotify.com"
+distfiles="http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_${version}.${_subver}_amd64.deb"
+checksum=c26366c253b856cdad552057d565b5f3c5568c443ef379d5044bc12dfdcf2fe7
+repository=nonfree
+restricted=yes
+nostrip=yes
+
+do_install() {
+	vbin "${FILESDIR}/spotify"
+
+	vmkdir usr/share/spotify
+	vmkdir usr/share/applications
+	vmkdir usr/libexec/
+	vcopy usr/share/spotify usr/libexec/
+
+	ln -s "../../libexec/spotify/icons" "${DESTDIR}/usr/share/spotify/"
+
+	# install icons
+	for _s in 16 22 24 32 48 64 128 256 512; do
+		vmkdir "usr/share/icons/hicolor/${_s}x${_s}/apps"
+		ln -sf "/usr/share/spotify/icons/spotify-linux-${_s}.png" \
+			"${DESTDIR}/usr/share/icons/hicolor/${_s}x${_s}/apps/spotify-client.png"
+	done
+
+	vmkdir usr/share/applications
+	mv "${DESTDIR}/usr/libexec/spotify/spotify.desktop" \
+		"${DESTDIR}/usr/share/applications/spotify.desktop"
+
+	# provide dynamic libraries
+	ln -s /usr/lib/libcurl.so.4 ${DESTDIR}/usr/libexec/spotify/libcurl-gnutls.so.4
+
+	vlicense ${FILESDIR}/EULA
+}

From 7832af7d5e3b3924e0802dc92ed1518976e93165 Mon Sep 17 00:00:00 2001
From: leeminusminus <superslothsworld2@gmail.com>
Date: Sat, 11 Jan 2025 01:15:05 -0500
Subject: [PATCH 2/3] spotify: update to 1.2.52

---
 srcpkgs/spotify/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/spotify/template b/srcpkgs/spotify/template
index 50a769cd795fa9..53108f5e5c46c3 100644
--- a/srcpkgs/spotify/template
+++ b/srcpkgs/spotify/template
@@ -1,8 +1,8 @@
 # Template file for 'spotify'
 pkgname=spotify
-version=1.2.50
+version=1.2.52
 revision=1
-_subver=335.g5e2860a8
+_subver=442.g01893f92
 archs="x86_64"
 create_wrksrc=yes
 hostmakedepends="libcurl"
@@ -12,7 +12,7 @@ maintainer="Stefan Mühlinghaus <jazzman@alphabreed.com>"
 license="custom:Proprietary"
 homepage="https://www.spotify.com"
 distfiles="http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_${version}.${_subver}_amd64.deb"
-checksum=0c1d068c80f3c2d8b1bc19afa253ab14d8b54e638e683b831396be4c39ec245c
+checksum=c26366c253b856cdad552057d565b5f3c5568c443ef379d5044bc12dfdcf2fe7
 repository=nonfree
 restricted=yes
 nostrip=yes

From 7501b62423d12cce51e0fe02dc1d2b092c59246a Mon Sep 17 00:00:00 2001
From: leeminusminus <superslothsworld2@gmail.com>
Date: Sat, 11 Jan 2025 01:16:30 -0500
Subject: [PATCH 3/3] Delete template

---
 template | 45 ---------------------------------------------
 1 file changed, 45 deletions(-)
 delete mode 100644 template

diff --git a/template b/template
deleted file mode 100644
index 53108f5e5c46c3..00000000000000
--- a/template
+++ /dev/null
@@ -1,45 +0,0 @@
-# Template file for 'spotify'
-pkgname=spotify
-version=1.2.52
-revision=1
-_subver=442.g01893f92
-archs="x86_64"
-create_wrksrc=yes
-hostmakedepends="libcurl"
-depends="libcurl libayatana-appindicator libatomic"
-short_desc="Proprietary music streaming client"
-maintainer="Stefan Mühlinghaus <jazzman@alphabreed.com>"
-license="custom:Proprietary"
-homepage="https://www.spotify.com"
-distfiles="http://repository.spotify.com/pool/non-free/s/spotify-client/spotify-client_${version}.${_subver}_amd64.deb"
-checksum=c26366c253b856cdad552057d565b5f3c5568c443ef379d5044bc12dfdcf2fe7
-repository=nonfree
-restricted=yes
-nostrip=yes
-
-do_install() {
-	vbin "${FILESDIR}/spotify"
-
-	vmkdir usr/share/spotify
-	vmkdir usr/share/applications
-	vmkdir usr/libexec/
-	vcopy usr/share/spotify usr/libexec/
-
-	ln -s "../../libexec/spotify/icons" "${DESTDIR}/usr/share/spotify/"
-
-	# install icons
-	for _s in 16 22 24 32 48 64 128 256 512; do
-		vmkdir "usr/share/icons/hicolor/${_s}x${_s}/apps"
-		ln -sf "/usr/share/spotify/icons/spotify-linux-${_s}.png" \
-			"${DESTDIR}/usr/share/icons/hicolor/${_s}x${_s}/apps/spotify-client.png"
-	done
-
-	vmkdir usr/share/applications
-	mv "${DESTDIR}/usr/libexec/spotify/spotify.desktop" \
-		"${DESTDIR}/usr/share/applications/spotify.desktop"
-
-	# provide dynamic libraries
-	ln -s /usr/lib/libcurl.so.4 ${DESTDIR}/usr/libexec/spotify/libcurl-gnutls.so.4
-
-	vlicense ${FILESDIR}/EULA
-}

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: spotify: update to 1.2.52
  2025-01-11  6:18 [PR PATCH] spotify: update to 1.2.52 leeminusminus
@ 2025-01-11 18:29 ` abenson
  2025-01-11 18:29 ` abenson
  2025-01-12  0:26 ` [PR PATCH] [Closed]: " abenson
  2 siblings, 0 replies; 4+ messages in thread
From: abenson @ 2025-01-11 18:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/53927#issuecomment-2585367573

Comment:
Please [rebase](https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase) to get rid of the merge commit and squash it into a single "spotify: update to 1.2.52" commit.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: spotify: update to 1.2.52
  2025-01-11  6:18 [PR PATCH] spotify: update to 1.2.52 leeminusminus
  2025-01-11 18:29 ` abenson
@ 2025-01-11 18:29 ` abenson
  2025-01-12  0:26 ` [PR PATCH] [Closed]: " abenson
  2 siblings, 0 replies; 4+ messages in thread
From: abenson @ 2025-01-11 18:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/53927#issuecomment-2585367573

Comment:
Please [rebase](https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase) (and then force push to this branch: `git push -f`) to get rid of the merge commit and squash it into a single "spotify: update to 1.2.52" commit.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PR PATCH] [Closed]: spotify: update to 1.2.52
  2025-01-11  6:18 [PR PATCH] spotify: update to 1.2.52 leeminusminus
  2025-01-11 18:29 ` abenson
  2025-01-11 18:29 ` abenson
@ 2025-01-12  0:26 ` abenson
  2 siblings, 0 replies; 4+ messages in thread
From: abenson @ 2025-01-12  0:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

There's a closed pull request on the void-packages repository

spotify: update to 1.2.52
https://github.com/void-linux/void-packages/pull/53927

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

The .deb file for 1.2.50 doesn't seem to exist anymore, and the old script doesn't work.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-01-12  0:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-11  6:18 [PR PATCH] spotify: update to 1.2.52 leeminusminus
2025-01-11 18:29 ` abenson
2025-01-11 18:29 ` abenson
2025-01-12  0:26 ` [PR PATCH] [Closed]: " abenson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).