Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] asahi-base: fix symlink
@ 2025-01-16 13:29 dkwo
  2025-01-16 13:32 ` [PR REVIEW] " classabbyamp
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: dkwo @ 2025-01-16 13:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 426 bytes --]

There is a new pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages asahi-bfix
https://github.com/void-linux/void-packages/pull/53992

asahi-base: fix symlink
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (aarch64)

@classabbyamp 

A patch file from https://github.com/void-linux/void-packages/pull/53992.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-asahi-bfix-53992.patch --]
[-- Type: text/x-diff, Size: 1117 bytes --]

From 723e599ba88bf0f521f14c3f249ec83989622627 Mon Sep 17 00:00:00 2001
From: dkwo <npiazza@disroot.org>
Date: Thu, 16 Jan 2025 14:23:22 +0100
Subject: [PATCH] asahi-base: fix symlink

---
 srcpkgs/asahi-base/INSTALL  | 4 ++--
 srcpkgs/asahi-base/template | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/asahi-base/INSTALL b/srcpkgs/asahi-base/INSTALL
index debdbd4d8e5c01..e6168ff18b6ae1 100644
--- a/srcpkgs/asahi-base/INSTALL
+++ b/srcpkgs/asahi-base/INSTALL
@@ -1,3 +1,3 @@
-if [ "${ACTION}" = "post" ] && ! [ -d /var/service/speakersafetyd ]; then
-	ln -s /etc/sv/speakersafetyd /var/service
+if [ "${ACTION}" = "post" ] && ! [ -d /etc/runit/runsvdir/default/speakersafetyd ]; then
+	ln -s /etc/sv/speakersafetyd /etc/runit/runsvdir/default
 fi
diff --git a/srcpkgs/asahi-base/template b/srcpkgs/asahi-base/template
index 19a08a051171b2..1d841a4fe83e39 100644
--- a/srcpkgs/asahi-base/template
+++ b/srcpkgs/asahi-base/template
@@ -1,6 +1,6 @@
 # Template file for 'asahi-base'
 pkgname=asahi-base
-version=20250113
+version=20250116
 revision=1
 archs="aarch64*"
 build_style=meta

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] asahi-base: fix symlink
  2025-01-16 13:29 [PR PATCH] asahi-base: fix symlink dkwo
@ 2025-01-16 13:32 ` classabbyamp
  2025-01-16 14:01 ` dkwo
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2025-01-16 13:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/53992#discussion_r1918563474

Comment:
```suggestion
if [ "${ACTION}" = "post" ] && ! [ -d etc/runit/runsvdir/default/speakersafetyd ]; then
	ln -s /etc/sv/speakersafetyd etc/runit/runsvdir/default
```
this allows it to run in `xbps-install -r /mnt` correctly iirc

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR REVIEW] asahi-base: fix symlink
  2025-01-16 13:29 [PR PATCH] asahi-base: fix symlink dkwo
  2025-01-16 13:32 ` [PR REVIEW] " classabbyamp
@ 2025-01-16 14:01 ` dkwo
  2025-01-16 14:01 ` [PR PATCH] [Updated] " dkwo
  2025-01-16 23:31 ` [PR PATCH] [Merged]: " classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: dkwo @ 2025-01-16 14:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

New review comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/53992#discussion_r1918607521

Comment:
done.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] asahi-base: fix symlink
  2025-01-16 13:29 [PR PATCH] asahi-base: fix symlink dkwo
  2025-01-16 13:32 ` [PR REVIEW] " classabbyamp
  2025-01-16 14:01 ` dkwo
@ 2025-01-16 14:01 ` dkwo
  2025-01-16 23:31 ` [PR PATCH] [Merged]: " classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: dkwo @ 2025-01-16 14:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

There is an updated pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages asahi-bfix
https://github.com/void-linux/void-packages/pull/53992

asahi-base: fix symlink
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (aarch64)

@classabbyamp 

A patch file from https://github.com/void-linux/void-packages/pull/53992.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-asahi-bfix-53992.patch --]
[-- Type: text/x-diff, Size: 1115 bytes --]

From 74c9b74131e227f06abe2fda9a8c2b5ea1466cff Mon Sep 17 00:00:00 2001
From: dkwo <npiazza@disroot.org>
Date: Thu, 16 Jan 2025 14:23:22 +0100
Subject: [PATCH] asahi-base: fix symlink

---
 srcpkgs/asahi-base/INSTALL  | 4 ++--
 srcpkgs/asahi-base/template | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/asahi-base/INSTALL b/srcpkgs/asahi-base/INSTALL
index debdbd4d8e5c01..18dad27e5152ec 100644
--- a/srcpkgs/asahi-base/INSTALL
+++ b/srcpkgs/asahi-base/INSTALL
@@ -1,3 +1,3 @@
-if [ "${ACTION}" = "post" ] && ! [ -d /var/service/speakersafetyd ]; then
-	ln -s /etc/sv/speakersafetyd /var/service
+if [ "${ACTION}" = "post" ] && ! [ -d etc/runit/runsvdir/default/speakersafetyd ]; then
+	ln -s /etc/sv/speakersafetyd etc/runit/runsvdir/default
 fi
diff --git a/srcpkgs/asahi-base/template b/srcpkgs/asahi-base/template
index 19a08a051171b2..1d841a4fe83e39 100644
--- a/srcpkgs/asahi-base/template
+++ b/srcpkgs/asahi-base/template
@@ -1,6 +1,6 @@
 # Template file for 'asahi-base'
 pkgname=asahi-base
-version=20250113
+version=20250116
 revision=1
 archs="aarch64*"
 build_style=meta

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: asahi-base: fix symlink
  2025-01-16 13:29 [PR PATCH] asahi-base: fix symlink dkwo
                   ` (2 preceding siblings ...)
  2025-01-16 14:01 ` [PR PATCH] [Updated] " dkwo
@ 2025-01-16 23:31 ` classabbyamp
  3 siblings, 0 replies; 5+ messages in thread
From: classabbyamp @ 2025-01-16 23:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

There's a merged pull request on the void-packages repository

asahi-base: fix symlink
https://github.com/void-linux/void-packages/pull/53992

Description:
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (aarch64)

@classabbyamp 

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-01-16 23:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-16 13:29 [PR PATCH] asahi-base: fix symlink dkwo
2025-01-16 13:32 ` [PR REVIEW] " classabbyamp
2025-01-16 14:01 ` dkwo
2025-01-16 14:01 ` [PR PATCH] [Updated] " dkwo
2025-01-16 23:31 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).