[PR PATCH] ddclient: update to 4.0.0, adopt.

[PR PATCH] ddclient: update to 4.0.0, adopt.

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

There is a new pull request by TinfoilSubmarine against master on the void-packages repository

https://github.com/TinfoilSubmarine/void-packages maint/ddclient
https://github.com/void-linux/void-packages/pull/54039

ddclient: update to 4.0.0, adopt.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/54039.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-maint/ddclient-54039.patch --]
[-- Type: text/x-diff, Size: 4934 bytes --]

From 94f4c469c7264dde6dd23b4f789f8c9dd4b31f84 Mon Sep 17 00:00:00 2001
From: Joel Beckmeyer <joel@beckmeyer.us>
Date: Fri, 17 Jan 2025 10:19:04 -0500
Subject: [PATCH] ddclient: update to 4.0.0, adopt.

---
 srcpkgs/ddclient/patches/porkbun.patch | 56 --------------------------
 srcpkgs/ddclient/template              | 10 ++---
 2 files changed, 5 insertions(+), 61 deletions(-)
 delete mode 100644 srcpkgs/ddclient/patches/porkbun.patch

diff --git a/srcpkgs/ddclient/patches/porkbun.patch b/srcpkgs/ddclient/patches/porkbun.patch
deleted file mode 100644
index 39268fda186db9..00000000000000
--- a/srcpkgs/ddclient/patches/porkbun.patch
+++ /dev/null
@@ -1,56 +0,0 @@
-diff --git a/ddclient.in b/ddclient.in
-index 7a66c5e..d236555 100755
---- a/ddclient.in
-+++ b/ddclient.in
-@@ -868,6 +868,7 @@ my %services = (
-             'apikey'         => setv(T_PASSWD, 1, 0, '',         undef),
-             'secretapikey'   => setv(T_PASSWD, 1, 0, '',         undef),
-             'on-root-domain' => setv(T_BOOL,   0, 0, 0,          undef),
-+            'server'         => setv(T_FQDNP,  1, 0, 'api.porkbun.com', undef),
-             'login'          => setv(T_LOGIN,  0, 0, 'unused',   undef),
-             'password'       => setv(T_PASSWD, 0, 0, 'unused',   undef),
-             'use'            => setv(T_USE,    0, 0, 'disabled', undef),
-@@ -7082,6 +7083,7 @@ sub nic_porkbun_update {
-     debug("\nnic_porkbun_update -------------------");
- 
-     foreach my $host (@_) {
-+        my $server = $config{$host}{'server'};
-         foreach my $ipv ('ipv4', 'ipv6') {
-             my $ip = delete $config{$host}{"want$ipv"};
-             if (!$ip) {
-@@ -7099,7 +7101,7 @@ sub nic_porkbun_update {
-             info("setting %s address to %s for %s", $ipv, $ip, $host);
-             verbose("UPDATE:","updating %s", $host);
- 
--            my $url = "https://porkbun.com/api/json/v3/dns/retrieveByNameType/$domain/$rrset_type/$sub_domain";
-+            my $url = "https://$server/api/json/v3/dns/retrieveByNameType/$domain/$rrset_type/$sub_domain";
-             my $data = encode_json({
-                 secretapikey => $config{$host}{'secretapikey'},
-                 apikey       => $config{$host}{'apikey'},
-@@ -7115,7 +7117,7 @@ sub nic_porkbun_update {
-             # No response, declare as failed
-             if (!defined($reply) || !$reply) {
-                 $config{$host}{"status-$ipv"} = "bad";
--                failed("updating %s: Could not connect to porkbun.com.", $host);
-+                failed("updating %s: Could not connect to $server.", $host);
-                 next;
-             }
-             if (!header_ok($host, $reply)) {
-@@ -7153,7 +7155,7 @@ sub nic_porkbun_update {
-                 my $notes = $records->[0]->{'notes'};
-                 debug("ttl = %s", $ttl);
-                 debug("notes = %s", $notes);
--                $url = "https://porkbun.com/api/json/v3/dns/editByNameType/$domain/$rrset_type/$sub_domain";
-+                $url = "https://$server/api/json/v3/dns/editByNameType/$domain/$rrset_type/$sub_domain";
-                 $data = encode_json({
-                     secretapikey => $config{$host}{'secretapikey'},
-                     apikey       => $config{$host}{'apikey'},
-@@ -7170,7 +7172,7 @@ sub nic_porkbun_update {
-                 );
-                 # No response, declare as failed
-                 if (!defined($reply) || !$reply) {
--                    failed("updating %s: Could not connect to porkbun.com.", $host);
-+                    failed("updating %s: Could not connect to $server.", $host);
-                     next;
-                 }
-                 if (!header_ok($host, $reply)) {
diff --git a/srcpkgs/ddclient/template b/srcpkgs/ddclient/template
index 833b7a9bc66923..bae125e89f6c8a 100644
--- a/srcpkgs/ddclient/template
+++ b/srcpkgs/ddclient/template
@@ -1,20 +1,20 @@
 # Template file for 'ddclient'
 pkgname=ddclient
-version=3.11.2
-revision=2
+version=4.0.0
+revision=1
 build_style=gnu-configure
-configure_args="--sysconfdir=/etc/ddclient"
+configure_args="--sysconfdir=/etc"
 hostmakedepends="automake curl"
 depends="perl-JSON curl"
 checkdepends="$depends perl-HTTP-Daemon perl-Plack perl-HTTP-Message
  perl-Test-MockModule perl-Test-Warnings curl net-tools"
 short_desc="Perl client used to update dynamic DNS"
-maintainer="rogi <rogi@skylittlesystem.org>"
+maintainer="Joel Beckmeyer <joel@beckmeyer.us>"
 license="GPL-2.0-or-later"
 homepage="https://github.com/ddclient/ddclient"
 changelog="https://raw.githubusercontent.com/ddclient/ddclient/master/ChangeLog.md"
 distfiles="https://github.com/ddclient/ddclient/archive/v${version}.tar.gz"
-checksum=243cd832abd3cdd2b49903e1b5ed7f450e2d9c4c0eaf8ce4fe692c244d3afd77
+checksum=4b37c99ac0011102d7db62f1ece7ff899b06df3d4b172e312703931a3c593c93
 
 conf_files="/etc/ddclient/ddclient.conf"
 make_dirs="/var/cache/ddclient 0750 root root"

Re: [PR PATCH] [Closed]: ddclient: update to 4.0.0, adopt.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

There's a closed pull request on the void-packages repository

ddclient: update to 4.0.0, adopt.
https://github.com/void-linux/void-packages/pull/54039

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->