[ISSUE] lsp-plugins not working under musl

[ISSUE] lsp-plugins not working under musl

[ohoes]

[-- Attachment #1: Type: text/plain, Size: 906 bytes --]

New issue by ohoes on void-packages repository

https://github.com/void-linux/void-packages/issues/54235

Description:
### Is this a new report?

Yes

### System Info

Void 6.12.11_1 x86_64-musl GenuineIntel notuptodate rFF

### Package(s) Affected

lsp-plugins

### Does a report exist for this bug with the project's home (upstream) and/or another distro?

https://github.com/lsp-plugins/lsp-plugins/issues/485

### Expected behaviour

For the plugins to be working correctly on musl.

### Actual behaviour

Plugins do not start on musl, JACK library cannot be found.
```
onno@t420:~$ lsp-plugins-compressor-stereo 
[ERR] Could not find JACK plugin core library
```

### Steps to reproduce

Install lsp-plugins from repo's. Get error yourself on musl.
Build it yourself, and it will work.
Package itself is the problem I think. If you build it yourself it will work, like shown in the upstream github.

Re: lsp-plugins not working under musl

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2643205380

Comment:
Did you rebuild using `xbps-src`? if that still has the issue, does deleting the `configure` function in there helps?
@Calandracas606 can you reproduce?

Re: lsp-plugins not working under musl

[ohoes]

[-- Attachment #1: Type: text/plain, Size: 575 bytes --]

New comment by ohoes on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2647981418

Comment:
> Did you rebuild using `xbps-src`? if that still has the issue, does deleting the `configure` function in there helps? [@Calandracas606](https://github.com/Calandracas606) can you reproduce?

No, I built it from the git repo, and it works perfectly. Although it is also a newer version. When I try to build it with xbps-src it doesn't work, I get the same error. If I remove the configure function I don't even get it built on musl.

Re: lsp-plugins not working under musl

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2648248332

Comment:
Why do you say _newer version_? as far as I can see, they are both at 1.2.20.
What I meant is edit the `configure` stage to see if you can make it work on musl, e.g. something like `make PREFIX=/usr config` or similar, as you would do when you build by hand.

Re: lsp-plugins not working under musl

[sadko4u]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

New comment by sadko4u on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2650294350

Comment:
@dkwo the `newer version` means the version from the development (`devel`) branch of the repository. This version (1.2.21) is not released yet because it is a development version.

Re: lsp-plugins not working under musl

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651188039

Comment:
I see, then another option is to edit Void's template to build from that branch, and see whether the issue is still there.

Re: lsp-plugins not working under musl

[sadko4u]

[-- Attachment #1: Type: text/plain, Size: 755 bytes --]

New comment by sadko4u on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651212790

Comment:
@dkwo I think you have improperly understood the problem.
It seems that `lsp-plugins` package should be build for both `musl` and `glibc`.
If you try to use `lsp-plugins` build for glibc, it will fail to load for `musl`. But simple workaround [described here](https://github.com/lsp-plugins/lsp-plugins/issues/485#issuecomment-2640601191) solves the problem.
The reason is, the `musl` library has different shared object name from `glibc` one.
I don't know anything about Void Linux infrastructure and availability of `lsp-plugins` package out of the box for Void Linux but that's the point I just want to mark.

Re: lsp-plugins not working under musl

[sadko4u]

[-- Attachment #1: Type: text/plain, Size: 757 bytes --]

New comment by sadko4u on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651212790

Comment:
@dkwo I think you have improperly understood the problem.
It seems that `lsp-plugins` package should be build for both `musl` and `glibc`.
If you try to use `lsp-plugins` build for `glibc`, it will fail to load for `musl`. But simple workaround [described here](https://github.com/lsp-plugins/lsp-plugins/issues/485#issuecomment-2640601191) solves the problem.
The reason is, the `musl` library has different shared object name from `glibc` one.
I don't know anything about Void Linux infrastructure and availability of `lsp-plugins` package out of the box for Void Linux but that's the point I just want to mark.

Re: lsp-plugins not working under musl

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651220940

Comment:
why are you trying to use the glibc package on musl?

Re: lsp-plugins not working under musl

[sadko4u]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New comment by sadko4u on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651233776

Comment:
I'm not trying to do this :). I suppose it's more a question to @ohoes.

Re: lsp-plugins not working under musl

[ohoes]

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

New comment by ohoes on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651348062

Comment:
My apologies if this was unclear. I assumed that the package Void has in its repos works for both glibc and musl. At least, it did in the past. I opened this issue because it seems that this is not the case. So yes, I think the package template in the repos needs to be modified so that it can be built for both libraries, currently it is not. It only works out of the box with glibc. I have indeed used the devel branch to build it myself, and it is proven to work, so at least we can rule out that it is a problem with musl itself. It just takes some modifications to make it work with the official release packages, at the moment.

@sadko4u Is this all correct so far? Please tell me if it is not the case.

Re: lsp-plugins not working under musl

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 615 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651372716

Comment:
There are already two versions of the package, one build with glibc and one with musl, both available in their respective repositories.

Seems like there is an issue with missing symbols.

```
Error relocating /usr/lib/lsp-plugins/liblsp-plugins-jack-1.2.20.so: _ZN3lsp3x8619detect_cpu_featuresEPNS0_14cpu_features_tE: symbol not found
Error relocating /usr/lib/lsp-plugins/liblsp-plugins-jack-1.2.20.so: _ZN3lsp3x868dsp_initEPKNS0_14cpu_features_tE: symbol not found
```

Re: lsp-plugins not working under musl

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651372716

Comment:
There are already two versions of the package, one build with glibc and one with musl, both available in their respective repositories. Under normal circumstances you are not able to install glibc packages on a musl system or vice versa. 

Seems like there is an issue with missing symbols.

```
Error relocating /usr/lib/lsp-plugins/liblsp-plugins-jack-1.2.20.so: _ZN3lsp3x8619detect_cpu_featuresEPNS0_14cpu_features_tE: symbol not found
Error relocating /usr/lib/lsp-plugins/liblsp-plugins-jack-1.2.20.so: _ZN3lsp3x868dsp_initEPKNS0_14cpu_features_tE: symbol not found
```

Re: lsp-plugins not working under musl

[sadko4u]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New comment by sadko4u on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651432191

Comment:
It seems that package for `musl` is broken.
I've just built `lsp-plugins` from `1.2.20` tag and they work well.

Re: [ISSUE] [CLOSED] lsp-plugins not working under musl

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 951 bytes --]

Closed issue by ohoes on void-packages repository

https://github.com/void-linux/void-packages/issues/54235

Description:
### Is this a new report?

Yes

### System Info

Void 6.12.11_1 x86_64-musl GenuineIntel notuptodate rFF

### Package(s) Affected

lsp-plugins, lsp-plugins-devel

### Does a report exist for this bug with the project's home (upstream) and/or another distro?

https://github.com/lsp-plugins/lsp-plugins/issues/485

### Expected behaviour

For the plugins to be working correctly on musl.

### Actual behaviour

Plugins do not start on musl, JACK library cannot be found.
```
onno@t420:~$ lsp-plugins-compressor-stereo 
[ERR] Could not find JACK plugin core library
```

### Steps to reproduce

Install lsp-plugins from repo's. Get error yourself on musl.
Build it yourself, and it will work.
Package itself is the problem I think. If you build it yourself it will work, like shown in the upstream github.
Glibc is not affected.

Re: lsp-plugins not working under musl

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651471744

Comment:
It passed `x86_64-musl`, our internal "architecture" string instead of `x86_64` to `make config ARCHITECTURE=`.

Re: lsp-plugins not working under musl

[sadko4u]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New comment by sadko4u on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651474971

Comment:
@Duncaen so that was the reason?

Re: lsp-plugins not working under musl

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651488852

Comment:
Yes, it resulted in `ARCHITECTURE=x86_64-musl` and `ARCHITECTURE_FAMILY=generic`  in `config.mk`. Fixed packages should be available in the repository in a bit.

Re: lsp-plugins not working under musl

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 239 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651665578

Comment:
Now crosscompilation is failing. Is it possible there is still something wrong in `do_configure` ?

Re: lsp-plugins not working under musl

[dkwo]

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651679897

Comment:
For example, aarch64 cross:
```
Configuring build...
Host architecture: x86_64/x86_64 (-O2 -pipe)
Architecture:      x86_64/x86_64 (-fstack-clash-protection -D_FORTIFY_SOURCE=2 -O2 -pipe -march=armv8-a  -g -I/usr/aarch64-linux-gnu/usr/include -ffile-prefix-map=/builddir/lsp-plugins-1.2.20=.)
Features:          clap doc gst jack ladspa lv2 ui vst2 vst3 xdg
Configured OK
```
```
  aarch64-linux-gnu-c++  [lsp-dsp-lib] main/x86/x86.cpp
  aarch64-linux-gnu-c++  [lsp-dsp-lib] main/x86/sse.cpp
aarch64-linux-gnu-g++: error: unrecognized command-line option '-mmmx'
aarch64-linux-gnu-g++: error: unrecognized command-line option '-msse'
```

Re: lsp-plugins not working under musl

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/issues/54235#issuecomment-2651730985

Comment:
Should be fixed now, I guess `XBPS_TARGET_ARCH` is actually not a thing, it wasn't actually set in cross builds.