[PR PATCH] pipewire: update to 1.4.0

[PR PATCH] pipewire: update to 1.4.0

[tm512]

[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]

There is a new pull request by tm512 against master on the void-packages repository

https://github.com/tm512/void-packages pipewire-1.4.0
https://github.com/void-linux/void-packages/pull/54604

pipewire: update to 1.4.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly** (at least for the official 1.4 release, though I have been using the 1.3.x release candidates without any issues for about a month)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (crossbuilds):
  - aarch64-glibc

PipeWire 1.4 adds support for EBU R128 loudness normalization (via libebur128), so I've added that as a dependency. Should it be put behind a build option? I would have to make sure that it actually has a meson flag and isn't a hard dependency.

A patch file from https://github.com/void-linux/void-packages/pull/54604.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-1.4.0-54604.patch --]
[-- Type: text/x-diff, Size: 2088 bytes --]

From e3621204bf3f0adb09bdd9b18429a67c7eb31d3a Mon Sep 17 00:00:00 2001
From: tm512 <elykdav@gmail.com>
Date: Thu, 6 Mar 2025 12:29:56 -0800
Subject: [PATCH] pipewire: update to 1.4.0

---
 srcpkgs/pipewire/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index d72527baa26b86..e05eca9316e8d0 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=1.2.7
+version=1.4.0
 revision=1
 build_style=meson
 configure_args="
@@ -30,10 +30,10 @@ makedepends="$(vopt_if sdl2 SDL2-devel) gst-plugins-base1-devel jack-devel
  vulkan-loader-devel pulseaudio-devel avahi-libs-devel webrtc-audio-processing-devel
  readline-devel openssl-devel lilv-devel libcanberra-devel dbus-devel
  libmysofa-devel opus-devel $(vopt_if ffado libffado-devel) liblc3-devel
- $(vopt_if selinux libselinux-devel) libcamera-devel libcap-devel"
+ $(vopt_if selinux libselinux-devel) libcamera-devel libcap-devel libebur128-devel"
 depends="libspa-alsa>=${version}_${revision} libspa-audioconvert>=${version}_${revision}
  libspa-audiomixer>=${version}_${revision} libspa-control>=${version}_${revision}
- libspa-v4l2>=${version}_${revision} pulseaudio-utils virtual?pipewire-session-manager"
+ libspa-v4l2>=${version}_${revision} pulseaudio-utils libebur128 virtual?pipewire-session-manager"
 checkdepends="pulseaudio-utils"
 short_desc="Server and user space API to deal with multimedia pipelines"
 maintainer="cinerea0 <cinerea0@protonmail.com>"
@@ -41,7 +41,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=e75568ed18bcbe75e9779af57cb9cc256fd7ebfaadc12bb347a0717055d1d3a9
+checksum=81076aac2020ec53ef6c3e2f6e8b5bee7275dad15c295bacab5c73e2727955ec
 make_dirs="/var/lib/pipewire 0755 _pipewire _pipewire"
 system_accounts="_pipewire"
 

Re: pipewire: update to 1.4.0

[tm512]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2705157156

Comment:
Forgot that mpv actually spits out a warning due to something that pipewire deprecated, fixed in upstream mpv: mpv-player/mpv#15915

I could locally backport that fix and make sure it works as intended.

Re: [PR PATCH] [Updated] pipewire: update to 1.4.0

[tm512]

[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]

There is an updated pull request by tm512 against master on the void-packages repository

https://github.com/tm512/void-packages pipewire-1.4.0
https://github.com/void-linux/void-packages/pull/54604

pipewire: update to 1.4.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly** (at least for the official 1.4 release, though I have been using the 1.3.x release candidates without any issues for about a month)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (crossbuilds):
  - aarch64-glibc

PipeWire 1.4 adds support for EBU R128 loudness normalization (via libebur128), so I've added that as a dependency. Should it be put behind a build option? I would have to make sure that it actually has a meson flag and isn't a hard dependency.

A patch file from https://github.com/void-linux/void-packages/pull/54604.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-1.4.0-54604.patch --]
[-- Type: text/x-diff, Size: 4482 bytes --]

From 689ab51e1a8ab85d07e1d670c6b0d3ce373d79b1 Mon Sep 17 00:00:00 2001
From: tm512 <elykdav@gmail.com>
Date: Thu, 6 Mar 2025 12:29:56 -0800
Subject: [PATCH 1/2] pipewire: update to 1.4.0

---
 srcpkgs/pipewire/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index d72527baa26b86..e05eca9316e8d0 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=1.2.7
+version=1.4.0
 revision=1
 build_style=meson
 configure_args="
@@ -30,10 +30,10 @@ makedepends="$(vopt_if sdl2 SDL2-devel) gst-plugins-base1-devel jack-devel
  vulkan-loader-devel pulseaudio-devel avahi-libs-devel webrtc-audio-processing-devel
  readline-devel openssl-devel lilv-devel libcanberra-devel dbus-devel
  libmysofa-devel opus-devel $(vopt_if ffado libffado-devel) liblc3-devel
- $(vopt_if selinux libselinux-devel) libcamera-devel libcap-devel"
+ $(vopt_if selinux libselinux-devel) libcamera-devel libcap-devel libebur128-devel"
 depends="libspa-alsa>=${version}_${revision} libspa-audioconvert>=${version}_${revision}
  libspa-audiomixer>=${version}_${revision} libspa-control>=${version}_${revision}
- libspa-v4l2>=${version}_${revision} pulseaudio-utils virtual?pipewire-session-manager"
+ libspa-v4l2>=${version}_${revision} pulseaudio-utils libebur128 virtual?pipewire-session-manager"
 checkdepends="pulseaudio-utils"
 short_desc="Server and user space API to deal with multimedia pipelines"
 maintainer="cinerea0 <cinerea0@protonmail.com>"
@@ -41,7 +41,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=e75568ed18bcbe75e9779af57cb9cc256fd7ebfaadc12bb347a0717055d1d3a9
+checksum=81076aac2020ec53ef6c3e2f6e8b5bee7275dad15c295bacab5c73e2727955ec
 make_dirs="/var/lib/pipewire 0755 _pipewire _pipewire"
 system_accounts="_pipewire"
 

From 95660119d92e96f916d37195d74f732a5c5e9846 Mon Sep 17 00:00:00 2001
From: tm512 <elykdav@gmail.com>
Date: Thu, 6 Mar 2025 17:16:11 -0800
Subject: [PATCH 2/2] mpv: backport fix for pipewire-1.4.0

---
 .../mpv/patches/0.39.0-pipewire-1.4-fix.patch | 33 +++++++++++++++++++
 srcpkgs/mpv/template                          |  2 +-
 2 files changed, 34 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch

diff --git a/srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch b/srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch
new file mode 100644
index 00000000000000..bdeaade6f93131
--- /dev/null
+++ b/srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch
@@ -0,0 +1,33 @@
+https://github.com/mpv-player/mpv/commit/c9970b5ba66e25aeab36cdbdb91b973f2d3f8d90.patch
+From c9970b5ba66e25aeab36cdbdb91b973f2d3f8d90 Mon Sep 17 00:00:00 2001
+From: llyyr <llyyr.public@gmail.com>
+Date: Wed, 19 Feb 2025 19:08:36 +0530
+Subject: [PATCH] ao_pipewire: don't load client-rt.conf properties
+
+Deprecated in https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/24bcacc6195ffbf8e40c9ea1374eb6666252eadc
+
+Fixes: #15914
+---
+ audio/out/ao_pipewire.c | 9 +++++----
+ 1 file changed, 5 insertions(+), 4 deletions(-)
+
+diff --git a/audio/out/ao_pipewire.c b/audio/out/ao_pipewire.c
+index 5e6bb1fa4fdf7..88c48ddca60e7 100644
+--- a/audio/out/ao_pipewire.c
++++ b/audio/out/ao_pipewire.c
+@@ -510,10 +510,11 @@ static int pipewire_init_boilerplate(struct ao *ao)
+     if (pw_thread_loop_start(p->loop) < 0)
+         goto error;
+ 
+-    context = pw_context_new(
+-            pw_thread_loop_get_loop(p->loop),
+-            pw_properties_new(PW_KEY_CONFIG_NAME, "client-rt.conf", NULL),
+-            0);
++    struct pw_properties *props = NULL;
++#if !PW_CHECK_VERSION(1, 3, 81)
++    props = pw_properties_new(PW_KEY_CONFIG_NAME, "client-rt.conf", NULL);
++#endif
++    context = pw_context_new(pw_thread_loop_get_loop(p->loop), props, 0);
+     if (!context)
+         goto error;
+ 
diff --git a/srcpkgs/mpv/template b/srcpkgs/mpv/template
index c1ce4c3a59a9b8..778f5e6fd5bb08 100644
--- a/srcpkgs/mpv/template
+++ b/srcpkgs/mpv/template
@@ -1,7 +1,7 @@
 # Template file for 'mpv'
 pkgname=mpv
 version=0.39.0
-revision=2
+revision=3
 build_style=meson
 configure_args="-Dcdda=enabled -Ddvbin=enabled -Ddvdnav=enabled
  -Dlibmpv=true -Dcplugins=enabled

Re: pipewire: update to 1.4.0

[eskeletor97]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

New comment by eskeletor97 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2708379114

Comment:
Tried it, or rather tried trying it, but the moment I hover over a minimized window on taskbar in KDE Plasma (tries to render the window preview), desktop env just crashes and kicks me out to sddm. Is there some plasma component that needs to be rebuilt too?

Re: pipewire: update to 1.4.0

[tm512]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2708711328

Comment:
For the thumbnails is Plasma using portals + pipewire (like with screen sharing)? `xdg-desktop-portal` depends on libpipewire, and in turn it's a dependency of `xdg-desktop-portal-kde`, so perhaps it needs to be rebuilt. Could you let me know if the issue persists if you bump the revision of `xdg-desktop-portal` and rebuild it?

Re: pipewire: update to 1.4.0

[tm512]

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2708711328

Comment:
For the thumbnails is Plasma using portals + pipewire (like with screen sharing)? `xdg-desktop-portal` depends on libpipewire, and in turn it's a dependency of `xdg-desktop-portal-kde`, so perhaps it needs to be rebuilt. Could you let me know if the issue persists if you bump the revision of `xdg-desktop-portal` and rebuild it?

Edit: looking at the reverse dependencies some more, I see both `kpipewire` and `kwin` both depend on libpipewire and might be culprits.

Re: pipewire: update to 1.4.0

[eskeletor97]

[-- Attachment #1: Type: text/plain, Size: 860 bytes --]

New comment by eskeletor97 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2708750881

Comment:
Okay, I tried bumping the packages you mentioned, but it didn't end up fixing it, but I've observed some really strange things.
1. Crash doesn't happen on 1.2.7.
2. Crash does happen even if pipewire(1.4.0) runs under the same session as kde.
3. Crash DOESN'T happen if I run pipewire (1.4.0) in a separate tty.
Also I've tried creating a new user account to test kde on a fresh config. And the issue doesn't happen there. So the issue occurs only on my main user account. Logs don't give anything because segfault happens in the application I hover over, not in kwin. Might be my fault because I changed something in the settings, but I didn't touch anything outside of what's available in the user interface.

Re: pipewire: update to 1.4.0

[eskeletor97]

[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]

New comment by eskeletor97 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2708750881

Comment:
Okay, I tried bumping the packages you mentioned, but it didn't end up fixing it, but I've observed some really strange things.
1. Crash doesn't happen on 1.2.7.
2. Crash does happen even if pipewire(1.4.0) runs under the same session as kde.
3. Crash DOESN'T happen if I run pipewire (1.4.0) in a separate tty.
Also I've tried creating a new user account to test kde on a fresh config. And the issue doesn't happen there. So the issue occurs only on my main user account. Logs don't give anything because segfault happens in the application I hover over, not in kwin. Might be my fault because I changed something in the settings, but I didn't touch anything outside of what's available in the user interface.

EDIT: It was crashing due to the fact that my account was in realtime group. After removing myself from it issue is gone. Sorry for wasting your time.

Re: pipewire: update to 1.4.0

[tm512]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2715955641

Comment:
Good to have it figured out at least. Is there a practical application to have your user in the `realtime` group, where this issue could end up being a blocker and worth bringing up with pipewire and/or KDE devs?

Re: pipewire: update to 1.4.0

[eskeletor97]

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

New comment by eskeletor97 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2716015928

Comment:
It should've allowed pipewire in the past to run at realtime without root. I'm not sure if this is a blocker, but it could definitely cause issues if someone needs that functionality for different applications (like audio production and such).
Also on the other note, after running 1.4.0 for a few days I noticed that screen sharing doesn't work (in discord, or through web browser), while on 1.2.7 it does. Does it work for you (or anyone on void)? I can't find any reports online, so I'm worried that it's something on my end again.

Re: pipewire: update to 1.4.0

[tm512]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2716194222

Comment:
I think nowadays rtkit is what's intended to be used for giving pipewire realtime privileges. Not sure if that covers every possible situation where someone might want to add themselves to the `realtime` group.

As for screen sharing through portals + pipewire, I don't actually have a desktop setup that utilizes that (I'm on Xorg and dwm). Hopefully someone else can chime in.

Re: pipewire: update to 1.4.0

[tm512]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2741675684

Comment:
About to push an update to 1.4.1 (which I've been running locally for about a week). I did get confirmation from someone else that 1.4.0 at least broke screen sharing on Plasma. Assuming that is still the case with 1.4.1, as a shot in the dark I've drafted an update to xdg-desktop-portal which on Void is currently a bit out of date. Perhaps it is missing something that more recent versions of KDE and pipewire rely on to facilitate screen sharing? I'd appreciate some testing on that when I get a PR put together for it.

Re: [PR PATCH] [Updated] pipewire: update to 1.4.0

[tm512]

[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]

There is an updated pull request by tm512 against master on the void-packages repository

https://github.com/tm512/void-packages pipewire-1.4.0
https://github.com/void-linux/void-packages/pull/54604

pipewire: update to 1.4.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly** (at least for the official 1.4 release, though I have been using the 1.3.x release candidates without any issues for about a month)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (crossbuilds):
  - aarch64-glibc

PipeWire 1.4 adds support for EBU R128 loudness normalization (via libebur128), so I've added that as a dependency. Should it be put behind a build option? I would have to make sure that it actually has a meson flag and isn't a hard dependency.

A patch file from https://github.com/void-linux/void-packages/pull/54604.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-1.4.0-54604.patch --]
[-- Type: text/x-diff, Size: 4483 bytes --]

From f6b8f083f8a06541b38a5cd7c39d95ff85865446 Mon Sep 17 00:00:00 2001
From: tm512 <elykdav@gmail.com>
Date: Thu, 20 Mar 2025 14:04:27 -0700
Subject: [PATCH 1/2] pipewire: update to 1.4.1

---
 srcpkgs/pipewire/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index d72527baa26b86..b9649d6a7a2ad9 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=1.2.7
+version=1.4.1
 revision=1
 build_style=meson
 configure_args="
@@ -30,10 +30,10 @@ makedepends="$(vopt_if sdl2 SDL2-devel) gst-plugins-base1-devel jack-devel
  vulkan-loader-devel pulseaudio-devel avahi-libs-devel webrtc-audio-processing-devel
  readline-devel openssl-devel lilv-devel libcanberra-devel dbus-devel
  libmysofa-devel opus-devel $(vopt_if ffado libffado-devel) liblc3-devel
- $(vopt_if selinux libselinux-devel) libcamera-devel libcap-devel"
+ $(vopt_if selinux libselinux-devel) libcamera-devel libcap-devel libebur128-devel"
 depends="libspa-alsa>=${version}_${revision} libspa-audioconvert>=${version}_${revision}
  libspa-audiomixer>=${version}_${revision} libspa-control>=${version}_${revision}
- libspa-v4l2>=${version}_${revision} pulseaudio-utils virtual?pipewire-session-manager"
+ libspa-v4l2>=${version}_${revision} pulseaudio-utils libebur128 virtual?pipewire-session-manager"
 checkdepends="pulseaudio-utils"
 short_desc="Server and user space API to deal with multimedia pipelines"
 maintainer="cinerea0 <cinerea0@protonmail.com>"
@@ -41,7 +41,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=e75568ed18bcbe75e9779af57cb9cc256fd7ebfaadc12bb347a0717055d1d3a9
+checksum=1eba67c6e5acfa23e32d70bdbabab5a3d221c4bfbb12e17aa29fd5051c095fa4
 make_dirs="/var/lib/pipewire 0755 _pipewire _pipewire"
 system_accounts="_pipewire"
 

From 571bfb907ca1a58d1be3ae687a6d91021c0e31cc Mon Sep 17 00:00:00 2001
From: tm512 <elykdav@gmail.com>
Date: Thu, 6 Mar 2025 17:16:11 -0800
Subject: [PATCH 2/2] mpv: backport fix for pipewire-1.4.0

---
 .../mpv/patches/0.39.0-pipewire-1.4-fix.patch | 33 +++++++++++++++++++
 srcpkgs/mpv/template                          |  2 +-
 2 files changed, 34 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch

diff --git a/srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch b/srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch
new file mode 100644
index 00000000000000..bdeaade6f93131
--- /dev/null
+++ b/srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch
@@ -0,0 +1,33 @@
+https://github.com/mpv-player/mpv/commit/c9970b5ba66e25aeab36cdbdb91b973f2d3f8d90.patch
+From c9970b5ba66e25aeab36cdbdb91b973f2d3f8d90 Mon Sep 17 00:00:00 2001
+From: llyyr <llyyr.public@gmail.com>
+Date: Wed, 19 Feb 2025 19:08:36 +0530
+Subject: [PATCH] ao_pipewire: don't load client-rt.conf properties
+
+Deprecated in https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/24bcacc6195ffbf8e40c9ea1374eb6666252eadc
+
+Fixes: #15914
+---
+ audio/out/ao_pipewire.c | 9 +++++----
+ 1 file changed, 5 insertions(+), 4 deletions(-)
+
+diff --git a/audio/out/ao_pipewire.c b/audio/out/ao_pipewire.c
+index 5e6bb1fa4fdf7..88c48ddca60e7 100644
+--- a/audio/out/ao_pipewire.c
++++ b/audio/out/ao_pipewire.c
+@@ -510,10 +510,11 @@ static int pipewire_init_boilerplate(struct ao *ao)
+     if (pw_thread_loop_start(p->loop) < 0)
+         goto error;
+ 
+-    context = pw_context_new(
+-            pw_thread_loop_get_loop(p->loop),
+-            pw_properties_new(PW_KEY_CONFIG_NAME, "client-rt.conf", NULL),
+-            0);
++    struct pw_properties *props = NULL;
++#if !PW_CHECK_VERSION(1, 3, 81)
++    props = pw_properties_new(PW_KEY_CONFIG_NAME, "client-rt.conf", NULL);
++#endif
++    context = pw_context_new(pw_thread_loop_get_loop(p->loop), props, 0);
+     if (!context)
+         goto error;
+ 
diff --git a/srcpkgs/mpv/template b/srcpkgs/mpv/template
index c1ce4c3a59a9b8..778f5e6fd5bb08 100644
--- a/srcpkgs/mpv/template
+++ b/srcpkgs/mpv/template
@@ -1,7 +1,7 @@
 # Template file for 'mpv'
 pkgname=mpv
 version=0.39.0
-revision=2
+revision=3
 build_style=meson
 configure_args="-Dcdda=enabled -Ddvbin=enabled -Ddvdnav=enabled
  -Dlibmpv=true -Dcplugins=enabled

Re: pipewire: update to 1.4.1

[tm512]

[-- Attachment #1: Type: text/plain, Size: 3530 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2742125405

Comment:
I was asked to not post this as a PR, since it's speculative and I don't currently have anything set up to test it. To at least make the patch available for testing, I guess I will just post it here. This updates xdg-desktop-portal to 1.20.0, and updates umockdev 0.19.1 in order to get 1.20.0 to build. @eskeletor97 @Johnnynator if you have the time and get the chance to, could you test this out and let me know whether this fixes screen sharing on KDE and pipewire 1.4? If so, I can clean it up and either post it as a separate PR, or add these as commits to this PR if that would be more appropriate.

```diff
diff --git a/srcpkgs/umockdev/template b/srcpkgs/umockdev/template
index 1439c8e603d..d1b7d813f0f 100644
--- a/srcpkgs/umockdev/template
+++ b/srcpkgs/umockdev/template
@@ -1,18 +1,18 @@
 # Template file for 'umockdev'
 pkgname=umockdev
-version=0.17.13
+version=0.19.1
 revision=1
 build_style=meson
 build_helper="gir"
 hostmakedepends="pkg-config vala"
-makedepends="vala-devel eudev-libudev-devel libpcap-devel gobject-introspection"
+makedepends="vala-devel eudev-libudev-devel libpcap-devel gobject-introspection libglib-devel"
 checkdepends="eudev which gphoto2 libgudev-devel python3-gobject usbutils xz"
 short_desc="Mock hardware devices for creating unit tests and bug reporting"
 maintainer="oreo639 <oreo6391@gmail.com>"
 license="LGPL-2.1-or-later"
 homepage="https://github.com/martinpitt/umockdev"
 distfiles="https://github.com/martinpitt/umockdev/releases/download/${version}/umockdev-${version}.tar.xz"
-checksum=6c6ebf6e6209b6a49746e0d91a448d027b54271bab82ed70a132ecf294ca13cf
+checksum=2cece0e8e366b89b4070be74f3389c9f7fa21aca56d8a5357e96e30cd8d4f426
 
 umockdev-devel_package() {
 	depends="umockdev>=${version}_${revision}"
diff --git a/srcpkgs/xdg-desktop-portal/template b/srcpkgs/xdg-desktop-portal/template
index 6b492fbd09c..17bcf4f68a9 100644
--- a/srcpkgs/xdg-desktop-portal/template
+++ b/srcpkgs/xdg-desktop-portal/template
@@ -1,21 +1,21 @@
 # Template file for 'xdg-desktop-portal'
 pkgname=xdg-desktop-portal
-version=1.18.4
+version=1.20.0
 revision=1
 build_style=meson
-configure_args="-Dgeoclue=enabled -Dlibportal=enabled
- -Dsystemd=disabled"
-hostmakedepends="pkg-config gettext glib-devel bubblewrap flatpak python3-docutils"
+configure_args="-Dgeoclue=enabled -Dsystemd=disabled"
+hostmakedepends="pkg-config gettext glib-devel bubblewrap flatpak python3-docutils python3-pytest
+ dbus python3-dbusmock gst-plugins-good1"
 makedepends="flatpak-devel fuse3-devel pipewire-devel geoclue2-devel
- libportal-devel polkit-devel"
-checkdepends="dbus python3-dbusmock"
+ libportal-devel polkit-devel gst-plugins-base1-devel libumockdev-devel"
+#checkdepends="dbus python3-dbusmock"
 short_desc="Portal frontend service for Flatpak"
 maintainer="Duncaen <duncaen@voidlinux.org>"
 license="LGPL-2.1-or-later"
 homepage="https://github.com/flatpak/xdg-desktop-portal"
 changelog="https://github.com/flatpak/xdg-desktop-portal/raw/main/NEWS"
 distfiles="https://github.com/flatpak/xdg-desktop-portal/archive/refs/tags/${version}.tar.gz"
-checksum=028d5aec19a7f6fdbe76d6c7cf982cbc4e4ee290493ded3a16b67dfff5cad589
+checksum=b596fa3dcec67e90d5a657395a17e347820095ac5616a28ba319f4d45a999792
 
 if [ "$XBPS_BUILD_ENVIRONMENT" = "void-packages-ci" ]; then
 	export TEST_IN_CI="true"
 ```

Re: pipewire: update to 1.4.1

[eskeletor97]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

New comment by eskeletor97 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2742703517

Comment:
Applied your diff, updated to pipewire 1.4.1 and rebuilt xdg-desktop-portal/-kde, but still fails with `Failed to create PipeWire stream` from KDE Portal Integration.

Re: pipewire: update to 1.4.1

[tm512]

[-- Attachment #1: Type: text/plain, Size: 511 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2744542627

Comment:
Thanks. Honestly, I'm at a bit of a loss here, and might've bit off more than I can chew by even touching pipewire. I'd need some real logs detailing the issue, since it seems like blind speculation is just going to waste everyone's time. I'm not entirely sure where logs would be sent, though. Does `dbus-monitor --session` spit out any details about the portal failure?

Re: pipewire: update to 1.4.1

[eskeletor97]

[-- Attachment #1: Type: text/plain, Size: 3413 bytes --]

New comment by eskeletor97 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2745148117

Comment:
dbus-monitor --session  "interface=org.freedesktop.portal.ScreenCast"
```
signal time=1742633165.492730 sender=org.freedesktop.DBus -> destination=:1.154 serial=2 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameAcquired
   string ":1.154"
signal time=1742633165.492740 sender=org.freedesktop.DBus -> destination=:1.154 serial=4 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameLost
   string ":1.154"
method call time=1742633198.364955 sender=:1.158 -> destination=:1.5 serial=9 path=/org/freedesktop/portal/desktop; interface=org.freedesktop.portal.ScreenCast; member=CreateSession
   array [
      dict entry(
         string "session_handle_token"
         variant             string "webrtc_session921315248"
      )
      dict entry(
         string "handle_token"
         variant             string "webrtc_4666713"
      )
   ]
method call time=1742633198.367304 sender=:1.158 -> destination=:1.5 serial=11 path=/org/freedesktop/portal/desktop; interface=org.freedesktop.portal.ScreenCast; member=SelectSources
   object path "/org/freedesktop/portal/desktop/session/1_158/webrtc_session921315248"
   array [
      dict entry(
         string "types"
         variant             uint32 2
      )
      dict entry(
         string "multiple"
         variant             boolean false
      )
      dict entry(
         string "cursor_mode"
         variant             uint32 4
      )
      dict entry(
         string "persist_mode"
         variant             uint32 1
      )
      dict entry(
         string "handle_token"
         variant             string "webrtc1183295161"
      )
   ]
method call time=1742633198.368314 sender=:1.158 -> destination=:1.5 serial=12 path=/org/freedesktop/portal/desktop; interface=org.freedesktop.portal.ScreenCast; member=Start
   object path "/org/freedesktop/portal/desktop/session/1_158/webrtc_session921315248"
   string ""
   array [
      dict entry(
         string "handle_token"
         variant             string "webrtc1982387488"
      )
   ]
```
So dbus is receiving and responding to the request.

/usr/libexec/xdg-desktop-portal-kde --replace
```
qrc:/qt/qml/org/kde/desktop/TabButton.qml:22: TypeError: Cannot read property 'y' of null
qrc:/qt/qml/org/kde/desktop/TabButton.qml:22: TypeError: Cannot read property 'y' of null
error creating screencast "Failed to create PipeWire stream"
error creating screencast "Failed to create PipeWire stream"
error creating screencast "Failed to create PipeWire stream"
qt.svg: link #SVGID17 is undefined!
qt.svg: link #SVGID17 is undefined!
qt.svg: link #SVGID17 is undefined!
qt.svg: link #SVGID17 is undefined!
qt.svg: link #SVGID17 is undefined!
qt.svg: link #SVGID17 is undefined!
qt.svg: link #SVGID17 is undefined!
qt.svg: link #SVGID17 is undefined!
xdp-kde-wayland-integration: failed to start streaming ScreencastingStream(0x55ffd61ecdf0) "Failed to create PipeWire stream"
xdp-kde-screencast: Invalid window! KWayland::Client::PlasmaWindow(0x55ffd566a630)
```
And then something goes wrong in the kde portal integration.

Nothing shows up in the pipewire log, it's like it's doesn't even know that it's supposed to do something.

Re: pipewire: update to 1.4.1

[tm512]

[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2746481799

Comment:
The other day I ended up getting KDE set up in a VM to investigate, and basically was seeing the exact same thing (albeit with OBS to test screen sharing). With the `org.freedesktop.portal.ScreenCast` interface I couldn't discern any difference between the output on a failed run with pw 1.4.1, and a successful run on 1.2.7, same stuff being sent over dbus. Broadening the scope to the entire bus, the only thing I could make out regarding the issue was the notification being sent.

Likewise I looked at pipewire's logging, xdg-desktop-portal's logging, and xdg-desktop-portal-kde's logging. Zero meaningful leads. It's baffling. Next time I have the time and the energy to, I'll probably go upstream and start asking about what could even be going on. I still suspect there's some related package that's too out of date on Void, but I'm kinda running out of obvious culprits. I've tried updating wireplumber in addition to xdg-desktop-portal, to no avail.

Re: pipewire: update to 1.4.1

[eskeletor97]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

New comment by eskeletor97 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2747071643

Comment:
Thanks for confirming it's not just something on my end. It's baffling to me too, especially that changelog claims API and ABI compatibility. Now I'm wondering if any of 1.3.x preview versions worked, maybe the "breaking" change was something relatively recent?

Re: pipewire: update to 1.4.1

[tm512]

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2747374374

Comment:
The patched template (adding libebur128 as a dependency) works as-is with at least 1.3.82 and 1.3.83 since it was initially made for the former. If you feel inclined to try it out, and it does happen to work on one of those RCs, it would narrow down the range for `git bisect`, if it comes down to that. I've wanted to avoid it, given the overhead of xbps-src, but maybe it'll end up being the only way to actually see what the issue is.

When I get around to it, I think my plan (since I don't think I have enough information or a solid case for an issue report yet) is to hop on the pipewire and/or freedesktop IRC channels and see if anyone might have ideas about where I could even look for clues.

Re: pipewire: update to 1.4.1

[eskeletor97]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New comment by eskeletor97 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2747924566

Comment:
I tried all RCs out, but sadly none of them worked. It's broken since the first one.

Re: pipewire: update to 1.4.1

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2750259665

Comment:
Does it work after installing `libspa-vulkan`?

Re: pipewire: update to 1.4.1

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2750259665

Comment:
Does it work after installing `libspa-vulkan`?

Apparently this is required with `-Dffmpeg=enabled` is specified (which we do through `--auto-features=enabled`).
The ffmpeg video converter was a recent addition: https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/2cbcdbc579bbffa682088fbedbca10e278e061dd

Re: pipewire: update to 1.4.1

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2750259665

Comment:
Does it work after installing `libspa-vulkan`?

Apparently the vulkan plugin is required with `-Dffmpeg=enabled` is specified (which we do through `--auto-features=enabled`).
The ffmpeg video converter was a recent addition: https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/2cbcdbc579bbffa682088fbedbca10e278e061dd

Re: pipewire: update to 1.4.1

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2750259665

Comment:
Does it work after installing `libspa-vulkan`?

Apparently the vulkan plugin is required when `-Dffmpeg=enabled` is specified (which we do through `--auto-features=enabled`).
The ffmpeg video converter was a recent addition: https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/2cbcdbc579bbffa682088fbedbca10e278e061dd

Re: pipewire: update to 1.4.1

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 494 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2750259665

Comment:
Does it work after installing `libspa-vulkan`?

The vulkan plugin seems to be required for the videoconvert plugin when `-Dffmpeg=enabled` is specified (which we do through `--auto-features=enabled`).
The ffmpeg video converter was a recent addition: https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/2cbcdbc579bbffa682088fbedbca10e278e061dd

Re: pipewire: update to 1.4.1

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2750259665

Comment:
Does it work after installing `libspa-vulkan`?

The vulkan plugin seems to be required for the videoconvert plugin when `-Dffmpeg=enabled` is specified (which we do through `--auto-features=enabled`).
The ffmpeg video converter was a recent addition: https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/2cbcdbc579bbffa682088fbedbca10e278e061dd

(The videoconvert plugin is used for screencast and camera)

Re: pipewire: update to 1.4.1

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2750259665

Comment:
Does it work after installing `libspa-videoconvert`?

Re: pipewire: update to 1.4.1

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2750259665

Comment:
Does it work after installing `libspa-videoconvert`?
(The videoconvert plugin is required for screencast and camera)

Re: pipewire: update to 1.4.1

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2750259665

Comment:
Does it work after installing `libspa-videoconvert`?

Re: [PR PATCH] [Updated] pipewire: update to 1.4.1

[tm512]

[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]

There is an updated pull request by tm512 against master on the void-packages repository

https://github.com/tm512/void-packages pipewire-1.4.0
https://github.com/void-linux/void-packages/pull/54604

pipewire: update to 1.4.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly** (at least for the official 1.4 release, though I have been using the 1.3.x release candidates without any issues for about a month)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (crossbuilds):
  - aarch64-glibc

PipeWire 1.4 adds support for EBU R128 loudness normalization (via libebur128), so I've added that as a dependency. Should it be put behind a build option? I would have to make sure that it actually has a meson flag and isn't a hard dependency.

A patch file from https://github.com/void-linux/void-packages/pull/54604.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-1.4.0-54604.patch --]
[-- Type: text/x-diff, Size: 4530 bytes --]

From 25d95aede9f4c7dc47ffcfe85c6c89f76611f28b Mon Sep 17 00:00:00 2001
From: tm512 <elykdav@gmail.com>
Date: Tue, 25 Mar 2025 01:43:49 -0700
Subject: [PATCH 1/2] pipewire: update to 1.4.1

---
 srcpkgs/pipewire/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index d72527baa26b86..312f6051257de3 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=1.2.7
+version=1.4.1
 revision=1
 build_style=meson
 configure_args="
@@ -30,10 +30,11 @@ makedepends="$(vopt_if sdl2 SDL2-devel) gst-plugins-base1-devel jack-devel
  vulkan-loader-devel pulseaudio-devel avahi-libs-devel webrtc-audio-processing-devel
  readline-devel openssl-devel lilv-devel libcanberra-devel dbus-devel
  libmysofa-devel opus-devel $(vopt_if ffado libffado-devel) liblc3-devel
- $(vopt_if selinux libselinux-devel) libcamera-devel libcap-devel"
+ $(vopt_if selinux libselinux-devel) libcamera-devel libcap-devel libebur128-devel"
 depends="libspa-alsa>=${version}_${revision} libspa-audioconvert>=${version}_${revision}
  libspa-audiomixer>=${version}_${revision} libspa-control>=${version}_${revision}
- libspa-v4l2>=${version}_${revision} pulseaudio-utils virtual?pipewire-session-manager"
+ libspa-v4l2>=${version}_${revision} libspa-videoconvert>=${version}_${revision}
+ pulseaudio-utils libebur128 virtual?pipewire-session-manager"
 checkdepends="pulseaudio-utils"
 short_desc="Server and user space API to deal with multimedia pipelines"
 maintainer="cinerea0 <cinerea0@protonmail.com>"
@@ -41,7 +42,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=e75568ed18bcbe75e9779af57cb9cc256fd7ebfaadc12bb347a0717055d1d3a9
+checksum=1eba67c6e5acfa23e32d70bdbabab5a3d221c4bfbb12e17aa29fd5051c095fa4
 make_dirs="/var/lib/pipewire 0755 _pipewire _pipewire"
 system_accounts="_pipewire"
 

From 4a9684ccfc2608d7dfde2cf05090ad22e3f0d5c6 Mon Sep 17 00:00:00 2001
From: tm512 <elykdav@gmail.com>
Date: Thu, 6 Mar 2025 17:16:11 -0800
Subject: [PATCH 2/2] mpv: backport fix for pipewire-1.4.0

---
 .../mpv/patches/0.39.0-pipewire-1.4-fix.patch | 33 +++++++++++++++++++
 srcpkgs/mpv/template                          |  2 +-
 2 files changed, 34 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch

diff --git a/srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch b/srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch
new file mode 100644
index 00000000000000..bdeaade6f93131
--- /dev/null
+++ b/srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch
@@ -0,0 +1,33 @@
+https://github.com/mpv-player/mpv/commit/c9970b5ba66e25aeab36cdbdb91b973f2d3f8d90.patch
+From c9970b5ba66e25aeab36cdbdb91b973f2d3f8d90 Mon Sep 17 00:00:00 2001
+From: llyyr <llyyr.public@gmail.com>
+Date: Wed, 19 Feb 2025 19:08:36 +0530
+Subject: [PATCH] ao_pipewire: don't load client-rt.conf properties
+
+Deprecated in https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/24bcacc6195ffbf8e40c9ea1374eb6666252eadc
+
+Fixes: #15914
+---
+ audio/out/ao_pipewire.c | 9 +++++----
+ 1 file changed, 5 insertions(+), 4 deletions(-)
+
+diff --git a/audio/out/ao_pipewire.c b/audio/out/ao_pipewire.c
+index 5e6bb1fa4fdf7..88c48ddca60e7 100644
+--- a/audio/out/ao_pipewire.c
++++ b/audio/out/ao_pipewire.c
+@@ -510,10 +510,11 @@ static int pipewire_init_boilerplate(struct ao *ao)
+     if (pw_thread_loop_start(p->loop) < 0)
+         goto error;
+ 
+-    context = pw_context_new(
+-            pw_thread_loop_get_loop(p->loop),
+-            pw_properties_new(PW_KEY_CONFIG_NAME, "client-rt.conf", NULL),
+-            0);
++    struct pw_properties *props = NULL;
++#if !PW_CHECK_VERSION(1, 3, 81)
++    props = pw_properties_new(PW_KEY_CONFIG_NAME, "client-rt.conf", NULL);
++#endif
++    context = pw_context_new(pw_thread_loop_get_loop(p->loop), props, 0);
+     if (!context)
+         goto error;
+ 
diff --git a/srcpkgs/mpv/template b/srcpkgs/mpv/template
index c1ce4c3a59a9b8..778f5e6fd5bb08 100644
--- a/srcpkgs/mpv/template
+++ b/srcpkgs/mpv/template
@@ -1,7 +1,7 @@
 # Template file for 'mpv'
 pkgname=mpv
 version=0.39.0
-revision=2
+revision=3
 build_style=meson
 configure_args="-Dcdda=enabled -Ddvbin=enabled -Ddvdnav=enabled
  -Dlibmpv=true -Dcplugins=enabled

Re: pipewire: update to 1.4.1

[tm512]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2750553789

Comment:
Added `libspa-videoconvert` to `pipewire`'s dependencies. Solves the issue on this VM setup.

Re: pipewire: update to 1.4.1

[eskeletor97]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

New comment by eskeletor97 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2751017930

Comment:
Yup, works on my bare metal too.

Re: pipewire: update to 1.4.1

[tm512]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2785243641

Comment:
Sorry it's been a bit since I've done anything with this PR. I remember I saw some disagreement on IRC about whether `libspa-videoconvert` belongs as a dependency of `pipewire` itself, or if it should be a dependency of `xdg-desktop-portal` instead. Was there a resolution to that?

Re: pipewire: update to 1.4.1

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2785268381

Comment:
> or if it should be a dependency of `xdg-desktop-portal` instead. Was there a resolution to that?

It isn't just required for xdg-destkop-portal it is necessary for anything involving video (including Camera).

Re: pipewire: update to 1.4.1

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 355 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2785268381

Comment:
> or if it should be a dependency of `xdg-desktop-portal` instead. Was there a resolution to that?

It isn't just required for xdg-destkop-portal, it is necessary for anything involving video (including Camera).

Re: pipewire: update to 1.4.1

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2785268381

Comment:
> or if it should be a dependency of `xdg-desktop-portal` instead. Was there a resolution to that?

It isn't just required for xdg-destkop-portal, it is necessary for anything involving video (including Camera support).

Re: pipewire: update to 1.4.1

[oreo639]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

New comment by oreo639 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2785268381

Comment:
> or if it should be a dependency of `xdg-desktop-portal` instead. Was there a resolution to that?

It isn't just required for xdg-destkop-portal, it is necessary for anything involving video (including Camera support, regardless of if you are using portals or libpipewire directly).

Re: pipewire: update to 1.4.1

[tm512]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2787798929

Comment:
Alright, so in that case I'll leave the dependencies as-is. Unrelated to that though, I noticed mpv 0.40.0 has been released, which contains the fix I backported in this PR. If mpv is updated prior to this being pulled, I could revise this and drop the patch + revbump. I'm guessing that would be preferable?

Re: pipewire: update to 1.4.1

[tm512]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2787798929

Comment:
Alright, so in that case I'll leave the dependencies as-is. Unrelated to that though, I noticed mpv 0.40.0 has been released, which contains the fix I backported in this PR. If mpv is updated prior to this being pulled, I could revise this and drop the patch + revbump. I'm guessing that would be preferable?

Edit: Huh, actually, I just built 0.40.0 and it does not appear to contain the fix. Bizarre. Going to see if I messed up with something.

Re: pipewire: update to 1.4.1

[tm512]

[-- Attachment #1: Type: text/plain, Size: 815 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2787798929

Comment:
Alright, so in that case I'll leave the dependencies as-is. Unrelated to that though, I noticed mpv 0.40.0 has been released, which contains the fix I backported in this PR. If mpv is updated prior to this being pulled, I could revise this and drop the patch + revbump. I'm guessing that would be preferable?

Edit: Huh, actually, I just built 0.40.0 and it does not appear to contain the fix. Bizarre. Going to see if I messed up with something.

Edit 2: I see, the pipewire version check is a compile-time macro. Unless the mpv update is building from a tree where pipewire is already updated, it's going to compile in with the code that spits out deprecation warnings.

Re: [PR PATCH] [Updated] pipewire: update to 1.4.1

[tm512]

[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]

There is an updated pull request by tm512 against master on the void-packages repository

https://github.com/tm512/void-packages pipewire-1.4.0
https://github.com/void-linux/void-packages/pull/54604

pipewire: update to 1.4.1
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly** (at least for the official 1.4 release, though I have been using the 1.3.x release candidates without any issues for about a month)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (crossbuilds):
  - aarch64-glibc

PipeWire 1.4 adds support for EBU R128 loudness normalization (via libebur128), so I've added that as a dependency. Should it be put behind a build option? I would have to make sure that it actually has a meson flag and isn't a hard dependency.

A patch file from https://github.com/void-linux/void-packages/pull/54604.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pipewire-1.4.0-54604.patch --]
[-- Type: text/x-diff, Size: 4530 bytes --]

From 46e14c529893a4ca3af19607e0a0d87d1276945b Mon Sep 17 00:00:00 2001
From: tm512 <elykdav@gmail.com>
Date: Tue, 29 Apr 2025 15:33:45 -0700
Subject: [PATCH 1/2] pipewire: update to 1.4.2

---
 srcpkgs/pipewire/template | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/pipewire/template b/srcpkgs/pipewire/template
index d72527baa26b86..7f786bb9aa5ce4 100644
--- a/srcpkgs/pipewire/template
+++ b/srcpkgs/pipewire/template
@@ -1,6 +1,6 @@
 # Template file for 'pipewire'
 pkgname=pipewire
-version=1.2.7
+version=1.4.2
 revision=1
 build_style=meson
 configure_args="
@@ -30,10 +30,11 @@ makedepends="$(vopt_if sdl2 SDL2-devel) gst-plugins-base1-devel jack-devel
  vulkan-loader-devel pulseaudio-devel avahi-libs-devel webrtc-audio-processing-devel
  readline-devel openssl-devel lilv-devel libcanberra-devel dbus-devel
  libmysofa-devel opus-devel $(vopt_if ffado libffado-devel) liblc3-devel
- $(vopt_if selinux libselinux-devel) libcamera-devel libcap-devel"
+ $(vopt_if selinux libselinux-devel) libcamera-devel libcap-devel libebur128-devel"
 depends="libspa-alsa>=${version}_${revision} libspa-audioconvert>=${version}_${revision}
  libspa-audiomixer>=${version}_${revision} libspa-control>=${version}_${revision}
- libspa-v4l2>=${version}_${revision} pulseaudio-utils virtual?pipewire-session-manager"
+ libspa-v4l2>=${version}_${revision} libspa-videoconvert>=${version}_${revision}
+ pulseaudio-utils libebur128 virtual?pipewire-session-manager"
 checkdepends="pulseaudio-utils"
 short_desc="Server and user space API to deal with multimedia pipelines"
 maintainer="cinerea0 <cinerea0@protonmail.com>"
@@ -41,7 +42,7 @@ license="MIT"
 homepage="https://pipewire.org/"
 changelog="https://gitlab.freedesktop.org/pipewire/pipewire/-/raw/master/NEWS"
 distfiles="https://gitlab.freedesktop.org/pipewire/pipewire/-/archive/${version}/pipewire-${version}.tar.gz"
-checksum=e75568ed18bcbe75e9779af57cb9cc256fd7ebfaadc12bb347a0717055d1d3a9
+checksum=4712aada64b9b49ad41fbb8b440914481432a560f2619ffbdd49461f8d22994f
 make_dirs="/var/lib/pipewire 0755 _pipewire _pipewire"
 system_accounts="_pipewire"
 

From 34b1eafe49f29a8a166f18877e952edefdc0025b Mon Sep 17 00:00:00 2001
From: tm512 <elykdav@gmail.com>
Date: Thu, 6 Mar 2025 17:16:11 -0800
Subject: [PATCH 2/2] mpv: backport fix for pipewire-1.4.0

---
 .../mpv/patches/0.39.0-pipewire-1.4-fix.patch | 33 +++++++++++++++++++
 srcpkgs/mpv/template                          |  2 +-
 2 files changed, 34 insertions(+), 1 deletion(-)
 create mode 100644 srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch

diff --git a/srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch b/srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch
new file mode 100644
index 00000000000000..bdeaade6f93131
--- /dev/null
+++ b/srcpkgs/mpv/patches/0.39.0-pipewire-1.4-fix.patch
@@ -0,0 +1,33 @@
+https://github.com/mpv-player/mpv/commit/c9970b5ba66e25aeab36cdbdb91b973f2d3f8d90.patch
+From c9970b5ba66e25aeab36cdbdb91b973f2d3f8d90 Mon Sep 17 00:00:00 2001
+From: llyyr <llyyr.public@gmail.com>
+Date: Wed, 19 Feb 2025 19:08:36 +0530
+Subject: [PATCH] ao_pipewire: don't load client-rt.conf properties
+
+Deprecated in https://gitlab.freedesktop.org/pipewire/pipewire/-/commit/24bcacc6195ffbf8e40c9ea1374eb6666252eadc
+
+Fixes: #15914
+---
+ audio/out/ao_pipewire.c | 9 +++++----
+ 1 file changed, 5 insertions(+), 4 deletions(-)
+
+diff --git a/audio/out/ao_pipewire.c b/audio/out/ao_pipewire.c
+index 5e6bb1fa4fdf7..88c48ddca60e7 100644
+--- a/audio/out/ao_pipewire.c
++++ b/audio/out/ao_pipewire.c
+@@ -510,10 +510,11 @@ static int pipewire_init_boilerplate(struct ao *ao)
+     if (pw_thread_loop_start(p->loop) < 0)
+         goto error;
+ 
+-    context = pw_context_new(
+-            pw_thread_loop_get_loop(p->loop),
+-            pw_properties_new(PW_KEY_CONFIG_NAME, "client-rt.conf", NULL),
+-            0);
++    struct pw_properties *props = NULL;
++#if !PW_CHECK_VERSION(1, 3, 81)
++    props = pw_properties_new(PW_KEY_CONFIG_NAME, "client-rt.conf", NULL);
++#endif
++    context = pw_context_new(pw_thread_loop_get_loop(p->loop), props, 0);
+     if (!context)
+         goto error;
+ 
diff --git a/srcpkgs/mpv/template b/srcpkgs/mpv/template
index c1ce4c3a59a9b8..778f5e6fd5bb08 100644
--- a/srcpkgs/mpv/template
+++ b/srcpkgs/mpv/template
@@ -1,7 +1,7 @@
 # Template file for 'mpv'
 pkgname=mpv
 version=0.39.0
-revision=2
+revision=3
 build_style=meson
 configure_args="-Dcdda=enabled -Ddvbin=enabled -Ddvdnav=enabled
  -Dlibmpv=true -Dcplugins=enabled

Re: pipewire: update to 1.4.2

[tm512]

[-- Attachment #1: Type: text/plain, Size: 362 bytes --]

New comment by tm512 on void-packages repository

https://github.com/void-linux/void-packages/pull/54604#issuecomment-2840401951

Comment:
Sorry for the lull in updates, haven't had the time or motivation to do anything with this for the last couple weeks, but I've bumped up to 1.4.2 which I've had running locally for the last day or so, and no problems here.

Re: [PR PATCH] [Merged]: pipewire: update to 1.4.2

[Johnnynator]

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

There's a merged pull request on the void-packages repository

pipewire: update to 1.4.2
https://github.com/void-linux/void-packages/pull/54604

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly** (at least for the official 1.4 release, though I have been using the 1.3.x release candidates without any issues for about a month)

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
- I built this PR locally for these architectures (crossbuilds):
  - aarch64-glibc

PipeWire 1.4 adds support for EBU R128 loudness normalization (via libebur128), so I've added that as a dependency. Should it be put behind a build option? I would have to make sure that it actually has a meson flag and isn't a hard dependency.