Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] jupyterlab: update to 4.4.0
@ 2025-04-17 22:12 dkwo
  2025-04-18 11:18 ` tornaria
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: dkwo @ 2025-04-17 22:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

There is a new pull request by dkwo against master on the void-packages repository

https://github.com/dkwo/void-packages jupyterlab440
https://github.com/void-linux/void-packages/pull/55101

jupyterlab: update to 4.4.0
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (ARCH-LIBC)

cc @tornaria I added a few depends. All tests pass. I decided not to package jupyter_lsp, not sure it is worth the effort.

A patch file from https://github.com/void-linux/void-packages/pull/55101.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-jupyterlab440-55101.patch --]
[-- Type: text/x-diff, Size: 1901 bytes --]

From d7752b54d1b1444e16ac4f72706cf7d5fbaec10d Mon Sep 17 00:00:00 2001
From: dkwo <npiazza@disroot.org>
Date: Thu, 17 Apr 2025 14:54:30 -0400
Subject: [PATCH] jupyterlab: update to 4.4.0

---
 srcpkgs/jupyterlab/template | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/jupyterlab/template b/srcpkgs/jupyterlab/template
index 4782370a75598d..46627ef529a708 100644
--- a/srcpkgs/jupyterlab/template
+++ b/srcpkgs/jupyterlab/template
@@ -1,21 +1,23 @@
 # Template file for 'jupyterlab'
 pkgname=jupyterlab
-version=4.2.4
-revision=2
+version=4.4.0
+revision=1
 build_style=python3-pep517
 hostmakedepends="hatchling hatch-jupyter-builder"
 depends="nodejs python3-async-lru python3-httpx python3-ipython_ipykernel
- python3-jupyterlab_server python3-notebook_shim"
-checkdepends="$depends python3-pytest-jupyter python3-pytest-xdist"
+ python3-Jinja2 python3-jupyter_core python3-jupyter_server python3-tornado
+ python3-packaging python3-setuptools
+ python3-traitlets python3-jupyterlab_server python3-notebook_shim"
+checkdepends="${depends} python3-pytest-jupyter python3-pytest-xdist"
 short_desc="JupyterLab computational environment"
 maintainer="dkwo <npiazza@disroot.org>, Gonzalo Tornaría <tornaria@cmat.edu.uy>"
 license="custom:jupyterlab"
 homepage="https://github.com/jupyterlab/jupyterlab/"
 changelog="https://raw.githubusercontent.com/jupyterlab/jupyterlab/main/CHANGELOG.md"
 distfiles="${PYPI_SITE}/j/jupyterlab/jupyterlab-${version}.tar.gz"
-checksum=343a979fb9582fd08c8511823e320703281cd072a0049bcdafdc7afeda7f2537
+checksum=f1767d5f0104e40f3b4a63bf6892bbef8e4704dcabf0c78408a3bdc411792f04
 
-if [ "$XBPS_BUILD_ENVIRONMENT" = void-packages-ci ]; then
+if [ "${XBPS_BUILD_ENVIRONMENT}" = void-packages-ci ]; then
 	# this test fails on CI (network timeout)
 	make_check_args="
 	 --deselect=jupyterlab/tests/test_build_api.py::TestBuildAPI

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: jupyterlab: update to 4.4.0
  2025-04-17 22:12 [PR PATCH] jupyterlab: update to 4.4.0 dkwo
@ 2025-04-18 11:18 ` tornaria
  2025-04-18 12:32 ` tornaria
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: tornaria @ 2025-04-18 11:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/55101#issuecomment-2815272055

Comment:
If we don't package `jupyter-lsp`, we should patch the dependency out. This actually affects runtime as you can see with `pip check` on a system with `jupyterlab` installed. See e.g. https://github.com/void-linux/void-packages/pull/54495 for an example of why this might be important.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: jupyterlab: update to 4.4.0
  2025-04-17 22:12 [PR PATCH] jupyterlab: update to 4.4.0 dkwo
  2025-04-18 11:18 ` tornaria
@ 2025-04-18 12:32 ` tornaria
  2025-04-18 12:44 ` tornaria
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: tornaria @ 2025-04-18 12:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/55101#issuecomment-2815357985

Comment:
```
# Template file for 'python3-jupyter-lsp'
pkgname=python3-jupyter-lsp
version=2.2.5
revision=1
build_style=python3-pep517
hostmakedepends="python3-setuptools"
depends="python3-jupyter_server"
checkdepends="$depends python3-pytest"
short_desc="Multi-Language Server WebSocket proxy for Jupyter Notebook/Lab server"
maintainer="dkwo <npiazza@disroot.org>, Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="BSD-3-Clause"
homepage="https://github.com/jupyter-lsp/jupyterlab-lsp"
changelog="https://github.com/jupyter-lsp/jupyterlab-lsp/releases"
distfiles="${PYPI_SITE}/j/jupyter-lsp/jupyter-lsp-${version}.tar.gz"
checksum=793147a05ad446f809fd53ef1cd19a9f5256fd0a2d6b7ce943a982cb4f545001

# This test needs R package languageserver which we don't have
make_check_args="
 --deselect jupyter_lsp/tests/test_detect.py::test_r_package_detection"

post_install() {
        mv ${DESTDIR}/usr/etc ${DESTDIR}
        vlicense LICENSE
}
```
I don't know how to use this. It may be useless without something else (e.g. https://pypi.org/project/jupyterlab-lsp/)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: jupyterlab: update to 4.4.0
  2025-04-17 22:12 [PR PATCH] jupyterlab: update to 4.4.0 dkwo
  2025-04-18 11:18 ` tornaria
  2025-04-18 12:32 ` tornaria
@ 2025-04-18 12:44 ` tornaria
  2025-04-19 21:38 ` dkwo
  2025-04-19 21:38 ` [PR PATCH] [Closed]: " dkwo
  4 siblings, 0 replies; 6+ messages in thread
From: tornaria @ 2025-04-18 12:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/55101#issuecomment-2815380244

Comment:
```
# Template file for 'python3-jupyterlab-lsp'
pkgname=python3-jupyterlab-lsp
version=5.1.0
revision=1
build_style=python3-pep517
hostmakedepends="python3-setuptools"
depends="python3-jupyter-lsp jupyterlab"
short_desc="Coding assistance for JupyterLab with Language Server Protocol"
maintainer="dkwo <npiazza@disroot.org>, Gonzalo Tornaría <tornaria@cmat.edu.uy>"
license="BSD-3-Clause"
homepage="https://github.com/jupyter-lsp/jupyterlab-lsp"
changelog="https://github.com/jupyter-lsp/jupyterlab-lsp/releases"
distfiles="${PYPI_SITE}/j/jupyterlab-lsp/jupyterlab-lsp-${version}.tar.gz"
checksum=aeac84093ada6d20ef57ae0e97811cc5796a0cab7237b32f8eddf993c0bb0356
make_check=no  # Upstream defines no tests

post_install() {
        vlicense LICENSE
}
```
I haven't tested any of this. In https://pypi.org/project/jupyterlab-lsp/ it shows how it is supposed to work.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PR PATCH] [Closed]: jupyterlab: update to 4.4.0
  2025-04-17 22:12 [PR PATCH] jupyterlab: update to 4.4.0 dkwo
                   ` (3 preceding siblings ...)
  2025-04-19 21:38 ` dkwo
@ 2025-04-19 21:38 ` dkwo
  4 siblings, 0 replies; 6+ messages in thread
From: dkwo @ 2025-04-19 21:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

There's a closed pull request on the void-packages repository

jupyterlab: update to 4.4.0
https://github.com/void-linux/void-packages/pull/55101

Description:
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-glibc)

cc @tornaria I added a few depends. All tests pass. I decided not to package `jupyter_lsp`, not sure it is worth the effort.
edit: of course the lint fails. what to do?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: jupyterlab: update to 4.4.0
  2025-04-17 22:12 [PR PATCH] jupyterlab: update to 4.4.0 dkwo
                   ` (2 preceding siblings ...)
  2025-04-18 12:44 ` tornaria
@ 2025-04-19 21:38 ` dkwo
  2025-04-19 21:38 ` [PR PATCH] [Closed]: " dkwo
  4 siblings, 0 replies; 6+ messages in thread
From: dkwo @ 2025-04-19 21:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/55101#issuecomment-2816875810

Comment:
Thanks. Let's move to your pr then.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2025-04-19 21:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-17 22:12 [PR PATCH] jupyterlab: update to 4.4.0 dkwo
2025-04-18 11:18 ` tornaria
2025-04-18 12:32 ` tornaria
2025-04-18 12:44 ` tornaria
2025-04-19 21:38 ` dkwo
2025-04-19 21:38 ` [PR PATCH] [Closed]: " dkwo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).