Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] xbps-src: document -Q non-recursiveness
@ 2025-05-01 14:54 tornaria
  2025-05-01 14:57 ` classabbyamp
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: tornaria @ 2025-05-01 14:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages usage
https://github.com/void-linux/void-packages/pull/55222

xbps-src: document -Q non-recursiveness
Document in usage that running check with -Q is not recursive,
and running check with -K is recursive.

This behaviour was implemented in #54633.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/55222.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-usage-55222.patch --]
[-- Type: text/x-diff, Size: 1063 bytes --]

From 147ec75de6e118399b7242c5552c0fbc1ee3df89 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Thu, 1 May 2025 11:50:01 -0300
Subject: [PATCH] xbps-src: document -Q non-recursiveness

Document in usage that running check with -Q is not recursive,
and running check with -K is recursive.

This behaviour was implemented in #54633.
---
 xbps-src | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xbps-src b/xbps-src
index 1ce830c7bf9c18..886803846a44d6 100755
--- a/xbps-src
+++ b/xbps-src
@@ -231,9 +231,9 @@ $(print_cross_targets)
     Variable is split and each word is printed in separate line by default.
     In order to print the whole value in one line, append asterisk to variable name.
 
--Q  Enable running the check stage.
+-Q  Enable running the check stage (non-recursive).
 
--K  Enable running the check stage with longer tests.
+-K  Enable running the check stage with longer tests (recursive).
 
 -q  Suppress informational output of xbps-src (build output is still printed).
 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: xbps-src: document -Q non-recursiveness
  2025-05-01 14:54 [PR PATCH] xbps-src: document -Q non-recursiveness tornaria
@ 2025-05-01 14:57 ` classabbyamp
  2025-05-01 21:48 ` tornaria
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2025-05-01 14:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/55222#issuecomment-2845005467

Comment:
recursive might be a bit obtuse, what about specifying it as "and run tests on built dependencies" or something?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: xbps-src: document -Q non-recursiveness
  2025-05-01 14:54 [PR PATCH] xbps-src: document -Q non-recursiveness tornaria
  2025-05-01 14:57 ` classabbyamp
@ 2025-05-01 21:48 ` tornaria
  2025-05-05 23:28 ` ahesford
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: tornaria @ 2025-05-01 21:48 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 798 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/55222#issuecomment-2845855335

Comment:
> recursive might be a bit obtuse, what about specifying it as "and run tests on built dependencies" or something?

I'd call that "concise" but point taken. What about:
```

-Q  Enable running the check stage (for the target package only).

-K  Enable running the check stage with longer tests (and also on built deps).

```
I'm trying to stick on one 80 char line, spelling "dependencies" brings the line to 86 char.
With two lines:
```

-Q  Enable running the check stage, for the target package only.

-K  Enable running the check stage with longer tests.
    Unlike -Q, this will also run the check stage on built dependencies.

```

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: xbps-src: document -Q non-recursiveness
  2025-05-01 14:54 [PR PATCH] xbps-src: document -Q non-recursiveness tornaria
  2025-05-01 14:57 ` classabbyamp
  2025-05-01 21:48 ` tornaria
@ 2025-05-05 23:28 ` ahesford
  2025-05-06  1:17 ` [PR PATCH] [Updated] " tornaria
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: ahesford @ 2025-05-05 23:28 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/55222#issuecomment-2852647737

Comment:
I favor the second option. Better to be verbose and break a line.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] xbps-src: document -Q non-recursiveness
  2025-05-01 14:54 [PR PATCH] xbps-src: document -Q non-recursiveness tornaria
                   ` (2 preceding siblings ...)
  2025-05-05 23:28 ` ahesford
@ 2025-05-06  1:17 ` tornaria
  2025-05-06  1:21 ` tornaria
  2025-05-06  2:05 ` [PR PATCH] [Merged]: " ahesford
  5 siblings, 0 replies; 7+ messages in thread
From: tornaria @ 2025-05-06  1:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages usage
https://github.com/void-linux/void-packages/pull/55222

xbps-src: document -Q non-recursiveness
Document in usage that running check with -Q is not recursive,
and running check with -K is recursive.

This behaviour was implemented in #54633.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/55222.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-usage-55222.patch --]
[-- Type: text/x-diff, Size: 1082 bytes --]

From d1ffe7edccc7f59045a82c54404ffea65e3cbd7e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Thu, 1 May 2025 11:50:01 -0300
Subject: [PATCH] xbps-src: document -Q non-recursiveness

Document in usage that running check with -Q is not recursive,
and running check with -K is recursive.

This behaviour was implemented in #54633.
---
 xbps-src | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xbps-src b/xbps-src
index 1ce830c7bf9c18..c6b45effefdb47 100755
--- a/xbps-src
+++ b/xbps-src
@@ -231,9 +231,10 @@ $(print_cross_targets)
     Variable is split and each word is printed in separate line by default.
     In order to print the whole value in one line, append asterisk to variable name.
 
--Q  Enable running the check stage.
+-Q  Enable running the check stage, for the target package only.
 
 -K  Enable running the check stage with longer tests.
+    Unlike -Q, this will also run the check stage on built dependencies.
 
 -q  Suppress informational output of xbps-src (build output is still printed).
 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: xbps-src: document -Q non-recursiveness
  2025-05-01 14:54 [PR PATCH] xbps-src: document -Q non-recursiveness tornaria
                   ` (3 preceding siblings ...)
  2025-05-06  1:17 ` [PR PATCH] [Updated] " tornaria
@ 2025-05-06  1:21 ` tornaria
  2025-05-06  2:05 ` [PR PATCH] [Merged]: " ahesford
  5 siblings, 0 replies; 7+ messages in thread
From: tornaria @ 2025-05-06  1:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/55222#issuecomment-2852925815

Comment:
A few days later, I now agree verbose is better, and using two lines looks better.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: xbps-src: document -Q non-recursiveness
  2025-05-01 14:54 [PR PATCH] xbps-src: document -Q non-recursiveness tornaria
                   ` (4 preceding siblings ...)
  2025-05-06  1:21 ` tornaria
@ 2025-05-06  2:05 ` ahesford
  5 siblings, 0 replies; 7+ messages in thread
From: ahesford @ 2025-05-06  2:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1243 bytes --]

There's a merged pull request on the void-packages repository

xbps-src: document -Q non-recursiveness
https://github.com/void-linux/void-packages/pull/55222

Description:
Document in usage that running check with -Q is not recursive,
and running check with -K is recursive.

This behaviour was implemented in #54633.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2025-05-06  2:05 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-01 14:54 [PR PATCH] xbps-src: document -Q non-recursiveness tornaria
2025-05-01 14:57 ` classabbyamp
2025-05-01 21:48 ` tornaria
2025-05-05 23:28 ` ahesford
2025-05-06  1:17 ` [PR PATCH] [Updated] " tornaria
2025-05-06  1:21 ` tornaria
2025-05-06  2:05 ` [PR PATCH] [Merged]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).