Void Linux discussion
 help / color / mirror / Atom feed
From: "'Quentin Rameau' via voidlinux" <voidlinux@googlegroups.com>
To: Void Linux <voidlinux@googlegroups.com>
Subject: [PATCH] xbps-src: Make build style printing more explicit
Date: Fri, 7 Apr 2023 13:10:54 +0200	[thread overview]
Message-ID: <ZC/6Pr0Br9dHbndx@fifth.space> (raw)

It happens that the way the build style is printed during build
misleads people into thinking this is an actual dependency being built.

Try solving this by being slightly more verbose.
---
 common/xbps-src/shutils/build_dependencies.sh | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/common/xbps-src/shutils/build_dependencies.sh b/common/xbps-src/shutils/build_dependencies.sh
index 1d19de54ae..02764c3a98 100644
--- a/common/xbps-src/shutils/build_dependencies.sh
+++ b/common/xbps-src/shutils/build_dependencies.sh
@@ -144,6 +144,8 @@ install_pkg_deps() {
         style+=" [$s]"
     done
 
+    [ -n "$style" ] && style="with$style"
+
     if [ "$pkg" != "$targetpkg" ]; then
         msg_normal "$pkgver: building${style} (dependency of $targetpkg) for $XBPS_TARGET_MACHINE...\n"
     else
-- 
2.40.0

-- 
You received this message because you are subscribed to the Google Groups "voidlinux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to voidlinux+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/voidlinux/ZC/6Pr0Br9dHbndx%40fifth.space.

             reply	other threads:[~2023-04-07 11:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-07 11:10 'Quentin Rameau' via voidlinux [this message]
2023-04-07 11:22 ` [PATCHv2] " 'Quentin Rameau' via voidlinux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZC/6Pr0Br9dHbndx@fifth.space \
    --to=voidlinux@googlegroups.com \
    --cc=quinq@fifth.space \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).