wireguard-tools Ubuntu package missing the binaries

wireguard-tools Ubuntu package missing the binaries

[Ryan Riley]

Hello,

I've been trying to setup wireguard to experiment with it a bit and I've 
run into a problem.  The i386 wireguard-tools package on the PPA for 
Ubuntu Xenial doesn't actually contain any of the binaries, just 
documentation.  You see this by checking the file listing at the end of 
the build log here:

https://launchpadlibrarian.net/315022481/buildlog_ubuntu-xenial-i386.wireguard_0.0.20170409-wg1~xenial_BUILDING.txt.gz

The amd64 package does contain the binaries.

I appreciate your work!

Thanks
Ryan

Re: wireguard-tools Ubuntu package missing the binaries

[Jonathon Fernyhough]

[-- Attachment #1.1: Type: text/plain, Size: 1360 bytes --]

On 16/04/17 12:06, Ryan Riley wrote:
> The i386 wireguard-tools package on the PPA for Ubuntu Xenial doesn't
> actually contain any of the binaries, just documentation.

It's not just i386 - each of the arm and ppc64 packages are also missing
binaries.

Debian's packages (and my testing backports based on those) don't have
that issue - might be time to check a diff or do a merge. :)

Looks like it's down to `make install`ing the tools during install-indep
rather than install-arch.


Working (Debian use a different flags setup, that's not the important bit):

> override_dh_auto_install-indep:
> 	$(MAKE) -C src DESTDIR=../debian/wireguard-dkms DKMSDIR=/usr/src/wireguard-$(DEB_VERSION)/ dkms-install
> 
> override_dh_auto_build-arch:
> 	$(MAKE) -C src/tools $(WIREGUARD_ARGS)
> 
> override_dh_auto_install-arch:
> 	$(MAKE) -C src/tools DESTDIR=../../debian/wireguard-tools $(WIREGUARD_ARGS) install


Non-working:

> override_dh_auto_install-indep:
> 	$(MAKE) -C wireguard-src/src DESTDIR=$(CURDIR)/debian/wireguard-dkms DKMSDIR=/usr/src/wireguard-$(DEB_VERSION_UPSTREAM)/ dkms-install
> 	$(MAKE) -C wireguard-src/src/tools DESTDIR=$(CURDIR)/debian/wireguard-tools WITH_SYSTEMDUNITS=yes WITH_WGQUICK=yes WITH_BASHCOMPLETION=yes install
> 
> override_dh_auto_build-arch:
>  	$(MAKE) -C wireguard-src/src/tools



J


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: wireguard-tools Ubuntu package missing the binaries

[Egbert Verhage]

Hey Jonathon and Ryan,

This problem got previously with my RaspPi. That tools binaries build
are not in de build of armv6 and think that is the same with i386.

This was a old item in the mailing list about arm packages in ubuntu
repo: https://lists.zx2c4.com/pipermail/wireguard/2017-February/001050.
html
Coud not figer out what the problem was.

And a great time to add ubuntu 17.04 (zesty) and test it on my pi.

hda (cryptofuture) is testing it now on his own ppa, see here the
github issue: https://github.com/EggieCode/wireguard-ppa/issues/13 and
the fix https://github.com/EggieCode/wireguard-ppa/pull/14

Greetz,
Egbert

On Sun, 2017-04-16 at 12:24 +0100, Jonathon Fernyhough wrote:
> On 16/04/17 12:06, Ryan Riley wrote:
> > The i386 wireguard-tools package on the PPA for Ubuntu Xenial
> > doesn't
> > actually contain any of the binaries, just documentation.
> 
> It's not just i386 - each of the arm and ppc64 packages are also
> missing
> binaries.
> 
> Debian's packages (and my testing backports based on those) don't
> have
> that issue - might be time to check a diff or do a merge. :)
> 
> Looks like it's down to `make install`ing the tools during install-
> indep
> rather than install-arch.
> 
> 
> Working (Debian use a different flags setup, that's not the important
> bit):
> 
> > override_dh_auto_install-indep:
> > 	$(MAKE) -C src DESTDIR=../debian/wireguard-dkms
> > DKMSDIR=/usr/src/wireguard-$(DEB_VERSION)/ dkms-install
> > 
> > override_dh_auto_build-arch:
> > 	$(MAKE) -C src/tools $(WIREGUARD_ARGS)
> > 
> > override_dh_auto_install-arch:
> > 	$(MAKE) -C src/tools DESTDIR=../../debian/wireguard-tools
> > $(WIREGUARD_ARGS) install
> 
> 
> Non-working:
> 
> > override_dh_auto_install-indep:
> > 	$(MAKE) -C wireguard-src/src
> > DESTDIR=$(CURDIR)/debian/wireguard-dkms DKMSDIR=/usr/src/wireguard-
> > $(DEB_VERSION_UPSTREAM)/ dkms-install
> > 	$(MAKE) -C wireguard-src/src/tools
> > DESTDIR=$(CURDIR)/debian/wireguard-tools WITH_SYSTEMDUNITS=yes
> > WITH_WGQUICK=yes WITH_BASHCOMPLETION=yes install
> > 
> > override_dh_auto_build-arch:
> >  	$(MAKE) -C wireguard-src/src/tools
> 
> 
> 
> J
> 
> _______________________________________________
> WireGuard mailing list
> WireGuard@lists.zx2c4.com
> https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: wireguard-tools Ubuntu package missing the binaries

[Jason A. Donenfeld]

Hello Egbert,

I did not comprehend your message. Is the problem fixed and are
packages that actually work available now on Launchpad?

Regards,
Jason

Re: wireguard-tools Ubuntu package missing the binaries

[Egbert Verhage]

To clarify my message.

Going to fix/test the package on arm and i386 with hda.
Then will update my PI to ubuntu 17.04 to add that to the package.

Greetz,
Egbert

On Sun, 2017-04-16 at 17:50 +0200, Jason A. Donenfeld wrote:
> I did not comprehend your message. Is the problem fixed and are
> packages that actually work available now on Launchpad?
> 
On Sun, 2017-04-16 at 17:47 +0200, Egbert Verhage wrote:
> 
> This problem got previously with my RaspPi. That tools binaries build
> are not in de build of armv6 and think that is the same with i386.
> 
> This was a old item in the mailing list about arm packages in ubuntu
> repo: https://lists.zx2c4.com/pipermail/wireguard/2017-February/00105
> 0.
> html
> Coud not figer out what the problem was.
> 
> And a great time to add ubuntu 17.04 (zesty) and test it on my pi.
> 
> hda (cryptofuture) is testing it now on his own ppa, see here the
> github issue: https://github.com/EggieCode/wireguard-ppa/issues/13
> and
> the fix https://github.com/EggieCode/wireguard-ppa/pull/14

Re: wireguard-tools Ubuntu package missing the binaries; Fixed

[Egbert Verhage]

Hey Ryan,

Fixed it. New build (0.0.20170409-wg2~xenial, 0.0.20170409-
wg2~yakkety,) is live on the PPA.

Can you test this for me?

Thanks Jonathon, for that solution.

Greetz,
Egbert


On Sun, 2017-04-16 at 12:24 +0100, Jonathon Fernyhough wrote:
> On 16/04/17 12:06, Ryan Riley wrote:
> > The i386 wireguard-tools package on the PPA for Ubuntu Xenial
> > doesn't
> > actually contain any of the binaries, just documentation.
> 
> It's not just i386 - each of the arm and ppc64 packages are also
> missing
> binaries.
> 
> Debian's packages (and my testing backports based on those) don't
> have
> that issue - might be time to check a diff or do a merge. :)
> 
> Looks like it's down to `make install`ing the tools during install-
> indep
> rather than install-arch.
> 
> 
> Working (Debian use a different flags setup, that's not the important
> bit):
> 
> > override_dh_auto_install-indep:
> > 	$(MAKE) -C src DESTDIR=../debian/wireguard-dkms
> > DKMSDIR=/usr/src/wireguard-$(DEB_VERSION)/ dkms-install
> > 
> > override_dh_auto_build-arch:
> > 	$(MAKE) -C src/tools $(WIREGUARD_ARGS)
> > 
> > override_dh_auto_install-arch:
> > 	$(MAKE) -C src/tools DESTDIR=../../debian/wireguard-tools
> > $(WIREGUARD_ARGS) install
> 
> 
> Non-working:
> 
> > override_dh_auto_install-indep:
> > 	$(MAKE) -C wireguard-src/src
> > DESTDIR=$(CURDIR)/debian/wireguard-dkms DKMSDIR=/usr/src/wireguard-
> > $(DEB_VERSION_UPSTREAM)/ dkms-install
> > 	$(MAKE) -C wireguard-src/src/tools
> > DESTDIR=$(CURDIR)/debian/wireguard-tools WITH_SYSTEMDUNITS=yes
> > WITH_WGQUICK=yes WITH_BASHCOMPLETION=yes install
> > 
> > override_dh_auto_build-arch:
> >  	$(MAKE) -C wireguard-src/src/tools
> 
> 
> 
> J
> 
> _______________________________________________
> WireGuard mailing list
> WireGuard@lists.zx2c4.com
> https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: wireguard-tools Ubuntu package missing the binaries; Fixed

[Ryan Riley]

Works great.  Thanks a lot!

Thanks
Ryan

On 04/16/2017 08:50 PM, Egbert Verhage wrote:
> Hey Ryan,
>
> Fixed it. New build (0.0.20170409-wg2~xenial, 0.0.20170409-
> wg2~yakkety,) is live on the PPA.
>
> Can you test this for me?
>
> Thanks Jonathon, for that solution.
>
> Greetz,
> Egbert
>
>
> On Sun, 2017-04-16 at 12:24 +0100, Jonathon Fernyhough wrote:
>> On 16/04/17 12:06, Ryan Riley wrote:
>>> The i386 wireguard-tools package on the PPA for Ubuntu Xenial
>>> doesn't
>>> actually contain any of the binaries, just documentation.
>> It's not just i386 - each of the arm and ppc64 packages are also
>> missing
>> binaries.
>>
>> Debian's packages (and my testing backports based on those) don't
>> have
>> that issue - might be time to check a diff or do a merge. :)
>>
>> Looks like it's down to `make install`ing the tools during install-
>> indep
>> rather than install-arch.
>>
>>
>> Working (Debian use a different flags setup, that's not the important
>> bit):
>>
>>> override_dh_auto_install-indep:
>>> 	$(MAKE) -C src DESTDIR=../debian/wireguard-dkms
>>> DKMSDIR=/usr/src/wireguard-$(DEB_VERSION)/ dkms-install
>>>
>>> override_dh_auto_build-arch:
>>> 	$(MAKE) -C src/tools $(WIREGUARD_ARGS)
>>>
>>> override_dh_auto_install-arch:
>>> 	$(MAKE) -C src/tools DESTDIR=../../debian/wireguard-tools
>>> $(WIREGUARD_ARGS) install
>>
>> Non-working:
>>
>>> override_dh_auto_install-indep:
>>> 	$(MAKE) -C wireguard-src/src
>>> DESTDIR=$(CURDIR)/debian/wireguard-dkms DKMSDIR=/usr/src/wireguard-
>>> $(DEB_VERSION_UPSTREAM)/ dkms-install
>>> 	$(MAKE) -C wireguard-src/src/tools
>>> DESTDIR=$(CURDIR)/debian/wireguard-tools WITH_SYSTEMDUNITS=yes
>>> WITH_WGQUICK=yes WITH_BASHCOMPLETION=yes install
>>>
>>> override_dh_auto_build-arch:
>>>   	$(MAKE) -C wireguard-src/src/tools
>>
>>
>> J
>>
>> _______________________________________________
>> WireGuard mailing list
>> WireGuard@lists.zx2c4.com
>> https://lists.zx2c4.com/mailman/listinfo/wireguard