Development discussion of WireGuard
 help / color / mirror / Atom feed
From: "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca>
To: paulmck@kernel.org
Cc: alexander.deucher@amd.com, amd-gfx@lists.freedesktop.org,
	"Arve Hjønnevåg" <arve@android.com>,
	"Christian Brauner" <christian@brauner.io>,
	christian.koenig@amd.com,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Hridya Valsaraju" <hridya@google.com>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	"Joel Fernandes" <joel@joelfernandes.org>,
	linux-kernel@vger.kernel.org, "Martijn Coenen" <maco@android.com>,
	rcu@vger.kernel.org, "Suren Baghdasaryan" <surenb@google.com>,
	"Todd Kjos" <tkjos@android.com>, "Theodore Ts'o" <tytso@mit.edu>,
	uladzislau.rezki@sony.com, urezki@gmail.com,
	wireguard@lists.zx2c4.com, Xinhui.Pan@amd.com
Subject: Re: CONFIG_ANDROID (was: rcu_sched detected expedited stalls in amdgpu after suspend)
Date: Tue, 28 Jun 2022 15:28:26 -0400	[thread overview]
Message-ID: <1656443915.mdjoauhqe0.none@localhost> (raw)
In-Reply-To: <20220628185437.GA1790663@paulmck-ThinkPad-P17-Gen-1>

Excerpts from Paul E. McKenney's message of June 28, 2022 2:54 pm:
> All you need to do to get the previous behavior is to add something like
> this to your defconfig file:
> 
> CONFIG_RCU_EXP_CPU_STALL_TIMEOUT=21000
> 
> Any reason why this will not work for you?

As far as I know, I do not require any particular RCU debugging features 
intended for developers; as an individual user and distro maintainer, I 
would like to select the option corresponding to "emit errors for 
unexpected conditions which should be reported upstream", not "emit 
debugging information for development purposes".

Therefore, I think 0 is a suitable setting for me and most ordinary 
(not tightly controlled) distributions. My concern is that other users 
and distro maintainers will also have confusion about what value to set 
and whether the warnings are important, since the help text does not say 
anything about Android, and "make oldconfig" does not indicate that the 
default value is different for Android.

My suggestion is that the default be set to 0, and if a non-zero value 
is appropriate for Android, that should be communicated to the Android 
developers, not made conditional on CONFIG_ANDROID.

Thanks,
Alex.

  reply	other threads:[~2022-06-28 19:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1656357116.rhe0mufk6a.none.ref@localhost>
     [not found] ` <1656357116.rhe0mufk6a.none@localhost>
     [not found]   ` <20220627204139.GL1790663@paulmck-ThinkPad-P17-Gen-1>
     [not found]     ` <1656379893.q9yb069erk.none@localhost>
     [not found]       ` <20220628041252.GV1790663@paulmck-ThinkPad-P17-Gen-1>
2022-06-28 15:02         ` Alex Xu (Hello71)
2022-06-28 15:13           ` Jason A. Donenfeld
2022-06-28 18:54           ` Paul E. McKenney
2022-06-28 19:28             ` Alex Xu (Hello71) [this message]
2022-06-28 20:11               ` Uladzislau Rezki
2022-07-04 11:30                 ` Christian König
2022-07-06 17:48                   ` Uladzislau Rezki
2022-07-06 17:58                     ` Paul E. McKenney
2022-07-06 18:09                       ` Uladzislau Rezki
2022-07-06 20:42                         ` Paul E. McKenney
2022-07-07  7:30                           ` Christian König
2022-07-07 13:29                             ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1656443915.mdjoauhqe0.none@localhost \
    --to=alex_y_xu@yahoo.ca \
    --cc=Jason@zx2c4.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=arve@android.com \
    --cc=christian.koenig@amd.com \
    --cc=christian@brauner.io \
    --cc=gregkh@linuxfoundation.org \
    --cc=hridya@google.com \
    --cc=joel@joelfernandes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=paulmck@kernel.org \
    --cc=rcu@vger.kernel.org \
    --cc=surenb@google.com \
    --cc=tkjos@android.com \
    --cc=tytso@mit.edu \
    --cc=uladzislau.rezki@sony.com \
    --cc=urezki@gmail.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).