From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: davem@davemloft.net Received: from krantz.zx2c4.com (localhost [127.0.0.1]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id f0f5219c for ; Wed, 7 Dec 2016 19:47:18 +0000 (UTC) Received: from shards.monkeyblade.net (shards.monkeyblade.net [184.105.139.130]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 4c5daa64 for ; Wed, 7 Dec 2016 19:47:18 +0000 (UTC) Date: Wed, 07 Dec 2016 14:52:40 -0500 (EST) Message-Id: <20161207.145240.1636297838792223189.davem@davemloft.net> To: Jason@zx2c4.com Subject: Re: Misalignment, MIPS, and ip_hdr(skb)->version From: David Miller In-Reply-To: References: <20161207.135127.789629809982860453.davem@davemloft.net> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Cc: netdev@vger.kernel.org, wireguard@lists.zx2c4.com, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Jason A. Donenfeld" Date: Wed, 7 Dec 2016 19:54:12 +0100 > On Wed, Dec 7, 2016 at 7:51 PM, David Miller wrote: >> It's so much better to analyze properly where the misalignment comes from >> and address it at the source, as we have for various cases that trip up >> Sparc too. > > That's sort of my attitude too, hence starting this thread. Any > pointers you have about this would be most welcome, so as not to > perpetuate what already seems like an issue in other parts of the > stack. The only truly difficult case to handle is GRE encapsulation. Is that the situation you are running into? If not, please figure out what the header configuration looks like in the case that hits for you, and what the originating device is just in case it is a device driver issue. Thanks.