From: Baptiste Jonglez <baptiste@bitsofnetworks.org>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: openwrt route_allowed_ips is inprecise
Date: Tue, 20 Dec 2016 02:13:34 +0100 [thread overview]
Message-ID: <20161220011334.GB16814@tuxmachine.polynome.dn42> (raw)
In-Reply-To: <CAHmME9q+aZNDDH5Nsnn1O7+4RxFm489f08oOmyGpWsVx1pLxwg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]
On Sun, Dec 18, 2016 at 09:14:18PM +0100, Jason A. Donenfeld wrote:
> The way it should be done is described in wg-config:
>
> https://git.zx2c4.com/WireGuard/tree/contrib/examples/wg-config/wg-config#n130
>
> if [[ $AUTO_ROUTE -eq 1 ]]; then
> for i in $(wg show "$INTERFACE" allowed-ips | cut -f 2 | tr -d ,); do
> if ! add_default "$i" && [[ $(ip route get "$i") != *dev\
> $INTERFACE\ * ]]; then
> add_route "$i"
> fi
> done
> fi
> the important thing is that I run `ip route get` for each one, and only
> add a route if necessary.
By the way, besides the issue of magic, this approach seems incorrect
depending on the order of the routes. Consider the case where cmd_add()
handles the following sequence of allowed-ips:
10.0.0.0/8 dev wg0
10.4.7.0/24 dev wg0
10.4.0.0/16 dev wg1
Your method would incorrectly drop the second route, and then the third
route would take over traffic for this /24 through the wrong interface.
I'm sure this approach can be made to actually work in all cases (with
great complexity), but really, who cares about a few redundant routes.
Baptiste
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2016-12-20 1:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-18 20:14 Jason A. Donenfeld
2016-12-19 8:00 ` Jörg Thalheim
2016-12-19 12:32 ` Jason A. Donenfeld
2016-12-19 13:06 ` Baptiste Jonglez
2016-12-19 13:09 ` Jason A. Donenfeld
2016-12-19 13:19 ` Baptiste Jonglez
2016-12-19 13:21 ` Jason A. Donenfeld
2016-12-20 1:13 ` Baptiste Jonglez [this message]
2016-12-20 3:14 ` Jason A. Donenfeld
2016-12-20 3:38 ` Dan Luedtke
2016-12-20 4:33 ` Jason A. Donenfeld
2016-12-20 8:52 ` Dan Lüdtke
2016-12-20 10:15 ` Dan Lüdtke
2016-12-20 13:33 ` Jason A. Donenfeld
2016-12-20 14:51 ` Dan Lüdtke
2016-12-20 18:27 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161220011334.GB16814@tuxmachine.polynome.dn42 \
--to=baptiste@bitsofnetworks.org \
--cc=Jason@zx2c4.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).