From: Baptiste Jonglez <baptiste@bitsofnetworks.org>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
Cc: wireguard@lists.zx2c4.com
Subject: Re: Memleak with 0.0.20171221-5 on Debian stretch
Date: Sun, 11 Feb 2018 19:43:12 +0100 [thread overview]
Message-ID: <20180211184312.GD12558@lud.localdomain> (raw)
In-Reply-To: <87r2prs80x.fsf@fifthhorseman.net>
[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]
On 11-02-18, Daniel Kahn Gillmor wrote:
> Hi Baptiste--
>
> On Sun 2018-02-11 14:48:37 +0100, Baptiste Jonglez wrote:
>
> > On a x86_64 VM with quite a lot of Wireguard traffic (~300 GB per day), I
> > am seeing a memory leak with wireguard 0.0.20171221-5. System is Debian
> > stretch, kernel 4.9.65-3+deb9u2, wireguard package from unstable.
>
> oof, thanks for this report, and for the really useful graph
> visualization.
>
> it's troubling that the changes correlated with the memleak are both a
> kernel upgrade *and* a wireguard upgrade, since that kind of conflation
> might be difficult to tease apart.
Yes, I *think* it's related to wireguard and not the kernel upgrade (since
far more people use the kernel than wireguard), but I'm not 100% sure.
And indeed, we could imagine it to be an issue in wireguard related to the
newer kernel...
> i'm curious from the graph -- do you know what happened at the start of
> week 6 where there's a sawtooth?
Actually, the amount of "slab_cache" didn't change at that point, it's
just the amount of application memory that dropped a bit. I looked at the
logs, some userspace processes were being killed by the OOM-killer.
> If you still see a leak with the latest wireguard, i'd appreciate if you
> could test the current kernel with 0.0.20171011-1 to see whether you can
> isolate the problem to the kernel. i'm not recommending running
> 0.0.20171011-1 for the long term, but it should still be wire-format
> compatible with other implementations and will help with debugging to
> have the comparison.
Excellent suggestion!
It does look like 0.0.20180202-1 still has the memleak. I will leave it
running a few more days to be certain, and then switch to 0.0.20171011-1.
Baptiste
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-11 18:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-11 13:48 Baptiste Jonglez
2018-02-11 18:20 ` Daniel Kahn Gillmor
2018-02-11 18:43 ` Baptiste Jonglez [this message]
2018-02-12 0:23 ` Jason A. Donenfeld
2018-02-12 7:35 ` Baptiste Jonglez
2018-02-12 7:42 ` Baptiste Jonglez
2018-02-12 11:04 ` Jason A. Donenfeld
2018-02-13 13:17 ` Baptiste Jonglez
2018-02-18 20:39 ` Jason A. Donenfeld
2018-02-22 7:45 ` Baptiste Jonglez
2018-02-12 3:34 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180211184312.GD12558@lud.localdomain \
--to=baptiste@bitsofnetworks.org \
--cc=dkg@fifthhorseman.net \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).