Pre 5.1-rc1 build issue

Pre 5.1-rc1 build issue

[Bruno Wolff III]

Commit 
 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d2c5c103b1337f590b7edf1509a6e294bdf22402
removed net/netfilter/nf_nat_core.h, which breaks wireguard builds for 
5.1.0-0.rc0.git5.2.fc31.x86_64.

It sounds like it isn't needed any more from the commit message.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: Pre 5.1-rc1 build issue

[Bruno Wolff III]

On Wed, Mar 13, 2019 at 13:38:18 -0500,
  Bruno Wolff III <bruno@wolff.to> wrote:
>Commit https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d2c5c103b1337f590b7edf1509a6e294bdf22402
>removed net/netfilter/nf_nat_core.h, which breaks wireguard builds for 
>5.1.0-0.rc0.git5.2.fc31.x86_64.
>
>It sounds like it isn't needed any more from the commit message.

There are also some rcu changes that I just guessed on fixes for. I think 
this change was covered in Paul McKenney's LCA talk in January.

I got something that seems to be working. So I'm good until the real fixes 
are ready.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: Pre 5.1-rc1 build issue

[Jason A. Donenfeld]

On Wed, Mar 13, 2019 at 12:53 PM Bruno Wolff III <bruno@wolff.to> wrote:
> I got something that seems to be working. So I'm good until the real fixes
> are ready.

Perhaps your [fake?!] fixes could become the real fixes if you ran
`git send-email` to the mailing list?

Jason
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

Re: Pre 5.1-rc1 build issue

[Bruno Wolff III]

On Wed, Mar 13, 2019 at 14:44:33 -0600,
  "Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
>On Wed, Mar 13, 2019 at 12:53 PM Bruno Wolff III <bruno@wolff.to> wrote:
>> I got something that seems to be working. So I'm good until the real fixes
>> are ready.
>
>Perhaps your [fake?!] fixes could become the real fixes if you ran
>`git send-email` to the mailing list?

I'll look at what I did to make sure I didn't make an unwanted rcu change. 
From Paul's talk it looks like there is a bit of a merger of a couple 
of rcu types to keep developers from getting confused and I think the 
unknown functions (that used to be known) should now call the non _bh 
version.

For the network include file I didn't include it any more. The correct 
fix is probably an ifdef based on kernel version or something like 
that.

So it might be useful to look at the changes I did, but I would be wary 
of committing them as is. It'll take me maybe an hour to double check 
and try it again on another system.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard