From: Bruno Wolff III <bruno@wolff.to>
To: wireguard@lists.zx2c4.com
Subject: Re: [PATCH] Merge two rcu types
Date: Thu, 14 Mar 2019 07:32:11 -0500 [thread overview]
Message-ID: <20190314123211.GA20943@wolff.to> (raw)
In-Reply-To: <20190314051608.9798-1-bruno@wolff.to>
On Thu, Mar 14, 2019 at 00:16:08 -0500,
Bruno Wolff III <bruno@wolff.to> wrote:
>Paul McKenney made it harder to mess up ending rcu sections with an
>incorrect function call by using the same functions to end multiple
>types of rcu sections.
There are a number of commits involved in this change, but this commit
has a pretty explicit comment about doing the renames I did.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c8d1da4000b0b95bf95d3e13b7450eec5428da1e
netfilter: Replace call_rcu_bh(), rcu_barrier_bh(), and synchronize_rcu_bh()
Now that call_rcu()'s callback is not invoked until after bh-disable
regions of code have completed (in addition to explicitly marked
RCU read-side critical sections), call_rcu() can be used in place
of call_rcu_bh(). Similarly, rcu_barrier() can be used in place of
rcu_barrier_bh() and synchronize_rcu() in place of synchronize_rcu_bh().
This commit therefore makes these changes.
In case it isn't obvious, the patch I supplied is only good for 5.1+
kernels. I'm not sure how you wanted to handle doing compatibility for
older kernels and didn't even have a good idea how to start.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
next prev parent reply other threads:[~2019-03-14 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 5:16 Bruno Wolff III
2019-03-14 12:32 ` Bruno Wolff III [this message]
2019-03-14 17:10 ` Bruno Wolff III
2019-03-14 18:58 ` Jason A. Donenfeld
2019-03-14 20:05 ` Bruno Wolff III
2019-03-15 5:14 ` [PATCH] global: the _bh variety of rcu helpers have been unified Jason A. Donenfeld
2019-03-16 16:11 ` Bruno Wolff III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314123211.GA20943@wolff.to \
--to=bruno@wolff.to \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).