From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3283C10F03 for ; Sat, 16 Mar 2019 16:12:40 +0000 (UTC) Received: from krantz.zx2c4.com (krantz.zx2c4.com [192.95.5.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 428EF21905 for ; Sat, 16 Mar 2019 16:12:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 428EF21905 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=wolff.to Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=wireguard-bounces@lists.zx2c4.com Received: from krantz.zx2c4.com (localhost [IPv6:::1]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 3b3aebf3; Sat, 16 Mar 2019 16:00:36 +0000 (UTC) Received: from krantz.zx2c4.com (localhost [127.0.0.1]) by krantz.zx2c4.com (ZX2C4 Mail Server) with ESMTP id 46022544 for ; Sat, 16 Mar 2019 16:00:34 +0000 (UTC) Received: from wolff.to (wolff.to [98.103.208.27]) by krantz.zx2c4.com (ZX2C4 Mail Server) with SMTP id d6a15b4d for ; Sat, 16 Mar 2019 16:00:34 +0000 (UTC) Received: (qmail 7199 invoked by uid 500); 16 Mar 2019 16:11:11 -0000 Date: Sat, 16 Mar 2019 11:11:11 -0500 From: Bruno Wolff III To: "Jason A. Donenfeld" Subject: Re: [PATCH] global: the _bh variety of rcu helpers have been unified Message-ID: <20190316161111.GA6435@wolff.to> References: <20190314200549.GA23870@wolff.to> <20190315051439.19361-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190315051439.19361-1-Jason@zx2c4.com> User-Agent: Mutt/1.11.3 (2019-02-01) Cc: wireguard@lists.zx2c4.com X-BeenThere: wireguard@lists.zx2c4.com X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: wireguard-bounces@lists.zx2c4.com Sender: "WireGuard" On Thu, Mar 14, 2019 at 23:14:39 -0600, "Jason A. Donenfeld" wrote: >--- >Hey Bruno, > >Based on your research, how does the below strike you? It's certainly >not pretty, but I'm struggling to come up with a better solution. I think anything that doesn't try to keep the _bh versions around is going to be ugly. But keeping the _bh versions is not going to be acceptible upstream, so that doesn't seem to be an option. What you did looks pretty good given the constraints. In the talk I saw, the motivation for the change was that mismatching rcu functions caused security issues, though I don't know how practical it is to exploit those mistakes. So I worry a bit about breaking things in old kernels accidentally, in the future. I don't have any good ideas for automatically catching misuse in new code. I did try the version you committed, yesterday, and it seemed to work fine on a 5.1 kernel. _______________________________________________ WireGuard mailing list WireGuard@lists.zx2c4.com https://lists.zx2c4.com/mailman/listinfo/wireguard