From: Tharre <tharre3@gmail.com>
To: Matt Layher <mdlayher@gmail.com>
Cc: wireguard@lists.zx2c4.com
Subject: Re: Use of __kernel_timespec in userspace genetlink API
Date: Mon, 22 Apr 2019 20:13:50 +0200 [thread overview]
Message-ID: <20190422181350.GA26003@xultrabook> (raw)
In-Reply-To: <f87c87a0-c5b4-9ee8-ba28-9ff575987f72@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 970 bytes --]
On 04/18, Matt Layher wrote:
> My C experience is very limited, and I have no experience working on C
> within the kernel, but is exposing a "__kernel*" type to userspace a normal
> procedure? I would have expected to see a regular timespec from
> linux/time.h, or perhaps a timespec64 in its place.
There is no timespec64 defined anywhere in include/linux, and it can't
be a normal timespec because of the Year 2038 problem. And despite it's
prefix, __kernel_timespec is defined in include/linux/time.h.
> I can do some slightly more intelligent checking to fix the current issue
> with my library, but I wanted to check in and confirm that this API contract
> is correct.
The change from struct timespec to struct __kernel_timespec happened in
commit c870c7a[0] so I'm guessing it's intentional.
Hope that helps.
[0] http://git.zx2c4.com/WireGuard/commit/?id=c870c7a
--
PGP fingerprint: 42CE 7698 D6A0 6129 AA16 EF5C 5431 BDE2 C8F0 B2F4
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 148 bytes --]
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
next prev parent reply other threads:[~2019-04-22 18:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-18 14:06 Matt Layher
2019-04-22 18:13 ` Tharre [this message]
2019-04-22 23:35 ` Ryan Whelan
2019-04-22 23:48 ` Tharre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190422181350.GA26003@xultrabook \
--to=tharre3@gmail.com \
--cc=mdlayher@gmail.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).