Development discussion of WireGuard
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: yuehaibing@huawei.com
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org, wireguard@lists.zx2c4.com
Subject: Re: [PATCH net-next] net: Remove unused including <linux/version.h>
Date: Thu, 12 Dec 2019 10:52:58 -0800 (PST)	[thread overview]
Message-ID: <20191212.105258.579549471896891617.davem@davemloft.net> (raw)
In-Reply-To: <20191212091527.35293-1-yuehaibing@huawei.com>

From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 12 Dec 2019 09:15:27 +0000

> Remove including <linux/version.h> that don't need it.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Appropriate subject line for this should have been:

	Subject: [PATCH net-next] wireguard: Remove unused include <linux/version.h>

'net' is too broad a subsystem prefix as it basically encompases half of the
entire kernel tree.  When people look at the git shortlog output you need to
be specific enough that people can tell what touches what.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

  parent reply	other threads:[~2019-12-12 18:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12  9:15 YueHaibing
2019-12-12  9:52 ` Jason A. Donenfeld
2019-12-12 18:52 ` David Miller [this message]
2019-12-12 19:06   ` Jason A. Donenfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191212.105258.579549471896891617.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=wireguard@lists.zx2c4.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).