From: Garrit Franke <garritfranke@gmail.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: "Tomcsanyi, Domonkos" <domi@tomcsanyi.net>,
WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH] Adding support for reloading configuration via systemd
Date: Fri, 24 Jul 2020 11:25:36 +0200 [thread overview]
Message-ID: <20200724092536.m2bsg2cxo2ga6vwc@CKC-BS-N0240> (raw)
In-Reply-To: <CAHmME9qsfmK6_d4bDF1Oj4585_56Vtm+wCT+i-2PO=tXN3Jsfw@mail.gmail.com>
On Fri, Jul 24, 2020 at 11:14:52AM +0200, Jason A. Donenfeld wrote:
> On Fri, Jul 24, 2020 at 10:30 AM Tomcsanyi, Domonkos <domi@tomcsanyi.net> wrote:
> >
> > Signed-off-by: Domonkos P. Tomcsanyi <domi@tomcsanyi.net>
> > ---
> > src/systemd/wg-quick@.service | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/src/systemd/wg-quick@.service b/src/systemd/wg-quick@.service
> > index a9cbb58..8eb040b 100644
> > --- a/src/systemd/wg-quick@.service
> > +++ b/src/systemd/wg-quick@.service
> > @@ -15,6 +15,7 @@ Type=oneshot
> > RemainAfterExit=yes
> > ExecStart=/usr/bin/wg-quick up %i
> > ExecStop=/usr/bin/wg-quick down %i
> > +ExecReload=/bin/bash -c '/usr/bin/wg syncconf %i <(/usr/bin/wg-quick strip
> > %i)'
> > Environment=WG_ENDPOINT_RESOLUTION_RETRIES=infinity
> >
> > [Install]
> > --
> > 2.17.1
> >
> > Not the cleanest solution, but I think it might help a lot of people, so I'm
> > submitting it.
>
> This actually doesn't seem too bad to me. Are there cleaner solutions
> that I'm not thinking of that I should consider before applying this
> patch?
I think it doesn't get cleaner than this one-liner.
Some time back I submitted a patch that added a restart command to wg-tools.
We settled on the conclusion that a systemd approach would be much cleaner.
next prev parent reply other threads:[~2020-07-24 9:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <VI1PR02MB52169D6F055314DCD03746EDE6760@VI1PR02MB5216.eurprd02.prod.outlook.com>
2020-07-23 14:10 ` Tomcsanyi, Domonkos
2020-07-24 9:14 ` Jason A. Donenfeld
2020-07-24 9:25 ` Garrit Franke [this message]
2020-07-24 9:27 ` Garrit Franke
2020-07-24 9:29 ` Jason A. Donenfeld
2020-07-24 13:09 ` Tomcsányi, Domonkos
2020-07-24 14:26 ` Jason A. Donenfeld
2020-07-24 14:46 ` Dominique Martinet
2020-07-24 14:49 ` Jason A. Donenfeld
2020-07-24 9:54 ` Matthias Urlichs
2020-07-24 10:52 ` Stefan Tatschner
2020-07-24 11:00 ` Matthias Urlichs
2020-07-25 12:16 ` Tore Anderson
2020-07-27 15:51 ` Jason A. Donenfeld
2020-07-27 20:04 ` Tore Anderson
2020-07-28 9:03 ` Jason A. Donenfeld
2020-07-28 9:54 ` Tore Anderson
2020-07-28 11:55 ` Jason A. Donenfeld
2020-07-28 12:17 ` Tore Anderson
2020-07-28 12:17 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724092536.m2bsg2cxo2ga6vwc@CKC-BS-N0240 \
--to=garritfranke@gmail.com \
--cc=Jason@zx2c4.com \
--cc=domi@tomcsanyi.net \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).