From: Tobias Klauser <tklauser@distanz.ch>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: WireGuard mailing list <wireguard@lists.zx2c4.com>
Subject: Re: [PATCH wireguard-go] tun: avoid leaking sock fd in CreateTUN error cases
Date: Fri, 24 Sep 2021 10:45:24 +0200 [thread overview]
Message-ID: <20210924084524.iwgnjuxhfxidwhnc@distanz.ch> (raw)
In-Reply-To: <CAHmME9rzGKO51oh5UBvPV+qn7J8yAXbQHsWXh-k+r1BkCHfVTw@mail.gmail.com>
On 2021-09-23 at 17:54:20 +0200, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> Applied, thanks! I'm curious: is this a bug you ran into somewhere?
I've not seen this causing problems with wireguard-go specifically, but
have seen issues with leaked fds elsewhere. So by now I'm attentive of
the pattern and send fixes where I notice it :)
prev parent reply other threads:[~2021-09-24 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 10:05 Tobias Klauser
2021-09-23 15:54 ` Jason A. Donenfeld
2021-09-24 8:45 ` Tobias Klauser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924084524.iwgnjuxhfxidwhnc@distanz.ch \
--to=tklauser@distanz.ch \
--cc=Jason@zx2c4.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).