From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F99EC433EF for ; Fri, 19 Nov 2021 18:53:14 +0000 (UTC) Received: from lists.zx2c4.com (lists.zx2c4.com [165.227.139.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8950861AA2 for ; Fri, 19 Nov 2021 18:53:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8950861AA2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.zx2c4.com Received: by lists.zx2c4.com (OpenSMTPD) with ESMTP id 90cbd9f1; Fri, 19 Nov 2021 18:53:11 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by lists.zx2c4.com (OpenSMTPD) with ESMTPS id 5b1d04c0 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO) for ; Fri, 19 Nov 2021 18:53:09 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D51C160E54; Fri, 19 Nov 2021 18:53:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637347987; bh=bkEC59vwr6ACcyDrI/o8TXZEvLkZv65iduYBaycj1So=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=t9kNIPRPkPCFX0/Hdiv2jhilymqje7gbvS1IKr3indwougpjnJ6FHdOqJht3vLHvs Bmypf/hfMW+kKS3GBBpgJuseqEhxZGAzYMoEzkHuliRs28rj0n5uWNthW3rYB5tVQ5 Z72gW6W0rHxh39M/WLRAZueemDTJkDTIcP7UXBDbH2DAz2UW1n9JzrrcoNRhoOzvl0 H+F/FNbsqduSAxNUiwoOaXFkYikhqXHsH6U9bQ9+WMj+C1a3hnFk3DmJZ/MnBKFkrB 117oucvZm1MUFuVNHVeF/qiJE4roMjrhGDVGi8vtLf8AG9v4CaxYoEwbcNb0ZjKMu4 BZk4zSFKAXxHQ== Date: Fri, 19 Nov 2021 10:53:05 -0800 From: Jakub Kicinski To: Kees Cook Cc: "Jason A. Donenfeld" , "Gustavo A . R . Silva" , "David S. Miller" , Jonathan Lemon , Alexander Lobakin , Jakub Sitnicki , Marco Elver , Willem de Bruijn , Eric Dumazet , Cong Wang , Paolo Abeni , Talal Ahmad , Kevin Hao , Ilias Apalodimas , Kumar Kartikeya Dwivedi , Vasily Averin , linux-kernel@vger.kernel.org, wireguard@lists.zx2c4.com, netdev@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] skbuff: Switch structure bounds to struct_group() Message-ID: <20211119105253.1db523b5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20211119104144.7cb1eac6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <20211118183615.1281978-1-keescook@chromium.org> <20211118231355.7a39d22f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <202111191015.509A0BD@keescook> <20211119104144.7cb1eac6@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: wireguard@lists.zx2c4.com X-Mailman-Version: 2.1.30rc1 Precedence: list List-Id: Development discussion of WireGuard List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: wireguard-bounces@lists.zx2c4.com Sender: "WireGuard" On Fri, 19 Nov 2021 10:41:44 -0800 Jakub Kicinski wrote: > On Fri, 19 Nov 2021 10:26:19 -0800 Kees Cook wrote: > > On Thu, Nov 18, 2021 at 11:13:55PM -0800, Jakub Kicinski wrote: > > > This adds ~27k of these warnings to W=1 gcc builds: > > > > > > include/linux/skbuff.h:851:1: warning: directive in macro's argument list > > > > Hrm, I can't reproduce this, using several GCC versions and net-next. What > > compiler version[1] and base commit[2] were used here? > > gcc version 11.2.1 20210728 (Red Hat 11.2.1-1) (GCC) > > HEAD was at: 3b1abcf12894 Merge tag 'regmap-no-bus-update-bits' of git://... Ah, damn, I just realized, it's probably sparse! The build sets C=1.