From: Kees Cook <keescook@chromium.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>,
"Gustavo A . R . Silva" <gustavoars@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Alexander Lobakin <alobakin@pm.me>,
Jakub Sitnicki <jakub@cloudflare.com>,
Marco Elver <elver@google.com>,
Willem de Bruijn <willemb@google.com>,
Eric Dumazet <edumazet@google.com>,
Cong Wang <cong.wang@bytedance.com>,
Paolo Abeni <pabeni@redhat.com>,
Talal Ahmad <talalahmad@google.com>,
Kevin Hao <haokexin@gmail.com>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Vasily Averin <vvs@virtuozzo.com>,
linux-kernel@vger.kernel.org, wireguard@lists.zx2c4.com,
netdev@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] skbuff: Switch structure bounds to struct_group()
Date: Fri, 19 Nov 2021 11:04:54 -0800 [thread overview]
Message-ID: <202111191103.074D77AF2@keescook> (raw)
In-Reply-To: <20211119105253.1db523b5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, Nov 19, 2021 at 10:53:05AM -0800, Jakub Kicinski wrote:
> On Fri, 19 Nov 2021 10:41:44 -0800 Jakub Kicinski wrote:
> > On Fri, 19 Nov 2021 10:26:19 -0800 Kees Cook wrote:
> > > On Thu, Nov 18, 2021 at 11:13:55PM -0800, Jakub Kicinski wrote:
> > > > This adds ~27k of these warnings to W=1 gcc builds:
> > > >
> > > > include/linux/skbuff.h:851:1: warning: directive in macro's argument list
> > >
> > > Hrm, I can't reproduce this, using several GCC versions and net-next. What
> > > compiler version[1] and base commit[2] were used here?
> >
> > gcc version 11.2.1 20210728 (Red Hat 11.2.1-1) (GCC)
> >
> > HEAD was at: 3b1abcf12894 Merge tag 'regmap-no-bus-update-bits' of git://...
>
> Ah, damn, I just realized, it's probably sparse! The build sets C=1.
*head desk* I looked right at the "C=1" (noting it was missing for the
clang build) and didn't put it together. Let me see what I need to do to
make sparse happy...
--
Kees Cook
prev parent reply other threads:[~2021-11-19 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 18:36 Kees Cook
2021-11-19 7:13 ` Jakub Kicinski
2021-11-19 16:24 ` Kees Cook
2021-11-19 18:26 ` Kees Cook
2021-11-19 18:41 ` Jakub Kicinski
2021-11-19 18:53 ` Jakub Kicinski
2021-11-19 19:04 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202111191103.074D77AF2@keescook \
--to=keescook@chromium.org \
--cc=Jason@zx2c4.com \
--cc=alobakin@pm.me \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elver@google.com \
--cc=gustavoars@kernel.org \
--cc=haokexin@gmail.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jakub@cloudflare.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=talalahmad@google.com \
--cc=vvs@virtuozzo.com \
--cc=willemb@google.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).